[Bioc-devel] Moving from development build to release build

2017-09-28 Thread Yong Kee Tan
Hi, I've built a package which was approved 2 months ago. What are the necessary steps I have to take to allow it to be fully published as a package on bioconductor and not just development version? http://bioconductor.org/packages/devel/bioc/html/oneSENSE.html -- Best Wishes, Tan Yong Kee

Re: [Bioc-devel] Printing DataFrame with nested data.frame/DataFrame/DataFrameList

2017-09-28 Thread Jialin Ma
Hi Hervé, Thanks for addressing it so quickly, I will check it when the new version if available for biocLite(). Thanks! Jialin On Thu, 2017-09-28 at 13:47 -0700, Hervé Pagès wrote: > Hi Jialin, > > Thanks for the excellent report. These "show" methods like > many others in Bioconductor, rely o

Re: [Bioc-devel] Printing DataFrame with nested data.frame/DataFrame/DataFrameList

2017-09-28 Thread Hervé Pagès
Hi Jialin, Thanks for the excellent report. These "show" methods like many others in Bioconductor, rely on low-level helper showAsCell() which was not working properly on data-frame-like or array-like objects with a single column, or on SplitDataFrameList objects. This should now be addressed. T

Re: [Bioc-devel] writing unit tests for functions in an initializer

2017-09-28 Thread Hervé Pagès
Yep. And w.r.t. empty objects, make sure new("MyClass") works and returns a valid object. This should produce an "empty" object. Note that the explicit constructor function should be named as the class itself (e.g. MyClass()). It's up to you to decide whether it should support being called with n

Re: [Bioc-devel] writing unit tests for functions in an initializer

2017-09-28 Thread Michael Lawrence
I agree with Kasper. You are better off just leaving initialize() to its default implementation. Violating that abstraction for the purpose of testing is only going to put your software more at risk, defeating the purpose of testing. Overriding initialize() makes it do more than just set slots, bu

Re: [Bioc-devel] writing unit tests for functions in an initializer

2017-09-28 Thread Kasper Daniel Hansen
Ok, this is answering a different question, but the recommendation is to avoid spending time on the initialize method and instead write am explicit constructor function. On Thu, Sep 28, 2017 at 10:48 AM, Zach Skidmore wrote: > Hi All, > > I maintain the GenVisR package and am currently convertin

[Bioc-devel] writing unit tests for functions in an initializer

2017-09-28 Thread Zach Skidmore
Hi All, I maintain the GenVisR package and am currently converting it to S4 classes. I'm running into a problem however when writing unit tests for functions within the initalizer. What I really need is a "mock" object of the class for which the initializer unit tests are being performed but wh

[Bioc-devel] Printing DataFrame with nested data.frame/DataFrame/DataFrameList

2017-09-28 Thread Jialin Ma
Dear all, I have a package in reviewing at https://github.com/Bioconductor/Contributions/issues/487, in which I would like to use a GRanges with nested data.frame or DataFrameList to represent the track data internally. However, the default show method does not seem to work well with such structu