On Fri, Jun 4, 2021 at 7:51 PM Sybren A. Stüvel via Bf-committers
wrote:
>
> On Wed, 2 Jun 2021 at 07:56, Campbell Barton via Bf-committers <
> bf-committers@blender.org> wrote:
>
> > If the proposed policies are followed to the letter, we end up in
> > situations where extra review iterations wou
I think most of these issues with be solved when we have CI bots?
In most bigger open source projects I contribute to, the bots makes sure
that everything is formated correctly and that there are no new
warning/errors in the code.
If there are any issues, they will post a comment pointing the iss
On Wed, 2 Jun 2021 at 07:56, Campbell Barton via Bf-committers <
bf-committers@blender.org> wrote:
> If the proposed policies are followed to the letter, we end up in
> situations where extra review iterations would be required for running
> clang-format, stripping what-space and spelling mistakes
On Wed, Jun 2, 2021 at 6:20 PM Sergey Sharybin via Bf-committers
wrote:
>
> Campbell, those are valid points, but here is what I propose:
>
> (a) Focus on making already-agreed-on topics public, go into more
> specific cases later.
Sergey, sounds good.
Since these rules are on our official wiki I
On Wed, Jun 2, 2021 at 5:22 PM Ray Molenkamp via Bf-committers
wrote:
>
> I'm somewhat confused on the goal some of the (proposed?) rules.
> But I'll just pick on the "Patch description should match the
> commit message."-rule for now not to make this longer than it
> needs to be.
>
> Most people
Campbell, those are valid points, but here is what I propose:
(a) Focus on making already-agreed-on topics public, go into more
specific cases later.
(b) Until the future of the Phabricator is known, do not spend too much
time in finding Phabricator-specific solutions for the cases we want to
cove
I'm somewhat confused on the goal some of the (proposed?) rules.
But I'll just pick on the "Patch description should match the
commit message."-rule for now not to make this longer than it
needs to be.
Most people are much more verbose in their patch description,
some have visual aids (images/cli
Hi, there are a few cases this document doesn't cover
(understandably as they're not so typical).
How to best make updates to a patch?
While proposing changes and having the patch author apply them is
almost always preferred, there are times when it is less t
Hi,
Just a quick note. The bf-admin team worked on several process related
documents to ensure a pleasant and efficient development process.
Today we've updated wiki with the patch review process:
https://wiki.blender.org/wiki/Process/Patch_Review
Feedback is welcome.
Best regards,
- Sergey -
-
