RE: Request for code feedback

2009-06-15 Thread Bob McConnell
From: Chap Harrison > On Jun 13, 2009, at 4:07 PM, David Christensen wrote: >> Chas. Owens wrote: >> >>> the only True Way is to use tabs for indent levels and spaces for >>> alignment, this allows the user to set his or her indentation to >>> whatever he or she wants by modifying how many spaces a

Re: Request for code feedback

2009-06-15 Thread Steve Bertrand
Steve Bertrand wrote: > Hi all, > > I'm still in the process of updating/replacing some accounting > applications, and thought I'd ask for a peer review. ... Thank you all for all of the wonderful detailed and descriptive feedback. I now have a good deal of information to go over. A couple of t

Re: Request for code feedback

2009-06-14 Thread Chas. Owens
On Sun, Jun 14, 2009 at 11:59, Tech W. wrote: > --- On Sat, 13/6/09, John W. Krahn wrote: >>     When you say >> >>         $scalar = (2, 5, 7, 9); >> >>     you’re using the comma operator in scalar >> context, so it uses the >>     scalar comma operator. > > Here, what is the "scalar comma opera

Re: Request for code feedback

2009-06-14 Thread Tech W.
--- On Sat, 13/6/09, John W. Krahn wrote: >     When you say > >         $scalar = (2, 5, 7, 9); > >     you’re using the comma operator in scalar > context, so it uses the >     scalar comma operator.  Here, what is the "scalar comma operator"? I can't understand for that. Thanks. Reg

Re: Request for code feedback

2009-06-13 Thread Chap Harrison
On Jun 13, 2009, at 4:07 PM, David Christensen wrote: Chas. Owens wrote: the only True Way is to use tabs for indent levels and spaces for alignment, this allows the user to set his or her indentation to whatever he or she wants by modifying how many spaces a tab displays. [72 columns maximum

RE: Request for code feedback

2009-06-13 Thread David Christensen
Chas. Owens wrote: > header comment blocks are wastes of space, that is what good source > control and documentation is for. > [author information] > [copyright] That stuff used to be mandatory when I coded for a living. Has the industry changed that much since then? >> 2. I don't see commen

Re: Request for code feedback

2009-06-13 Thread Chas. Owens
On Sat, Jun 13, 2009 at 07:30, John W. Krahn wrote: > Chas. Owens wrote: >> >> On Sat, Jun 13, 2009 at 03:48, John W. Krahn wrote: >>> >>> Chas. Owens wrote: On Fri, Jun 12, 2009 at 20:24, Steve Bertrand wrote: > > my $hours_used   = ($hours_lookup->get_month_hours($dbh, $username

Re: Request for code feedback

2009-06-13 Thread John W. Krahn
Chas. Owens wrote: On Sat, Jun 13, 2009 at 03:48, John W. Krahn wrote: Chas. Owens wrote: On Fri, Jun 12, 2009 at 20:24, Steve Bertrand wrote: my $hours_used = ($hours_lookup->get_month_hours($dbh, $username, $search_date, 'dialup')); Why are you creating a list here? Just say Do yo

Re: Request for code feedback

2009-06-13 Thread Chas. Owens
On Sat, Jun 13, 2009 at 03:48, John W. Krahn wrote: > Chas. Owens wrote: >> >> On Fri, Jun 12, 2009 at 20:24, Steve Bertrand wrote: >>> >>> my $hours_used   = ($hours_lookup->get_month_hours($dbh, $username, >>> $search_date, 'dialup')); >> >> Why are you creating a list here?  Just say > > Do you

Re: Request for code feedback

2009-06-13 Thread John W. Krahn
Chas. Owens wrote: On Fri, Jun 12, 2009 at 20:24, Steve Bertrand wrote: my $hours_used = ($hours_lookup->get_month_hours($dbh, $username, $search_date, 'dialup')); Why are you creating a list here? Just say Do you mean the list ($dbh, $username, $search_date, 'dialup')? I think that i

Re: Request for code feedback

2009-06-12 Thread Chas. Owens
On Sat, Jun 13, 2009 at 00:54, David Christensen wrote: > Steve Bertrand wrote: >> If anyone has the time to review and report, I would much appreciate > it. >> http://ipv6canada.com/extra_billing.txt > > 1.  I don't see a header comment block. header comment blocks are wastes of space, that is wh

Re: Request for code feedback

2009-06-12 Thread Chas. Owens
On Fri, Jun 12, 2009 at 20:24, Steve Bertrand wrote: > Hi all, > > I'm still in the process of updating/replacing some accounting > applications, and thought I'd ask for a peer review. snip My version of your code is available at http://codepad.org/jrP45bUp It has not been tested because I don't h

RE: Request for code feedback

2009-06-12 Thread David Christensen
Steve Bertrand wrote: > If anyone has the time to review and report, I would much appreciate it. > http://ipv6canada.com/extra_billing.txt 1. I don't see a header comment block. 2. I don't see comment section boundaries. 3. I don't see author information. 4. I don't see a copyright notice.