Re: File::Find script questions

2011-07-19 Thread Uri Guttman
> "M" == Marc writes: M>Thanks to both Uri and John for their input. I've added your suggestions and the script is much cleaner and more concise now. M>I decided to keep the header info in the sub because I'm now setting the subject to the path of the error log, so at a glance

Re: File::Find script questions

2011-07-19 Thread Marc
Thanks to both Uri and John for their input. I've added your suggestions and the script is much cleaner and more concise now. I decided to keep the header info in the sub because I'm now setting the subject to the path of the error log, so at a glance I know where there's a pro

Re: File::Find script questions

2011-07-18 Thread Uri Guttman
> "M" == Marc writes: M>The script works great but I'd like to get advice on how I can M>clean up my code, so any comments are welcome. M>Also, do I really need the foreach block in there? I couldn't M>get it to work without it, but it seems like I should be able

Re: File::Find script questions

2011-07-18 Thread Uri Guttman
> "HW" == Hal Wigoda writes: HW> Why clean it up when it works and is not obfusticating. because he asked for comments and it will be educational to all on the list. uri -- Uri Guttman -- uri AT perlhunter DOT com --- http://www.perlhunter.com -- Perl Developer Recruit

Re: File::Find script questions

2011-07-18 Thread John W. Krahn
Marc wrote: I've written a script to traverse my web server, find any files called "error_log", e-mail them to me, and then delete them. It is triggered by cron twice a day. The script works great but I'd like to get advice on how I can clean up my code, so any comments are welcome. Also, do I

Re: File::Find script questions

2011-07-18 Thread Hal Wigoda
Why clean it up when it works and is not obfusticating. On Mon, Jul 18, 2011 at 8:59 PM, Marc wrote: >        I've written a script to traverse my web server, find any files called > "error_log", e-mail them to me, and then delete them.  It is triggered by > cron twice a day. > >        The scr