Re: Check my script

2003-08-18 Thread Keith Olmstead
Thanks for everybody that has given there input. I have changed a few things up and all is good. Thanks, Keith On Fri, 15 Aug 2003, Keith Olmstead wrote: Date: Fri, 15 Aug 2003 16:16:44 -0500 (CDT) From: Keith Olmstead <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: Check my script

Re: Check my script

2003-08-15 Thread John W . Krahn
On Friday 15 August 2003 19:09, Jeff 'japhy' Pinyan wrote: > > Everyone has been telling you to use strict, and scope the $log > variable, but no one has run the code they've corrected, or they'd > spot that scoping $log in the for loop makes in NOT visible in the > eachFile() function. > > Here's

Re: Check my script

2003-08-15 Thread Jeff 'japhy' Pinyan
On Aug 15, Keith Olmstead said: >foreach $log (@logfile) { >find (\&eachFile, "$startdir"); >} # End for loop >sub eachFile { >if (-e $_ && $_ =~ /$log$/) { push @log, $File::Find::name;} >} # End eachFile Everyone has been telling you to use strict, and scope the $log variable, but no o

Re: Check my script

2003-08-15 Thread John W . Krahn
On Friday 15 August 2003 14:16, Keith Olmstead wrote: > > Hello, Hello, > I have this script to gzip logs in different directories. Can some > one check it for me. It works fine, but I want to make sure I did it > correctly and the best way. If it works then it must be correct! :-) As to "the

Re: Check my script

2003-08-15 Thread James Edward Gray II
On Friday, August 15, 2003, at 04:16 PM, Keith Olmstead wrote: Hello, Howdy. I have this script to gzip logs in different directories. Can some one check it for me. It works fine, but I want to make sure I did it correctly and the best way. I think it's excellent that you want a review of wo

Check my script

2003-08-15 Thread Keith Olmstead
Hello, I have this script to gzip logs in different directories. Can some one check it for me. It works fine, but I want to make sure I did it correctly and the best way. BTW, this is my frist script that I wrote. Thanks, Keith Olmstead #!/usr/bin/perl my $startdir = "/opt/log/hosts/"; use