Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-08 Thread Kern Sibbald
> Before I cause a panic, there is a cut/paste error in my description > below. > There is nothing wrong with Sparse + Compression, it should say "Works > fine" > not "Restore broken". Thanks for the update -- yes, if sparse + compression were broken, I would be very worried ... :-) > > -Ori

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-05 Thread Robert Nelson
I've checked in the fix which makes everything work properly. I've tested every combination of encryption, sparse and compression, both backup and restore. I've also compared the restored contents against the original to ensure that there is no corruption of the data. Any previous backups that w

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-05 Thread Robert Nelson
Before I cause a panic, there is a cut/paste error in my description below. There is nothing wrong with Sparse + Compression, it should say "Works fine" not "Restore broken". -Original Message- From: Kern Sibbald [mailto:[EMAIL PROTECTED] Sent: Friday, November 03, 2006 5:05 PM To: Robert

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-03 Thread Kern Sibbald
I've got to go now. Thanks for the explaination. I'll respond as soon as I can, but I would also like to see Landon's response. > Perhaps if I explained the problem: > > Currently (as of 1.39.27) > > No filters = Works fine > Sparse = Works fine > Compression = Works fine > Encryption = Works fin

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-03 Thread Robert Nelson
Perhaps if I explained the problem: Currently (as of 1.39.27) No filters = Works fine Sparse = Works fine Compression = Works fine Encryption = Works fine Sparse + Compression = Restore broken Sparse + Encryption = Restore broken Sparse + Compression + Encryption = Restore broken Compression + E

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-03 Thread Kern Sibbald
ember 03, 2006 4:40 PM > To: Robert Nelson > Cc: [EMAIL PROTECTED]; 'Landon Fuller'; > bacula-users@lists.sourceforge.net > Subject: Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict > in CVS > > >> This code is backwards compatible for everything e

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-03 Thread Michael Brennen
On Friday 03 November 2006 18:39, Kern Sibbald wrote: > > This code is backwards compatible for everything except encrypted data. > > Previously compressed backups will still work fine. > > I'm not 100% sure what you mean, but here are my thoughts: > > If it breaks something that previously worked,

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-03 Thread Robert Nelson
ssage- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Kern Sibbald Sent: Friday, November 03, 2006 4:40 PM To: Robert Nelson Cc: [EMAIL PROTECTED]; 'Landon Fuller'; bacula-users@lists.sourceforge.net Subject: Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conf

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-03 Thread Kern Sibbald
> This code is backwards compatible for everything except encrypted data. > Previously compressed backups will still work fine. I'm not 100% sure what you mean, but here are my thoughts: If it breaks something that previously worked, then it is does not fit with the Bacula philosophy of always b

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-03 Thread Kern Sibbald
> The problem is that currently there are three filters defined: > compression, > encryption, and sparse file handling. The current implementation of > compression and sparse file handling both require block boundary > preservation. Even if zlib streaming could handle the existing block > based

Re: [Bacula-users] [Bacula-devel] Encryption/Compression Conflict in CVS

2006-11-03 Thread Landon Fuller
On Nov 2, 2006, at 16:29, Robert Nelson wrote: In that case, would you like me to commit the code I have? That'd be super. Thanks for fixing it. I agree about reworking the stream implementation. The existing code could be written as a number of filters: gzip, openssl, sparse, block/ deb