Re: [Bacula-devel] Something amiss in bacula-9.6.7: Possible race condition

2021-01-19 Thread Martin Simmons
> On Mon, 18 Jan 2021 16:17:04 -0500, Phil Stracchino said: > > On 1/18/21 2:08 PM, Martin Simmons wrote: > > Looks reasonable to me. (*) > > > > If the INSERT failed for some other reason then the original mysql_query() > > should have failed rather than mysql_affected_rows() returning 0.

Re: [Bacula-devel] Something amiss in bacula-9.6.7: Possible race condition

2021-01-19 Thread Phil Stracchino
On 1/19/21 1:40 PM, Martin Simmons wrote: > In theory jobs running without batch insert share a single BDB object in > memory, but it is used with a lock by a per-job thread (which is why the db > library has to be thread-safe). See setup_job(). > > I say "in theory" because it looks like Bacula

Re: [Bacula-devel] Something amiss in bacula-9.6.7: Possible race condition

2021-01-19 Thread Phil Stracchino
On 1/19/21 1:40 PM, Martin Simmons wrote: > To fix it, replace db_driver_len with db_driver_len+1 in this call to > bstrncpy. This has been fixed in Bacula 11 because the seemingly minor > problem with "status catalog" was reported in > https://bugs.bacula.org/view.php?id=2551 but it looks like th

Re: [Bacula-devel] Something amiss in bacula-9.6.7: Possible race condition

2021-01-19 Thread Phil Stracchino
On 1/19/21 3:17 PM, Phil Stracchino wrote: > Fix applied. I'll send Gentoo a patch for 9.6.7. Bug report and patch submitted to Gentoo. -- Phil Stracchino Babylon Communications ph...@caerllewys.net p...@co.ordinate.org Landline: +1.603.293.8485 Mobile: +1.603.998.6958

Re: [Bacula-devel] Something amiss in bacula-9.6.7: Possible race condition

2021-01-19 Thread Sven Hartge
On 19.01.21 19:40, Martin Simmons wrote: I say "in theory" because it looks like Bacula 9.6.4 broke this! What is the output of "show catalog" in bconsole? My guess is that you will see db_driver=MySQ i.e. missing the final "L" of MySQL. This will prevent it from reusing the BDB object, leadi