Re: Help with -Werror

2019-04-24 Thread Russ Allbery
Bob Friesenhahn writes: > One possibility would be to add configure support for > --enable-maintainer-mode and then change the defaults when it is > enabled. Another possiblity is to add a configure option to enable the > option, which developers should always enable. I personally use a separat

Re: Help with -Werror

2019-04-24 Thread Bob Friesenhahn
On Wed, 24 Apr 2019, Phillip Susi wrote: For the most part, -Werror is a developer tool which will only cause problems for users, so my strong recommendation is that it should never appear in package releases, but not everybody subscribes to that philosophy... I am tempted to switch it off...

Re: Help with -Werror

2019-04-24 Thread Phillip Susi
Nick Bowler writes: > Automake does not add -Werror to the default C compiler flags, and it > does not do anything with a CFLAGS_WERROR variable. Yea, I forgot about configure.ac... it was in there. > If that is happening for a particular package, then it is because the > package authors did so

Re: Help with -Werror

2019-04-24 Thread Nick Bowler
Hello, On 2019-04-24, Phillip Susi wrote: > It seems like every time I go back to try to do somoe work on the parted > sources I run into a failure to compile due to some silly warning or > other and -Werror being enabled. This time it is from a generated > source file made by gperf. Is this se

Help with -Werror

2019-04-24 Thread Phillip Susi
It seems like every time I go back to try to do somoe work on the parted sources I run into a failure to compile due to some silly warning or other and -Werror being enabled. This time it is from a generated source file made by gperf. Is this set by default these days in automake? Because I can

Re: Stopping unit test on failed partial ordering dependency

2019-04-24 Thread Bob Friesenhahn
On Tue, 23 Apr 2019, Kip Warner wrote: Now suppose the TestStartDaemon.sh bails for some reason. There is no point on doing all the queries and having them all fail. There has to be a sane way of handling this scenario. Having all the dependent tests fail seems ok, as long as the failure is e