Re: My patches

2001-03-23 Thread Russ Allbery
Akim Demaille <[EMAIL PROTECTED]> writes: > I have a question: what is the version of Perl we can require. There > are feature implemented in 5.6 that I would like to use, but is it > acceptable? I know Tom already answered this, but just to add a bit more information, 5.6.0 wasn't particularly

overriding tested automake & aclocal in test suite

2001-03-23 Thread Derek R. Price
Is there some reason the automake test suite doesn't allow the user to override its AUTOMAKE & ACLOCAL variables? I like to do it on ocassion to compare the current behavior against my installed version and the like. Derek -- Derek Price CVS Solutions Architect ( http://CVS

Re: Including foreign makefiles

2001-03-23 Thread Adam C Powell IV
Tom Tromey wrote: > > "Adam" == Adam C Powell IV <[EMAIL PROTECTED]> writes: > > Adam> So the question is, is there an automake-kosher way to include a > Adam> foreign makefile, or specify that certain variables will be > Adam> somehow defined elsewhere, not in Makefile.am or configure.in? >

Re: 81-lang-extensions.patch

2001-03-23 Thread Raja R Harinath
Hi, Akim Demaille <[EMAIL PROTECTED]> writes: > Raja R Harinath <[EMAIL PROTECTED]> writes: [snip] > | Wouldn't this be more compact and readable without the loop? > | > | $lang_obj->ansi($options{'ansi'})if exists $options{'ansi'}; > | $lang_obj->autodep ($options{'autodep'}) if ex

Re: 34-name-clash.patch

2001-03-23 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in (&read_am_file, &file_contents): Avoid name clashed on $cond. I fixed the typo in the ChangeLog, and applied it: one of the previous patches had a severe typo which badly damaged Automake.

Re: 25-cond-string.patch

2001-03-23 Thread Akim Demaille
> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: Akim> * automake.in (&read_am_file): Keep $cond_string up to date. Tom> Ok. Tom> With cryptic, "technical" patches like this one, an explanation Tom> of why it is needed would really help. Hm, OK, but actually it is not needed at all :) Its

Re: 81-lang-extensions.patch

2001-03-23 Thread Akim Demaille
| Hi, | Akim Demaille <[EMAIL PROTECTED]> writes: | > +while (my ($attr, $value) = each %option) | > { | [snip] | > + if ($attr eq 'ansi') | > { | > + $lang_obj->ansi ($value); | > } | > + elsif ($attr eq 'autodep') | > { | > + $lang_obj->autodep ($value);

Re: My patches

2001-03-23 Thread Akim Demaille
> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: Akim> I would like to emphasize that there is a chunk of patches which Akim> should be applied altogether if we don't want to leave a broken Akim> Automake in the repo. Tom> Well, automake should never be broken in the repo. OK, then I can

Re: 14-variable-define.patch

2001-03-23 Thread Akim Demaille
> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: Tom> macro_define is fine, thanks. I updated all my patches to use macro_define. Consider each time you read `variable_define' it is now `macro_define'.

Re: 12-true-and-false.patch

2001-03-23 Thread Akim Demaille
> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: Tom> Could you add this to your to-do list, or submit a PR or Tom> something? Here is what I actually applied. 2001-03-23 Akim Demaille <[EMAIL PROTECTED]> * automake.in (read_am_file): TRUE and FALSE are predefined condit

Re: Including foreign makefiles

2001-03-23 Thread Tom Tromey
> "Adam" == Adam C Powell IV <[EMAIL PROTECTED]> writes: Adam> So the question is, is there an automake-kosher way to include a Adam> foreign makefile, or specify that certain variables will be Adam> somehow defined elsewhere, not in Makefile.am or configure.in? Not really. I'm suprised you

Re: My patches

2001-03-23 Thread Tom Tromey
> "David" == David Lee <[EMAIL PROTECTED]> writes: David> One might be tempted to argue that anyone dabbling with David> automake will already be a keen perl "bleeding edge" junkie; David> but I would urge caution before leaping to that conclusion. My real goal is to have 1.5 be reliable eno

Re: My patches

2001-03-23 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> Right now I don't have enough time to apply my patches, I will Akim> probably do tomorrow Friday, or Saturday, or Sunday, but I will Akim> try to catch up as soon as possible. Don't speed up on my account. I'm gone all next week.

Re: 81-lang-extensions.patch

2001-03-23 Thread Raja R Harinath
Hi, Akim Demaille <[EMAIL PROTECTED]> writes: > +while (my ($attr, $value) = each %option) > { [snip] > + if ($attr eq 'ansi') > { > + $lang_obj->ansi ($value); > } > + elsif ($attr eq 'autodep') > { > + $lang_obj->autodep ($value); > } > +

Re: Understanding objc.test

2001-03-23 Thread Tom Tromey
> "Akim" == akim <[EMAIL PROTECTED]> writes: Akim> I don't understand the test objc.test (which fails with one of Akim> the patches I work on). Akim> I don't understand why $(LINK) should be (and was) defined. Objective C shouldn't be a `pure' language. My understanding is that in this cas

Re: rpm spec bad

2001-03-23 Thread Tom Tromey
> ">" == D Stimits <[EMAIL PROTECTED]> writes: >> I suspect though that the answer requires altering the rpm spec's. >> Meaning the automake 1.4d rpm package maintainer, but I don't know >> who that is. We don't know either. Maybe the answer is in the spec file. Tom

Re: Conditionals in CVS Automake

2001-03-23 Thread Akim Demaille
> "Robert" == Robert Boehne <[EMAIL PROTECTED]> writes: Robert> Hello all! I've found a problem with conditional compilation Robert> in the CVS version of Automake that was introduced some time Robert> since March 4. Multi-language-branch libtool fails 16 test Robert> cases because the Make

78-lang-autodep.patch

2001-03-23 Thread Akim Demaille
There is one significant semantic difference, but I doubt it was meant, hence was insignificant :) Have a look at: $language_map{"$lang-autodep"} = 'no'; $language_map{"$lang-derived-autodep"} = 'no'; and foreach my $key (sort keys %language_map) { next unless $key =~ /

81-lang-extensions.patch

2001-03-23 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in: (Language): Add attribute `extensions'. (Automake): Pass a hash to `®ister_language' instead of a list of pseudo assignments. (®ister_language): Adjust. (&finish_languages): Initialize

79-lang-compile.patch

2001-03-23 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in (Language): Add attributes `flags', `compile' and `compiler'. (&finish_languages, &handle_single_transform_list, &handle_dist) (&add_depend2, ®ister_language): Use them and the `linker' and

82-lang-finish.patch

2001-03-23 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in: (Language): Add attribute `_finish'. (&finish): New. (Automake): Adjust. (&lang_header_finish, &lang_yaccxx_finish, &lang_lexxx_finish) (&lang_asm_finish): Remove. Ind

80-lang-finish.patch

2001-03-23 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in (Language): Add attribute `output_arg'. (%language_map): Remove. (®ister_language): Build only the object, and store in %languages only. (&finish_languages, &handle_single_transform_lis

77-language-class.patch

2001-03-23 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in (Language): New package, temporarily in this file. Use Class::Struct. (Automake): New package. (%languages): New. (&handle_single_transform_list): Use the language object's `ansi'