> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes:
This is mostly ok.
Akim> * automake.in (&variable_conditionally_defined): Rename as...
Akim> (&variable_unconditionally_defined): this.
Please make sure your ChangeLog entries are accurate.
This entry is wrong.
Akim> (&variable_du
Akim> * automake.in (&handle_footer, &handle_installdirs)
Akim> (&read_main_am_file): Don't read %contents directly, use
Akim> &variable_value.
Ok.
Really we can probably just get rid of SOURCES and OBJECTS.
Tom
Akim> * automake.in (&read_am_file): Define the variables in a single
Akim> shot.
Akim> Factor the $saw_bk code.
Ok
Tom
Akim> * automake.in (&read_am_file): Keep $cond_string up to date.
Ok.
With cryptic, "technical" patches like this one, an explanation of why
it is needed would really help.
Tom
Akim> * automake.in (&define_variable): Use &variable_define.
Ok.
Tom
Akim> * automake.in (&variable_define): Don't lose the location if we
Akim> redefine a variable.
Akim> Don't push all the variables in @var_list, let...
Akim> (&read_am_file, &file_contents): ... do it.
Akim> (&define_pretty_variable): Use variable_define.
Akim> (&am_install_var): Dele
Akim> * automake.in (&conditional_dump): Rename as...
Akim> (&variables_dump): this. Use...
Akim> (&variable_dump): this new sub.
Ok.
Tom
Akim> * automake.in (&file_contents): Maintain $cond_string sync with
Akim> @cond_stack.
Akim> Output rules only if not under `FALSE'.
Akim> Define variables under $cond_string.
Akim> * scripts.am: For the time being if/endif does not work properly
Akim> with macros.
Ok.
Tom
Akim> * automake.in (IF_PATTERN): Unobfuscate the parens.
Akim> (ENDIF_PATTERN): Allow a condition to be specified.
Akim> (&file_contents): Use a @cond_stack.
Akim> (&transform): At least for an easy transition, also transform
Akim> %?FOO% and %!FOO%, as suggested by Lars.
Akim> * scri
Akim> * automake.in (&file_contents): Use rule_define.
Ok.
Tom
Akim> * automake.in (&variable_define): Don't rely on $1.
Akim> Initialize the variable.
Akim> Set its Automakism only if not defined or if given to the user.
Akim> When concatenating values, insert a separator only if the value
Akim> was not empty.
Akim> (&read_am_file): When dumping
>> Is there any way to prohibit the user from doing:
>> AM_CONDITIONAL(TRUE, blah)
>> ?
Akim> Yep, easily from conditional.m4
Could you add this to your to-do list, or submit a PR or something?
Tom
Akim> I chose variable_define after having thought a lot about it :)
Akim> The thing is that in the long term I don't think we need all
Akim> these functions (define_variable etc.), and there should be one
Akim> only (plus a few wrappers when pleasant). That's why I meant to
Akim> have a canonica
13 matches
Mail list logo
