Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

2023-10-18 Thread KO Myung-Hun
Hi/2. Zack Weinberg wrote: > On Sun, Oct 15, 2023, at 2:58 AM, KO Myung-Hun wrote: >> Zack Weinberg wrote: >>> On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote: * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2. >>> Please explain why it isn't also necessary to add double quotes >>> ar

Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2

2023-10-18 Thread KO Myung-Hun
Hi/2. Zack Weinberg wrote: > On Sun, Oct 15, 2023, at 3:43 AM, KO Myung-Hun wrote: >> Zack Weinberg wrote: >>> On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote: * bin/autom4te.in (handle_output): Ignore setting mode failure on OS/2. >>> >>> Not OK, for two reasons: > ... >> How about this

Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2

2023-10-18 Thread Zack Weinberg
On Tue, Oct 17, 2023, at 2:58 PM, Paul Eggert wrote: > On 10/17/23 11:16, Zack Weinberg wrote: ... >> you have to be exquisitely careful, or a malicious concurrent process >> might be able to trick you into overwriting some file elsewhere on >> the filesystem. ... > ? If /tmp is sticky, a malicious

Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2

2023-10-18 Thread Zack Weinberg
On Wed, Oct 18, 2023, at 10:21 AM, KO Myung-Hun wrote: > Zack Weinberg wrote: >> I don’t want to have code in Autoconf that is only safe because of >> non-obvious details of the context it’s used in. People might >> reuse the code in a different context where it’s *not* safe, without >> realizing

Re: [PATCH 1/2] Fix detection of GNU M4 on mksh

2023-10-18 Thread Zack Weinberg
On Wed, Oct 18, 2023, at 10:09 AM, KO Myung-Hun wrote: > Zack Weinberg wrote: >> Details please? > > Commit message was not enough ? I'm afraid not. I needed to know everything you say in the next two paragraphs: > $ac_snip2 contains NL. And in order to print it, `print -r --' command > is used