Hi/2.
These are patches for OS/2.
Review, please...
[PATCH 1/2] Fix detection of GNU M4 on mksh
[PATCH 2/2] Ignore failure of setting mode on a temporary file on
OS/2 does not allow chmod() on an opened file.
* bin/autom4te.in (handle_output): Ignore setting mode failure on OS/2.
---
bin/autom4te.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/bin/autom4te.in b/bin/autom4te.in
index 71d7e6a6..ac5fe18b 100644
--- a/bin/autom4te.in
* m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2.
---
m4/m4.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/m4.m4 b/m4/m4.m4
index e6203118..76fbd04f 100644
--- a/m4/m4.m4
+++ b/m4/m4.m4
@@ -46,7 +46,7 @@ AC_PATH_PROGS_FEATURE_CHECK([M4], [m4 gm4 gnum4],
test -
On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote:
> * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2.
Please explain why it isn't also necessary to add double quotes
around all the other variable expansions in this check, particularly
$ac_snippet and $ac_path_M4.
Also, typo in your commit
On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote:
> OS/2 does not allow chmod() on an opened file.
>
> * bin/autom4te.in (handle_output): Ignore setting mode failure on OS/2.
Not OK, for two reasons: (1) IIRC this is used to create scripts with the
execute bit set in at least one place. Ignor
"Zack Weinberg" writes:
> Really what we need here is for File::Temp to allow us to supply the
> third argument to the open() system call. That feature was added in
> version 0.2310 of the File::Temp module. Does anyone have time right
> now to do the archaeology on what version of File::Temp s
Hi/2.
Zack Weinberg wrote:
> On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote:
>> * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2.
>
> Please explain why it isn't also necessary to add double quotes
> around all the other variable expansions in this check, particularly
> $ac_snippet and
