Re: [PATCH] Add quotes in AS_IF test for gid_t

2024-02-07 Thread Sam James
Paul Eggert writes: > On 2/6/24 20:37, Nick Bowler wrote: >> On 2024-02-06 22:33, Sam James wrote: >>> Noticed when building Emacs: >>> ``` >>> * checking type of array argument to getgroups... ./configure: 42782: test: >>> =: unexpected operator >>> ``` > >> Oh look, I see this line in emacs-

Re: [PATCH] Add quotes in AS_IF test for gid_t

2024-02-07 Thread Sam James
Nick Bowler writes: > On 2024-02-06 22:33, Sam James wrote: >> Noticed when building Emacs: >> ``` >> * checking type of array argument to getgroups... ./configure: 42782: test: >> =: unexpected operator >> ``` >> This turns out to be because of missing quotes in AS_IF for >> ac_cv_type_gid_t

Re: [PATCH] Add quotes in AS_IF test for gid_t

2024-02-07 Thread Paul Eggert
On 2/6/24 20:37, Nick Bowler wrote: On 2024-02-06 22:33, Sam James wrote: Noticed when building Emacs: ``` * checking type of array argument to getgroups... ./configure: 42782: test: =: unexpected operator ``` Oh look, I see this line in emacs-29.2/configure.ac: AC_DEFUN([AC_TYPE_UID_T])

Re: [PATCH] Add quotes in AS_IF test for gid_t

2024-02-06 Thread Nick Bowler
On 2024-02-07 00:54, Nick Bowler wrote: > On 2024-02-07 00:37, Paul Eggert wrote: >> On 2024-02-06 20:37, Nick Bowler wrote: >>> The right place to fix this problem is in Emacs. >> >> I don't see this problem in current (bleeding-edge Savannah) Emacs. >> Sam, which Emacs are you talking about? > >

Re: [PATCH] Add quotes in AS_IF test for gid_t

2024-02-06 Thread Nick Bowler
On 2024-02-07 00:37, Paul Eggert wrote: > On 2024-02-06 20:37, Nick Bowler wrote: >> The right place to fix this problem is in Emacs. > > I don't see this problem in current (bleeding-edge Savannah) Emacs. > Sam, which Emacs are you talking about? The issue is still present on emacs git master as

Re: [PATCH] Add quotes in AS_IF test for gid_t

2024-02-06 Thread Paul Eggert
On 2024-02-06 20:37, Nick Bowler wrote: The right place to fix this problem is in Emacs. I don't see this problem in current (bleeding-edge Savannah) Emacs. Sam, which Emacs are you talking about?

Re: [PATCH] Add quotes in AS_IF test for gid_t

2024-02-06 Thread Nick Bowler
On 2024-02-06 22:33, Sam James wrote: > Noticed when building Emacs: > ``` > * checking type of array argument to getgroups... ./configure: 42782: test: > =: unexpected operator > ``` > This turns out to be because of missing quotes in AS_IF for > ac_cv_type_gid_t in AC_TYPE_GETGROUPS. No, I don'

[PATCH] Add quotes in AS_IF test for gid_t

2024-02-06 Thread Sam James
Noticed when building Emacs: ``` * checking type of array argument to getgroups... ./configure: 42782: test: =: unexpected operator ``` This turns out to be because of missing quotes in AS_IF for ac_cv_type_gid_t in AC_TYPE_GETGROUPS. * lib/autoconf/types.m4 (AC_TYPE_GETGROUPS): Use quotes in AS