Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread
On 08/28/2014 11:28 AM, Eric Blake wrote: Untested: # M4 macros, for use during autoconf time... m4_define([MAJOR_VERSION], [1]) m4_define([MINOR_VERSION], [0]) m4_define([PATCH_VERSION], [0]) AC_INIT([foo], MAJOR_VERSION.MINOR_VERSION.PATCH_VERSION) Thanks for providing an example. It appear

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread Eric Blake
On 08/29/2014 06:52 AM, Zé wrote: > On 08/28/2014 11:28 AM, Eric Blake wrote: >> Untested: >> >> # M4 macros, for use during autoconf time... >> m4_define([MAJOR_VERSION], [1]) >> m4_define([MINOR_VERSION], [0]) >> m4_define([PATCH_VERSION], [0]) >> AC_INIT([foo], MAJOR_VERSION.MINOR_VERSION.PATCH_

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread
On 08/29/2014 02:02 PM, Eric Blake wrote: Two questiosn: 1) is there anything wrong with the way this script has been set? If it worked for you, that's the ultimate test. But I would remove the quoting, to make sure it works by design and not just by chance. Your comments made sense, and it

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread Shawn H Corey
On Fri, 29 Aug 2014 13:52:05 +0100 Zé wrote: > The configure.in file starts off with this: > > # Autoconf script > > AC_PREREQ(2.61) > > m4_define([MAJOR_VERSION], [1]) > m4_define([MINOR_VERSION], [0]) > m4_define([PATCH_VERSION], [0]) > > AC_INIT(foo,[MAJOR_VERSION.MINOR_VERSION.PATCH_VERSI

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread Eric Blake
On 08/29/2014 08:01 AM, Shawn H Corey wrote: > I'm new to all this but can this be done? > > m4_define([MAJOR_VERSION], [1]) > m4_define([MINOR_VERSION], [0]) > m4_define([PATCH_VERSION], [0]) > m4_define([VERSION],[MAJOR_VERSION.MINOR_VERSION.PATCH_VERSION]) > > AC_INIT(foo,[VERSION]) Sure, bu

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread Bob Friesenhahn
All of these strategies are done in m4 and result in the configure script being re-generated, which seems senseless and annoying to me. I will do anything in my power to not modify what has already been exhaustively tested just seconds before a release. The new configure script might not even

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread
On 08/29/2014 03:01 PM, Shawn H Corey wrote: I'm new to all this but can this be done? m4_define([MAJOR_VERSION], [1]) m4_define([MINOR_VERSION], [0]) m4_define([PATCH_VERSION], [0]) m4_define([VERSION],[MAJOR_VERSION.MINOR_VERSION.PATCH_VERSION]) AC_INIT(foo,[VERSION]) AM_INIT_AUTOMAKE(foo,[V

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread Shawn H Corey
On Fri, 29 Aug 2014 19:55:53 +0100 Zé wrote: > So, it appears that defining the VERSION variable ends up replacing > the VERSION string in the output with the definition provided by the > newly added m4_define() line. I thought there might be a conflict. Try: m4_define([APP_MAJOR_VERSION], [1])

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread Zack Weinberg
On Fri, Aug 29, 2014 at 2:04 PM, Bob Friesenhahn wrote: > All of these strategies are done in m4 and result in the configure script > being re-generated, which seems senseless and annoying to me. So, I wonder, does anything break if you do it in shell instead? Just take Shawn's strategy and make

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread Frank Lahm
Am 29.08.2014 um 20:04 schrieb Bob Friesenhahn : > All of these strategies are done in m4 and result in the configure script > being re-generated, which seems senseless and annoying to me. I will do > anything in my power to not modify what has already been exhaustively tested > just seconds b

Re: Strategy to specify major, minor, and patch versions

2014-08-29 Thread Bob Friesenhahn
On Fri, 29 Aug 2014, Zack Weinberg wrote: If that works, you can then take the APP_{MAJOR,MINOR,PATCH}_VERSION= lines and split them out to their own file, let's call it VERSION.sh, and read it from configure.ac with ". $srcdir/VERSION.sh". I *think* $srcdir is set already at that point. The