Re: autoconf: AC_SYS_LARGEFILE should output to CPPFLAGS

2017-01-25 Thread Thorsten Glaser
On Wed, 25 Jan 2017, Zack Weinberg wrote: > > Interesting, as I recall seeing -D_FILE_OFFSET_BITS=64 on various > > compiler command lines when working under GNU. (I normally work > > under BSD at home, so I don’t know where exactly.) > > Is it possible that those programs were not using a config

Re: autoconf: AC_SYS_LARGEFILE should output to CPPFLAGS

2017-01-25 Thread Paul Eggert
On 01/25/2017 10:24 AM, Zack Weinberg wrote: The ChangeLog entry for the addition says "Import AC_SYS_LARGEFILE from largefile.m4 serial 12", so that sounds like there was an add-on .m4 file with the same functionality floating around prior to that - I don't know where to find copies of that file

Re: autoconf: AC_SYS_LARGEFILE should output to CPPFLAGS

2017-01-25 Thread Zack Weinberg
On Wed, Jan 25, 2017 at 1:02 PM, Thorsten Glaser wrote: > On Wed, 25 Jan 2017, Zack Weinberg wrote: > >> As far as I can tell from the Git history, AC_SYS_LARGEFILE has >> *always* used AC_DEFINE_UNQUOTED to define the various preprocessor >> macros that it can define (_FILE_OFFSET_BITS, _LARGE_FI

Re: autoconf: AC_SYS_LARGEFILE should output to CPPFLAGS

2017-01-25 Thread Thorsten Glaser
On Wed, 25 Jan 2017, Zack Weinberg wrote: > As far as I can tell from the Git history, AC_SYS_LARGEFILE has > *always* used AC_DEFINE_UNQUOTED to define the various preprocessor > macros that it can define (_FILE_OFFSET_BITS, _LARGE_FILES, and > _DARWIN_USE_64_BIT_INODE). Interesting, as I recall

Re: autoconf: AC_SYS_LARGEFILE should output to CPPFLAGS

2017-01-25 Thread Zack Weinberg
On Wed, Jan 25, 2017 at 12:21 PM, Thorsten Glaser wrote: > > Would you at least *consider* moving the definition back to some > command line argument? (Changing severity to wishlist now; if not, > we can likely close the bug, but I’d still like you to please at > least consider doing the change.)

Re: autoconf: AC_SYS_LARGEFILE should output to CPPFLAGS

2017-01-25 Thread Thorsten Glaser
severity 852617 wishlist tags 852617 = upstream thanks On Wed, 25 Jan 2017, Eric Blake wrote: > If the real-world package is not including config.h first, then that is > a bug in the real-world package that should be fixed there. Autoconf OK, I’ve (separately) reported the bug to xrdp upstream.

Re: autoconf: AC_SYS_LARGEFILE should output to CPPFLAGS

2017-01-25 Thread Eric Blake
On 01/25/2017 10:57 AM, Thorsten Glaser wrote: > On Wed, 25 Jan 2017, Thorsten Glaser wrote: > >> Looking at the source, AC_SYS_LARGEFILE calls AC_DEFINE_UNQUOTED, >> which appends to DEFS (which I agree with Tom Dickey is wrong) as >> Florian Weimer said, but — even more confusingly — only when >