Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-24 Thread Frederic Berat
I was a bit too conservative in my estimation, I'm done with the walkthrough. I summary, I found 7 packages affected by a false negative on headers check (mainly for stdbool.h), due to https://lists.gnu.org/archive/html/autoconf/2022-11/msg00127.html: ledmon, libmobi, libsafec, steghide, srmio, ru

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-18 Thread Frederic Berat
For now I track the failures through a "meta-bug" in Fedora [1], and create individual bugs for each package's maintainer individually as the analysis progresses [2][3][4][5], and if the issue is assumed to be on their side. Considering the amount of work, I leave the upstream discussion to the res

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-18 Thread Frederic Berat
There are about 70 softwares (in Fedora ecosystem at least) which are affected by this comma. It will be hard for one person to track the upstream for each of them individually. I'll probably create issues at the package level on our side, so that their respective maintainers track the issue with

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-18 Thread Bob Friesenhahn
On Thu, 17 Nov 2022, Paul Eggert wrote: Thanks for reporting that. I installed the attached patch to work around the bug in libpng. Of course this is just a hack, but there's some benefit to it and no harm that I can see. Could you please report the issue to the libpng maintainers? The attach

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-18 Thread Nick Bowler
On 2022-11-18, Frederic Berat wrote: > The apr program has shown a weird behavior during configure execution: [...] > I found that the problem was actually that "$EGREP_TRADITIONAL" was > undefined during the execution of AC_TYPE_UID_T. > While the corresponding symbol was constructed within a cas

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-18 Thread Sam James
> On 18 Nov 2022, at 07:11, Frederic Berat wrote: > > Thanks, I'll update the bug I opened for them. Could you share the links? Thanks. signature.asc Description: Message signed with OpenPGP

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-18 Thread Frederic Berat
Hello, I may have found a weird one with EGREP_TRADITIONAL. It'll be hard to have a snippet though, but I'll try to explain. The apr program has shown a weird behavior during configure execution: configure:26378: checking whether int64_t and long use fmt %ld configure:26413: gcc -c -g -O2 -Werr

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-17 Thread Frederic Berat
Thanks, I'll update the bug I opened for them. On Thu, Nov 17, 2022 at 6:54 PM Zack Weinberg wrote: > On 2022-11-17 9:30 AM, Zack Weinberg wrote: > > Or even better, get rid of the AC_EGREP_CPP at the same time > > > > AC_CACHE_CHECK([whether we need to define $1], ac_var, > > [AC_PREPRO

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-17 Thread Frederic Berat
Yes and yes. On Thu, Nov 17, 2022 at 7:16 PM Paul Eggert wrote: > On 2022-11-17 04:41, Frederic Berat wrote: > > They have the following code in their aclocal.m4{,.cross} files: > > Does the attached, self-contained configure.ac illustrate the problem > for you? I don't want to have to figure ou

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-17 Thread Paul Eggert
On 2022-11-17 04:41, Frederic Berat wrote: They have the following code in their aclocal.m4{,.cross} files: Does the attached, self-contained configure.ac illustrate the problem for you? I don't want to have to figure out all of Wine. Also, can you narrow down which Autoconf commit causes Wi

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-17 Thread Zack Weinberg
On 2022-11-17 9:30 AM, Zack Weinberg wrote: Or even better, get rid of the AC_EGREP_CPP at the same time AC_CACHE_CHECK([whether we need to define $1], ac_var, [AC_PREPROC_IFELSE([[#ifndef $1 #error not defined #endif]], [AS_VAR_SET(ac_var,yes)],[AS_VAR_SET(ac_var,no)])]) Cor

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-17 Thread Paul Eggert
Thanks for reporting that. I installed the attached patch to work around the bug in libpng. Of course this is just a hack, but there's some benefit to it and no harm that I can see. Could you please report the issue to the libpng maintainers? The attached second patch should work around the im

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-17 Thread Zack Weinberg
On Thu, Nov 17, 2022, at 7:41 AM, Frederic Berat wrote: > One more failure analysis, this time for Wine. > They have the following code in their aclocal.m4{,.cross} files: ... > dnl Check whether we need to define a symbol on the compiler command > line > dnl > dnl Usage: WINE_CHECK_DEFIN

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-17 Thread Frederic Berat
Hello again, One more failure analysis, this time for Wine. They have the following code in their aclocal.m4{,.cross} files: dnl Check whether we need to define a symbol on the compiler command line dnl dnl Usage: WINE_CHECK_DEFINE(name),[action-if-yes,[action-if-no]]) dnl AC_DEFUN([WIN

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Zack Weinberg
On Wed, Nov 16, 2022, at 4:06 AM, Frederic Berat wrote: > Hello again, > > Some progress on this, it looks like, at least for libpng, there is at one > place where the "Port AC_LANG_CALL" seems to be the culprit. > Specifically, the "," in the C comment, is interpreted by M4 as argument > split whi

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Frederic Berat
On Wed, Nov 16, 2022 at 5:05 PM Arsen Arsenović wrote: > > > Frederic Berat writes: > > > Some progress on this, it looks like, at least for libpng, there is at one > > place where the "Port AC_LANG_CALL" seems to be the culprit. > > Specifically, the "," in the C comment, is interpreted by M4 as

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Arsen Arsenović
Frederic Berat writes: > Some progress on this, it looks like, at least for libpng, there is at one > place where the "Port AC_LANG_CALL" seems to be the culprit. > Specifically, the "," in the C comment, is interpreted by M4 as argument > split which in turn leads to the syntax error. FWIW, I

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Frederic Berat
On Wed, Nov 16, 2022 at 4:27 PM Sam James wrote: > > > > > On 16 Nov 2022, at 07:41, Frederic Berat wrote: > > > > Hello, > > > > In the past few months, I worked on a tool that massively rebuild packages > > that depend on a specific other package, in order to help spot problems as > > early as

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Sam James
> On 16 Nov 2022, at 07:41, Frederic Berat wrote: > > Hello, > > In the past few months, I worked on a tool that massively rebuild packages > that depend on a specific other package, in order to help spot problems as > early as possible (on Fedora and RHEL so far). > I'm interested in this w

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Sam James
> On 16 Nov 2022, at 09:06, Frederic Berat wrote: > > Hello again, > > Some progress on this, it looks like, at least for libpng, there is at one > place where the "Port AC_LANG_CALL" seems to be the culprit. > Specifically, the "," in the C comment, is interpreted by M4 as argument > split wh

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Frederic Berat
After a few more hours of investigation, the failure in krb5 seems to be due to a bug in their aclocal.m4 file: a misplaced "fi" similar to the one fixed by v2.72c-10-g68fac90c: 'AC_FUNC_ALLOCA: fix a misplaced (now fatal) closing "fi"'. So I guess I can only dig into the other failures one by one

Re: Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Frederic Berat
Hello again, Some progress on this, it looks like, at least for libpng, there is at one place where the "Port AC_LANG_CALL" seems to be the culprit. Specifically, the "," in the C comment, is interpreted by M4 as argument split which in turn leads to the syntax error. I made a small test where I

Possible regressions with trunk autoconf (vs 2.71)

2022-11-16 Thread Frederic Berat
Hello, In the past few months, I worked on a tool that massively rebuild packages that depend on a specific other package, in order to help spot problems as early as possible (on Fedora and RHEL so far). I used this tool to check whether a new version of autoconf could lead to build failures in o