Re: Use of lexical binding plus various other things

2021-04-02 Thread Stefan Monnier
> Thanks. I've found one more occurrence of XEmacs compat code in > reftex-vars.el. Can you please install the attached patch as well? > TIA. Thanks, pushed. > Note to myself: We have to adjust RefTeX manual as well and mention the > removal of XEmacs support. I believe I just took care of tha

Re: Use of lexical binding plus various other things

2021-03-30 Thread Arash Esbati
Stefan Monnier writes: >> I suggest to apply the following change to reftex-auc.el. The declared >> functions are defined in ext:latex and not ext:tex; and the name of >> arguments are also corrected. I don't have access to emacs repo, do you >> mind install the change? > > Pushed, thanks, Tha

Re: Use of lexical binding plus various other things

2021-03-29 Thread Stefan Monnier
> I suggest to apply the following change to reftex-auc.el. The declared > functions are defined in ext:latex and not ext:tex; and the name of > arguments are also corrected. I don't have access to emacs repo, do you > mind install the change? Pushed, thanks, Stefan

Re: Use of lexical binding plus various other things

2021-03-29 Thread Arash Esbati
Stefan Monnier writes: >>> Many thanks for this. I ran `make' in tests directory and get the >>> following error (re-arranged for legibility): >> Thanks for the report. I don't experience such error, so I suppose that >> emacs 28 enhanced check for scope discrepancy between lexical and >> dynami

Re: Use of lexical binding plus various other things

2021-03-29 Thread Stefan Monnier
>> Many thanks for this. I ran `make' in tests directory and get the >> following error (re-arranged for legibility): > Thanks for the report. I don't experience such error, so I suppose that > emacs 28 enhanced check for scope discrepancy between lexical and > dynamic variables. (I'm using emacs

Re: Use of lexical binding plus various other things

2021-03-29 Thread Ikumi Keita
Hi Arash, > Arash Esbati writes: > Many thanks for this. I ran `make' in tests directory and get the > following error (re-arranged for legibility): Thanks for the report. I don't experience such error, so I suppose that emacs 28 enhanced check for scope discrepancy between lexical and dyna

Re: Use of lexical binding plus various other things

2021-03-29 Thread Arash Esbati
Ikumi Keita writes: >> Ikumi Keita writes: >> Stefan Monnier writes: >>> BTW, I rebased my branch on top of your patch, and hence on top of >>> auctex.git's `master`. > >> Thanks, I'd like to merge them into AUCTeX repository. If nobody >> objects, I'll do it soon. > > Merged. Many tha

Re: Use of lexical binding plus various other things

2021-03-24 Thread Stefan Monnier
>> Thanks, I'd like to merge them into AUCTeX repository. If nobody >> objects, I'll do it soon. > Merged. Great, thanks! Stefan

Re: Use of lexical binding plus various other things

2021-03-24 Thread Ikumi Keita
> Ikumi Keita writes: > Stefan Monnier writes: >> BTW, I rebased my branch on top of your patch, and hence on top of >> auctex.git's `master`. > Thanks, I'd like to merge them into AUCTeX repository. If nobody > objects, I'll do it soon. Merged. Bye, Ikumi Keita

Re: Use of lexical binding plus various other things

2021-03-24 Thread Ikumi Keita
> Stefan Monnier writes: > BTW, I rebased my branch on top of your patch, and hence on top of > auctex.git's `master`. Thanks, I'd like to merge them into AUCTeX repository. If nobody objects, I'll do it soon. Regards, Ikumi Keita

Re: Use of lexical binding plus various other things

2021-03-23 Thread Stefan Monnier
> Oh, I wasn't aware of that! Thank you. > > By the way again, here are two very minor issues about your update to > font-latex.el: > 1. The doc string of `font-latex-keywords-1' was formerly > "Subdued level highlighting for LaTeX modes." > , but is now > "High level highlighting for LaTeX modes."

Re: Use of lexical binding plus various other things

2021-03-23 Thread Ikumi Keita
> Stefan Monnier writes: > I think your patch is much better/cleaner than what I put in my branch > (since it removes those hideous advice), so if you push your patch to > AUCTeX's branch, I'll be happy to rebase my code on top if it. Thanks, I just pushed it. >> By the way, may I ask why ma

Re: Use of lexical binding plus various other things

2021-03-23 Thread Stefan Monnier
BTW, I rebased my branch on top of your patch, and hence on top of auctex.git's `master`. Stefan

Re: Use of lexical binding plus various other things

2021-03-23 Thread Stefan Monnier
>> Duh! Thanks for the heads up! >> Indeed, `defadvice` hides the code from the byte-compiler which is why >> I didn't get a warning for the (boundp 'begin). > > I expect that the attached patch makes preview.el.in ready for lexical > binding...oops, I just noticed that revised commit has been put

Re: Use of lexical binding plus various other things

2021-03-23 Thread Ikumi Keita
Hi Stefan, > Stefan Monnier writes: > Duh! Thanks for the heads up! > Indeed, `defadvice` hides the code from the byte-compiler which is why > I didn't get a warning for the (boundp 'begin). I expect that the attached patch makes preview.el.in ready for lexical binding...oops, I just notice

Re: Use of lexical binding plus various other things

2021-03-23 Thread Stefan Monnier
> Duh! Thanks for the heads up! > Indeed, `defadvice` hides the code from the byte-compiler which is why > I didn't get a warning for the (boundp 'begin). > And I clearly forgot my usual scan of `(set `. I (force) pushed an updated set of patches which should fix those problems. Stefan

Re: Use of lexical binding plus various other things

2021-03-23 Thread Stefan Monnier
> (defadvice TeX-region-create (around preview-counters) > "Write out counter information to region." > (let ((TeX-region-extra > (concat > (and (boundp 'begin) > ^ >preview-buffer-has-counters >(mapconcat >

Re: Use of lexical binding plus various other things

2021-03-22 Thread Ikumi Keita
Hi Stefan, > Stefan Monnier writes: > I pushed to the branch `scratch/auctex-lexbind` of the `elpa.git` > repository a series of 10 patches which convert all of AUCTeX to use > lexical binding, and includes various other more or less > cosmetic changes. > The commit log is below, the overall