Re: ath10k: fix bug in masking of TID value

2018-06-28 Thread Kalle Valo
; This was found during code review. > > Signed-off-by: Erik Stromdahl > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. d1a566bec588 ath10k: fix bug in masking of TID value -- https://patchwork.kernel.org/patch/10466271/ https://wireless.wiki.k

Re: [PATCH] ath10k: fix bug in masking of TID value

2018-06-15 Thread Erik Stromdahl
Hi Kalle, On 06/15/2018 02:58 PM, Kalle Valo wrote: Erik Stromdahl writes: Although the TID mask is 0xf, the modulus operation does still not produce identical results as the bitwise and operator. If the TID is 15, the modulus operation will "convert" it to 0, whereas the bitwise and will ke

Re: [PATCH] ath10k: fix bug in masking of TID value

2018-06-15 Thread Kalle Valo
Erik Stromdahl writes: > Although the TID mask is 0xf, the modulus operation does still not > produce identical results as the bitwise and operator. > > If the TID is 15, the modulus operation will "convert" it to 0, whereas > the bitwise and will keep it as 15. > > Signed-off-by: Erik Stromdahl

[PATCH] ath10k: fix bug in masking of TID value

2018-06-15 Thread Erik Stromdahl
Although the TID mask is 0xf, the modulus operation does still not produce identical results as the bitwise and operator. If the TID is 15, the modulus operation will "convert" it to 0, whereas the bitwise and will keep it as 15. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k