Re: [PATCH] ath10k: fix wmi service bitmap

2014-08-25 Thread Kalle Valo
Michal Kazior writes: > Service mapping for main firmware branch was > incorrectly used for 10.x firmware and vice-versa. > This caused wmi_services in debugfs to print wrong > values. > > This actually fixes a problem with the previous > wmi service bitmap patch itself. For some reason > there w

[PATCH] ath10k: fix wmi service bitmap

2014-08-19 Thread Michal Kazior
Service mapping for main firmware branch was incorrectly used for 10.x firmware and vice-versa. This caused wmi_services in debugfs to print wrong values. This actually fixes a problem with the previous wmi service bitmap patch itself. For some reason there was either a conflict that wasn't resolv

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-19 Thread Kalle Valo
Michal Kazior writes: > On 12 August 2014 09:44, Kalle Valo wrote: >> Michal Kazior writes: >> >>> The 10.x and main firmware branches have >>> conflicting WMI service bitmap definitions. >>> >>> This also fixes WMI services parsing on big-endian >>> hosts and changes debugfs output to be more

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-19 Thread Michal Kazior
On 12 August 2014 09:44, Kalle Valo wrote: > Michal Kazior writes: > >> The 10.x and main firmware branches have >> conflicting WMI service bitmap definitions. >> >> This also fixes WMI services parsing on big-endian >> hosts and changes debugfs output to be more human >> friendly. >> >> Signed-o

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-12 Thread Kalle Valo
Michal Kazior writes: > The 10.x and main firmware branches have > conflicting WMI service bitmap definitions. > > This also fixes WMI services parsing on big-endian > hosts and changes debugfs output to be more human > friendly. > > Signed-off-by: Michal Kazior Thanks, applied. -- Kalle Valo

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-08 Thread Kalle Valo
Michal Kazior writes: >> Based on Joe's suggestion, I'm planning to change the macro like below. >> Are you ok with that? >> >> It actually adds a new checkpatch warning but I'm going to ignore that >> for now: >> >> drivers/net/wireless/ath/ath10k/wmi.h:177: ERROR: Macros with complex values >>

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-08 Thread Michal Kazior
On 8 August 2014 12:11, Kalle Valo wrote: > Michal Kazior writes: > >> The 10.x and main firmware branches have >> conflicting WMI service bitmap definitions. >> >> This also fixes WMI services parsing on big-endian >> hosts and changes debugfs output to be more human >> friendly. >> >> Signed-of

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-08 Thread Kalle Valo
Michal Kazior writes: > The 10.x and main firmware branches have > conflicting WMI service bitmap definitions. > > This also fixes WMI services parsing on big-endian > hosts and changes debugfs output to be more human > friendly. > > Signed-off-by: Michal Kazior Based on Joe's suggestion, I'm p

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-02 Thread Kalle Valo
Joe Perches writes: >> This introduces a new checkpatch warning: >> >> drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around >> that ':' (ctx:VxE) >> >> But I think that's just a false warning and I should ignore it. Any >> other ideas? > > I don't get a warning with this pa

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-02 Thread Joe Perches
On Sat, 2014-08-02 at 09:39 +0300, Kalle Valo wrote: > Michal Kazior writes: > > > The 10.x and main firmware branches have > > conflicting WMI service bitmap definitions. > > > > This also fixes WMI services parsing on big-endian > > hosts and changes debugfs output to be more human > > friendly

Re: [PATCH] ath10k: fix wmi service bitmap debug

2014-08-01 Thread Kalle Valo
Michal Kazior writes: > The 10.x and main firmware branches have > conflicting WMI service bitmap definitions. > > This also fixes WMI services parsing on big-endian > hosts and changes debugfs output to be more human > friendly. > > Signed-off-by: Michal Kazior [...] > + SVCSTR(WMI_SERVIC

[PATCH] ath10k: fix wmi service bitmap debug

2014-07-29 Thread Michal Kazior
The 10.x and main firmware branches have conflicting WMI service bitmap definitions. This also fixes WMI services parsing on big-endian hosts and changes debugfs output to be more human friendly. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/core.h | 2 +- drivers/net/wire