Re: [PATCH] ath10k: add configurable debugging.

2017-06-01 Thread Kalle Valo
Adrian Chadd writes: --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -2444,6 +2444,8 @@ struct ath10k *ath10k_core_create(size_t priv_size, struct device *dev, ar->hw_rev = hw_rev; ar->hif.ops = hif_ops;

Re: [PATCH] ath10k: add configurable debugging.

2017-06-01 Thread Adrian Chadd
On 1 June 2017 at 06:24, Kalle Valo wrote: > Arend van Spriel writes: > >> On 31-05-17 14:16, Kalle Valo wrote: >>> Adrian Chadd writes: >>> This adds a few configurable debugging options: * driver debugging and tracing is now configurable per device * driver debugging and tr

Re: [PATCH] ath10k: add configurable debugging.

2017-06-01 Thread Kalle Valo
Arend van Spriel writes: > On 31-05-17 14:16, Kalle Valo wrote: >> Adrian Chadd writes: >> >>> This adds a few configurable debugging options: >>> >>> * driver debugging and tracing is now configurable per device >>> * driver debugging and tracing is now configurable at runtime >>> * the debugg

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Adrian Chadd
On 31 May 2017 at 14:28, Arend van Spriel wrote: > On 31-05-17 22:23, Adrian Chadd wrote: >> On 31 May 2017 at 13:20, Arend van Spriel >> wrote: >>> On 31-05-17 14:16, Kalle Valo wrote: Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver deb

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Arend van Spriel
On 31-05-17 22:23, Adrian Chadd wrote: > On 31 May 2017 at 13:20, Arend van Spriel > wrote: >> On 31-05-17 14:16, Kalle Valo wrote: >>> Adrian Chadd writes: >>> This adds a few configurable debugging options: * driver debugging and tracing is now configurable per device * dri

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Adrian Chadd
On 31 May 2017 at 13:20, Arend van Spriel wrote: > On 31-05-17 14:16, Kalle Valo wrote: >> Adrian Chadd writes: >> >>> This adds a few configurable debugging options: >>> >>> * driver debugging and tracing is now configurable per device >>> * driver debugging and tracing is now configurable at ru

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Arend van Spriel
On 31-05-17 14:16, Kalle Valo wrote: > Adrian Chadd writes: > >> This adds a few configurable debugging options: >> >> * driver debugging and tracing is now configurable per device >> * driver debugging and tracing is now configurable at runtime >> * the debugging / tracing is not run at all (bes

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Kalle Valo
Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device > * driver debugging and tracing is now configurable at runtime > * the debugging / tracing is not run at all (besides a mask check) > unless the specific deb

Re: [PATCH] ath10k: add configurable debugging.

2017-05-31 Thread Kalle Valo
Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device So this means that there's a debugfs file /sys/kernel/debug/ieee80211/phy0/ath10k/debug for every ath10k device. Sounds like a good idea. I just don't like the

Re: [PATCH] ath10k: add configurable debugging.

2017-05-19 Thread Kalle Valo
Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device > * driver debugging and tracing is now configurable at runtime > * the debugging / tracing is not run at all (besides a mask check) > unless the specific deb

Re: [PATCH] ath10k: add configurable debugging.

2017-05-19 Thread Kalle Valo
Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device > * driver debugging and tracing is now configurable at runtime > * the debugging / tracing is not run at all (besides a mask check) > unless the specific deb

[PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Adrian Chadd
This adds a few configurable debugging options: * driver debugging and tracing is now configurable per device * driver debugging and tracing is now configurable at runtime * the debugging / tracing is not run at all (besides a mask check) unless the specific debugging bitmap field is configured.

Re: [PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Adrian Chadd
grr, no. lemme go re-add that and resubmit. thanks! -a On 10 May 2017 at 09:44, Steve deRosier wrote: > Hi Adrian, > > On Wed, May 10, 2017 at 9:25 AM, Adrian Chadd wrote: > >> diff --git a/drivers/net/wireless/ath/ath10k/debug.h >> b/drivers/net/wireless/ath/ath10k/debug.h >> index 257d109

Re: [PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Steve deRosier
Hi Adrian, On Wed, May 10, 2017 at 9:25 AM, Adrian Chadd wrote: > diff --git a/drivers/net/wireless/ath/ath10k/debug.h > b/drivers/net/wireless/ath/ath10k/debug.h > index 257d10985c6e..7bd461927029 100644 > --- a/drivers/net/wireless/ath/ath10k/debug.h > +++ b/drivers/net/wireless/ath/ath10k/de

[PATCH] ath10k: add configurable debugging.

2017-05-10 Thread Adrian Chadd
This adds a few configurable debugging options: * driver debugging and tracing is now configurable per device * driver debugging and tracing is now configurable at runtime * the debugging / tracing is not run at all (besides a mask check) unless the specific debugging bitmap field is configured.