[kvalo-ath:ath-qca] BUILD SUCCESS 030d640c8b9b10b2e27531f77b892d50d44a004d

2023-09-21 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20230921 gcc arm allmodconfig gcc arm allnoconfig

[kvalo-ath:ath-next] BUILD SUCCESS 9066794113c4813b6ce4a66ed6ce14ecdf35625d

2023-09-21 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20230921 gcc arm allmodconfig

[kvalo-ath:master-pending] BUILD SUCCESS d76dd5111439961c375ddbe4a9cd1823519f7797

2023-09-21 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20230921 gcc arm allmodconfig

[kvalo-ath:master] BUILD SUCCESS 73e13f6a439b75a9dbc84bbfa0b0d6624b354853

2023-09-21 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20230921 gcc arm allmodconfig

Re: [PATCH 1/6] [v3] wifi: ath10k: cleanup CE ring initialization

2023-09-21 Thread Kalle Valo
Dmitry Antipov writes: >> If most/all of the functions return the same error value type as int >> it makes a lot easier to read the code. > > ...but still not sure that this is reasonable for any non-trivial piece > of the source code. What's the concrete benefit from having few functions which

Re: [PATCH 1/6] [v3] wifi: ath10k: cleanup CE ring initialization

2023-09-21 Thread Dmitry Antipov
On 9/20/23 16:23, Kalle Valo wrote: I have on purpose avoided to use void functions in ath10k/ath11k/ath12k. The problem is that if some of the functions return void and some of the functions return int it's much harder to review the code. I realize that you're constantly overloaded with revi

Re: [PATCH] wifi: ath10k: drop HTT_DATA_TX_STATUS_DOWNLOAD_FAIL

2023-09-21 Thread Kalle Valo
Dmitry Antipov wrote: > According to Jeff, 'HTT_DATA_TX_STATUS_DOWNLOAD_FAIL' from > 'enum htt_data_tx_status' is never actually used by the > firmware code and so may be dropped, with the related > adjustment to 'ath10k_htt_rx_tx_compl_ind()'. > > Suggested-by: Jeff Johnson > Signed-off-by: Dm

Re: [PATCH] wifi: ath10k: Annotate struct ath10k_ce_ring with __counted_by

2023-09-21 Thread Kalle Valo
Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for