Re: [PATCH v3 2/3] ath10k: Disable interface pause wow config for integrated chipset

2019-02-07 Thread Kalle Valo
Govind Singh wrote: > wow pause iface config controls the PCI D0/D3-WOW cases for pcie > bus state. Firmware does not expects WOW_IFACE_PAUSE_ENABLED config > for bus/link that cannot be suspended ex:snoc and does not trigger > common subsystem shutdown. > Disable interface pause wow config for i

Re: [PATCH 1/2] ath10k: Assign 'n_cipher_suites = 11' for WCN3990 to enable WPA3

2019-02-07 Thread Kalle Valo
Abhishek Ambure wrote: > Hostapd uses CCMP, GCMP & GCMP-256 as 'wpa_pairwise' option to run WPA3. > In WCN3990 firmware cipher suite numbers 9 to 11 are for CCMP, > GCMP & GCMP-256. > > To enable CCMP, GCMP & GCMP-256 cipher suites in WCN3990 firmware, > host sets 'n_cipher_suites = 11' while in

Re: [PATCH] ath10k: Fill tx_duration for each peer in Tx stats per STA

2019-02-07 Thread Kalle Valo
Surabhi Vishnoi wrote: > Firmware sends the tx_duration for each in HTT_T2H_MSG_TYPE_PEER_STATS > msg. Fill the tx_duration sent by firmware in the tx stats information > per STA. > > Tested HW: WCN3990 > Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1, >WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1

Re: [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly

2019-02-07 Thread Kalle Valo
Surabhi Vishnoi wrote: > The firmware advertises the LDPC support information for HT in > HT capability info in the wmi service ready event. To provide > granularity, firmware now advertises WMI_HT_CAP_RX_LDPC and > WMI_HT_CAP_TX_LDPC separately. To support LDPC, host should > also check for WMI_

Re: [PATCH] ath10k: reduce transmit msdu count

2019-02-07 Thread Kalle Valo
Wen Gong wrote: > Reduce the transmit MSDU count for SDIO, to match with the descriptors > as used by the firmware. This also acts as a high watermark level for > transmit. Too many packets to the firmware results in transmit overflow > interrupt. > > It only affect SDIO chip, it will not cause

Re: [PATCH] ath10k: do not return invalid pointers as a *dentry

2019-02-07 Thread Kalle Valo
Greg Kroah-Hartman wrote: > When calling debugfs functions, they can now return error values if > something went wrong. If that happens, return a NULL as a *dentry to > the relay core instead of passing it an illegal pointer. > > The relay core should be able to handle an illegal pointer, but a

Re: [PATCH][RESEND] ath10k: snoc: remove set but not used variable 'ar_snoc'

2019-02-07 Thread Kalle Valo
YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/ath/ath10k/snoc.c: In function > 'ath10k_snoc_tx_pipe_cleanup': > drivers/net/wireless/ath/ath10k/snoc.c:681:22: warning: > variable 'ar_snoc' set but not used [-Wunused-but-set-variable] > > Signed-of

Re: [PATCH] ath10k: sdio: add .owner field

2019-02-07 Thread Kalle Valo
Brian Norris wrote: > sdio_register_driver() doesn't do this for us, unlike (for example) > platform_driver_register(). This is important for helping track > module-to-device relationships. > > Signed-off-by: Brian Norris > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git

Re: [PATCH] ath10k: Change swap mail box check after htc ready

2019-02-07 Thread Kalle Valo
Wen Gong wrote: > The swap box flag of firmware is not set before htc ready, then it > will not set swap box flag in ath10k driver, and it will let swap > box setting not same between firmware and ath10k driver, then it > will trigger firmware assert failure. > > Check the flag and set swap box

Re: [PATCH] ath10k: Fix hw-restart crash inject mode for WCN3990

2019-02-07 Thread Kalle Valo
Rakesh Pillai wrote: > The hw-restart crash inject mode is a special mode, where > there is no crash generated in the firmware, but instead > the driver restarts the firmware. In order to restart WCN3990 > firmware, the driver needs to send qmi_wlan_disable message > followed by the qmi_wlan_enab

Re: [PATCH] ath10k: fix dma unmap direction for management frames

2019-02-07 Thread Kalle Valo
Rakesh Pillai wrote: > The management frames transmitted are dma mapped with > direction TO_DEVICE, but incorrectly mapped with > direction FROM_DEVICE during tx complete and error cases. > > Fix the direction of dma during dma unmap of the > transmitted management frames. > > Tested HW: WCN399

Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting

2019-02-07 Thread Kalle Valo
Peter Oh writes: > On 12/10/2018 08:56 PM, Pradeep Kumar Chitrapu wrote: >> From: Pradeep kumar Chitrapu >> >> Invalid rate code is sent to firmware when multicast rate value of 0 is >> sent to driver indicating disabled case, causing broken mesh path. >> so fix that. >> >> Tested on QCA9984 wit

Re: FW: [PATCH] ath10k: fix return value check in wake_tx_q op

2019-02-07 Thread Kalle Valo
(please don't top post) yiboz writes: > We have met performance issue on our two-core system after applying > your patch. In WDS mode, we found that the peak throughput in TCP-DL > and UDP-DL dropped more than 10% compared with previous one. And in > some cases, though throughput stays the same,

Re: [PATCH v2 1/2] ath10k: Handle bundled tx completion for management frames

2019-02-07 Thread Kalle Valo
Rakesh Pillai wrote: > WCN3990 supports sending tx completion for multiple > management frames bundled together in a single event. > > Add support to handle the bundled tx completion > event for WCN3990. > > Tested HW: WCN3990 > Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1 > > Signed-off-by: Ra

Re: [PATCH v2 1/1] ath10k: update HOST capability qmi message

2019-02-07 Thread Kalle Valo
Govind Singh wrote: > HOST capability interface data structures are updated > in HL3.1 fw version. Update the qmi host capability > members for compatibility across different firmware > versions. > Since this change breaks backward compatibility with > HL2.0 fw, HL2.0 fw upgrade to WLAN.HL.2.0-01

Re: [PATCH] ath10k: implement set_base_macaddr to fix rx-bssid mask in multiple APs conf

2019-02-07 Thread Ben Greear
On 02/07/2019 06:19 AM, Kalle Valo wrote: Christian Lamparter writes: On Monday, February 4, 2019 4:45:12 PM CET Kalle Valo wrote: Christian Lamparter writes: @@ -8885,6 +8904,7 @@ static const struct wmi_ops wmi_ops = { .gen_pdev_suspend = ath10k_wmi_op_gen_pdev_suspend,

Re: [PATCH] ath10k: Enable Factory Test Mode for WCN3990

2019-02-07 Thread Kalle Valo
Brian Norris writes: > On Wed, Aug 29, 2018 at 12:30:38PM +0530, Rakesh Pillai wrote: >> The support to put WCN3990 firmware into Factory >> test mode is not present currently. The WCN3990 >> firmware can operate in Factory test mode based >> on the mode it receives in the wlan enable message >>

Re: [PATCH] ath10k: implement set_base_macaddr to fix rx-bssid mask in multiple APs conf

2019-02-07 Thread Kalle Valo
Christian Lamparter writes: > On Monday, February 4, 2019 4:45:12 PM CET Kalle Valo wrote: >> Christian Lamparter writes: >> >> > @@ -8885,6 +8904,7 @@ static const struct wmi_ops wmi_ops = { >> > >> >.gen_pdev_suspend = ath10k_wmi_op_gen_pdev_suspend, >> >.gen_pdev_resume = ath10k_wm

Re: [PATCH] ath10k: Fill tx_duration for each peer in Tx stats per STA

2019-02-07 Thread Kalle Valo
+ lists Surabhi Vishnoi writes: > On 2019-02-04 21:03, Kalle Valo wrote: >> Surabhi Vishnoi writes: >> >>> Firmware sends the tx_duration for each in HTT_T2H_MSG_TYPE_PEER_STATS >>> msg. Fill the tx_duration sent by firmware in the tx stats information >>> per STA. >>> >>> Tested HW: WCN3990 >>

Re: [PATCH] ath10k: Add a condtion to fill the LDPC capability correctly

2019-02-07 Thread Kalle Valo
+ lists Surabhi Vishnoi writes: > On 2019-02-04 21:02, Kalle Valo wrote: >> Surabhi Vishnoi writes: >> >>> The firmware advertises the LDPC support information for HT in >>> HT capability info in the wmi service ready event. To provide >>> granularity, firmware now advertises WMI_HT_CAP_RX_LDPC