Re: ath10k failed to receive control response from QCA9888

2018-09-06 Thread Su Kang Yin
I have tried also Ubuntu 18.04 LTS, firmware crashed: [ 47.969872] ath10k_pci :08:00.0: board_file api 2 bmi_id 0:17 crc32 74a04250 [ 51.472590] ath10k_pci :08:00.0: firmware crashed! (guid b645cef3-35fb-4576-83a9-dc0117647f28) [ 51.481685] ath10k_pci :08:00.0: qca9888 hw2.0 targ

ath10k failed to receive control response from QCA9888

2018-09-06 Thread Su Kang Yin
Hi all, Currently I bought a wave2 W-FI card Compex WLE650V5-18A, but it failed to use on Linux 4.9.111 on x86, below are the kernel log and card info.Appreciate your inputs and help. Thanks / # modprobe ath10k_pci [67637.318466] ath10k_pci :08:00.0: pci irq msi oper_irq_mode 2 irq_mode

[for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation"

2018-09-06 Thread Brian Norris
Hi Greg / stable maintainer(s), IIUC, this commit is a good candidate for -stable. I just hit the bug on 4.14, because of new vendor firmware that noticed the mismatched length (an internal "assert"), but it seems like this is equally problematic from the kernel side for as long as this code exist

[PATCH v3 2/3] mac80211: support FTM responder configuration/statistics

2018-09-06 Thread Pradeep Kumar Chitrapu
New bss param ftm_responder is used to notify the driver to enable fine timing request (FTM) responder role in AP mode. Plumb the new cfg80211 API for FTM responder statistics through to the driver API in mac80211. Signed-off-by: David Spinadel Signed-off-by: Johannes Berg Signed-off-by: Pradee

[PATCH v3 0/3] support ftm responder configuration/statistics

2018-09-06 Thread Pradeep Kumar Chitrapu
Currently ftm_responder parameter in hostapd.conf is only used for fine timing measurement (FTM) capability advertisement and actual control of the functionality is with low-level device/driver. This leads to confusion to the user when the capability advertisement is different from actual FTM respo

[PATCH v3 1/3] cfg80211: support FTM responder configuration/statistics

2018-09-06 Thread Pradeep Kumar Chitrapu
Allow userspace to enable fine timing measurement responder functionality with configurable LCI/Civic parameters in AP mode. This can be done at AP start or changing beacon parameters. A new EXT_FEATURE flag is introduced for drivers to advertise the capability. Also nl80211 API support for retri

[PATCH v3 3/3] ath10k: Add support to configure ftm responder role

2018-09-06 Thread Pradeep Kumar Chitrapu
Configure fine timing measurement (FTM) responder role from the ftm_responder bss param sent by mac80211. With FTM functionality offloaded to firmware, adding the interface allows userspace to enable FTM responder functionality. ath10k disables it at the time of interface creation. Supported FW: 1

Re: [PATCH v3 0/3] support ftm responder configuration/statistics

2018-09-06 Thread Johannes Berg
I'm not sure what you're doing, but this time only the cover letter made it to the list, afaict. maybe try to resend from somewhere else? johannes > ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [RFC v5 01/12] ath10k: add struct ath10k_bus_params

2018-09-06 Thread Erik Stromdahl
Hi Kalle, On 9/6/18 6:16 PM, Kalle Valo wrote: Erik Stromdahl wrote: This struct is used as argument to ath10k_core_register in order to make it easier to add more bus parameters in the future. Signed-off-by: Erik Stromdahl Signed-off-by: Kalle Valo 12 patches applied to ath-next branch

[PATCH v3 3/3] ath10k: Add support to configure ftm responder role

2018-09-06 Thread Pradeep Kumar Chitrapu
Configure fine timing measurement (FTM) responder role from the ftm_responder bss param sent by mac80211. With FTM functionality offloaded to firmware, adding the interface allows userspace to enable FTM responder functionality. ath10k disables it at the time of interface creation. Supported FW: 1

[PATCH v3 0/3] support ftm responder configuration/statistics

2018-09-06 Thread Pradeep Kumar Chitrapu
Currently ftm_responder parameter in hostapd.conf is only used for fine timing measurement (FTM) capability advertisement and actual control of the functionality is with low-level device/driver. This leads to confusion to the user when the capability advertisement is different from actual FTM respo

[PATCH v3 2/3] mac80211: support FTM responder configuration/statistics

2018-09-06 Thread Pradeep Kumar Chitrapu
New bss param ftm_responder is used to notify the driver to enable fine timing request (FTM) responder role in AP mode. Plumb the new cfg80211 API for FTM responder statistics through to the driver API in mac80211. Signed-off-by: David Spinadel Signed-off-by: Johannes Berg Signed-off-by: Pradee

[PATCH v3 1/3] cfg80211: support FTM responder configuration/statistics

2018-09-06 Thread Pradeep Kumar Chitrapu
Allow userspace to enable fine timing measurement responder functionality with configurable LCI/Civic parameters in AP mode. This can be done at AP start or changing beacon parameters. A new EXT_FEATURE flag is introduced for drivers to advertise the capability. Also nl80211 API support for retri

Re: [PATCH v3 0/3] support ftm responder configuration/statistics

2018-09-06 Thread Kalle Valo
Johannes Berg writes: > On Thu, 2018-09-06 at 18:15 +0300, Kalle Valo wrote: >> >> Actually patch 3 made it: >> >> https://patchwork.kernel.org/patch/10590115/ >> >> But it didn't get the rest as it says "Untitled series #15763". >> Patchwork was timing out for me quite heavily so in that way

Re: [RFC v5 01/12] ath10k: add struct ath10k_bus_params

2018-09-06 Thread Kalle Valo
Erik Stromdahl wrote: > This struct is used as argument to ath10k_core_register in order to > make it easier to add more bus parameters in the future. > > Signed-off-by: Erik Stromdahl > Signed-off-by: Kalle Valo 12 patches applied to ath-next branch of ath.git, thanks. c0d8d565787c ath10k:

Re: [PATCH 1/3] ath10k: optimize pci diag mem read & write operations

2018-09-06 Thread Kalle Valo
Carl Huang wrote: > Delay 1ms is too long for both diag read and write operations. > This is observed when writing a big memory buffer to target or > reading a big memory buffer from target. Take writing/reading > 512k bytes as example, the delay itself is 256ms as the maximum > length of every w

Re: [PATCH v3 0/3] support ftm responder configuration/statistics

2018-09-06 Thread Johannes Berg
On Thu, 2018-09-06 at 18:15 +0300, Kalle Valo wrote: > > Actually patch 3 made it: > > https://patchwork.kernel.org/patch/10590115/ > > But it didn't get the rest as it says "Untitled series #15763". > Patchwork was timing out for me quite heavily so in that way I'm not > surprised that patches

Re: [PATCHv2 3/3] ath10k: average ack rssi support for data frames

2018-09-06 Thread Kalle Valo
Balaji Pothunoori wrote: > Average ack rssi value is weighted average of ack rssi for > no of msdu's has been sent. > This feature is enabled by the host driver if firmware is capable. > After receiving event from host, firmware allocates the necessary > memory to store the ack_rssi for data pack

Re: [PATCH 1/1] ath10k: avoid possible memory access violation

2018-09-06 Thread Kalle Valo
"K.T.VIJAYAKUMAAR" wrote: > array "ctl_power_table" access index "pream" is initialized with -1 and > is raised as a static analysis tool issue. > [drivers\net\wireless\ath\ath10k\wmi.c:4719] -> > [drivers\net\wireless\ath\ath10k\wmi.c:4730]: (error) Array index -1 is > out of bounds. > > Since

Re: [PATCHv2 1/4] ath10k: get the legacy rate index to update the txrate table

2018-09-06 Thread Kalle Valo
ako...@codeaurora.org wrote: > Get the legacy rate index to update the pkts/bytes counter > against each possible tx rate. > > Signed-off-by: Anilkumar Kolli > Signed-off-by: Kalle Valo 4 patches applied to ath-next branch of ath.git, thanks. 0189dbd71cbd ath10k: get the legacy rate index to

Re: [PATCH 1/2] ath10k: Support extended board data download for dual-band QCA9984

2018-09-06 Thread Kalle Valo
Sathishkumar Muruganandam wrote: > Just moving functions down in the file, no functional changes. > > Signed-off-by: Sathishkumar Muruganandam > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 5849ed48d226 ath10k: refactoring needed for extended board data

Re: [PATCH 1/2] ath10k: Introduce CE_ATTR_POLL attribute for polling pipe

2018-09-06 Thread Kalle Valo
Govind Singh wrote: > Existing copy engine interrupt enable logic assumes that last > CE is using polling mode and due to this interrupt for last copy engine > are always disabled. WCN3990 uses last CE for pktlog and > interrupt remains disabled with existing logic. > > To mitigate this issue, i

Re: [PATCH v3 0/3] support ftm responder configuration/statistics

2018-09-06 Thread Kalle Valo
Johannes Berg writes: > On Wed, 2018-09-05 at 18:01 -0700, Pradeep Kumar Chitrapu wrote: >> Currently ftm_responder parameter in hostapd.conf is only used for fine >> timing measurement (FTM) capability advertisement and actual control of >> the functionality is with low-level device/driver. This

Re: [PATCH] ath10k: Fix tx status flag setting for management frames

2018-09-06 Thread Rakesh Pillai
Hi All, Please ignore this patchset. I have added the Tested HW/FW info and sent the v2 version for this patchset. Thanks, Rakesh Pillai. On 2018-09-06 18:50, Rakesh Pillai wrote: The tx_status for management frames is being filled incorrectly in the flags of skb_cb. This incorrect flag sett

[PATCH v2] ath10k: Fix tx status flag setting for management frames

2018-09-06 Thread Rakesh Pillai
The tx_status for management frames is being filled incorrectly in the flags of skb_cb. This incorrect flag setting causes the upper layers to consider that the particular frame was not transmitted properly, leading to improper behavior. Set the IEEE80211_TX_STAT_ACK flag in the info flags of skb_

[PATCH] ath10k: Fix tx status flag setting for management frames

2018-09-06 Thread Rakesh Pillai
The tx_status for management frames is being filled incorrectly in the flags of skb_cb. This incorrect flag setting causes the upper layers to consider that the particular frame was not transmitted properly, leading to improper behavior. Set the IEEE80211_TX_STAT_ACK flag in the info flags of skb_

Re: [PATCH v2 3/3] ath10k: management tx ack rssi capability check

2018-09-06 Thread Balaji Pothunoori
On 2018-08-29 14:23, Johannes Berg wrote: On Thu, 2018-07-19 at 18:56 +0530, Balaji Pothunoori wrote: - if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map)) + if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map) || + test_bit(WMI_SERVICE_HTT_MGMT_TX_COMP_VALID_FL

Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2018-09-06 Thread Toke Høiland-Jørgensen
Grant Grundler writes: >> And, well, Grant's data is from a single test in a noisy >> environment where the time series graph shows that throughput is all over >> the place for the duration of the test; so it's hard to draw solid >> conclusions from (for instance, for the 5-stream test, the avera

Re: [RFC v2] ath10k: report tx rate using ieee80211_tx_status()

2018-09-06 Thread Anilkumar Kolli
On 2018-09-03 15:48, Johannes Berg wrote: On Fri, 2018-08-31 at 15:29 +0300, Kalle Valo wrote: Too me this feels like a bad idea but I'm not familiar enough with mac80211 to really comment on this. What kind of implications does this have for Mesh or ATF, for example? Adding Johannes and Toke