[PATCH] ath10k: fix parenthesis alignment

2018-07-30 Thread Kalle Valo
These were recently introduced and found by checkpatch: drivers/net/wireless/ath/ath10k/mac.c:6118: Alignment should match open parenthesis drivers/net/wireless/ath/ath10k/mac.c:6121: Alignment should match open parenthesis drivers/net/wireless/ath/ath10k/mac.c:6124: Alignment should match open

Re: [PATCH] ath10k: Limit available channels via DT ieee80211-freq-limit

2018-07-30 Thread Arend van Spriel
On 7/30/2018 8:54 PM, Arend van Spriel wrote: + Rafał On 7/30/2018 5:39 PM, Sven Eckelmann wrote: Tri-band devices (1x 2.4GHz + 2x 5GHz) often incorporate special filters in the RX and TX path. These filtered channel can in theory still be used by the hardware but the signal strength is reduced

Re: [PATCH] ath10k: Limit available channels via DT ieee80211-freq-limit

2018-07-30 Thread Arend van Spriel
+ Rafał On 7/30/2018 5:39 PM, Sven Eckelmann wrote: Tri-band devices (1x 2.4GHz + 2x 5GHz) often incorporate special filters in the RX and TX path. These filtered channel can in theory still be used by the hardware but the signal strength is reduced so much that it makes no sense. There is alre

Re: [PATCH] ath10k: Limit available channels via DT ieee80211-freq-limit

2018-07-30 Thread Arend van Spriel
+ Rafał On 7/30/2018 5:39 PM, Sven Eckelmann wrote: Tri-band devices (1x 2.4GHz + 2x 5GHz) often incorporate special filters in the RX and TX path. These filtered channel can in theory still be used by the hardware but the signal strength is reduced so much that it makes no sense. There is alre

Re: [PATCH] ath10k: add debugfs file warm_hw_reset

2018-07-30 Thread Kalle Valo
Maharaja Kennadyrajan wrote: > Debugfs support to do hardware warm reset with WMI command > WMI_PDEV_PARAM_PDEV_RESET for 10.4 and 10.2.4(if wmi > service is enabled in the firmware for backward compatibility). > > This change is purely for debugging purpose when hardware hangs/mutes. > > This

Re: [PATCH] ath10k: htt_tx: move lock into id_get function

2018-07-30 Thread Kalle Valo
Nicholas Mc Guire wrote: > This is only code refactoring as all call sites of > ath10k_htt_tx_alloc_msdu_id() take the same lock it can be moved into the > id_get function and the assertion dropped. > > Signed-off-by: Nicholas Mc Guire > Signed-off-by: Kalle Valo Patch applied to ath-next bra

Re: [PATCH] ath10k: remove redundant pointers 'dev' and 'noa'

2018-07-30 Thread Kalle Valo
Colin King wrote: > Pointers dev and noa are being assigned but are never used hence they > are redundant and can be removed. > > Cleans up clang warnings: > warning: variable 'dev' set but not used [-Wunused-but-set-variable] > warning: variable 'noa' set but not used [-Wunused-but-set-variable

[PATCH] ath10k: Protect against buggy firmware.

2018-07-30 Thread greearb
From: Ben Greear While testing some buggy wave-2 firmware, I was seeing full kernel crashes. Adding this additional check keeps the kernel from crashing. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/htt_rx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

Re: [PATCH 1/2] ath10k: Disable bundle mgmt tx completion event support

2018-07-30 Thread Kalle Valo
Rakesh Pillai wrote: > The tx completion of multiple mgmt frames can be bundled > in a single event and sent by the firmware to host, if this > capability is not disabled explicitly by the host. If the host > cannot handle the bundled mgmt tx completion, this capability > support needs to be disa

Re: [PATCH v2] ath10k: support for multicast rate control

2018-07-30 Thread Kalle Valo
Pradeep Kumar Chitrapu wrote: > Issues a wmi command to firmware when multicast rate change is received with > the > new BSS_CHANGED_MCAST_RATE flag. Also fixes the incorrect fixed_rate setting > for CCK rates which got introduced with addition of ath10k_rates_rev2 enum. > > Tested on QCA9984

Re: [PATCH] ath10k: fix open brace location inath10k_wmi_tlv_op_gen_dbglog_cfg()

2018-07-30 Thread Kalle Valo
Kalle Valo wrote: > Fixes a recently added checkpatch warning: > > wmi-tlv.c:2703: open brace '{' following function definitions go on the next > line > > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 1e3c43a7f111 ath10k: fix open brace location in ath10k_w

[PATCH] ath10k: Limit available channels via DT ieee80211-freq-limit

2018-07-30 Thread Sven Eckelmann
Tri-band devices (1x 2.4GHz + 2x 5GHz) often incorporate special filters in the RX and TX path. These filtered channel can in theory still be used by the hardware but the signal strength is reduced so much that it makes no sense. There is already a DT property to limit the available channels but a