Re: 160 mhz crash

2018-06-28 Thread Sebastian Gottschall
Am 28.06.2018 um 14:24 schrieb Sven Eckelmann: On Donnerstag, 28. Juni 2018 11:56:39 CEST Sebastian Gottschall wrote: btw. openwrt imported my patches recently, but with some openwrt specific modifications Thanks, just tested these [1]. It doesn't crash anymore and at least the basic functio

Re: ath10k-firmware: QCA4019 hw1.0: Add ZyXEL WRE6606 specific BDFs

2018-06-28 Thread Skorpy
Hi, This is a set of board.bin files for the ZyXEL WRE6606 Router [0], which I wish to be added to the ath10k-firmware repository. As per the current "Submitting board files" guidelines [1]: * description for what hardware this is: - it is a IPQ4018 based board [0] - one QCA40xx radio i

Re: 160 mhz crash

2018-06-28 Thread Sven Eckelmann
On Donnerstag, 28. Juni 2018 11:56:39 CEST Sebastian Gottschall wrote: > btw. openwrt imported my patches recently, but with some openwrt > specific modifications Thanks, just tested these [1]. It doesn't crash anymore and at least the basic functionality seems to work. On Donnerstag, 28. Juni

ath10k: tpc_stats(_final) odd twicepowers and 160Mhz not supported

2018-06-28 Thread Sven Eckelmann
Hi, I have some small question regarding the debugging functionality introduced by commit bc64d05220f3 ("ath10k: debugfs support to get final TPC stats for 10.4 variants") [1] and commit 295426669cd6 ("ath10k: implement debugfs interface for Transmit Power Control stats") [2]. Goal of this is t

Re: [1/2] ath10k: rename HTC_HOST_MAX_MSG_PER_BUNDLE define

2018-06-28 Thread Kalle Valo
Erik Stromdahl wrote: > This define is only used for RX bundling so it is more descriptive if > RX is added to the define-name. > > Signed-off-by: Erik Stromdahl > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. ab687de9535c ath10k: rename HTC_HOST_MAX_MSG_

Re: 160 mhz crash

2018-06-28 Thread Sebastian Gottschall
btw. openwrt imported my patches recently, but with some openwrt specific modifications Am 28.06.2018 um 08:46 schrieb Sven Eckelmann: On Samstag, 16. Juni 2018 10:11:27 CEST Sebastian Gottschall wrote: this is normal. i already posted a patch on this mailinglist to resolve this issue, but b

Re: 160 mhz crash

2018-06-28 Thread Sebastian Gottschall
Am 28.06.2018 um 08:46 schrieb Sven Eckelmann: On Samstag, 16. Juni 2018 10:11:27 CEST Sebastian Gottschall wrote: this is normal. i already posted a patch on this mailinglist to resolve this issue, but but it hasnt found its way to the main source yes. Problem seems to be that the patch [1

Re: ath10k: fix bug in masking of TID value

2018-06-28 Thread Kalle Valo
Erik Stromdahl wrote: > Although the TID mask is 0xf, the modulus operation does still not > produce identical results as the bitwise and operator. If the TID is 15, the > modulus operation will "convert" it to 0, whereas the bitwise and will keep it > as 15. > > This was found during code revie

Re: [v2] ath10k: Protect ath10k_htt_rx_ring_free with rx_ring.lock

2018-06-28 Thread Kalle Valo
Ben Greear wrote: > While debugging driver crashes related to a buggy firmware > crashing under load, I noticed that ath10k_htt_rx_ring_free > could be called without being under lock. I'm not sure if this > is the root cause of the crash or not, but it seems prudent to > protect it. > > Origin

Re: [v3] ath10k: transmit queued frames after processing rx packets

2018-06-28 Thread Kalle Valo
Niklas Cassel wrote: > When running iperf on ath10k SDIO, TX can stop working: > > iperf -c 192.168.1.1 -i 1 -t 20 -w 10K > [ 3] 0.0- 1.0 sec 2.00 MBytes 16.8 Mbits/sec > [ 3] 1.0- 2.0 sec 3.12 MBytes 26.2 Mbits/sec > [ 3] 2.0- 3.0 sec 3.25 MBytes 27.3 Mbits/sec > [ 3] 3.0- 4.0 sec

Re: ath10k: fix tlv 5ghz channel missing issue

2018-06-28 Thread Kalle Valo
zhic...@codeaurora.org wrote: > The 5ghz channel parameters of TLV target wasn't passed to host, it caused > host can only use lower channels from 36 to 64. > > Signed-off-by: Zhi Chen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 98dc04ba60b9 ath10k: fix tl

Re: ath10k: fixed scan crash

2018-06-28 Thread Kalle Valo
zhic...@codeaurora.org wrote: > Length of WMI scan message was not calculated correctly. The allocated > buffer was smaller than what we expected. So WMI message corrupted > skb_info, which is at the end of skb->data. This fix takes TLV header > into account even if the element is zero-length. >

Re: [v2] ath10k: Update the phymode along with bandwidth change request

2018-06-28 Thread Kalle Valo
Ryan Hsu wrote: > In the case of Station connects to AP with narrower bandwidth at beginning. > And later the AP changes the bandwidth to winder bandwidth, the AP will > beacon with wider bandwidth IE, eg VHT20->VHT40->VHT80 or VHT40->VHT80. > > Since the supported BANDWIDTH will be limited by t

[PATCH 2/2] ath10k: Handle mgmt tx completion event

2018-06-28 Thread Rakesh Pillai
WCN3990 transmits management frames via WMI with reference. Currently, with the management tx completion not being handled, these frames are not getting freed even after the transmission status is returned by the firmware. The transmitted management frames should be freed when the firmware sends t

[PATCH 1/2] ath10k: Disable bundle mgmt tx completion event support

2018-06-28 Thread Rakesh Pillai
From: Surabhi Vishnoi The tx completion of multiple mgmt frames can be bundled in a single event and sent by the firmware to host, if this capability is not disabled explicitly by the host. If the host cannot handle the bundled mgmt tx completion, this capability support needs to be disabled in t

[PATCH 0/2] ath10k: Handle mgmt tx completion event

2018-06-28 Thread Rakesh Pillai
The transmitted management frame completion can be sent by the firmware as one completion per event or it can bundle the completion of a bunch of management frames and send it in one single event. Disable the bundle tx completion for management frames and handle the tx completion event for managem