Re: [apparmor] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-22 Thread Damien Le Moal
ne inode_ctime_get() ? Also, inode_set_ctime() & inode_get_ctime() may be a little more natural. But no strong opinion about that though. -- Damien Le Moal Western Digital Research

Re: [apparmor] [PATCH v2 08/92] fs: new helper: simple_rename_timestamp

2023-07-06 Thread Damien Le Moal
_dir, struct dentry > *old_dentry, > + struct inode *new_dir, struct dentry *new_dentry); > extern int simple_rename_exchange(struct inode *old_dir, struct dentry > *old_dentry, > struct inode *new_dir, struct dentry > *new_dentry); > extern int simple_rename(struct mnt_idmap *, struct inode *, -- Damien Le Moal Western Digital Research

Re: [apparmor] [PATCH v2 07/92] fs: add ctime accessors infrastructure

2023-07-06 Thread Damien Le Moal
o that safely though, we'll need to eradicate raw > accesses of the inode->i_ctime field from the kernel. > > Add new accessor functions for the ctime that we use to replace them. > > Reviewed-by: Jan Kara > Reviewed-by: Luis Chamberlain > Signed-off-by: Jeff Layt

Re: [apparmor] [PATCH v2 92/92] fs: rename i_ctime field to __i_ctime

2023-07-06 Thread Damien Le Moal
On 7/6/23 03:58, Jeff Layton wrote: > Now that everything in-tree is converted to use the accessor functions, > rename the i_ctime field in the inode to discourage direct access. > > Signed-off-by: Jeff Layton Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Wes

Re: [apparmor] [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-03 Thread Damien Le Moal
ata_dev_warn(dev, "%s is not supported for %s\n", >modestr, list[i]); Looks good to me. Acked-by: Damien Le Moal# drivers/ata/ -- Damien Le Moal Western Digital Research