Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-15 Thread James Bottomley
On Mon, 2025-03-10 at 12:57 -0700, Ryan Lee wrote: > On Wed, Mar 5, 2025 at 1:47 PM Malte Schröder > wrote: > > > > On 05/03/2025 20:22, Ryan Lee wrote: > > > On Wed, Mar 5, 2025 at 11:11 AM Malte Schröder > > > wrote: > > > > Hi, > > > > > > > > I hope this is the right place to report this. S

Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-12 Thread James Bottomley
On Tue, 2025-03-11 at 16:55 +0100, Christian Brauner wrote: > On Tue, Mar 11, 2025 at 09:01:36AM -0400, James Bottomley wrote: > > On Tue, 2025-03-11 at 09:45 +0100, Christian Brauner wrote: [...] > > > efivars as written only has a single global superblock and it > > > doesn't support idmapped mou

Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-12 Thread James Bottomley
On Tue, 2025-03-11 at 17:15 +, Al Viro wrote: > On Tue, Mar 11, 2025 at 12:20:05PM -0400, James Bottomley wrote: > > > That's the way it's supposed to work, yes.  However, if we move to > > an always persistent superblock and mnt, I was thinking there'd > > have to be an indicator in the sfi a

Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-12 Thread Ard Biesheuvel
(cc Al Viro) On Mon, 10 Mar 2025 at 22:49, James Bottomley wrote: > > On Mon, 2025-03-10 at 12:57 -0700, Ryan Lee wrote: > > On Wed, Mar 5, 2025 at 1:47 PM Malte Schröder > > wrote: > > > > > > On 05/03/2025 20:22, Ryan Lee wrote: > > > > On Wed, Mar 5, 2025 at 11:11 AM Malte Schröder > > > > w

Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-12 Thread James Bottomley
On Tue, 2025-03-11 at 09:45 +0100, Christian Brauner wrote: > On Tue, Mar 11, 2025 at 08:16:34AM +0100, Ard Biesheuvel wrote: > > (cc Al Viro) > > > > On Mon, 10 Mar 2025 at 22:49, James Bottomley > > wrote: [...] > > > The problem comes down to the superblock functions not being able > > > to ge

Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-11 Thread Al Viro
On Tue, Mar 11, 2025 at 12:20:05PM -0400, James Bottomley wrote: > That's the way it's supposed to work, yes. However, if we move to an > always persistent superblock and mnt, I was thinking there'd have to be > an indicator in the sfi about whether the variables were reflected or > not. Just ha

Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-11 Thread Christian Brauner
On Tue, Mar 11, 2025 at 04:55:16PM +0100, Christian Brauner wrote: > On Tue, Mar 11, 2025 at 09:01:36AM -0400, James Bottomley wrote: > > On Tue, 2025-03-11 at 09:45 +0100, Christian Brauner wrote: > > > On Tue, Mar 11, 2025 at 08:16:34AM +0100, Ard Biesheuvel wrote: > > > > (cc Al Viro) > > > > >

Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-11 Thread Christian Brauner
On Tue, Mar 11, 2025 at 09:01:36AM -0400, James Bottomley wrote: > On Tue, 2025-03-11 at 09:45 +0100, Christian Brauner wrote: > > On Tue, Mar 11, 2025 at 08:16:34AM +0100, Ard Biesheuvel wrote: > > > (cc Al Viro) > > > > > > On Mon, 10 Mar 2025 at 22:49, James Bottomley > > > wrote: > [...] > >

Re: [apparmor] apparmor NULL pointer dereference on resume [efivarfs]

2025-03-11 Thread Christian Brauner
On Tue, Mar 11, 2025 at 08:16:34AM +0100, Ard Biesheuvel wrote: > (cc Al Viro) > > On Mon, 10 Mar 2025 at 22:49, James Bottomley > wrote: > > > > On Mon, 2025-03-10 at 12:57 -0700, Ryan Lee wrote: > > > On Wed, Mar 5, 2025 at 1:47 PM Malte Schröder > > > wrote: > > > > > > > > On 05/03/2025 20:2