Re: [ansible-devel] Ansible 2.10 and Project Restructuring

2020-07-07 Thread Alan Rominger
Gotcha, I had not read close enough. Your fix looks correct. I proposed a fix on the ansible-test side. Both are valid in my book, and your discovery argues strongly that this should be a failure (as opposed to either a traceback or a pass). https://github.com/ansible/ansible/pull/70507 Thanks.

Re: [ansible-devel] Ansible 2.10 and Project Restructuring

2020-07-07 Thread flowerysong
On Tuesday, July 7, 2020 at 2:58:34 PM UTC-4 arom...@redhat.com wrote: > > cd ~/.ansible/collections/ansible_collections/community/aws/ > > ansible-test sanity > > However, that still winds me up with > > > AttributeError: 'TypeError' object has no attribute 'errors' > > Maybe I still need to upgr

Re: [ansible-devel] Ansible 2.10 and Project Restructuring

2020-07-07 Thread Alan Rominger
Matt, I think there is valid stuff in what you're saying. Let me write out a formula: cd ~/Documents/test git clone https://github.com/ansible-collections/community.aws.git ansible-galaxy collection build rm -rf ~/.ansible/collections/ansible_collections/community/aws/ ansible-galaxy collecti

Re: [ansible-devel] Ansible 2.10 and Project Restructuring

2020-07-07 Thread Matthew Davis
Hi Felix, > it should go pretty fast I have literally spent hours on this, and there are just so many obstacles to a new person trying to run existing tests. Do you expect it to take hours? Or less than one hour? Please give me an actual numeric estimate of how long you expect it would take so

Re: [ansible-devel] Ansible 2.10 and Project Restructuring

2020-06-30 Thread 'Felix Fontein' via Ansible Development
Hi Matt, > Unfortunately I'm still very lost. > (Which means there's probably lots of other potential contributors > who are lost too.) > > > If you have the module in your collection path > > What's a collection path? > Do you mean that iam_role.py needs to be in a directory within my OS > $P

Re: [ansible-devel] Ansible 2.10 and Project Restructuring

2020-06-30 Thread Matthew Davis
Thanks Sam and Felix. Unfortunately I'm still very lost. (Which means there's probably lots of other potential contributors who are lost too.) > If you have the module in your collection path What's a collection path? Do you mean that iam_role.py needs to be in a directory within my OS $PATH v

Re: [ansible-devel] Ansible 2.10 and Project Restructuring

2020-06-29 Thread Sam Doran
Matt, Hopefully the documentation provided by Felix answered some of your questions. I'll try to add a little more clarity. > Do I need to clone both the collection repo, and the main ansible/ansible > repo? No, but with some short term caveats. If you are only interested in working on collec