Greetings All,
I was trying to ask a question on IRC but after registering it just complains
and I have no idea why,
if you want my nick to check it out it is was haweh. Anyhow I'm a student with
interest in helping out with
your mesa stack.
I've already got a few very minor patc
sking for help from one of your reviewers
whom you trust. I don't doubt it's hard to find maintainers, but
existing maintainers should go out of their way to entrust
co-maintainers especially when they find their workload becomes too
high. And reviewing/picking up trivial patches is probab
way.
>
> Right, looking at my latest randconfig logs, I see the same problem on x86
> builds with clang as well, though I'm not entirely sure which other
> configuration
> options are needed to trigger it.
>
> So my patch can be disregarded, but I agree this needs a better fix,
> either in clang or in the dcn driver.
If you could give https://github.com/ClangBuiltLinux/frame-larger-than
a spin again, I would appreciate any feedback.
--
Thanks,
~Nick Desaulniers
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Fri, Apr 7, 2023 at 10:52 AM Nick Desaulniers
wrote:
>
> Jimmy, can you review?
>
> The change LGTM; but I'm not sure if there was something else intended here.
Nevermind, Jimmy's email address bounced.
Reviewed-by: Nick Desaulniers
>
> On Sat, Mar 25, 20
0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix
Thanks for the patch!
Fixes: commit 75145aab7a0d ("drm/amdgpu/swsmu: clean up a bunch of
stale interfaces")
Reviewed-by: Nick Desaulniers
> ---
> drivers/gpu/drm/amd/pm/swsmu/am
se
> + if (assignment.stream != state->streams[i])
> valid_stream_ptrs = false;
> }
> }
> --
> 2.27.0
>
--
Thanks,
~Nick Desaulniers
t; > >> diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
> > > >> b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
> > > >> index 3648994724c2..cba087e529c0 100644
> > > >> --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
> > > >> +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
> > > >> @@ -701,6 +701,7 @@ static void
> > > >> mmhub_v1_8_reset_ras_error_count(struct amdgpu_device *adev)
> > > >>mmhub_v1_8_inst_reset_ras_error_count(adev, i);
> > > >> }
> > > >>
> > > >> +__maybe_unused
> > > >> static const uint32_t mmhub_v1_8_mmea_err_status_reg[] = {
> > > >>regMMEA0_ERR_STATUS,
> > > >>regMMEA1_ERR_STATUS,
> > > >> --
> > > >> 2.25.1
> > > >>
> > >
>
--
Thanks,
~Nick Desaulniers
On Tue, Oct 15, 2019 at 11:30 AM Alex Deucher wrote:
>
> On Tue, Oct 15, 2019 at 2:07 PM Nick Desaulniers
> wrote:
> >
> > On Tue, Oct 15, 2019 at 12:19 AM Arnd Bergmann wrote:
> > >
> > > On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote:
> > >
On Tue, Oct 15, 2019 at 1:26 PM Arvind Sankar wrote:
>
> On Tue, Oct 15, 2019 at 11:05:56AM -0700, Nick Desaulniers wrote:
> > Hmmm...I would have liked to remove it outright, as it is an ABI
> > mismatch that is likely to result in instability and non-fun-to-debug
> &g
AND use a
16B aligned stack in these translation units.
This is only a functional change for GCC 7.1+ users, and should be boot
tested.
Link: https://bugs.freedesktop.org/show_bug.cgi?id=109487
Signed-off-by: Nick Desaulniers
---
drivers/gpu/drm/amd/display/dc/calcs/Makefile | 4 +---
drivers/gpu/
ags, as it will result in runtime GPFs when built with Clang. Cleanups
for GCC will be sent in later patches in the series.
Link: https://github.com/ClangBuiltLinux/linux/issues/735
Debugged-by: Yuxuan Shui
Reported-by: Shirish S
Reported-by: Yuxuan Shui
Suggested-by: Andrew Cooper
Signed-of
n may help keep this code
building for pre-GCC 7.1 users.
The version check for GCC is broken into two conditionals, both because
cc-ifversion is currently GCC specific, and it simplifies a subsequent
patch.
Signed-off-by: Nick Desaulniers
---
drivers/gpu/drm/amd/display/dc/calcs/Makefile | 9 +++
gnments. Idealistically, we'd mark the driver broken for pre-GCC
7.1. Pragmatically, "if it ain't broke, don't fix it."
Nick Desaulniers (3):
drm/amdgpu: fix stack alignment ABI mismatch for Clang
drm/amdgpu: fix stack alignment ABI mismatch for GCC 7.1+
drm/am
On Wed, Oct 16, 2019 at 11:55 AM Arvind Sankar wrote:
>
> On Tue, Oct 15, 2019 at 06:51:26PM -0700, Nick Desaulniers wrote:
> > On Tue, Oct 15, 2019 at 1:26 PM Arvind Sankar wrote:
> > >
> > > On Tue, Oct 15, 2019 at 11:05:56AM -0700, Nick Desaulniers wrote:
> &
On Wed, Oct 16, 2019 at 4:02 PM Nick Desaulniers
wrote:
>
> The x86 kernel is compiled with an 8B stack alignment via
> `-mpreferred-stack-boundary=3` for GCC since 3.6-rc1 via
> commit d9b0cde91c60 ("x86-64, gcc: Use -mpreferred-stack-boundary=3 if
> supported")
>
ehavior. To make that clear to Clang
> without explicitly casting these values, change id's type to uint8_t
> in pp_atomfwctrl_get_clk_information_by_clkid so no conversion happens.
>
> Reported-by: Nick Desaulniers
> Signed-off-by: Nathan Chancellor
> ---
> drivers/gpu/
ing between types, just
> change status to type uint8_t (since its max size is 255) which avoids
> this construct altogether.
>
> Reported-by: Nick Desaulniers
> Signed-off-by: Nathan Chancellor
> ---
> drivers/gpu/drm/amd/display/dc/dc_ddc_types.h | 2 +-
> 1 file changed, 1
_operation_result' to different enumeration type 'enum
> > aux_transaction_reply' [-Wenum-conversion]
> > reply->status = AUX_CHANNEL_OPERATION_FAILED_HPD_DISCON;
> > ~ ^~~
> >
> > The cu
g much seems to have changed in this area so I bet
this could recur.
Signed-off-by: Nick Alcock
---
drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c
b/drivers/gpu/drm/radeon/evergreen_cs.c
index 543243
On 5 Oct 2018, Michel Dänzer told this:
> On 2018-10-04 9:58 p.m., Nick Alcock wrote:
>> So a few days ago I started getting sprays of these warnings --
>> sorry, but because it was a few days ago I'm not sure what I was
>> running at the time (but it was probably ei
On 9 Oct 2018, Michel Dänzer stated:
> On 2018-10-05 7:14 p.m., Nick Alcock wrote:
>> On 5 Oct 2018, Michel Dänzer told this:
>>
>>> On 2018-10-04 9:58 p.m., Nick Alcock wrote:
>>>> So a few days ago I started getting sprays of these warnings --
>>>&
e callsite of `mod_freesync_build_vrr_infopacket` in
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c#4949:
- NULL,
+ transfer_func_unknown,
Maybe at that point the `if (app_tf != NULL)` could be replaced with
`if (
On Tue, Dec 11, 2018 at 2:24 PM Nathan Chancellor
wrote:
> On Tue, Dec 11, 2018 at 02:07:31PM -0800, Nick Desaulniers wrote:
> > On Tue, Dec 11, 2018 at 1:42 PM Nathan Chancellor
> > wrote:
> > >
> > > On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulni
On Tue, Dec 11, 2018 at 1:42 PM Nathan Chancellor
wrote:
>
> On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulniers wrote:
> > On Mon, Dec 10, 2018 at 3:42 PM Nathan Chancellor
> > wrote:
> > >
> > > Clang warns when an expression that equals zero is used
On Fri, Jan 25, 2019 at 8:05 AM Sedat Dilek wrote:
>
> On Fri, Jan 25, 2019 at 4:15 PM Wentland, Harry
> wrote:
> >
> > On 2019-01-25 3:25 a.m., Koenig, Christian wrote:
> > > Am 25.01.19 um 08:42 schrieb Sedat Dilek:
> > >> [ CC Nick D. ]
> >
thub.com/ClangBuiltLinux/linux/issues/327
> >>>> Cc: sta...@vger.kernel.org # 4.19
> >>>> Reported-by: S, Shirish
> >>>> Reported-by: Matthias Kaehlcke
> >>>> Suggested-by: James Y Knight
> >>>> Suggested-by: Nathan Chancello
is warning
> bool shadow;
>^
> = 0
> 1 warning generated.
>
> It is not wrong so initialize shadow to false to ensure shadow is always
> used initialized.
Yep, thanks for the patch.
Reviewed-by: Nick Desaulniers
>
> Fixes:
_reg2);
> else if (offset == grbm_idx)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> emai
"Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to clang-built-linux+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/clang-built-linux/e4a852b2-807b-bc73-7328-bcc399341085%40amd.com.
--
Thanks,
~Nick Desaulniers
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
7f5c318d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dsc/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dsc/Makefile
> @@ -3,14 +3,15 @@
> # Makefile for the 'dsc' sub-component of DAL.
>
> ifdef CONFIG_X86
> -dsc_ccflags := -mhard-float -msse
> +dsc_ccflag
igned at the
> bottom of this file but Clang can't tell that. If the callback were
> ever to disappear, num_of_levels would never be initialized. Just
> zero initialize it to ensure that the intent behind this code
> remains the same.
Thanks for the simple fix.
Reviewed-by: Nick D
't disable kernel-wide for most cases.
-Wenum-conversion has spotted many bugs. While the enums in question
today are not different, they MIGHT eventually diverge and lead to
bugs, like the others we've found and fixed throughout the kernel. So
I would r
lization of subobject [-Wmissing-braces]
> struct amdgpu_task_info task_info = { 0 };
> ^
> {}
> 1 warning generated.
>
> Reported-by: Nick Desaulniers
> Si
On Wed, Sep 12, 2018 at 1:24 PM Richard Smith wrote:
>
> On Wed, Sep 12, 2018 at 10:38 AM Nick Desaulniers
> wrote:
>>
>> On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor
>> wrote:
>> >
>> > Clang warns if there are missing braces around a subobjec
}
> +
> +static enum mod_hdcp_status exchange_ks_and_test_for_repeater(struct
> mod_hdcp *hdcp,
> + struct mod_hdcp_event_context *event_ctx,
> + struct mod_hdcp_transition_input_hdcp2 *input)
> +{
> + enum mod_hdcp_status status = MOD_HDCP_ST
On Mon, Sep 16, 2019 at 2:03 AM Xinpeng Liu wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/Makefile:70: *** missing
> `endif'. Stop.
> make[4]: *** [drivers/gpu/drm/amd/amdgpu] Error 2
>
> Signed-off-by: Xinpeng Liu
Tested-by: Nick Desaulniers
+ Mark
I think t
> Apparently this bug is still present in both the released clang-9
> and the current development version of clang-10.
> I was hoping we would not need a workaround in clang-9+, but
> it seems that we do.
I think I'd rather:
1. mark AMDGPU BROKEN if CC_IS_CLANG. There are numerous other issues bui
On Wed, Oct 2, 2019 at 10:07 AM Nathan Chancellor
wrote:
>
> On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built
> Linux wrote:
> > > Apparently this bug is still present in both the released clang-9
> > > and the current develop
le.build:265: recipe for target
> 'drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o' failed
>
> Use the same variant that we have for dcn20 to fix compilation.
>
> Fixes: eced51f9babb ("drm/amd/display: Add hubp block for Renoir (v2)")
> S
On Wed, Oct 2, 2019 at 2:24 PM Alex Deucher wrote:
>
> On Wed, Oct 2, 2019 at 5:19 PM Nick Desaulniers
> wrote:
> >
> > Alex, do you know why the AMDGPU driver uses a different stack
> > alignment (16B) than the rest of the x86 kernel? (see
> > arch/x86/Makef
y to write/send the
follow up patch, but I'd need help testing).
--
Thanks,
~Nick Desaulniers
On Tue, Oct 15, 2019 at 12:19 AM Arnd Bergmann wrote:
>
> On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote:
> > On 10/15/2019 3:52 AM, Nick Desaulniers wrote:
>
> > My gcc build fails with below errors:
> >
> > dcn_calcs.c:1:0: error: -mpreferred-stack-b
On Tue, Oct 15, 2019 at 11:05 AM Nick Desaulniers
wrote:
>
> On Tue, Oct 15, 2019 at 12:19 AM Arnd Bergmann wrote:
> >
> > On Tue, Oct 15, 2019 at 9:08 AM S, Shirish wrote:
> > > On 10/15/2019 3:52 AM, Nick Desaulniers wrote:
> >
> >
cc_stack_align := -mpreferred-stack-boundary=4
> +else ifneq ($(call cc-option, -mstack-alignment=16),)
> + cc_stack_align := -mstack-alignment=16
> +endif
> +
> +dsc_ccflags := -mhard-float -msse $(cc_stack_align)
> +
> +CFLAGS_rc_calc.o := $(dsc_ccflags)
> +CFLAGS_rc_calc_dpi.o := $(dsc_ccflags)
> +CFLAGS_codec_main_amd.o := $(dsc_ccflags)
> +CFLAGS_dc_dsc.o := $(dsc_ccflags)
--
Thanks,
~Nick Desaulniers
Clang from
emitting libcalls to undefined SW FP routines"")
due to bugreports from GCC builds. Add guards to only do so for Clang.
Link: https://bugs.freedesktop.org/show_bug.cgi?id=109487
Link: https://github.com/ClangBuiltLinux/linux/issues/327
Suggested-by: Sedat Dilek
Suggested-by: Sami
45 matches
Mail list logo
