On 2019/6/22 14:02, Julia Lawall wrote:
>
>
> On Sat, 22 Jun 2019, Mao Wenan wrote:
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set
On 2019/6/22 21:06, Julia Lawall wrote:
>
>
> On Sat, 22 Jun 2019, Mao Wenan wrote:
>
>> There is one warning:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set
>> but not used [-Wunused-bu
On 2019/6/23 2:13, Joe Perches wrote:
> On Sat, 2019-06-22 at 21:05 +0800, Mao Wenan wrote:
>> There is one warning:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set
>> but not used [-Wunused
On 2019/6/22 22:00, Julia Lawall wrote:
>
>
> On Sat, 22 Jun 2019, maowenan wrote:
>
>>
>>
>> On 2019/6/22 21:06, Julia Lawall wrote:
>>>
>>>
>>> On Sat, 22 Jun 2019, Mao Wenan wrote:
>>>
>>>> There is one warni
On 2019/6/24 16:39, Dan Carpenter wrote:
> On Mon, Jun 24, 2019 at 11:45:32AM +0800, Mao Wenan wrote:
>> There is one warning:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pmu_init’:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:249:6: warning: variable ‘ret’ set
>> but not used
On 2019/6/25 1:42, Kim, Jonathan wrote:
> Immediate return should be ok since perf registration isn't dependent on gpu
> hw.
>
> Reviewed-by: Jonathan Kim
thanks for review.
>
> -Original Message-
> From: Mao Wenan
> Sent: Monday, June 24, 2019 7:23 AM
> To: airl...@linux.ie; dan
gentle ping
On 2019/6/26 19:35, maowenan wrote:
>
>
> On 2019/6/25 1:42, Kim, Jonathan wrote:
>> Immediate return should be ok since perf registration isn't dependent on gpu
>> hw.
>>
>> Reviewed-by: Jonathan Kim
>
> thanks for review.
>
>
