eeds backlight patches queued up outside of drm there's two
options:
- merge the backlight stuff through drm-misc (imo simplest, we have all
the fbdev stuff in there too by now)
- shared topic branch merged in drm-misc and optionally backlight tree
Otherwise this is going to be a pain to me
the offset is 0). And then this patch here removing that
again. Or cc: stable this patch here, since we seem to have a gap in
validating addfb.
-Daniel
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +-
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
s with their
own ddx in their CI rig only.
This also avoids a bunch of layering and locking unprettiness, since
display code doesn't need to dig around in gem_bo side of things. On that,
there's another amdgpu_bo_get_tiling_flags in amdgpu_dm_commit_planes
which probably shoul
07-17' of
> git://people.freedesktop.org/~agd5f/linux into drm-next")
>
> the spelling error has been introduced on one side of the merge and
> introduced and corrected on the other. This would have produced a
> conflict which David presumably resolved in haste b
lane or not.
I've also dropped some comments on Bas' series for adding modifiers which
might be relevant for shuffling all this. But yeah stuff this into plane
state sounds like a good idea.
-Daniel
>
> [How]
> This change should mostly be a refactor. Only commit check is
o subclass
drm_atomic_state.
Another thing I wondered is whether we should rename drm_atomic_state to
drm_atomic_state_update, so it's clear it's the container with the updated
states, not a real state object thing itself.
-Daniel
>
> [1] https://bugzilla.kernel.org/show_bug.cg
27;
series are even more relevant now. I think long term would be best to bake
these flags in at addfb time when modifiers aren't set. And otherwise
always use the modifiers flag, and completely ignore the legacy flags
here.
-Daniel
>
> [How]
> We unfortunately can't drop this fun
uch synchronization in your
locking (e.g. modern compositors do like to change tiling and stuff,
especially once you have modifiers enabled, so this shouldn't cause a sync
across crtc except when absolutely needed).
-Daniel
>
> Optimization can come later so we don't reset DC planes
ing else.
The idea is that essentially you treat individual stream objects as
read-locks on that part of the overall global state, and only when you
need to do a write do you grab all the "read locks" to do the update.
But might not actually help for your hw. Just highlighting this as a
pa
we could look into moving the actual DC states into drm private states
perhaps (if that helps with the code structure and overall flow).
Maybe as next steps.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
e rollout")
> Signed-off-by: Li Heng
Queued up, should make it into 5.9 merge window, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/drm_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/dr
On Mon, Jul 27, 2020 at 10:49:48PM -0400, Kazlauskas, Nicholas wrote:
> On 2020-07-27 5:32 p.m., Daniel Vetter wrote:
> > On Mon, Jul 27, 2020 at 11:11 PM Mazin Rezk wrote:
> > >
> > > On Monday, July 27, 2020 4:29 PM, Daniel Vetter wrote:
> > >
>
/context swap idea should make the use-after-free behave how it
> > > did in 5.6. Since the bug doesn't cause an issue in 5.6, it's less of a
> > > "less disturbance" workaround and more of a "no disturbance" workaround.
> >
> > Sorry
on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T
actually as drm-resident.
> > >
> > > Signed-off-by: Tvrtko Ursulin
> > > Cc: Alex Deucher
> > > Cc: Christian König
> > > Cc: Rob Clark
> >
> > Reviewed-by: Rob Clark
>
> Thanks!
>
> So this one is stand alone and cou
and and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.
; drm/amd/display: DML2.1 resynchronization
>
> Charlene Liu (3):
> drm/amd/display: restore immediate_disable_crtc for w/a
> drm/amd/display: sync dmub output event type.
> drm/amd/display: remove redundant msg to pmfw at boot/resume
>
> Chris Park (3):
ally lgtm
Reviewed-by: Daniel Vetter
Reading code a bit I did wonder whether we could have send/receive macros
that just work for compile-time statically sized types ... but not even
kmalloc is there yet I think, at least haven't seen anything.
-Sima
> ---
> .../gpu/drm/amd/d
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 10 +-
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index 39f1dc45
ad of
> plumbing it into drm mst code.
Yeah ec5fa9fcdeca ("drm/amd/display: Adjust the MST resume flow") promised
a follow-up, but that seems to have never materialized. Really should
materialize though. Patch lgtm
Reviewed-by: Daniel Vetter
> ---
> .../gpu
Hi Vignesh,
On Thu, 5 Sept 2024 at 10:41, Vignesh Raman wrote:
> Uprev IGT to the latest version and deqp-runner
> to v0.20.0. Also update expectation files.
Thanks! This is:
Reviewed-by: Daniel Stone
and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.
_bo export
case, which your patch seems to do? Or maybe I'm just extremely confused.
-Sima
>
> static const struct virtio_dma_buf_ops virtgpu_dmabuf_ops = {
> @@ -83,7 +115,7 @@ static const struct virtio_dma_buf_ops virtgpu_dmabuf_ops
> = {
> .vmap = drm_gem_dmabuf_vmap,
> .vunmap = drm_gem_dmabuf_vunmap,
> },
> - .device_attach = drm_gem_map_attach,
> + .device_attach = virtgpu_gem_device_attach,
> .get_uuid = virtgpu_virtio_get_uuid,
> };
>
> --
> 2.34.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote:
> On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote:
> > As vram objects don't have backing pages and thus can't implement
> > drm_gem_object_funcs.get_sg_table callback. This removes drm
ith new patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Disp
IGBUS
on dma-buf mmaps is no-go for drm drivers, because it would break way too
much userspace in ways which are simply not fixable (since sig handlers
are shared in a process, which means the gl/vk driver cannot use it).
Otherwise it's bog standard "fix the kernel bugs" work, just a lot
On Tue, Feb 06, 2024 at 07:42:49PM +0100, Christian König wrote:
> Am 06.02.24 um 15:29 schrieb Daniel Vetter:
> > On Fri, Feb 02, 2024 at 03:40:03PM -0800, Greg Kroah-Hartman wrote:
> > > On Fri, Feb 02, 2024 at 05:25:56PM -0500, Hamza Mahfooz wrote:
> > > > Removi
stom - Read EDID data using given EDID block read
> > function
> > * @connector: Connector to use
> > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
> > index 7923bc00dc7a..ca41be289fc6 100644
> > --- a/include/drm/drm_edid.h
> > +++ b/include/drm/drm_edid.h
> > @@ -410,6 +410,7 @@ struct edid *drm_do_get_edid(struct drm_connector
> > *connector,
> > void *data);
> > struct edid *drm_get_edid(struct drm_connector *connector,
> > struct i2c_adapter *adapter);
> > +const struct drm_edid *drm_get_acpi_edid(struct drm_connector *connector);
>
> There's a comment
>
> /* Interface based on struct drm_edid */
>
> towards the end of the file, gathering all the new API under it.
>
> Other than that, LGTM,
>
> BR,
> Jani.
>
> > u32 drm_edid_get_panel_id(struct i2c_adapter *adapter);
> > struct edid *drm_get_edid_switcheroo(struct drm_connector *connector,
> > struct i2c_adapter *adapter);
>
> --
> Jani Nikula, Intel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
9,12 @@ static int __alloc_range(struct drm_buddy *mm,
> } while (1);
>
> list_splice_tail(&allocated, blocks);
> +
> + if (total_allocated < size) {
> + err = -ENOSPC;
> + goto err_free;
> + }
> +
> return 0;
>
> err_undo:
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Fri, Feb 09, 2024 at 09:34:13AM -0600, Mario Limonciello wrote:
> On 2/9/2024 05:07, Daniel Vetter wrote:
> > On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote:
> > > On Wed, 07 Feb 2024, Mario Limonciello wrote:
> > > > Some manufacturers have intentio
On Sat, Feb 10, 2024 at 12:06:58AM +0530, Arunpravin Paneer Selvam wrote:
> Hi Daniel,
>
> On 2/9/2024 11:34 PM, Daniel Vetter wrote:
> > On Fri, Feb 09, 2024 at 08:56:24PM +0530, Arunpravin Paneer Selvam wrote:
> > > Few users have observed display corruption when they b
of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce
Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill
mdgpu_umsch_mm.c | 4 +--
> drivers/gpu/drm/drm_atomic_uapi.c | 19 +++
> drivers/gpu/drm/drm_trace.h | 28 +--
> include/trace/events/dma_fence.h | 34 +++
> 14 files changed, 144 insertions(+), 26 deletions(-)
>
> --
> 2.40.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
gt; +
> +DEFINE_EVENT(dma_fence_from, dma_fence_sync_to,
> +
> + TP_PROTO(struct dma_fence *fence, const char *reason),
> +
> + TP_ARGS(fence, reason)
> +);
> +
> #endif /* _TRACE_DMA_FENCE_H */
>
> /* This part must be outside protection */
> --
> 2.40.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
; > + trace_drm_mode_atomic_commit(file_priv, crtcs, num_crtcs,
> > arg->flags);
> > +
> > + kfree(crtcs);
> > + }
> > +
> > ret = prepare_signaling(dev, state, arg, file_priv, &fence_state,
> > &num_fences);
> > if (ret)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Mon, Feb 12, 2024 at 01:27:57PM +0200, Jani Nikula wrote:
> On Sat, 10 Feb 2024, Mario Limonciello wrote:
> > On 2/9/2024 12:57, Daniel Vetter wrote:
> >> On Fri, Feb 09, 2024 at 09:34:13AM -0600, Mario Limonciello wrote:
> >>> On 2/9/2024 05:07, Daniel Vette
On Fri, Feb 16, 2024 at 05:51:59PM +0100, Christian König wrote:
> Am 16.02.24 um 17:32 schrieb Daniel Vetter:
> > On Tue, Feb 13, 2024 at 04:50:26PM +0100, Pierre-Eric Pelloux-Prayer wrote:
> > > This new event can be used to trace where a given dma_fence is added
> > &
t;> lower somehow? Say after modifying the registry or something like
> > >>>>>> that?
> > >>>>>> Or through external tools?
> > >>>>> Windows uses the same limit. I'm not aware of any way to override the
> > >>>>> limit on windows off hand.
> > >>>>>
> > >>>>> Alex
> > >>>>>
> > >>>>>
> > >>>>>> Ciao, Thorsten
> > >>>>>>
> > >>>>>>>>>>> Roman posted something that apparently was meant to go to the
> > >>>>>>>>>>> list, so
> > >>>>>>>>>>> let me put it here:
> > >>>>>>>>>>>
> > >>>>>>>>>>> """
> > >>>>>>>>>>> UPDATE: User fililip already posted patch, but it need to be
> > >>>>>>>>>>> merged,
> > >>>>>>>>>>> discussion is on gitlab link below.
> > >>>>>>>>>>>
> > >>>>>>>>>>> (PS: I hope I am replying correctly to "all" now? - using
> > >>>>>>>>>>> original addr.)
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>>> it seems that commit was already found(see user's 'fililip'
> > >>>>>>>>>>>> comment):
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> https://gitlab.freedesktop.org/drm/amd/-/issues/3183
> > >>>>>>>>>>>> commit 1958946858a62b6b5392ed075aa219d199bcae39
> > >>>>>>>>>>>> Author: Ma Jun
> > >>>>>>>>>>>> Date: Thu Oct 12 09:33:45 2023 +0800
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> drm/amd/pm: Support for getting power1_cap_min value
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Support for getting power1_cap_min value on smu13 and
> > >>>>>>>>>>>> smu11.
> > >>>>>>>>>>>> For other Asics, we still use 0 as the default value.
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> Signed-off-by: Ma Jun
> > >>>>>>>>>>>> Reviewed-by: Kenneth Feng
> > >>>>>>>>>>>> Signed-off-by: Alex Deucher
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> However, this is not good as it remove under-powering range
> > >>>>>>>>>>>> too far. I
> > >>>>>>>>>>> was getting only about 7% less performance but 90W(!) less
> > >>>>>>>>>>> consumption
> > >>>>>>>>>>> when set to my 115W before. Also I wonder if we as a OS of
> > >>>>>>>>>>> options and
> > >>>>>>>>>>> freedom have to stick to such very high reference for min
> > >>>>>>>>>>> values without
> > >>>>>>>>>>> ability to override them through some sys ctrls. Commit was
> > >>>>>>>>>>> done by amd
> > >>>>>>>>>>> guy and I wonder if because of maybe this post that I made few
> > >>>>>>>>>>> months
> > >>>>>>>>>>> ago(business strategy?):
> > >>>>>>>>>>> https://www.reddit.com/r/Amd/comments/183gye7/rx_6700xt_from_230w_to_capped_115w_at_only_10/
> > >>>>>>>>>>>> This is not a dangerous OC upwards where I can understand
> > >>>>>>>>>>>> desire to
> > >>>>>>>>>>> protect HW, it is downward, having min cap at 190W when card
> > >>>>>>>>>>> pull on
> > >>>>>>>>>>> 115W almost same speed is IMO crazy to deny. We don't talk
> > >>>>>>>>>>> about default
> > >>>>>>>>>>> or reference values here either, just a move to lower the range
> > >>>>>>>>>>> of
> > >>>>>>>>>>> options for whatever reason.
> > >>>>>>>>>>>> I don't know how much power you guys have over them, but please
> > >>>>>>>>>>> consider either reverting this change, or give us an option to
> > >>>>>>>>>>> set
> > >>>>>>>>>>> min_cap through say /sys (right now param is readonly, even for
> > >>>>>>>>>>> root).
> > >>>>>>>>>>>> Thank you in advance for looking into this, with regards:
> > >>>>>>>>>>>> Romano
> > >>>>>>>>>>> """
> > >>>>>>>>>>>
> > >>>>>>>>>>> And while at it, let me add this issue to the tracking as well
> > >>>>>>>>>>>
> > >>>>>>>>>>> [TLDR: I'm adding this report to the list of tracked Linux
> > >>>>>>>>>>> kernel
> > >>>>>>>>>>> regressions; the text you find below is based on a few templates
> > >>>>>>>>>>> paragraphs you might have encountered already in similar form.
> > >>>>>>>>>>> See link in footer if these mails annoy you.]
> > >>>>>>>>>>>
> > >>>>>>>>>>> Thanks for the report. To be sure the issue doesn't fall
> > >>>>>>>>>>> through the
> > >>>>>>>>>>> cracks unnoticed, I'm adding it to regzbot, the Linux kernel
> > >>>>>>>>>>> regression
> > >>>>>>>>>>> tracking bot:
> > >>>>>>>>>>>
> > >>>>>>>>>>> #regzbot introduced 1958946858a62b /
> > >>>>>>>>>>> #regzbot title drm: amdgpu: under-powering broke
> > >>>>>>>>>>>
> > >>>>>>>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression
> > >>>>>>>>>>> tracker' hat)
> > >>>>>>>>>>> --
> > >>>>>>>>>>> Everything you wanna know about Linux kernel regression
> > >>>>>>>>>>> tracking:
> > >>>>>>>>>>> https://linux-regtracking.leemhuis.info/about/#tldr
> > >>>>>>>>>>> That page also explains what to do if mails like this annoy you.
> > >>>>>>>
> > >
> > >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
| 16 +
> include/uapi/drm/drm_mode.h | 14 +
> 38 files changed, 3882 insertions(+), 30 deletions(-)
> create mode 100644 Documentation/gpu/rfc/color_pipeline.rst
> create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c
> create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.h
> create mode 100644 drivers/gpu/drm/drm_colorop.c
> create mode 100644 drivers/gpu/drm/tests/drm_fixp_test.c
> create mode 100644 drivers/gpu/drm/vkms/Kconfig
> create mode 100644 drivers/gpu/drm/vkms/tests/.kunitconfig
> create mode 100644 drivers/gpu/drm/vkms/tests/vkms_color_tests.c
> create mode 100644 drivers/gpu/drm/vkms/vkms_colorop.c
> create mode 100644 drivers/gpu/drm/vkms/vkms_luts.c
> create mode 100644 drivers/gpu/drm/vkms/vkms_luts.h
> create mode 100644 include/drm/drm_colorop.h
>
> --
> 2.44.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce
[Public]
Hi all,
I can confirm that this re-enables VRR for a RX6800, and a RX7900XTX.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1
Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill
on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1
added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1
BB and IP the same as DCN35) with new
patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
ith new patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Disp
nlock(struct
> drm_fb_helper *fb_helper)
> width = dev->mode_config.max_width;
> height = dev->mode_config.max_height;
>
> + ret = drm_fb_helper_create_lid_handler(fb_helper);
> + if (ret)
> + return ret;
> +
> drm_client_mo
> >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> >> @@ -458,6 +458,8 @@ static void
> amdgpu_connector_add_common_modes(struct drm_encoder *encoder,
> >> continue;
> >>
> &g
-> drm/amdgpu: remove
amdgpu_mes_fence_wait_polling()) with new patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Disp
> > > - if (ret < 0)
> > > > > - goto out;
> > > > > +
> > > > > + /* Some ioctl can opt-out of powermanagement handling
> > > > > + * if they don't require the device to be resumed.
> > > > > + */
> > > > > + switch (cmd) {
> > > > > + default:
> > > > > + needs_device = true;
> > > > > + }
> > > > > +
> > > > > + if (needs_device) {
> > > > > + ret = pm_runtime_get_sync(dev->dev);
> > > > > + if (ret < 0)
> > > > > + goto out;
> > > > > + }
> > > > > ret = drm_ioctl(filp, cmd, arg);
> > > > > - pm_runtime_mark_last_busy(dev->dev);
> > > > > out:
> > > > > - pm_runtime_put_autosuspend(dev->dev);
> > > > > + if (needs_device) {
> > > > > + pm_runtime_mark_last_busy(dev->dev);
> > > > > + pm_runtime_put_autosuspend(dev->dev);
> > > > > + }
> > > > > +
> > > > > return ret;
> > > > > }
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
ons) with new patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Disp
drm/amdgpu: add missing error handling in function
> amdgpu_gmc_flush_gpu_tlb_pasid
>
> Dan Carpenter (2):
> drm/amd/display: Clean up indenting in dm_dp_mst_is_port_support_mode()
> drm/amdgpu/kfd: Add unlock() on error path to add_queue_mes()
>
> Daniel Sa (1):
%)
> rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn10/dcn10_stream_encoder.h
> (100%)
> rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn20/dcn20_link_encoder.c
> (100%)
> rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn20/dcn20_link_encoder.h
> (100%)
> rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn20/dcn20_stream_encoder.c
> (100%)
> rename drivers/gpu/drm/amd/display/dc/{ => dio}/dcn20/dcn20_stream_encoder.h
> (100%)
> rename drivers/gpu/drm/amd/display/dc/{ =>
> dio}/dcn30/dcn30_dio_link_encoder.c (100%)
> rename drivers/gpu/drm/amd/display/dc/{ =>
> dio}/dcn30/dcn30_dio_link_encoder.h (100%)
> rename drivers/gpu/drm/amd/display/dc/{ =>
> dio}/dcn30/dcn30_dio_stream_encoder.c (100%)
> rename drivers/gpu/drm/amd/display/dc/{ =>
> dio}/dcn30/dcn30_dio_stream_encoder.h (100%)
> rename drivers/gpu/drm/amd/display/dc/{ =>
> dio}/dcn31/dcn31_dio_link_encoder.c (100%)
> rename drivers/gpu/drm/amd/display/dc/{ =>
> dio}/dcn31/dcn31_dio_link_encoder.h (100%)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
+-
> .../amd/display/dc/dml/dcn32/display_mode_vba_32.c | 3 ++
> .../amd/display/dc/dml2/dml2_translation_helper.c | 1 +
> drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 2 +-
> drivers/gpu/drm/amd/include/atomfirmware.h | 2 +-
> drivers/gpu/drm/radeon/radeon_gem.c| 2 +-
> 6 files changed, 59 insertions(+), 4 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Sat, 6 Jul 2024 at 18:36, Alex Deucher wrote:
>
> On Fri, Jul 5, 2024 at 7:15 AM Daniel Vetter wrote:
> >
> > On Wed, Jul 03, 2024 at 02:47:23PM -0400, Alex Deucher wrote:
> > > Hi Dave, Sima,
> > >
> > > Fixes for 6.10.
&
t; + /**
> + * @offdelay_ms: Vblank off delay in ms, used to determine how long
> + * @disable_timer waits before disabling.
> + */
> + int offdelay_ms;
> +
> /**
>* @hwmode:
>*
> @@ -255,6 +261,7 @@ void drm_calc_timestamping_constants(struct drm_crtc
> *crtc,
> wait_queue_head_t *drm_crtc_vblank_waitqueue(struct drm_crtc *crtc);
> void drm_crtc_set_max_vblank_count(struct drm_crtc *crtc,
> u32 max_vblank_count);
> +void drm_crtc_set_vblank_offdelay(struct drm_crtc *crtc, int offdelay);
>
> /*
> * Helpers for struct drm_crtc_funcs
> --
> 2.45.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_state))) {
> dc_stream_retain(dm_new_crtc_state->stream);
> acrtc->dm_irq_params.stream = dm_new_crtc_state->stream;
> - manage_dm_interrupts(adev, acrtc, true);
> + manage_dm_interrupts(adev, acrtc,
> +
On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote:
> On Mon, Jul 08, 2024 at 04:29:07PM -0400, Hamza Mahfooz wrote:
> > Hook up drm_crtc_set_vblank_offdelay() in amdgpu_dm, so that we can
> > enable PSR more quickly for displays that support it.
> >
> > S
On Tue, Jul 09, 2024 at 10:02:08AM -0400, Hamza Mahfooz wrote:
> On 7/9/24 06:09, Daniel Vetter wrote:
> > On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote:
> > > On Mon, Jul 08, 2024 at 04:29:07PM -0400, Hamza Mahfooz wrote:
> > > > Hook up drm_crtc_set_
it.
Tested on Ubuntu 24.04.1, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce
On Wed, Jul 10, 2024 at 05:13:18PM -0400, Hamza Mahfooz wrote:
> On 7/10/24 04:43, Daniel Vetter wrote:
> > On Tue, Jul 09, 2024 at 10:02:08AM -0400, Hamza Mahfooz wrote:
> > > On 7/9/24 06:09, Daniel Vetter wrote:
> > > > On Tue, Jul 09, 2024 at 11:32:11AM +0200, Dan
is completed) with new patches added on top of it.
Tested on Ubuntu 24.04.1, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Disp
or (q = 0; q < V3D_MAX_QUEUES; q++) {
> - drm_sched_start(&v3d->queue[q].sched);
> + drm_sched_start(&v3d->queue[q].sched, 0);
> }
>
> mutex_unlock(&v3d->reset_lock);
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index fe8edb917360..a8d19b10f9b8 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -579,7 +579,7 @@ bool drm_sched_wqueue_ready(struct drm_gpu_scheduler
> *sched);
> void drm_sched_wqueue_stop(struct drm_gpu_scheduler *sched);
> void drm_sched_wqueue_start(struct drm_gpu_scheduler *sched);
> void drm_sched_stop(struct drm_gpu_scheduler *sched, struct drm_sched_job
> *bad);
> -void drm_sched_start(struct drm_gpu_scheduler *sched);
> +void drm_sched_start(struct drm_gpu_scheduler *sched, int errno);
> void drm_sched_resubmit_jobs(struct drm_gpu_scheduler *sched);
> void drm_sched_increase_karma(struct drm_sched_job *bad);
> void drm_sched_reset_karma(struct drm_sched_job *bad);
> --
> 2.34.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com
-Original Message-
From: Siqueira, Rodrigo
On Mon, Jul 29, 2024 at 08:43:05PM +0200, Christian König wrote:
> Am 26.07.24 um 16:21 schrieb Daniel Vetter:
> > On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote:
> > > The current implementation of drm_sched_start uses a hardcoded
> > > -ECANCELED t
On Tue, Jul 30, 2024 at 02:06:08PM +0200, Christian König wrote:
> Am 30.07.24 um 10:36 schrieb Daniel Vetter:
> > > In the end you have a really nice circle dependency.
> > Maybe a follow up, so for arb robustness or vk context where we want the
> > context to die and r
rs/gpu/drm/drm_connector.c | 34
> > +++++++
> > include/drm/drm_connector.h | 2 ++
> > 3 files changed, 42 insertions(+)
> > ---
> > base-commit: 36821612eb3091a21f7f4a907b497064725080c3
> > change-id: 20240610-amdgpu-min-backlight-quirk-8402fd8e736a
> >
> > Best regards,
>
> --
> Jani Nikula, Intel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
it series adds support in drm-ci to run tests
> for both GPU and display drivers for MediaTek mt8173/mt8183, Rockchip
> rk3288/rk3399, and Amlogic Meson G12B (A311D) platforms.
>
> Update the expectations file, and skip driver-specific tests and
> tools_test on non-intel platforms.
Tha
KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill, ON L3T 7X6
amd.com
-Original Mess
his, it needs to be in drm core. Otherwise
the vgaswitcheroo delayed switching stops working if you disable fbdev
support. Which doesn't make much sense.
-Sima
> +
> }
> EXPORT_SYMBOL(drm_fb_helper_lastclose);
>
> --
> 2.46.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Wed, Aug 07, 2024 at 10:41:36AM +0200, Thomas Zimmermann wrote:
> The output_poll_changed hook was only necessary before in-kernel
> DRM clients existed, but is now obsolete. The client code handles
> display otplugging internally.
>
> Signed-off-by: Thomas Zimmermann
Revi
ermann
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/nouveau/nouveau_vga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c
> b/drivers/gpu/drm/nouveau/nouveau_vga.c
> index ee637f1fe03d..ab4e11dc0b
On Wed, Aug 07, 2024 at 10:41:38AM +0200, Thomas Zimmermann wrote:
> The function is unused. Remove it.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Without the next patch to remove ->lastclose there's some confusion text
left in the DOC: section in drm_fb
On Wed, Aug 07, 2024 at 10:41:40AM +0200, Thomas Zimmermann wrote:
> The output_poll_changed hook in struct drm_mode_config_funcs is
> unused. Remove it. The helper drm_client_dev_hotplug() implements
> the callback's functionality.
>
> Signed-off-by: Thomas Zimmermann
still a midlayer mess,
where the locking is at the wrong layers resulting in the can_switch check
potentially being racy. But that's a different can of worms.
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_file.c | 4
> drivers/gpu/vga/vga_switcheroo.c | 3 +--
&
rm_lastclose().
>
> v2:
> - update commit message
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 --
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 17 -
e().
>
> v2:
> - update commit description
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
> drivers/gpu/drm/nouveau/nouveau_vga.c | 7 ---
> drivers/gpu/drm/nouveau/nouveau_vga.h | 1 -
>
On Mon, Aug 12, 2024 at 10:28:27AM +0200, Thomas Zimmermann wrote:
> The old callbacks lastclose and output_poll_changed are deprecated and
> unused. Remove them from the documentation.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/d
On Mon, Aug 12, 2024 at 10:28:28AM +0200, Thomas Zimmermann wrote:
> The function is unused. Remove it.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_fb_helper.c | 15 ---
> include/drm/drm_fb_helper.h | 6
On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote:
> On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote:
> > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from
> > their lastclose callbacks. Call it from drm_lastclose(), so that the
>
On Mon, Aug 12, 2024 at 12:41:39PM +0200, Thomas Zimmermann wrote:
> Hi
>
> Am 12.08.24 um 12:18 schrieb Daniel Vetter:
> > On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote:
> > > On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote:
> &g
Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill
added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
---
Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E, Thornhill
at's "either do $foo or on this one driver, do $bar" is just
guaranteed to fragement the ecosystem, so imo that should be the absolute
last resort.
-Sima
> > > +
> > > - drm-shared-: [KiB|MiB]
> > > The total size of buffers that are shared with another file (e.g.,
> > > have more
> > > @@ -145,6 +150,9 @@ than a single handle).
> > > The total size of buffers that including shared and private memory.
> > > +This is an alias for drm-memory- and only one of the two
> > > should be
> > > +present.
> > > +
> > > - drm-resident-: [KiB|MiB]
> > > The total size of buffers that are resident in the specified region.
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Fri, May 03, 2024 at 06:06:03PM +0100, Tvrtko Ursulin wrote:
>
> On 03/05/2024 16:58, Alex Deucher wrote:
> > On Fri, May 3, 2024 at 11:33 AM Daniel Vetter wrote:
> > >
> > > On Fri, May 03, 2024 at 01:58:38PM +0100, Tvrtko Ursulin wrote:
> > > >
&g
mm, start, end, order,
> flags, !fallback);
>
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
ace) with new patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Disp
amd/display: avoid variable reinitialization
>
> Chaitanya Dhere (1):
> drm/amd/display: Remove references to unused dml arch version
>
> Christian König (3):
> drm/amdgpu: fix error handling in amdgpu_bo_list_get()
> drm/amdgpu: lower CS errors to debug sev
top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce
| 6 +--
> drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 3 ++
> drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 10 ++---
> drivers/gpu/drm/amd/display/dc/dc_types.h | 1 +
> .../display/dc/dcn35/dcn35_dio_stream_encoder.c| 10 ++---
> .../gpu/drm/amd/display/dc/lin
.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E
on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1
rivers/gpu/drm/drm_atomic_state_helper.c | 1 +
> > drivers/gpu/drm/drm_atomic_uapi.c | 43 +-
> > drivers/gpu/drm/drm_property.c | 49 ++
> > include/drm/drm_mode_object.h | 2 +-
> > include/drm/drm_plane.h | 7 +
> > include/drm/drm_property.h| 6 +
> > include/uapi/drm/drm_mode.h | 8 +
> > 16 files changed, 1377 insertions(+), 109 deletions(-)
> >
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr
of error data) with new patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Disp
.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley Dr E
Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma and Gnome.
Tested-by: Daniel Wheeler
Thank you and happy holidays,
Dan Wheeler
Sr. Technologist | AMD
SW Display
--
1 Commerce Valley
;) with
new patches added on top of it.
Tested on Ubuntu 22.04.3, on Wayland and X11, using KDE Plasma (Version 5.24.7)
and Gnome (Version 42.9).
Tested-by: Daniel Wheeler
Thank you,
Dan Wheeler
Sr. Technolog
1 - 100 of 1682 matches
Mail list logo
