Re: [PATCH 3/6] drm/amd/pp: Lock powerplay when reset pp table

2018-03-22 Thread Zhu, Rex
Please see inline. Best Regards Rex From: Alex Deucher Sent: Thursday, March 22, 2018 9:17 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 3/6] drm/amd/pp: Lock powerplay when reset pp table On Thu, Mar 22, 2018 at 7:40 AM, Rex Zhu wrote: > Change

Re: [PATCH 2/6] drm/amd/pp: Add hwmgr_sw_init/fini functioins

2018-03-22 Thread Zhu, Rex
Thanks Alex. I should be more careful when reorder patches . Best Regards Rex From: Alex Deucher Sent: Thursday, March 22, 2018 9:13 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 2/6] drm/amd/pp: Add hwmgr_sw_init/fini functioins On Thu, Mar 22

Re: [PATCH] drm/amd/pp: use mlck_table.count for array loop index limit

2018-03-22 Thread Zhu, Rex
Thanks. Will apply the patch to drm-next. Best Regards Rex From: Joe Perches Sent: Thursday, March 22, 2018 3:02 AM To: Colin King; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zhu, Rex; amd-gfx@lists.freedesktop.org; dri-de

RE: [PATCH 2/6] drm/amd/pp: Add hwmgr_sw_init/fini functioins

2018-03-22 Thread Zhu, Rex
Good. Thanks Best Regards Rex -Original Message- From: Huang Rui [mailto:ray.hu...@amd.com] Sent: Friday, March 23, 2018 9:49 AM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/6] drm/amd/pp: Add hwmgr_sw_init/fini functioins On Thu, Mar 22, 2018 at 07:40:14PM

RE: [PATCH v2] drm/amdgpu: Parse module param amdgpu_dpm in check_arguments

2018-03-26 Thread Zhu, Rex
Sorry, Please ignore this patch. Setting dpm_enabled when check_arguments didn't make sense. We will set dpm_enabled to true when smu hw init successfully. Best Regards Rex -Original Message- From: Quan, Evan Sent: Monday, March 26, 2018 4:36 PM To: Zhu, Rex; am

Re: [PATCH][next] drm/amd/pp: Fix spelling mistake: "suppported" -> "supported"

2018-03-27 Thread Zhu, Rex
Applied and thanks. Best Regards Rex From: Colin King Sent: Tuesday, March 27, 2018 4:32 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zhu, Rex; Quan, Evan; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org

RE: [PATCH] drm/amd/powerply: fix power reading on Fiji

2018-03-30 Thread Zhu, Rex
>> Power value is wrong reported by customer. Hi Eric, What is the wrong value customer reported? In my end, there is no big difference between 20ms and 200ms or 2s. I tested on Fiji/Tonga when gpu idle or running fullscreen glxgears. why need 50 ms? How long does the SMU core take to complet

Re: [PATCH] drm/amd/pp: Clean register first to avoid read original value

2018-03-30 Thread Zhu, Rex
when PPSMC_MSG_PmStatusLogSample sent, firmware will clean the temp sampling date, and add the sample task to dpm loop. but firmware not clean the registers. if firmware not update the registers, we will read out the original value. Best Regards Rex From:

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-04 Thread Zhu, Rex
If user send message PPSMC_MSG_GetCurrPkgPwr, firmware will return the pkgpwr immediately as current power value. as no PPSMC_MSG_GetCurrPkgPwr support, so send message let firmware write pkgpwr to ixSMU_PM_STATUS_94, and driver delay 10ms to read ixSMU_PM_STATUS_94. I don't think there is

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

2018-04-04 Thread Zhu, Rex
with this patch, there should be no difference between AGT and sysfs. Best Regards Rex From: Huang, JinHuiEric Sent: Thursday, April 5, 2018 12:00 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

Re: [PATCH] drm/amd/powerplay: get real current gfxclk frequency instead of dpm level value

2018-04-09 Thread Zhu, Rex
You can add descriptions like: fix bug read wrong engine clock when in deep sleep. Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Evan Quan Sent: Tuesday, April 10, 2018 1:08 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan; Zhu

Re: [PATCH] drm/amdgpu/powerplay: fix smu7_get_memory_type for fiji

2018-04-11 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Thursday, April 12, 2018 6:59 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay: fix smu7_get_memory_type for fiji Fiji use

Re: [PATCH] drm/amdgpu/powerplay: rename smu7_upload_mc_firmware

2018-04-11 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Thursday, April 12, 2018 7:11 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay: rename smu7_upload_mc_firmware It doesn't

RE: [PATCH 4/6] drm/amdgpu/pm: document pp_dpm_sclk pp_dpm_mclk pp_dpm_pcie

2018-04-19 Thread Zhu, Rex
Hi Alex, > There will be a '*' next to the level that is currently active. We need to add a level for deep sleep state. Otherwise, On Vega/Rv, when gpu in deepsleep, we can't set "*" for the current level. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lis

Re: [PATCH] drm/amdgpu/powerplay: actually return the power with the new query

2018-04-22 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Sunday, April 22, 2018 3:11 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay: actually return the power with the new query

Re: [PATCH] drm/amdgpu/display: check if ppfuncs exists before using it

2018-05-30 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Wednesday, May 30, 2018 10:37 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/display: check if ppfuncs exists before using it Fixes

Re: [PATCH] drm/amdgpu/pp: switch the default dpm implementation for CI

2018-05-31 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 1, 2018 1:48 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: switch the default dpm implementation for CI Switch ha

Re: [PATCH 2/2] drm/amdgpu: Make gfx_off control by GFX ip

2018-06-05 Thread Zhu, Rex
first. Currently, it is not a big deal, because SMU don't support CG/PG on all legacy asics. Best Regards Rex From: Huang Rui Sent: Wednesday, June 6, 2018 10:33 AM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: Mak

Re: [PATCH] drm/amd/powerplay: fix wrong clock adjust sequence

2018-06-05 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Evan Quan Sent: Wednesday, June 6, 2018 1:54 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan; Zhu, Rex Subject: [PATCH] drm/amd/powerplay: fix wrong clock adjust sequence The clocks

Re: [PATCH] drm/amd/powerplay: Set higher SCLK&MCLK frequency than dpm7 in OD

2018-06-12 Thread Zhu, Rex
Acked-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, June 12, 2018 10:54 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/powerplay: Set higher SCLK&MCLK frequency than dpm7 in OD Fix the is

Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

2018-06-13 Thread Zhu, Rex
_ From: jv...@scarletmail.rutgers.edu on behalf of Jan Vesely Sent: Wednesday, June 13, 2018 9:30 PM To: Koenig, Christian Cc: Zhu, Rex; amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006 Hi, can you please improve the commit message? seeing "Revert $HAS

Re: [PATCH 4/7] drm/amd/pp: Add gfx pg support in smu through set_powergating_by_smu

2018-06-13 Thread Zhu, Rex
; Move this change to patch3. From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, June 13, 2018 7:18 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 4/7] drm/amd/pp: Add gfx pg support in smu through set_powergating_by_smu gfx ip bl

Re: [PATCH] drm/amd/pp: Fix uninitialized variable

2018-06-18 Thread Zhu, Rex
Applied. Thanks. Best Regards Rex From: rajan.v...@gmail.com Sent: Monday, June 18, 2018 3:31 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); Zhu, Rex; StDenis, Tom Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org

Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

2018-06-19 Thread Zhu, Rex
Hi Evan, did we need to check the following flags on vega12?will driver set those flags when user select the umd_pstate? PHM_PlatformCaps_UMDPState/PHM_PlatformCaps_PState. Best Regards Rex ?? Outlook for Android From: amd-gfx on behal

Re: [PATCH 2/5] drm/amd/pp: Fix wrong clock-unit exported to Display

2018-06-20 Thread Zhu, Rex
de on raven in linux. Best Regards Rex From: Alex Deucher Sent: Wednesday, June 20, 2018 11:47 AM To: Wentland, Harry Cc: amd-gfx list; Wu, Hersen; Lipski, Mikita; Laktyushkin, Dmytro; Zhu, Rex Subject: Re: [PATCH 2/5] drm/amd/pp: Fix wrong clock-unit export

Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode

2018-06-26 Thread Zhu, Rex
i36> From: amd-gfx on behalf of Michel Dänzer Sent: Tuesday, June 26, 2018 6:38:14 PM To: Zhu, Rex Cc: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode On 2018-06-26 12:23 PM, rex zhu wrote: >

Re: [PATCH] drm/amdgpu/pp: fix copy paste typo in smu7_get_pp_table_entry_callback_func_v1

2018-06-28 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: fix copy paste typo in smu7_get_pp_table_entry_call

Re: [PATCH] drm/amdgpu/pm: fix display count in non-DC path

2018-06-28 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pm: fix display count in non-DC path new_active_crtcs i

Re: [PATCH] drm/amdgpu/pp: add missing byte swapping in process_pptables_v1_0.c

2018-06-28 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: add missing byte swapping in process_pptables_v1_0.

Re: [PATCH] drm/amdgpu/pp: fix endian swapping in atomctrl_get_voltage_range

2018-06-28 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: fix endian swapping in atomctrl_get_voltage_range

Re: [PATCH] drm/amdgpu/pp: fix copy paste typo in smu7_init_dpm_defaults

2018-06-28 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: fix copy paste typo in smu7_init_dpm_defaults Shoul

Re: [PATCH] drm/amd/powerplay: initialize uvd/vce powergate status v3

2018-06-28 Thread Zhu, Rex
Do we need to maintain the uvd/vce pg state in pp? uvd/vce have maintained the pg state by themselves. pp only provide an interface for uvd/vce/gfx/mmhub to power up/down the ip through smu if smu supported, concurrently enable/disable uvd/vce/mmhub dpm feature. Best Regards Rex __

Re: [PATCH 2/2] drm/amd/display: make function tables const

2018-07-06 Thread Zhu, Rex
Add Michel, seems Michel found a similar issue. Please see the kern.log. Best Regards Rex From: amd-gfx on behalf of Harry Wentland Sent: Friday, July 6, 2018 9:32 PM To: Christian König; amd-gfx@lists.freedesktop.org Cc: Lipski, Mikita Subject: Re: [PATCH

Re: [PATCH 2/2] drm/amd/display: make function tables const

2018-07-07 Thread Zhu, Rex
: Saturday, July 7, 2018 8:30 PM To: Zhu, Rex; Wentland, Harry; amd-gfx@lists.freedesktop.org; Michel Dänzer Cc: Lipski, Mikita Subject: Re: [PATCH 2/2] drm/amd/display: make function tables const That's a completely different issue. I'm running into it with just a Tonga in my system. Ac

RE: [PATCH] drm/amdgpu: fix rmmod KCQ disable failed error

2017-11-16 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: Wang Hongcheng [mailto:annie.w...@amd.com] Sent: Friday, November 17, 2017 2:24 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex; Wang, Annie Subject: [PATCH] drm/amdgpu: fix rmmod KCQ disable failed error If

RE: [PATCH 3/3] drm/amd/pp: Refine pp_dpm_set_pp_table logic

2018-01-02 Thread Zhu, Rex
Sorry, please ignore this patch as the new logic is wrong. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Tuesday, January 02, 2018 3:54 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 3/3

RE: [PATCH v2] drm/amd/pp: Implement get_max_high_clocks for CI/VI

2018-01-04 Thread Zhu, Rex
iginal Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, January 04, 2018 2:58 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH v2] drm/amd/pp: Implement get_max_high_clocks for CI/VI On Thu, Jan 4, 2018 at 1:01 AM, Rex Zhu wrote: > v2: add table length check.

RE: [PATCH] drm/amd/powerplay: fix typo error for '3be7be08ac'

2018-01-04 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Yintian Tao Sent: Thursday, January 04, 2018 5:05 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou, David(ChunMing); Tao, Yintian Subject: [PATCH] drm/amd/power

RE: [PATCH] drm/amd/powerplay: Fix no-cast warnings in smu7_smu_fini

2018-01-04 Thread Zhu, Rex
Reviewed-by: Rex Zhu and pushed the patch to drm-next. Best Regards Rex From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Deucher, Alexander Sent: Friday, January 05, 2018 12:09 AM To: Wentland, Harry; amd-gfx@lists.freedesktop.org; Tao, Yintian Subject: Re: [PATCH] drm

Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs

2018-01-05 Thread Zhu, Rex
Ok. Thanks. I will query twice.one for pstate sclk and one for mclk. Best Regards Rex From: Deucher, Alexander Sent: Friday, January 5, 2018 11:44:00 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display

Re: [PATCH 1/2] drm/amdgpu: add custom power policy support in sysfs

2018-01-10 Thread Zhu, Rex
Yes, this new interface is more common, I just save the input and send to hw backend. Smu7 and Vega can share this interface. Best Regards Rex From: Alex Deucher Sent: Thursday, January 11, 2018 4:18:11 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 1/2

RE: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature

2018-01-16 Thread Zhu, Rex
>>Setting the feature mask to 0x2fff unsets PP_SOCCLK_DPM_MASK. >>Probably not intended. I think you want 0x3fff. Yes, Thanks for pointing it out. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, January 17, 2018 1:1

RE: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature

2018-01-16 Thread Zhu, Rex
-Original Message- From: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Wednesday, January 17, 2018 1:53 AM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature On Tue, Jan 16, 2018 at 2:02 PM, Rex Zhu

RE: [PATCH 2/3] drm/amd/pp: Add stable Pstate clk display when print_clock_levels

2018-01-16 Thread Zhu, Rex
Ok, I will drop this patch. and please review the new attached patch expose stable pstate clock by ioctl. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, January 17, 2018 12:03 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 2

RE: [PATCH 1/2] drm/amdgpu: add custom power policy support in sysfs

2018-01-16 Thread Zhu, Rex
Sure. We should add the PP_SMC_POWER_PROFILE_AUTO in PP_SMC_POWER_PROFILE. And will be implemented as auto wattman feature. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Tuesday, January 16, 2018 11:59 PM To: Zhu, Rex Cc: amd-gfx list Subject

RE: [PATCH] drm/amd/powerplay: Fix smu_table_entry.handle type

2018-01-18 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex From: Deucher, Alexander Sent: Thursday, January 18, 2018 7:11 AM To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org Cc: Lipski, Mikita; Zhu, Rex Subject: Re: [PATCH] drm/amd/powerplay: Fix smu_table_entry.handle type Reviewed-by: Alex Deucher

RE: [amd-staging-drm-next]: amdgpu: [powerplay] pp_get_power_profile_mode was not implemented.

2018-01-19 Thread Zhu, Rex
Yes, I just implemented this callback function on Vega10. Best Regards Rex -Original Message- From: Dieter Nützel [mailto:die...@nuetzel-hh.de] Sent: Friday, January 19, 2018 4:23 PM To: Zhu, Rex Cc: amd-devel Subject: [amd-staging-drm-next]: amdgpu: [powerplay

RE: [PATCH] drm/amdgpu/powerplay/vega10: fix compute profile name

2018-01-21 Thread Zhu, Rex
Thanks, Alex. Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Saturday, January 20, 2018 1:14 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powe

Re: [PATCH 5/5] drm/amd/pp: Implement get_power_profile_mode on smu7

2018-01-23 Thread Zhu, Rex
* 10 16 31 so add current_mode to notify user current parameters. Best Regards Rex From: Deucher, Alexander Sent: Tuesday, January 23, 2018 11:15 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org S

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

2018-01-24 Thread Zhu, Rex
Hi Eric, We have sysfs pp-dpm-sclk/mclk to set min dpm level Best Regards Rex From: amd-gfx on behalf of Eric Huang Sent: Thursday, January 25, 2018 12:04:55 AM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_m

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

2018-01-24 Thread Zhu, Rex
Yes. Best Regards Rex From: Huang, JinHuiEric Sent: Thursday, January 25, 2018 4:47:23 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 Hi Rex, So you intend to separate previous one

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

2018-01-24 Thread Zhu, Rex
. Best Regards Rex From: Kuehling, Felix Sent: Thursday, January 25, 2018 5:41:43 AM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 Hi Rex, As I understand it (the way

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

2018-01-24 Thread Zhu, Rex
ll try to not affect existing tools. Best Regards Rex From: amd-gfx on behalf of Felix Kuehling Sent: Thursday, January 25, 2018 7:12 AM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 On 20

Re: [PATCH 6/6] drm/amdgpu/pm: rework the hwmon visibility settings

2018-01-24 Thread Zhu, Rex
Series is Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Thursday, January 25, 2018 7:55 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 6/6] drm/amdgpu/pm: rework the hwmon visibility settin

RE: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

2018-01-25 Thread Zhu, Rex
issue. Thanks. Best Regards Rex -Original Message- From: Kuehling, Felix Sent: Thursday, January 25, 2018 12:16 PM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 On 2018-01-24 09:28 PM, Zhu, Re

RE: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

2018-01-25 Thread Zhu, Rex
So the problem maybe we should not name new sysfs as "power_profile_mode ". It is easy to add min sclk/mclk in the new sysfs, I just think it repeated with other sysfs. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Se

Re: [PATCH 1/4] drm/amd/pp: Add new smu callback function

2018-01-25 Thread Zhu, Rex
For the power containment issue on Fiji. We want to expose set power limit function. Maybe we can adjust the power limit instand of just disable this feature. But I am not sure this can meet kfd ‘ s requirement. Best Regards Rex From: amd-gfx on behalf of Eric Hua

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-25 Thread Zhu, Rex
From: Kuehling, Felix Sent: Friday, January 26, 2018 12:55:19 AM To: amd-gfx@lists.freedesktop.org; Zhu, Rex Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level This patch breaks unforcing of clocks, which is currently done

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Zhu, Rex
t: Friday, January 26, 2018 8:26 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level On 2018-01-25 07:07 PM, Zhu, Rex wrote: > I also think about this problem. > just think user should unforced clk level

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Zhu, Rex
e in this case, driver still can set min sclk/mclk. Best Regards Rex From: Kuehling, Felix Sent: Saturday, January 27, 2018 12:49 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performanc

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Zhu, Rex
rom: Kuehling, Felix Sent: Saturday, January 27, 2018 3:32 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level On 2018-01-26 02:20 PM, Zhu, Rex wrote: > > >1. You're breaking the semantic

RE: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-29 Thread Zhu, Rex
one less command need to input if they want to use pp_dpm_sclk/mclk/pcie. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Saturday, January 27, 2018 7:51 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-29 Thread Zhu, Rex
Currently we just unfore the clock range in the auto state. Anyway, I will drop this patch. Best Regards Rex From: Alex Deucher Sent: Tuesday, January 30, 2018 2:02 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: Re: [PATC

Re: [PATCH 2/2] drm/amdgpu/pm: get/set dgpu power cap via hwmon API

2018-01-29 Thread Zhu, Rex
>Isn't the power limit only multiplied by 256 on smu7? Yes,I will fix it and convert the output to mw. Best Regards Rex From: Alex Deucher Sent: Tuesday, January 30, 2018 4:00 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 2/2] drm/amdgpu/pm: get/

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-29 Thread Zhu, Rex
Hi Alex, It's Ok, I got it. Thanks. Best Regards Rex From: Alex Deucher Sent: Tuesday, January 30, 2018 6:26 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mod

RE: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init

2016-07-28 Thread Zhu, Rex
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Thursday, July 28, 2016 1:46 PM To: Tom St Denis Cc: StDenis, Tom; amd-gfx list Subject: Re: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init On Tue, Jul 26, 2016 at 11:38 AM, Tom St Deni

Re: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init

2016-07-28 Thread Zhu, Rex
Looks good to me. Best Regards Rex From: StDenis, Tom Sent: Thursday, July 28, 2016 8:19:52 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init Nevermind I moved the locking into

Re: [PATCH 4/4] drm/amd/powerplay: Prevent UVD powerdown before init

2016-07-28 Thread Zhu, Rex
you mean +if (cz_hwmgr->uvd_power_gated == bgate) { return 0; +} I didn't pay any attention at first. Best Regards Rex From: StDenis, Tom Sent: Thursday, July 28, 2016 8:44:11 PM To: Zhu, Rex; Alex Deucher Cc: amd-gfx list Sub

Re: [PATCH 07/14] drm/amd/powerplay: remove enable_clock_power_gatings_tasks from initialize and resume events

2016-07-28 Thread Zhu, Rex
For the series: Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Tom St Denis Sent: Thursday, July 28, 2016 10:19:05 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH 07/14] drm/amd/powerplay: remove enable_clock_power_g

<    1   2   3