RE: [PATCH] drm/amdgpu: remove distinction between explicit and implicit sync (v2)

2020-06-09 Thread Zhou, David(ChunMing)
[AMD Official Use Only - Internal Distribution Only] Not sue if this is right direction, I think usermode wants all synchronizations to be explicit. Implicit sync often confuses people who don't know its history. I remember Jason from Intel is driving explicit synchronization through the Linux

Re: [PATCH] drm/ttm: use the parent resv for ghost objects v2

2019-10-24 Thread Zhou, David(ChunMing)
On 2019/10/24 下午6:25, Christian König wrote: > Ping? > > Am 18.10.19 um 13:58 schrieb Christian König: >> This way the TTM is destroyed with the correct dma_resv object >> locked and we can even pipeline imported BO evictions. >> >> v2: Limit this to only cases when the parent object uses a separa

RE: [PATCH] drm/amdgpu: remove fence fallback

2018-09-18 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Tuesday, September 18, 2018 4:43 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: remove fence fallback > > DC doesn't seem to have a fallback path either. > > So when interrupts doesn't wo

RE: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

2018-09-19 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Wednesday, September 19, 2018 3:45 PM > To: Zhou, David(ChunMing) ; Zhou, > David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel >

RE: [PATCH 2/6] [RFC]drm: add syncobj timeline support v7

2018-09-20 Thread Zhou, David(ChunMing)
Ping... > -Original Message- > From: amd-gfx On Behalf Of > Chunming Zhou > Sent: Wednesday, September 19, 2018 5:18 PM > To: dri-de...@lists.freedesktop.org > Cc: Zhou, David(ChunMing) ; amd- > g...@lists.freedesktop.org; Rakos, Daniel ; Daniel > Vette

RE: [PATCH 2/6] [RFC]drm: add syncobj timeline support v7

2018-09-20 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Thursday, September 20, 2018 5:35 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; Daniel Vetter ; amd- > g...@lists.freedeskto

RE: [PATCH 3/6] drm: add support of syncobj timeline point wait v2

2018-09-21 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Thursday, September 20, 2018 7:11 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 3/6] drm: add support o

RE: Making use of more Gitlab features for xf86-video-amdgpu

2018-09-21 Thread Zhou, David(ChunMing)
After moving patch submitted and reviewed as MRs, mail list will be no useful? And many people could miss new patches, right? Regards, David Zhou > -Original Message- > From: amd-gfx On Behalf Of > Michel D?nzer > Sent: Friday, September 21, 2018 3:13 PM > To: amd-gfx@lists.freedesktop.

RE: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu CS

2018-10-07 Thread Zhou, David(ChunMing)
> -Original Message- > From: Nicolai Hähnle > Sent: Wednesday, September 26, 2018 5:06 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu

RE: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu CS

2018-10-07 Thread Zhou, David(ChunMing)
> -Original Message- > From: Nicolai Hähnle > Sent: Wednesday, September 26, 2018 4:44 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu C

RE: [PATCH 3/6] drm: add support of syncobj timeline point wait v2

2018-10-07 Thread Zhou, David(ChunMing)
September 25, 2018 5:50 PM To: Jason Ekstrand ; Zhou, David(ChunMing) Cc: amd-gfx mailing list ; Maling list - DRI developers Subject: Re: [PATCH 3/6] drm: add support of syncobj timeline point wait v2 Am 25.09.2018 um 11:22 schrieb Jason Ekstrand: On Thu, Sep 20, 2018 at 6:04 AM Chunming Zh

RE: [PATCH 7/7] drm/amdgpu: update version for timeline syncobj support in amdgpu

2018-10-15 Thread Zhou, David(ChunMing)
> To: dri-de...@lists.freedesktop.org > Cc: Zhou, David(ChunMing) ; amd- > g...@lists.freedesktop.org > Subject: [PATCH 7/7] drm/amdgpu: update version for timeline syncobj > support in amdgpu > > Signed-off-by: Chunming Zhou > --- > drivers/gpu/drm/amd/amdgpu/am

RE: [PATCH 2/2] drm/amdgpu: Fix null point errro

2018-10-18 Thread Zhou, David(ChunMing)
A minor suggestion, not sure if it's proper, Can we insert these callback checking to func? I know these func could be defined as a macro, can we change them to function definition? David > -Original Message- > From: amd-gfx On Behalf Of Rex > Zhu > Sent: Friday, October 19, 2018 10:51

RE: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet

2018-10-23 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of Rex > Zhu > Sent: Wednesday, October 24, 2018 2:03 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet > > the csa buffer is used by sdma engine to do context save wh

RE: [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

2018-10-25 Thread Zhou, David(ChunMing)
Make igt for cross-driver, I think you should rename it first, not an intel specific. NO company wants their employee working on other company stuff. You can rename it to DGT(drm graphics test), and published following libdrm, or directly merge to libdrm, then everyone can use it and develop it

RE: [PATCH] drm/amdgpu: wait for IB test on first device open

2018-11-02 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou > -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Friday, November 02, 2018 4:45 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: wait for IB test on first device open > > Instead of delaying that to the first que

RE: [PATCH 2/3] drm/amdgpu: drop the sched_sync

2018-11-04 Thread Zhou, David(ChunMing)
> -Original Message- > From: Koenig, Christian > Sent: Monday, November 05, 2018 3:48 PM > To: Liu, Monk ; amd-gfx@lists.freedesktop.org; Zhou, > David(ChunMing) > Subject: Re: [PATCH 2/3] drm/amdgpu: drop the sched_sync > > Am 05.11.18 um 08:24 schrieb Liu, M

RE: [PATCH libdrm 5/5] [libdrm] add syncobj timeline tests

2018-11-05 Thread Zhou, David(ChunMing)
> -Original Message- > From: Daniel Vetter On Behalf Of Daniel Vetter > Sent: Monday, November 05, 2018 5:39 PM > To: Zhou, David(ChunMing) > Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH libdrm 5/5] [libdrm] add syncobj time

RE: [PATCH] drm/amd: add the checking to avoid NULL pointer dereference

2018-11-21 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of > Sharma, Deepak > Sent: Thursday, November 22, 2018 10:37 AM > To: amd-gfx@lists.freedesktop.org > Cc: Sharma, Deepak > Subject: [PATCH] drm/amd: add the checking to avoid NULL pointer > dereference > > when returned fence is not valid

RE: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference

2018-11-26 Thread Zhou, David(ChunMing)
> -Original Message- > From: Christian König > Sent: Monday, November 26, 2018 5:23 PM > To: Sharma, Deepak ; Zhou, David(ChunMing) > ; Koenig, Christian ; > amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer

RE: [PATCH libdrm 4/5] wrap syncobj timeline query/wait APIs for amdgpu v3

2018-11-30 Thread Zhou, David(ChunMing)
> -Original Message- > From: Christian König > Sent: Friday, November 30, 2018 5:15 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH libdrm 4/5] wrap syncobj timeline query/wait APIs for &g

RE: [PATCH 02/11] dma-buf: add new dma_fence_chain container v2

2018-12-03 Thread Zhou, David(ChunMing)
> -Original Message- > From: Christian König > Sent: Monday, December 03, 2018 9:56 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 02/11] dma-buf: add new dma_fence

RE: [PATCH 2/2] drm/sched: Rework HW fence processing.

2018-12-06 Thread Zhou, David(ChunMing)
> -Original Message- > From: dri-devel On Behalf Of > Andrey Grodzovsky > Sent: Friday, December 07, 2018 1:41 AM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; > ckoenig.leichtzumer...@gmail.com; e...@anholt.net; > etna...@lists.freedesktop.org > Cc: Liu, Monk >

RE: [PATCH 1/3] drm/amdgpu: use HMM mirror callback to replace mmu notifier v6

2018-12-07 Thread Zhou, David(ChunMing)
Even you should rename amdgpu_mn.c/h to amdgpu_hmm.c/h. -David > -Original Message- > From: amd-gfx On Behalf Of Yang, > Philip > Sent: Friday, December 07, 2018 5:03 AM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Philip > Subject: [PATCH 1/3] drm/amdgpu: use HMM mirror callback to

RE: [PATCH -next] drm/amdgpu: remove set but not used variable 'grbm_soft_reset'

2018-12-09 Thread Zhou, David(ChunMing)
> -Original Message- > From: YueHaibing > Sent: Saturday, December 08, 2018 11:01 PM > To: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; airl...@linux.ie; Liu, Leo ; > Gao, Likun ; Panariti, David > ; S, Shirish ; Zhu, Rex > ; Grodzovsk

RE: [PATCH v3 2/2] drm/sched: Rework HW fence processing.

2018-12-10 Thread Zhou, David(ChunMing)
gt; Sent: Tuesday, December 11, 2018 5:44 AM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; > ckoenig.leichtzumer...@gmail.com; e...@anholt.net; > etna...@lists.freedesktop.org > Cc: Zhou, David(ChunMing) ; Liu, Monk > ; Grodzovsky, Andrey > > Subject: [PA

RE: [PATCH 01/10] dma-buf: add new dma_fence_chain container v4

2018-12-11 Thread Zhou, David(ChunMing)
Hi Daniel and Chris, Could you take a look on all the patches? Can we get your RB or AB on all patches including igt patch before we submit to drm-misc? We already fix all existing issues, and also add test case in IGT as your required. Btw, the patch set is tested by below tests: a. vulkan

RE: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-12 Thread Zhou, David(ChunMing)
lready add test case to igt, and tested by many existing test, like libdrm unit test, igt related test, vulkan cts, and steam games. -David > -Original Message- > From: Daniel Vetter > Sent: Wednesday, December 12, 2018 7:15 PM > To: Koenig, Christian > Cc: Zhou, D

RE: [PATCH 2/2] drm/amdgpu: disable vm fault irq during prt accessed

2019-01-03 Thread Zhou, David(ChunMing)
> -Original Message- > From: Christian König > Sent: Thursday, January 03, 2019 5:05 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; Zhou, David(ChunMing) > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amdgpu: disable vm fault irq during pr

RE: [PATCH 2/2] drm/amdgpu: disable vm fault irq during prt accessed

2019-01-03 Thread Zhou, David(ChunMing)
Seems we don't need two page table, we just map every prt range to dummy page, any problem? -David > -Original Message- > From: Zhou, David(ChunMing) > Sent: Thursday, January 03, 2019 5:23 PM > To: Koenig, Christian ; amd- > g...@lists.freedesktop.org > Subje

RE: [PATCH 2/2] drm/amdgpu: disable vm fault irq during prt accessed

2019-01-03 Thread Zhou, David(ChunMing)
Doesn't gpu check PTE prt bit first and then access va range? Even wrte to dummy page, seem there still is no problem, we don't care that content at all. -David > -Original Message- > From: Christian König > Sent: Thursday, January 03, 2019 5:54 PM > To: Zhou, Da

RE: [PATCH libdrm] amdgpu: add a faster BO list API

2019-01-07 Thread Zhou, David(ChunMing)
Looks good to me, Reviewed-by: Chunming Zhou > -Original Message- > From: amd-gfx On Behalf Of > Marek Ol?ák > Sent: Tuesday, January 08, 2019 3:31 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH libdrm] amdgpu: add a faster BO list API > > From: Marek Olšák > > --- > amdgpu

回复:[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable

2019-01-28 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou send from my phone 原始邮件 主题:[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable 发件人:Christian König 收件人:amd-gfx@lists.freedesktop.org 抄送: We only need to set this to false now when BOs are removed from the LRU. Signed-off-by: Christian König ---

RE: [PATCH] drm/amdgpu: partial revert cleanup setting bulk_movable v2

2019-01-31 Thread Zhou, David(ChunMing)
If Tom tests it OK as well, feel free add my RB to submit it ASAP. -David > -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Thursday, January 31, 2019 3:57 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: partial revert cleanup setting bulk_

RE: [PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN

2019-02-13 Thread Zhou, David(ChunMing)
> -Original Message- > From: Bo YU > Sent: Thursday, February 14, 2019 12:46 PM > To: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; airl...@linux.ie; dan...@ffwll.ch; Zhu, Rex > ; Grodzovsky, Andrey > ; dri-de...@lists.freed

RE: [PATCH 1/3] drm/amdgpu: change Vega IH ring 1 config

2019-03-06 Thread Zhou, David(ChunMing)
Acked-by: Chunming Zhou > -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Wednesday, March 06, 2019 5:29 PM > To: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/3] drm/amdgpu: change Vega IH ring 1 config > > Ping? Can anybody review this? > > Thanks,

RE: [PATCH] drm/amdgpu: force to use CPU_ACCESS hint optimization

2019-03-06 Thread Zhou, David(ChunMing)
> -Original Message- > From: Christian König > Sent: Wednesday, March 06, 2019 7:55 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: force to use CPU_ACCESS hint > optimization > > A

Re:[PATCH] drm/amdgpu: enable bo priority setting from user space

2019-03-07 Thread Zhou, David(ChunMing)
Yes, you are right, thanks to point it out. Will see if there is other way. -David send from my phone Original Message Subject: Re: [PATCH] drm/amdgpu: enable bo priority setting from user space From: Christian König To: "Zhou, David(ChunMing)" ,amd-gfx@lists.freed

Re:[PATCH] drm/amdgpu: enable bo priority setting from user space

2019-03-07 Thread Zhou, David(ChunMing)
Am 07.03.19 um 14:09 schrieb Zhou, David(ChunMing): Yes, you are right, thanks to point it out. Will see if there is other way. -David send from my phone Original Message Subject: Re: [PATCH] drm/amdgpu: enable bo priority setting from user space From: Christian König To: "Zho

Re:[PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-21 Thread Zhou, David(ChunMing)
cmpxchg be replaced by some simple c sentance? otherwise we have to remove __rcu of chian->prev. -David Original Message Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 From: Christian König To: "Zhou, David(ChunMing)" ,kbuild test robot

RE: [PATCH] drm/amdgpu: fix old fence check in amdgpu_fence_emit

2019-03-31 Thread Zhou, David(ChunMing)
> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Saturday, March 30, 2019 2:33 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: fix old fence check in amdgpu_fence_emit > > We don't hold a reference to the old fence, so it can go away any

RE: [PATCH 2/9] drm/syncobj: add new drm_syncobj_add_point interface v4

2019-03-31 Thread Zhou, David(ChunMing)
> -Original Message- > From: Lionel Landwerlin > Sent: Saturday, March 30, 2019 10:09 PM > To: Koenig, Christian ; Zhou, David(ChunMing) > ; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; ja...@jlekstrand.net; Hector, Tobias > > Subject: Re:

RE: DMA-buf P2P

2019-04-19 Thread Zhou, David(ChunMing)
Which test are you using? Can share? -David > -Original Message- > From: dri-devel On Behalf Of > Christian K?nig > Sent: Thursday, April 18, 2019 8:09 PM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Subject: DMA-buf P2P > > Hi guys, > > as promised this is th

Re:[PATCH v5 3/6] drm/scheduler: rework job destruction

2019-04-23 Thread Zhou, David(ChunMing)
[PATCH v5 3/6] drm/scheduler: rework job destruction From: "Grodzovsky, Andrey" To: "Zhou, David(ChunMing)" ,dri-de...@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,e...@anholt.net,etna...@lists.freedesktop.org,ckoenig.leichtzumer...@gmail.com CC: "Kazlauskas, Nicholas&q

Re:[PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Zhou, David(ChunMing)
do you mean fence timer? why not stop it as well when stopping sched for the reason of hw reset? Original Message Subject: Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled. From: "Grodzovsky, Andrey" To: "Zhou, David(Chun

RE: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-23 Thread Zhou, David(ChunMing)
et detection. -David From: amd-gfx On Behalf Of Grodzovsky, Andrey Sent: Wednesday, April 24, 2019 12:00 AM To: Zhou, David(ChunMing) ; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; e...@anholt.net; etna...@lists.freedesktop.org; ckoenig.leichtzumer...@gmail.com Cc: Kazlauskas, Nich

RE: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

2019-04-27 Thread Zhou, David(ChunMing)
Sorry, I only can put my Acked-by: Chunming Zhou on patch#3. I cannot fully judge patch #4, #5, #6. -David From: amd-gfx On Behalf Of Grodzovsky, Andrey Sent: Friday, April 26, 2019 10:09 PM To: Koenig, Christian ; Zhou, David(ChunMing) ; dri-de...@lists.freedesktop.org; amd-gfx

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-14 Thread Zhou, David(ChunMing)
my only concern is how to fresh LRU when bo is from bo list. -David Original Message Subject: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Olsak, Marek" ,"Zhou, David(ChunMing)" ,"Liang, Prike" ,d

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-14 Thread Zhou, David(ChunMing)
CS From: Christian König To: "Zhou, David(ChunMing)" ,"Olsak, Marek" ,"Liang, Prike" ,dri-de...@lists.freedesktop.org,amd-gfx@lists.freedesktop.org CC: [CAUTION: External Email] Hui? What do you mean with that? Christian. Am 14.05.19 um 15:12 schrieb Zhou, David

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-15 Thread Zhou, David(ChunMing)
Isn't this patch trying to stop removing for all BOs from bo list? -David Original Message Subject: Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,"

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

2019-05-15 Thread Zhou, David(ChunMing)
ng CS From: "Koenig, Christian" To: "Zhou, David(ChunMing)" ,"Olsak, Marek" ,"Liang, Prike" ,dri-de...@lists.freedesktop.org,amd-gfx@lists.freedesktop.org CC: [CAUTION: External Email] BO list? No, we stop removing them from the LRU. But we still mov

RE: [PATCH 01/11] drm/ttm: Make LRU removal optional.

2019-05-17 Thread Zhou, David(ChunMing)
> -Original Message- > From: Christian König > Sent: Tuesday, May 14, 2019 8:31 PM > To: Olsak, Marek ; Zhou, David(ChunMing) > ; Liang, Prike ; dri- > de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Subject: [PATCH 01/11] drm/ttm: Make LRU removal op

RE: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-29 Thread Zhou, David(ChunMing)
Patch #1,#5,#6,#8,#9,#10 are Reviewed-by: Chunming Zhou Patch #2,#3,#4 are Acked-by: Chunming Zhou -David > -Original Message- > From: dri-devel On Behalf Of > Christian K?nig > Sent: Wednesday, May 29, 2019 8:27 PM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org >

RE: [PATCH 7/7] drm/amdgpu: minor cleanup in amdgpu_job.c

2018-07-15 Thread Zhou, David(ChunMing)
Series is Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, July 13, 2018 11:20 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 7/7] drm/amdgpu: minor cleanup in amdgpu_job.c Remove sup

RE: [PATCH 2/2] drm/amdgpu: change ring priority after pushing the job

2018-07-16 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou for series. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, July 16, 2018 9:25 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: change ring priority after pushing th

RE: [PATCH] drm/amdgpu: always initialize job->base.sched

2018-07-17 Thread Zhou, David(ChunMing)
Acked-by: Chunming Zhou , but I think it isn't a nice evaluation although there is comment in code. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Tuesday, July 17, 2018 3:05 PM To: amd-gfx@lists.freedesktop.org Subject

RE: [PATCH] drm/amdgpu: fix job priority handling

2018-07-18 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, July 19, 2018 2:15 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: fix job priority handling The job might already be

RE: [PATCH 2/2] drm/amdgpu: clean up UVD instance handling v2

2018-07-18 Thread Zhou, David(ChunMing)
Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, July 19, 2018 2:45 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: clean up UVD instance handling v2 The whole handl

RE: [PATCH] drm/amdgpu/powerplay: use irq source defines for smu7 sources

2018-07-18 Thread Zhou, David(ChunMing)
Rewiewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Thursday, July 19, 2018 5:09 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay: use irq source defin

RE: [PATCH 1/2] drm/amdgpu: remove superflous UVD encode entity

2018-07-18 Thread Zhou, David(ChunMing)
Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, July 19, 2018 2:45 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 1/2] drm/amdgpu: remove superflous UVD encode entity Not sure wha

RE: [PATCH] drm/amdgpu: add proper error handling to amdgpu_bo_list_get

2018-07-29 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, July 27, 2018 9:39 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: add proper error handling to amdgpu_bo_list_get Othe

RE: [PATCH] drm/amdgpu: add new amdgpu_vm_bo_trace_cs() function

2018-07-29 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, July 27, 2018 10:58 PM To: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey Subject: [PATCH] drm/amdgpu: add new amdgpu_vm_bo_trace_cs

RE: [PATCH] drm/amdgpu: add new amdgpu_vm_bo_trace_cs() function v2

2018-07-30 Thread Zhou, David(ChunMing)
Go ahead with my RB. -Original Message- From: amd-gfx On Behalf Of Christian K?nig Sent: Monday, July 30, 2018 5:19 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: add new amdgpu_vm_bo_trace_cs() function v2 This allows us to trace all VM ranges which should be valid i

RE: [PATCH 9/9] drm/amdgpu: create an empty bo_list if no handle is provided

2018-07-30 Thread Zhou, David(ChunMing)
Series is Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx On Behalf Of Christian K?nig Sent: Monday, July 30, 2018 10:52 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 9/9] drm/amdgpu: create an empty bo_list if no handle is provided Instead of having extra handling

RE: [PATCH 1/2] drm/amdgpu: return bo itself if userptr is cpu addr of bo (v3)

2018-07-30 Thread Zhou, David(ChunMing)
, David(ChunMing) ; Koenig, Christian Subject: Re: [PATCH 1/2] drm/amdgpu: return bo itself if userptr is cpu addr of bo (v3) Am 30.07.2018 um 12:02 schrieb Junwei Zhang: > From: Chunming Zhou > > v2: get original gem handle from gobj > v3: update find bo data structure as u

RE: [PATCH 1/2] drm/amdgpu: return bo itself if userptr is cpu addr of bo (v3)

2018-07-30 Thread Zhou, David(ChunMing)
Typo, excepted -> expected -Original Message- From: amd-gfx On Behalf Of Zhou, David(ChunMing) Sent: Tuesday, July 31, 2018 9:41 AM To: Koenig, Christian ; Zhang, Jerry ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 1/2] drm/amdgpu: return bo itself if userptr is cpu addr of

RE: [PATCH 3/4] drm/scheduler: add new function to get least loaded sched v2

2018-08-01 Thread Zhou, David(ChunMing)
Another big question: I agree the general idea is good to balance scheduler load for same ring family. But, when same entity job run on different scheduler, that means the later job could be completed ahead of front, Right? That will break fence design, later fence must be signaled after front fen

RE: [PATCH] drm/scheduler: Add stopped flag to drm_sched_entity

2018-08-20 Thread Zhou, David(ChunMing)
-Original Message- From: dri-devel On Behalf Of Andrey Grodzovsky Sent: Friday, August 17, 2018 11:16 PM To: dri-de...@lists.freedesktop.org Cc: Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/scheduler: Add stopped flag to drm_sched_entity The flag will prevent

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Zhou, David(ChunMing)
> -Original Message- > From: Koenig, Christian > Sent: Thursday, September 13, 2018 2:56 PM > To: Zhou, David(ChunMing) ; Zhou, > David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-gfx@lists.freedesktop.org > Subjec

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Zhou, David(ChunMing)
> -Original Message- > From: Christian König > Sent: Thursday, September 13, 2018 4:50 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; dri-de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-gfx@lists.freedesktop.org > Subject: Re: [

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-13 Thread Zhou, David(ChunMing)
> -Original Message- > From: Koenig, Christian > Sent: Thursday, September 13, 2018 5:20 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/3] [RFC]d

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-14 Thread Zhou, David(ChunMing)
> -Original Message- > From: Koenig, Christian > Sent: Friday, September 14, 2018 3:27 PM > To: Zhou, David(ChunMing) ; Zhou, > David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-gfx@lists.freedesktop.org; Daniel Vetter

RE: [PATCH] [RFC]drm: add syncobj timeline support v5

2018-09-16 Thread Zhou, David(ChunMing)
> -Original Message- > From: Daniel Vetter On Behalf Of Daniel Vetter > Sent: Saturday, September 15, 2018 12:11 AM > To: Koenig, Christian > Cc: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Dave Airlie > ; Rakos, Dan

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-19 Thread Zhou, David(ChunMing)
[AMD Official Use Only - Internal Distribution Only] Christian is right here, that will cause many problems for simply using VMID in kernel. We already have an pair interface for RGP, I think you can use it instead of involving additional kernel change. amdgpu_vm_reserve_vmid/ amdgpu_vm_unreserv

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-20 Thread Zhou, David(ChunMing)
[AMD Official Use Only - Internal Distribution Only] You can enhance amdgpu_vm_ioctl In amdgpu_vm.c to return vmid to userspace. -David From: He, Jacob Sent: Thursday, February 20, 2020 10:46 PM To: Zhou, David(ChunMing) ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-21 Thread Zhou, David(ChunMing)
[AMD Official Use Only - Internal Distribution Only] That's fine to me. -David From: Koenig, Christian Sent: Friday, February 21, 2020 11:33 PM To: Deucher, Alexander ; Christian König ; Zhou, David(ChunMing) ; He, Jacob ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu:

RE: [PATCH 2/3] drm/amdgpu: reserve at least 4MB of VRAM for page tables

2019-09-02 Thread Zhou, David(ChunMing)
Do you need update the vram size reported to UMD ? -David -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Monday, September 2, 2019 6:52 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/3] drm/amdgpu: reserve at least 4MB of VRAM for page tables This hopefully

Re:[PATCH] drm/amdgpu: resvert "disable bulk moves for now"

2019-09-12 Thread Zhou, David(ChunMing)
I dont know dkms status,anyway, we should submit this one as early as possible. 原始邮件 主题:Re: [PATCH] drm/amdgpu: resvert "disable bulk moves for now" 发件人:Christian König 收件人:"Zhou, David(ChunMing)" ,amd-gfx@lists.freedesktop.org 抄送: Just to double check: We

RE: [PATCH] drm/amdgpu: remove gfx9 NGG

2019-09-19 Thread Zhou, David(ChunMing)
+Alex Yan to confirm which doesn't affect us. -Original Message- From: amd-gfx On Behalf Of Marek Olšák Sent: Friday, September 20, 2019 10:16 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: remove gfx9 NGG From: Marek Olšák Never used. Signed-off-by: Marek Olšák

RE: [PATCH] drm/amd/amdgpu: fix spelling mistake: "comleted" -> "completed"

2016-12-29 Thread Zhou, David(ChunMing)
+amd-gfx, patch is Reviewed-by: Chunming Zhou -Original Message- From: Colin King [mailto:colin.k...@canonical.com] Sent: Thursday, December 29, 2016 11:47 PM To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Zhou, David(ChunMing) ; StDenis, Tom ; Liu, Monk ; dri-de

amd-gfx@lists.freedesktop.org

2017-02-05 Thread Zhou, David(ChunMing)
I'm curious what problem this patch fix? Any crash? My impression list_for will check if the list is empty, am I wrong? Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk Liu Sent: Saturday, February 04, 2017 6:22 PM To:

RE: [PATCH 2/2] drm/amdgpu/virt: schedule work to handle vm fault for VF

2017-02-06 Thread Zhou, David(ChunMing)
INIT_WORK(&work->base, gmc_v8_0_vm_fault_sched); However VF is used or not, schedule work shouldn't handle registers reading for interrupt, especially for status register, which could have been changed when you handle it in schedule work after interrupt. Regards, David Zhou -Original Messag

RE: [PATCH 4/4] drm/amdgpu: resize VRAM BAR for CPU access

2017-03-15 Thread Zhou, David(ChunMing)
Does that means we don't need invisible vram later? David -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, March 15, 2017 3:38 PM To: Ayyappa Ch Cc: linux-...@vger.kernel.org; linux-ker...@vger.kernel.org;

RE: [PATCH 2/2] drm/amd/sched: add schuduling policy

2017-03-16 Thread Zhou, David(ChunMing)
piece to it so that the efficiency is same with occupied previous. Regards, David Zhou -Original Message- From: Andres Rodriguez [mailto:andre...@gmail.com] Sent: Friday, March 17, 2017 12:32 AM To: Christian König ; Zhou, David(ChunMing) ; Koenig, Christian ; amd-gfx@lists.freedeskto

RE: Plan: BO move throttling for visible VRAM evictions

2017-03-27 Thread Zhou, David(ChunMing)
For APU special case, can we prevent eviction happening between VRAM <> GTT? Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Michel D?nzer Sent: Monday, March 27, 2017 3:36 PM To: Marek Olšák Cc: amd-gfx mailing list

RE: [PATCH] drm/amdgpu:fix waiting on dirty fence

2017-05-02 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk Liu Sent: Monday, May 01, 2017 4:18 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH] drm/amdgpu:fix waiting on dirty fence if bo->shadow is NUL

RE: [PATCH 1/5] drm/amdgpu:keep ctx alive till all job finished

2017-05-02 Thread Zhou, David(ChunMing)
You can add ctx as filed of job, but not get reference of it, when you try to use ctx, just check if ctx == NULL. Another stupid method: Use idr_for_each_entry(..job->vm->ctx_mgr...) and compare the job->fence->fence_context with ctx->ring[].entity->fence_context. if not found, then ctx is fre

RE: [PATCH 1/2] drm/amdgpu:use FRAME_CNTL for new GFX ucode

2017-05-04 Thread Zhou, David(ChunMing)
How about compute ring? Is there same requirement? David -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Liu, Monk Sent: Thursday, May 04, 2017 6:49 PM To: amd-gfx@lists.freedesktop.org Subject: FW: [PATCH 1/2] drm/amdgpu:use FRAME_CNTL for ne

RE: [PATCH] drm/amdgpu: fix sem list soft lockup issue

2017-05-11 Thread Zhou, David(ChunMing)
This is internal only patch, please send to internal mail list. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Junwei Zhang Sent: Friday, May 12, 2017 2:54 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH] drm/amdgpu: fix

RE: [PATCH 6/7] drm/amdgpu: stop joining VM PTE updates

2017-05-17 Thread Zhou, David(ChunMing)
Patch#2: Reviewed-by: Chunming Zhou Patch#3: RB should be from Hawking, so Acked-by: Chunming Zhou Patch#5 #6, are Reviewed-by: Chunming Zhou For patch#7, further transfer +1 page table, I need a bit time of tomorrow. Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-

RE: [PATCH 4/4] drm/amdgpu: reset fpriv vram_lost_counter

2017-05-17 Thread Zhou, David(ChunMing)
König Cc: Zhou, David(ChunMing) ; Michel Dänzer ; amd-gfx mailing list Subject: Re: [PATCH 4/4] drm/amdgpu: reset fpriv vram_lost_counter David, We already have a query that returns whether a device is lost. It's called amdgpu_cs_query_reset_state. That should return whether a hang was c

回复: [PATCH] drm/amdgpu: fix ocl test performance drop

2017-05-22 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou 原始邮件 主题:Re: [PATCH] drm/amdgpu: fix ocl test performance drop 发件人:Flora Cui 收件人:"Zhou, David(ChunMing)" 抄送:amd-gfx@lists.freedesktop.org partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in amdgpu_vm_

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

2017-09-13 Thread Zhou, David(ChunMing)
Could you describe how difficult to directly use CS syncfile fd in Mesa compared with concerting CS seq to syncfile fd via several syncobj ioctls? Regards, David Zhou 发自坚果 Pro Marek Ol?醟 于 2017年9月13日 下午6:11写道: On Wed, Sep 13, 2017 at 5:03 AM, zhoucm1 wrote: > Hi Marek, > > You're doing same

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

2017-09-13 Thread Zhou, David(ChunMing)
Ol?醟 于 2017年9月13日 下午8:06写道: On Wed, Sep 13, 2017 at 1:32 PM, Zhou, David(ChunMing) wrote: > Could you describe how difficult to directly use CS syncfile fd in Mesa > compared with concerting CS seq to syncfile fd via several syncobj ioctls? It just simplifies things. Mesa primarily uses

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

2017-09-13 Thread Zhou, David(ChunMing)
rther. Regards, Christian. Am 13.09.2017 um 14:25 schrieb Zhou, David(ChunMing): Yes, to be comptibility, I kept both seq_no and syncfile fd in the patch set, you can take a look, which really is simpler and effective way. syncfile indeed be a good way to pass fence for user space, which already is pr

RE: [PATCH 12/18] drm/amdgpu:use formal register to trigger hdp invalidate

2017-09-18 Thread Zhou, David(ChunMing)
Please answer my question as I raised in another thread, otherwise I will give a NAK on this! Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Liu, Monk Sent: Tuesday, September 19, 2017 12:04 PM To: Koenig, Christian ; amd

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

2017-09-30 Thread Zhou, David(ChunMing)
Could you test and review it? On hand, I have no env. Regards, David Zhou 发自坚果 Pro Marek Ol?醟 于 2017年9月30日 下午11:56写道: The idea sounds good. Marek On Sat, Sep 30, 2017 at 3:55 AM, Chunming Zhou wrote: > My mean is like the attached, I revert part of yours. > > Regards, > > David zhou > > >

Re: [PATCH 3/5] drm/amdgpu: rename amdgpu_ttm_bind to amdgpu_ttm_alloc_gart

2017-11-02 Thread Zhou, David(ChunMing)
I'm not sue if it's properly, and have no strong opinion, Alex or others can have a look. 发自坚果 Pro Christian K鰊ig 于 2017年11月2日 下午8:19写道: Ping? Any objects or can I push this? Asking because the next patch is desperately needed upstream. Christian. Am 27.10.2017 um 16:43 schrieb Christian K

Re: [PATCH 1/2] drm/amdgpu: use multipipe compute policy on non PL11 asics

2017-11-06 Thread Zhou, David(ChunMing)
Then snychronization should have no problem, it maybe relate to multipipe hw setting issue. Regards, David Zhou From: Andres Rodriguez Sent: Tuesday, November 7, 2017 2:00:57 AM To: Zhou, David(ChunMing); amd-gfx list Cc: Deucher, Alexander Subject: Re

Re: [PATCH 1/2] drm/amdgpu: use multipipe compute policy on non PL11 asics

2017-11-07 Thread Zhou, David(ChunMing)
he hung is related to the pipe is used both ORCA and rocm. But Felix said they dont support rocm on Tonga, that could mean this issue doesn't matter currently. Regards, David Zhou From: Andres Rodriguez Sent: Tuesday, November 7, 2017 3:26:38 PM To: Zhou, Dav

  1   2   >