RE: [PATCH] drm/amdgpu: enable full ras by default

2019-09-18 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chen, Guchun Sent: 2019年9月19日 11:15 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Zhou1, Tao ; Grodzovsky, Andrey Cc: Li, Candice ; Chen, Guchun Subject: [PATCH] drm/amdgpu: enable full ras by default Enable

RE: [PATCH 05/21] drm/amdgpu: refine sdma4 ras_data_cb

2019-09-19 Thread Zhang, Hawking
Let's add comments to clarifying why checking GFX IP BLOCK for SDMA interrupt so people will not be confusing here. Regards, Hawking -Original Message- From: Chen, Guchun Sent: 2019年9月19日 21:59 To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, Hawking Subject: RE: [PATCH

RE: [PATCH 3/3] drm/amdgpu: enable psp front door loading by default on Arcturus

2019-09-23 Thread Zhang, Hawking
Patch #2 should be already in drm-next. Please drop it from the series when you push them. The series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Le Ma Sent: 2019年9月23日 14:29 To: amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: [PATCH

RE: [PATCH 2/2] drm/amdgpu: correct condition check for psp rlc autoload

2019-09-23 Thread Zhang, Hawking
Please help to add simple description for both patches. with that fixed, Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Le Ma Sent: 2019年9月23日 21:31 To: amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: [PATCH 2/2] drm/amdgpu: corre

RE: [PATCH] drm/amdgpu: fix an UMC hw arbitrator bug

2019-09-23 Thread Zhang, Hawking
The patch is in high risk to break other VG series and MI series. Any confidence this is a common hw bug across all UMC 6.x generations? Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Monk Liu Sent: 2019年9月24日 11:39 To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subje

RE: [PATCH] drm/amdgpu: fix an UMC hw arbitrator bug

2019-09-23 Thread Zhang, Hawking
u can leverage this to simplify the logic in the umc callback function. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: 2019年9月24日 13:44 To: Liu, Monk ; amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: RE: [PATCH] drm/amdgpu: fix an UMC hw arbit

RE: [PATCH] drm/amd/amdgpu: add IH cg support on soc15 project

2019-09-26 Thread Zhang, Hawking
We should implement get_clock_gating callback function for IH block as well. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: 2019年9月26日 16:48 To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/amdgpu: add IH cg support on soc15

RE: [PATCH] drm/amd/amdgpu: add IH cg support on soc15 project

2019-09-26 Thread Zhang, Hawking
Check navi10_ih_get_clock_gating for the reference. Regards, Hawking -Original Message- From: Zhang, Hawking Sent: 2019年9月26日 23:09 To: 'Kenneth Feng' ; amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: RE: [PATCH] drm/amd/amdgpu: add IH cg support on soc15 project

RE: [PATCH 1/1] drm/amdgpu: Fix error handling in amdgpu_ras_recovery_init

2019-10-04 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Kuehling, Felix Sent: 2019年10月4日 6:01 To: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey Cc: Cox, Philip Subject: [PATCH 1/1] drm/amdgpu: Fix error handling in amdgpu_ras_recovery_init Don't

RE: [BUG] failed to load firmware - AMD Ryzen 5 2500U

2019-10-07 Thread Zhang, Hawking
I haven't closely looked at the issue, but it seems to me we do have potential risk to fail set up tmr on APU since from the change that move tmr region from visible framebuffer to invisible range. The point is in some APU platform, there might be no invisible frame buffer, so we need a fallback

RE: [PATCH 2/2] drm/amd/powerplay: enable df cstate control on swSMU routine

2019-10-09 Thread Zhang, Hawking
Yes, we have to toggle DF-C state before/after programming DF Perf counter registers. The series is to provide interface for such case. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Feng, Kenneth Sent: 2019年10月10日 12:50 To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc:

RE: [PATCH] drm/amdgpu/discovery: reserve discovery data at the top of VRAM

2019-10-10 Thread Zhang, Hawking
Please add define on tmr memory size instead of hard-code. Other than that the patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Yuan, Xiaojie Sent: 2019年10月10日 20:48 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xiao, Jack ; Yuan, Xiaojie

RE: [PATCH 0/3] RAS Support for GFX blocks

2019-10-10 Thread Zhang, Hawking
Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Dennis Li Sent: 2019年10月11日 10:49 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao ; Zhang, Hawking ; Chen, Guchun Cc: Li, Dennis Subject: [PATCH 0/3] RAS Support for GFX blocks 1

RE: [PATCH 1/4] drm/amdgpu/soc15: disable doorbell interrupt as part of BACO entry sequence

2019-10-11 Thread Zhang, Hawking
Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Le Ma Sent: 2019年10月11日 19:10 To: amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: [PATCH 1/4] drm/amdgpu/soc15: disable doorbell interrupt as part of BACO entry sequence Workaround to

RE: [PATCH] drm/amdgpu: disable gfxoff on navi10

2019-06-24 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Tianci Yin Sent: 2019年6月24日 20:16 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Yin, Tianci (Rico) Subject: [PATCH] drm/amdgpu: disable gfxoff on navi10 From: tiancyin The gfxoff brings unstability

RE: [amd-staging-drm-next] broken after Navi merge

2019-06-24 Thread Zhang, Hawking
Please pull my latest fixes that probably helps on issue you ran into. 61adda1f6f080717a9ee4c96a74c8df6ffab1ff0 drm/amdgpu: fix modprobe failure for uvd_4/5/6 Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Dieter Nützel Sent: 2019年6月24日 21:29 To: Alex Deucher Cc: amd-dev

RE: [amd-staging-drm-next] broken after Navi merge

2019-06-24 Thread Zhang, Hawking
Ah, sorry, it has not landed yet. but the patch is in review list now. [PATCH] drm/amdgpu: fix modprobe failure for uvd_4/5/6 Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: 2019年6月24日 21:50 To: Dieter Nützel ; Alex Deucher Cc: amd-devel Subject: RE

RE: [PATCH 2/2] drm/amdgpu/display: switch udelay to msleep

2019-06-25 Thread Zhang, Hawking
Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: 2019年6月25日 21:59 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amdgpu/display: switch udelay to msleep We may need to sleep for up

RE: [PATCH] drm/amd/powerplay: add missing smu_get_clk_info_from_vbios() call

2019-06-25 Thread Zhang, Hawking
The comments below is actually for check_pptable, instead of get_clk_info_from vbios. Please adjust the comments as well. * check if the format_revision in vbios is up to pptable header * version, and the structure size is not 0. */ With that fixed, the patch is Reviewed-by: Hawking Zhang Rega

RE: [PATCH] drm/amdgpu: drop copy/paste leftover to fix big endian

2019-06-27 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: 2019年6月27日 22:16 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: drop copy/paste leftover to fix big endian The buf swap field doesn't exis

RE: [PATCH] drm/amdkfd: remove an unused variable

2019-07-02 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Xiao, Jack Sent: 2019年7月2日 14:58 To: amd-gfx@lists.freedesktop.org Cc: Xiao, Jack Subject: [PATCH] drm/amdkfd: remove an unused variable Just for cleanup. Signed-off-by: Jack Xiao --- drivers/g

RE: [PATCH] drm/amd/powerplay: increase waiting time for smu response

2019-07-03 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Xiao, Jack Sent: 2019年7月3日 12:18 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking Cc: Xiao, Jack Subject: [PATCH] drm/amd/powerplay: increase waiting time for smu response We observed some

RE: [PATCH] drm/amd/powerplay: add baco smu reset function for smu11

2019-07-03 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang From: Wang, Kevin(Yang) Sent: 2019年7月4日 11:13 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xiao, Jack ; Huang, Ray ; Feng, Kenneth ; Quan, Evan Subject: Re: [PATCH] drm/amd/powerplay: add baco smu reset function for smu11 ping..., which one can help me

RE: [PATCH] drm/amdgpu: add mode1 (psp) reset for navi asic

2019-07-04 Thread Zhang, Hawking
- From: Wang, Kevin(Yang) Sent: 2019年7月5日 12:58 To: amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; kenenth.f...@amd.com; Zhang, Hawking ; Wang, Kevin(Yang) Subject: [PATCH] drm/amdgpu: add mode1 (psp) reset for navi asic add mode1 (by psp) reset for navi asic. Change-Id

RE: [PATCH] drm/amdgpu/psp: add a mutex to protect access to the psp ring

2019-07-08 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: 2019年7月9日 2:36 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/psp: add a mutex to protect access to the psp ring We need to serialize acces

RE: [PATCH 1/2] drm/amdgpu: switch to macro for psp bootloader command

2019-07-10 Thread Zhang, Hawking
e internal psp_gfx_if.h files, so I put them in general psp header. Regards, Hawking -Original Message- From: Alex Deucher Sent: 2019年7月11日 1:25 To: Zhang, Hawking Cc: amd-gfx list ; Yuan, Xiaojie ; Clements, John ; Deucher, Alexander Subject: Re: [PATCH 1/2] drm/amdgpu: switch to mac

RE: [PATCH 1/2] drm/amdgpu: switch to macro for psp bootloader command

2019-07-11 Thread Zhang, Hawking
Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: 2019年7月11日 12:13 To: Alex Deucher Cc: Deucher, Alexander ; Clements, John ; amd-gfx list ; Yuan, Xiaojie Subject: RE: [PATCH 1/2] drm/amdgpu: switch to macro for psp bootloader command RE - Maybe this would be better in psp_gfx_if.h

RE: [PATCH libdrm 2/2] tests/amdgpu: add gpu reset test

2019-07-18 Thread Zhang, Hawking
Series is: Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Cui, Flora Sent: 2019年7月18日 16:11 To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH libdrm 2/2] tests/amdgpu: add gpu reset test 1. perform gpu reset 2. perform dispatch

RE: [PATCH] drm/amdgpu: fix double ucode load by PSP(v3)

2019-07-31 Thread Zhang, Hawking
in suspend/resume call stack looks reasonable to me. Patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Liu, Monk Sent: 2019年8月1日 11:43 To: Deucher, Alexander ; Koenig, Christian ; Zhang, Hawking Cc: Deng, Emily ; amd-gfx@lists.freedesktop.org Subject: RE

RE: [PATCH 0/6] umc ras code refinement

2019-08-01 Thread Zhang, Hawking
Please add one line description for patch #2 & 3. Other than that, the series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: 2019年8月1日 14:43 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Chen, Guchun ;

RE: [PATCH 0/4] enable umc ras ce interrupt

2019-08-01 Thread Zhang, Hawking
the hardcoded value seems not match with the value calculated by those macro. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: 2019年8月1日 14:54 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Chen, Guchun ; Pan, Xinhui Cc: Zhou1, Tao Subj

RE: [PATCH 0/5] enable umc ras ce interrupt v2

2019-08-01 Thread Zhang, Hawking
Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: 2019年8月1日 19:55 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Chen, Guchun ; Pan, Xinhui Cc: Zhou1, Tao Subject: [PATCH 0/5] enable umc ras ce

RE: [PATCH] drm/amdgpu: Fix panic during gpu reset

2019-08-05 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Pan, Xinhui Sent: 2019年8月5日 14:58 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Monk Subject: [PATCH] drm/amdgpu: Fix panic during gpu reset Clear the flag after hw suspend, oth

RE: [PATCH] drm/amdgpu: update ras sysfs feature info

2019-08-05 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: 2019年8月5日 16:04 To: amd-gfx@lists.freedesktop.org; Pan, Xinhui ; Zhang, Hawking Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: update ras sysfs feature info remove confused ras

RE: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14

2019-08-05 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Tianci Yin Sent: 2019年8月5日 17:35 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xiao, Jack ; Yuan, Xiaojie ; Yin, Tianci (Rico) Subject: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14 From

RE: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14

2019-08-05 Thread Zhang, Hawking
BTW, please make sure you have the latest drm-next code base. The deleted code seems like in some topic branch. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: 2019年8月5日 17:45 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack

RE: [PATCH] drm/amdgpu/discovery: move common discovery code out of navi1*_reg_base_init()

2019-08-05 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Yuan, Xiaojie Sent: 2019年8月5日 17:55 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xiao, Jack ; Yuan, Xiaojie Subject: [PATCH] drm/amdgpu/discovery: move common discovery code out of navi1*_reg_base_init

RE: [PATCH libdrm 0/3] add ras eject test for gfx and umc module

2019-08-06 Thread Zhang, Hawking
We shall add back umc multi-uncorrectable error injection in default config file. With that fixed, the series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Guchun Chen Sent: 2019年8月6日 15:36 To: amd-gfx@lists.freedesktop.org; Zhang

RE: [PATCH v2 libdrm 0/3] add ras inject test for gfx and umc module

2019-08-07 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Guchun Chen Sent: 2019年8月7日 14:52 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Dennis ; Pan, Xinhui ; Zhou1, Tao Cc: Chen, Guchun Subject: [PATCH v2 libdrm 0/3] add ras inject test

RE: [PATCH 2/2] drm/amd/powerplay: update smu11_driver_if_navi10.h

2019-08-07 Thread Zhang, Hawking
Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tianci Yin Sent: 2019年8月8日 13:49 To: amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Yin, Tianci (Rico) ; Zhang, Hawking ; Quan, Evan ; Yuan, Xiaojie Subject

RE: [PATCH 2/7] drm/amdgpu/gfx6: clean up cu configuration

2017-02-07 Thread Zhang, Hawking
gards, Hawking -Original Message- From: Flora Cui [mailto:flora@amd.com] Sent: Tuesday, February 07, 2017 16:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH 2/7] drm/amdgpu/gfx6: clean up cu configuration Change-Id: Ieb6f58ab238a2dcf59cc369c0ba4975d4a244c8d

RE: [PATCH 1/7] drm/amdgpu/gfx6: clean up rb configuration

2017-02-07 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Flora Cui [mailto:flora@amd.com] Sent: Tuesday, February 07, 2017 16:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH 1/7] drm/amdgpu/gfx6: clean up rb configuration Change-Id

RE: [PATCH 3/7] drm/amdgpu/gfx6: clean up spi configuration

2017-02-07 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Flora Cui [mailto:flora@amd.com] Sent: Tuesday, February 07, 2017 16:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH 3/7] drm/amdgpu/gfx6: clean up spi configuration Change-Id

RE: [PATCH 5/7] drm/amdgpu: update VERDE_GB_ADDR_CONFIG_GOLDEN

2017-02-07 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Flora Cui [mailto:flora@amd.com] Sent: Tuesday, February 07, 2017 16:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH 5/7] drm/amdgpu: update VERDE_GB_ADDR_CONFIG_GOLDEN Change

RE: [PATCH 6/7] drm/amdgpu: update HAINAN_GB_ADDR_CONFIG_GOLDEN

2017-02-07 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Flora Cui [mailto:flora@amd.com] Sent: Tuesday, February 07, 2017 16:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH 6/7] drm/amdgpu: update HAINAN_GB_ADDR_CONFIG_GOLDEN

RE: [PATCH 7/7] drm/amd/gfx6: update gb_addr_config

2017-02-07 Thread Zhang, Hawking
Why you need to re-program this bit? Regards, Hawking -Original Message- From: Flora Cui [mailto:flora@amd.com] Sent: Tuesday, February 07, 2017 16:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH 7/7] drm/amd/gfx6: update gb_addr_config Change

RE: [PATCH 4/7] drm/amdgpu: refine si_read_register

2017-02-07 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Flora Cui [mailto:flora@amd.com] Sent: Tuesday, February 07, 2017 16:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH 4/7] drm/amdgpu: refine si_read_register Change-Id

RE: [PATCH 3/3] drm/amdgpu: fix another fundamental VM bug

2017-05-16 Thread Zhang, Hawking
oint. Anyway, the base physical address (vram_base_offset) should plus an offset to reflect the real physical address of vram bo. Regards, Hawking -Original Message- From: Zhou, David(ChunMing) Sent: Tuesday, May 16, 2017 10:45 To: Christian König ; amd-gfx@lists.freedesktop.org; Zhang,

RE: [PATCH 3/3] drm/amdgpu: fix another fundamental VM bug

2017-05-16 Thread Zhang, Hawking
-GFX9 adapter? Regards, Hawking -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: Tuesday, May 16, 2017 15:49 To: Zhang, Hawking ; Zhou, David(ChunMing) ; amd-gfx@lists.freedesktop.org; Koenig, Christian Subject: Re: [PATCH 3/3] drm/amdgpu: fix another funda

RE: [PATCH] drm/amd/amdgpu: Enable raven gpu_info firmware

2017-05-18 Thread Zhang, Hawking
IIRC It's already in amd-staging-4.9 branch. Anyway, the patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Thursday, May 18, 2017 20:00 To: amd-gfx@lists.freedesktop.org C

RE: [PATCH] drm/amdgpu: fix merge of vcn_v1_0.c

2017-05-22 Thread Zhang, Hawking
: Zhang, Hawking Subject: [PATCH] drm/amdgpu: fix merge of vcn_v1_0.c From: Christian König That line got missed during the merge. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b

RE: [PATCH] drm/amdgpu: fix merge of vcn_v1_0.c

2017-05-22 Thread Zhang, Hawking
: Zhang, Hawking Subject: [PATCH] drm/amdgpu: fix merge of vcn_v1_0.c From: Christian König That line got missed during the merge. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c

RE: [PATCH 00/18] Vega10 S3 following up

2017-05-31 Thread Zhang, Hawking
I would suggest to use RREG32_SOC15/ WREG32_SOC15 to avoid code refactor again... Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Huang Rui Sent: Thursday, June 01, 2017 0:15 To: amd-gfx@lists.freedesktop.org; Deucher, Alexan

RE: [PATCH] drm/amdgpu: enable gfx 9.0 cp interrupts

2017-05-31 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Ken Wang Sent: Thursday, June 01, 2017 11:07 To: amd-gfx@lists.freedesktop.org Cc: Wang, Ken Subject: [PATCH] drm/amdgpu: enable gfx 9.0 cp interrupt

RE: [PATCH 1/2] drm/ttm: remove unused placement flags

2016-09-09 Thread Zhang, Hawking
Hi Chris, Removing the flag will make ttm_mem_type_from_place skip counting the corresponding placement and thus have impact on mem region create and bo movement. There is no guarantee that amdgpu would never introduce new memory domain in future. In such case, I'd like to vote for keeping thes

RE: [PATCH 1/2] drm/ttm: remove unused placement flags

2016-09-09 Thread Zhang, Hawking
Hi Chris, Removing the flag will make ttm_mem_type_from_place skip counting the corresponding placement and thus have impact on mem region create and bo movement. There is no guarantee that amdgpu would never introduce new memory domain in future. In such case, I'd like to vote for keeping thes

RE: [PATCH] drm/amdgpu:fix exclusive mode game texture blank(v2)

2016-09-30 Thread Zhang, Hawking
+ if (job && !job->vm_needs_flush && ring->type == AMDGPU_RING_TYPE_GFX) { + extra_nop = 128; + } + Please remove the redundant braces here. With that fixed, the patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gf

RE: [PATCH] drm/amd/amdgpu: move get memory type function from early init to sw init

2017-06-30 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Jim Qu Sent: Friday, June 30, 2017 14:57 To: amd-gfx@lists.freedesktop.org Cc: Qu, Jim Subject: [PATCH] drm/amd/amdgpu: move get memory type function f

RE: [PATCH 2/3] drm/amdgpu/atomfirmware: implement vram_width for APUs

2017-07-05 Thread Zhang, Hawking
Series are Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Thursday, July 06, 2017 3:51 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/3] drm/amdgpu/at

RE: [PATCH] drm/amdgpu: fix vega10 graphic hang issue in S3 test

2017-08-17 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of ken.w...@amd.com Sent: Thursday, August 17, 2017 13:43 To: amd-gfx@lists.freedesktop.org Cc: Wang, Ken Subject: [PATCH] drm/amdgpu: fix vega10 graphic

RE: [PATCH] drm/amd/powerplay: delete pp dead code on raven

2017-08-25 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Friday, August 25, 2017 18:18 To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amd/powerplay: delete pp dead code on

RE: [PATCH 3/9] drm/amdgpu: add amdgpu module parameter for zfb

2018-02-07 Thread Zhang, Hawking
Apart from the allocation failure, reserving 1024M cma is also not realistic Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Chunming Zhou Sent: Thursday, February 08, 2018 12:35 To: Koenig, Christian ; Xu, Feifei ; amd-g

RE: [PATCH] drm/amdgpu: query vram type from atombios

2018-03-08 Thread Zhang, Hawking
Please ignore this patch since it doesn't sync up to the latest code base. I will re-send another review later Regards, Hawking -Original Message- From: Hawking Zhang Sent: 2018年3月8日 17:37 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: query

RE: [PATCH] drm/amdgpu: init gfx9 aperture settings

2018-04-19 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Flora Cui Sent: 2018年4月19日 13:35 To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH] drm/amdgpu: init gfx9 aperture settings Change-Id: Ie5683816e21d1dbf9b4f84f05ecbe056a321f06c Sign

RE: [PATCH 1/4] drm/amdgpu: add new DF 1.7 register defs

2018-05-20 Thread Zhang, Hawking
Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: 2018年5月19日 3:48 To: amd-gfx list Cc: Deucher, Alexander Subject: Re: [PATCH 1/4] drm/amdgpu: add new DF 1.7 register defs Ping? On Wed, May 16, 2018 at 4:51 PM, Ale

RE: [PATCH v2] drm/amdgpu: fix CG enabling hang with gfxoff enabled

2018-06-04 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Huang Rui Sent: 2018年6月5日 11:02 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kuehling, Felix ; Huang, Ray ; Koenig, Christian ; Zhang, Hawking Subject: [PATCH v2] drm/amdgpu: fix

RE: [PATCH v2] drm/amdgpu: fix CG enabling hang with gfxoff enabled

2018-06-05 Thread Zhang, Hawking
that before push the patch. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: 2018年6月5日 14:42 To: Huang, Ray ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kuehling, Felix ; Huang, Ray ; Koenig, Christian Subject: RE: [PATCH v2] drm/amdgpu

RE: [PATCH 5/5] drm/amd/pp: Remove the gfx pg/off ctrl code out of pp_set_powergating_state

2018-06-05 Thread Zhang, Hawking
Patch #1 ~ 4 are Reviewed-by: Hawking Zhang Patch #5 The patch will break recent gfxoff fix from Ray where he leveraged pp_set_powergating_state to enable gfxoff. If we didn't control gfxoff in smc power gating function, we have to add a new gfx function which then call into amdgpu_pp interfac

RE: [PATCH v2 2/2] drm/amdgpu: Make gfx_off control by GFX ip

2018-06-05 Thread Zhang, Hawking
The patch possibly cause ASIC hung during S3. GFXOFF should be disabled as the first step when suspend, and then enabled again as the last step when resume. Otherwise, any mmio access will result to aisc hung. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Rex Zhu Sent:

RE: [PATCH] Add freesync ioctl interface

2016-08-01 Thread Zhang, Hawking
The implementation is as [PATCH] Enable/disable freesync when enter/exit fullscreen game. Please take a review Regards, Hawking -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Tuesday, August 02, 2016 11:11 To: Zhang, Hawking Cc: amd-gfx@lists.freedesktop.org

RE: [PATCH] Add freesync ioctl interface

2016-08-01 Thread Zhang, Hawking
The implementation is as [PATCH] Enable/disable freesync when enter/exit fullscreen game. Please take a review Regards, Hawking -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Tuesday, August 02, 2016 11:11 To: Zhang, Hawking Cc: amd-gfx@lists.freedesktop.org

RE: [PATCH] Add freesync ioctl interface

2016-08-01 Thread Zhang, Hawking
The kernel branch has already merged the ioctl implementation. I'm okay to keep it internal although. Regards, Hawking -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Tuesday, August 02, 2016 11:32 To: Zhang, Hawking Cc: amd-gfx@lists.freedesktop.org Su

RE: [PATCH v2] drm/amdgpu: Add NPS switch support for GC 9.4.3

2024-10-09 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Tuesday, October 8, 2024 22:01 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Bhardwaj, Rajneesh ; Errabolu

RE: [PATCH] drm/amdgpu: Skip IP coredump for RAS errors

2024-11-03 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Monday, November 4, 2024 12:44 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Zhou1, Tao ; Khatri, Sunil

RE: [PATCH] drm/amdgpu: Fix DPX valid mode check on GC 9.4.3

2024-11-03 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Monday, November 4, 2024 13:11 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad Subject: [PATCH] drm

RE: [PATCH v3] drm/amdgpu: Add supported NPS modes node

2024-11-05 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kamal, Asad Sent: Tuesday, November 5, 2024 20:34 To: amd-gfx@lists.freedesktop.org; Lazar, Lijo ; Zhang, Hawking Cc: Ma, Le ; Zhang, Morris ; Kamal, Asad

RE: [PATCH 1/1] drm/amdgpu: add generic func to check if ta fw is applicable

2024-10-28 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Le Ma Sent: Monday, October 28, 2024 11:15 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Lazar, Lijo ; Deucher, Alexander ; Ma

RE: [PATCH 02/23] drm/amdgpu: do RAS init in NPS mode switch

2024-11-11 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] In nps mode is somehow confusing. We'd like to differentiate recovery (*after* reset) from regular initialization. Is it possible to replace in nps mode check with more general approach? In regular initialization, set ras interface availa

RE: [PATCH] drm/amdgpu: optimize ACA log print

2024-10-25 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Yang(Kevin) Sent: Friday, October 25, 2024 15:19 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao Subject: [PATCH] drm/amdgpu: optimize

RE: [PATCH v2 4/4] drm/amdgpu: Add supported partition mode node

2024-09-24 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kamal, Asad Sent: Tuesday, September 24, 2024 22:16 To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Ma, Le ; Zhang, Hawking ; Zhang, Morris

RE: [PATCH] amd/amdgpu: Reduce unnecessary repetitive GPU resets

2024-09-20 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chai, Thomas Sent: Friday, September 20, 2024 15:36 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang

RE: [PATCH] drm/amdgpu/mes12: set enable_level_process_quantum_check

2024-09-18 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Jack Xiao Sent: Wednesday, September 18, 2024 17:31 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Huang

RE: [PATCH] drm/amdgpu/mes12: correct kiq unmap latency

2024-11-07 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Xiao, Jack Sent: Thursday, November 7, 2024 15:39 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking Cc: Xiao, Jack Subject: [PATCH] drm

RE: [PATCH] drm/amdgpu: Simplify cleanup check for FRU sysfs

2024-11-28 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Friday, November 29, 2024 10:54 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH] drm/amdgpu

RE: [PATCH 01/21] drm/amdgpu: simplify RAS page retirement in one memory row

2024-11-19 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Tuesday, November 19, 2024 14:36 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 01/21] drm/amdg

RE: [PATCH] drm/amd/pm: Remove arcturus min power limit

2024-11-20 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, November 20, 2024 11:14 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Feng, Kenneth Subject: [PATCH

RE: [PATCH] drm/amdgpu: Prefer RAS recovery for scheduler hang

2024-11-19 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Monday, November 18, 2024 13:44 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Zhou1, Tao

RE: [PATCH] drm/amdgpu: Remove gfxoff usage

2024-11-26 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, November 27, 2024 14:14 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Khatri, Sunil Subject: [PATCH

RE: [PATCH] drm/amdgpu: return error when eeprom checksum failed

2024-12-01 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Please replace DRM_ERROR with dev_err. Other than that, the patch looks good to me. Regards, Hawking -Original Message- From: Su, Joe Sent: Monday, December 2, 2024 11:30 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking

RE: [PATCH] drm/amdgpu: return error when eeprom checksum failed

2024-12-01 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Ah, hold on please. I assume even the BADG is written to headers. There are still valid eeprom record available in the eeprom, right? Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: Monday

RE: [PATCH] drm/amdgpu: return error when eeprom checksum failed

2024-12-01 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Su, Joe Sent: Monday, December 2, 2024 13:30 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Yang, Stanley ; Su, Joe Subject: [PATCH] drm/amdgpu

RE: [PATCH 2/2] drm/amdgpu: correct the calculation of RAS bad page

2024-12-02 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Monday, December 2, 2024 18:25 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 2/2] drm/amdgpu:

RE: [PATCH 4/4] drm/amdgpu: Support nbif v6_3_1 fatal error handling

2024-12-06 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Candice Li Sent: Friday, December 6, 2024 17:05 To: amd-gfx@lists.freedesktop.org Cc: Li, Candice Subject: [PATCH 4/4] drm/amdgp

RE: [PATCH] drm/amdgpu: Fix for MEC SJT FW Load Fail on VF

2024-12-27 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Yuan Feng Sent: Friday, December 27, 2024 12:44 To: amd-gfx@lists.freedesktop.org Cc: Feng, Yuan Subject: [PATCH] drm/amdgpu: Fix for MEC S

RE: [PATCH v2 4/4] drm/amdgpu: Make VBIOS image read optional

2025-02-06 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Thursday, February 6, 2025 12:23 To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Zhang, Hawking ; Deucher

RE: [PATCH 1/4] drm/scheduler: Add drm_sched_cancel_all_jobs helper

2025-02-06 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] I agree with the overall approach and support Chris's suggestion. The function amdgpu_job_stop_all_jobs_on_sched is now only applicable to a few older AMD hardware models when they encounter uncorrectable hardware errors. We have discont

RE: [PATCH v2 1/4] drm/amdgpu: Move xgmi definitions to xgmi header

2025-02-10 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Monday, February 10, 2025 15:01 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kim, Jonathan Subject

RE: [PATCH] drm/amd/pm: Rename pmfw message SetPstatePolicy

2025-02-10 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kamal, Asad Sent: Monday, February 10, 2025 16:02 To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Ma, Le ; Zhang, Hawking ; Zhang, Morris ; Kamal, Asad

RE: [PATCH] drm/amdgpu: Enable psp v14_0_3 RAS support for non-SRIOV configurations.

2024-12-16 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Candice Li Sent: Monday, December 16, 2024 17:24 To: amd-gfx@lists.freedesktop.org Cc: Li, Candice Subject: [PATCH] drm/amdgpu: Enable psp

RE: [PATCH] drm/amdgpu: Update usage for bad page threshold

2025-01-22 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Please ignore this one. will send out a new one soon Regards, Hawking -Original Message- From: Zhang, Hawking Sent: Wednesday, January 22, 2025 18:30 To: amd-gfx@lists.freedesktop.org; Zhou1, Tao Cc: Zhang, Hawking Subject

<    5   6   7   8   9   10   11   >