[PATCH] drm/amd/display: Fix error handling on waiting for completion

2021-10-26 Thread Stylon Wang
one completion doesn't need to worry about interruption from signal. Signed-off-by: Stylon Wang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd

[PATCH 00/14] DC Patches May 10, 2021

2021-05-07 Thread Stylon Wang
This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC v3.2.135.1 * Improvements across DP, DPP, clock management, pixel formats Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.65 Anthony Wang (1): drm/amd/display: Handle potential dpp_inst mismat

[PATCH 01/14] drm/amd/display: Update DPRX detection.

2021-05-07 Thread Stylon Wang
From: Jimmy Kizito [Why] Some extra provisions are required during DPRX detection for links which lack physical HPD and AUX/DDC pins. [How] Avoid attempting to access nonexistent physical pins during DPRX detection. Signed-off-by: Jimmy Kizito Reviewed-by: Jun Lei Acked-by: Stylon Wang

[PATCH 02/14] drm/amd/display: Update setting of DP training parameters.

2021-05-07 Thread Stylon Wang
From: Jimmy Kizito [Why] Some links are dynamically assigned link encoders on stream enablement. [How] Update DisplayPort training parameter determination stage that assumes link encoder statically assigned to link. Signed-off-by: Jimmy Kizito Reviewed-by: Jun Lei Acked-by: Stylon Wang

[PATCH 03/14] drm/amd/display: Add fallback and abort paths for DP link training.

2021-05-07 Thread Stylon Wang
Lei Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 5 ++- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 40 +++ .../drm/amd/display/dc/core/dc_link_hwss.c| 3 +- .../gpu/drm/amd/display/dc/inc/dc_link_dp.h | 3 +- .../amd/display/include

[PATCH 04/14] drm/amd/display: Expand DP module training API.

2021-05-07 Thread Stylon Wang
From: Jimmy Kizito [Why & How] Add functionality useful for DP link training to public interface. Signed-off-by: Jimmy Kizito Reviewed-by: Jun Lei Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 +- drivers/gpu/drm/amd/display/dc/inc/dc_link_

[PATCH 05/14] drm/amd/display: Add dc log for DP SST DSC enable/disable

2021-05-07 Thread Stylon Wang
From: Fangzhi Zuo Signed-off-by: Fangzhi Zuo Reviewed-by: Mikita Lipski Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b

[PATCH 06/14] drm/amd/display: DETBufferSizeInKbyte variable type modifications

2021-05-07 Thread Stylon Wang
variables like DETBufferSizeY, DETBufferSizeC that are involved in DETBufferSizeInKByte calculations to unsigned int in all the display_mode_vba_xx files. Signed-off-by: Chaitanya Dhere Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../dc/dml/dcn20/display_mode_vba_20.c| 26

[PATCH 07/14] drm/amd/display: minor dp link training refactor

2021-05-07 Thread Stylon Wang
link_service_types.h Signed-off-by: Wenjing Liu Reviewed-by: George Shen Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 124 ++ drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 1 + drivers/gpu/drm/amd/display/dc/dc_link.h | 6 - .../amd/display/include

[PATCH 08/14] drm/amd/display: Fix clock table filling logic

2021-05-07 Thread Stylon Wang
per DCFCLK level instead of one entry per FCLK level. This is needed because the maximum FCLK does not necessarily need maximum voltage, whereas DCFCLK values from SMU cover the full voltage range. Signed-off-by: Ilya Bakoulin Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../amd

[PATCH 09/14] drm/amd/display: Handle pixel format test request

2021-05-07 Thread Stylon Wang
: Hanghong Ma Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index 27c5d49a7bc1

[PATCH 10/14] drm/amd/display: Handle potential dpp_inst mismatch with pipe_idx

2021-05-07 Thread Stylon Wang
the dpp_inst associated with each pipe from res_pool. Signed-off-by: Anthony Wang Reviewed-by: Yongqiang Sun Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display

[PATCH 11/14] drm/amd/display: fix use_max_lb flag for 420 pixel formats

2021-05-07 Thread Stylon Wang
From: Dmytro Laktyushkin Right now the flag simply selects memory config 0 when flag is true however 420 modes benefit more from memory config 3. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 9

[PATCH 12/14] drm/amd/display: 3.2.135

2021-05-07 Thread Stylon Wang
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index d9e1657ba6a6

[PATCH 13/14] drm/amd/display: [FW Promotion] Release 0.0.65

2021-05-07 Thread Stylon Wang
From: Anthony Koo - Implement INBOX0 messaging for HW lock Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 123 +- 1 file changed, 116 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 14/14] drm/amd/display: 3.2.135.1

2021-05-07 Thread Stylon Wang
From: Aric Cyr - adding missed FW promotion Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc

[PATCH 00/20] DC Patches May 17, 2021

2021-05-13 Thread Stylon Wang
This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC v3.2.136 * Improvements across DP, DMUB, code documentation, suspend/resume, etc -- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.66 Aric Cyr (1): drm/amd/display: 3.2.136 Bhawanpreet Lakh

[PATCH 01/20] drm/amd/display: treat memory as a single-channel for asymmetric memory V3

2021-05-13 Thread Stylon Wang
Reviewed-by: Sung Lee Acked-by: Stylon Wang --- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 48 ++- drivers/gpu/drm/amd/display/dc/dc.h | 2 + 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c b

[PATCH 02/20] drm/amd/display: Add get_current_time interface to dmub_srv

2021-05-13 Thread Stylon Wang
From: Wyatt Wood [Why] Need to get current DMUB time. [How] Add get_current_time interface to dmub_srv. Signed-off-by: Wyatt Wood Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc.c | 39 ++- .../gpu/drm/amd/display/dc/dcn21

[PATCH 03/20] drm/amd/display: Add documentation for power gate plane

2021-05-13 Thread Stylon Wang
From: Rodrigo Siqueira This commit introduces kernel documentation to some essential functions related to power gate control over planes. It also adds a macro to make one part of the code easy to understand. Signed-off-by: Rodrigo Siqueira Reviewed-by: Harry Wentland Acked-by: Stylon Wang

[PATCH 04/20] drm/amd/display: Remove legacy comments

2021-05-13 Thread Stylon Wang
Wentland Acked-by: Stylon Wang --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 160 -- 1 file changed, 160 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c index 90cd8f8529d3

[PATCH 05/20] drm/amd/display: Add kernel-doc to some hubp functions

2021-05-13 Thread Stylon Wang
From: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira Reviewed-by: Harry Wentland Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu

[PATCH 06/20] drm/amd/display: Document set RECOUT operation

2021-05-13 Thread Stylon Wang
in order to make it easy for developers to navigate this set of functions. Signed-off-by: Rodrigo Siqueira Reviewed-by: Harry Wentland Acked-by: Stylon Wang --- .../drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 49 +-- drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h | 6 +++ 2

[PATCH 07/20] drm/amd/display: Minor refactor of DP PHY test automation

2021-05-13 Thread Stylon Wang
From: George Shen [Why] Improve readability and maintainability of code. [How] Refactor test pattern size calculation out of function call parameter and store value in variable. Signed-off-by: George Shen Reviewed-by: Wenjing Liu Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core

[PATCH 08/20] drm/amd/display: Disconnect non-DP with no EDID

2021-05-13 Thread Stylon Wang
, disconnect sink on detection when no EDID is read due to timeout. Signed-off-by: Chris Park Reviewed-by: Nicholas Kazlauskas Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/amd

[PATCH 09/20] drm/amd/display: determine dp link encoding format from link settings

2021-05-13 Thread Stylon Wang
From: Wenjing Liu [how] Implement a function that determines link encoding format based on the link settings passed in. Signed-off-by: Wenjing Liu Reviewed-by: George Shen Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 7 +++ drivers/gpu/drm/amd/display/dc

[PATCH 10/20] drm/amd/display: decide link training settings based on channel coding

2021-05-13 Thread Stylon Wang
From: Wenjing Liu [how] Rename initialize_training_settings to decide_training_settings. Call get link encoding format and decide training settings based on current channel coding. Signed-off-by: Wenjing Liu Reviewed-by: George Shen Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core

[PATCH 11/20] drm/amd/display: rename perform_link_training_int function

2021-05-13 Thread Stylon Wang
erstand it. Signed-off-by: Wenjing Liu Reviewed-by: George Shen Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/displ

[PATCH 12/20] drm/amd/display: consider channel coding in configure lttpr mode

2021-05-13 Thread Stylon Wang
From: Wenjing Liu [why] Some lttpr configuration steps are exclusive to 8b/10b channel coding mode. We need to take channel conding into account. Signed-off-by: Wenjing Liu Reviewed-by: George Shen Acked-by: Stylon Wang Acked-by: Wesley Chalmers --- .../gpu/drm/amd/display/dc/core

[PATCH 13/20] drm/amd/display: Refactor suspend/resume of Secure display

2021-05-13 Thread Stylon Wang
Wayne Lin Reviewed-by: Chao-kai Wang Acked-by: Stylon Wang --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 27 .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 61 --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h | 4 -- 3 files changed, 15 insertions(+), 77 dele

[PATCH 14/20] drm/amd/display: Add Overflow check to skip MALL

2021-05-13 Thread Stylon Wang
are the stutter_period with the frame time and if we will overflow there is no point in trying to enable MALL (and see the ASSERT) so we early exist in this case Signed-off-by: Bhawanpreet Lakha Reviewed-by: Jun Lei Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c

[PATCH 15/20] drm/amd/display: Correct DPCD revision for eDP v1.4

2021-05-13 Thread Stylon Wang
From: Zhan Liu [Why] eDP version and DPCD revision are different. Per VESA spec, "The DPCD revision for eDP v1.4 is 13h". SUPPORTED_LINK_RATES is valid since eDP v1.4 (DPCD_REV_13). [How] Correct DPCD_REV for eDP v1.4. Signed-off-by: Zhan Liu Reviewed-by: Nikola Cornij Acked-by: S

[PATCH 16/20] drm/amd/display: Avoid get/put vblank when stream disabled

2021-05-13 Thread Stylon Wang
EINVAL to skip actions on vblank refcount when stream is not enabled. Signed-off-by: Wayne Lin Reviewed-by: Chao-kai Wang Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++-- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 2 +- 2 files changed, 4

[PATCH 17/20] drm/amd/display: Use the correct max downscaling value for DCN3.x family

2021-05-13 Thread Stylon Wang
igned-off-by: Nikola Cornij Reviewed-by: Charlene Liu Reviewed-by: Harry Wentland Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 7 --- drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 7 --- drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resou

[PATCH 18/20] drm/amd/display: Refactor and add visual confirm for HW Flip Queue

2021-05-13 Thread Stylon Wang
for driver flips, visual confirm needs to be updated on every frame, including fast updates. Add a new hw sequencer interface update_visual_confirm_color, and a new mpc function pointer set_bg_color. Signed-off-by: Wyatt Wood Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- .../amd/display/dc

[PATCH 19/20] drm/amd/display: [FW Promotion] Release 0.0.66

2021-05-13 Thread Stylon Wang
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd

[PATCH 20/20] drm/amd/display: 3.2.136

2021-05-13 Thread Stylon Wang
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 63b61468898f

[PATCH 00/17] DC Patches Jan 31, 2022

2022-01-28 Thread Stylon Wang
This DC patchset brings improvements in multiple areas. In summary, we have: - DC refactor and bug fixes for DP links - Bug fixes for DP2 - Fix regressions causing display not light up - Improved debug trace - Improved DP AUX transfer - Updated watermark latencies to fix underflows in some modes

[PATCH 01/17] drm/amd/display: Add link enc null ptr check for cable ID (#2597)

2022-01-28 Thread Stylon Wang
From: "Shen, George" [Why] Certain configurations will result in link encoder to not be assigned to the link at the time we apply cable ID logic. We should skip it in those cases. [How] Check if link_enc is not null before applying cable ID. Reviewed-by: Wenjing Liu Acked-by: S

[PATCH 02/17] drm/amd/display: Improve dce_aux_transfer_with_retries logging

2022-01-28 Thread Stylon Wang
From: Wyatt Wood [Why + How] Payload reply is unknown and not handled in switch statement. Reviewed-by: Anthony Koo Acked-by: Stylon Wang Signed-off-by: Wyatt Wood --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 03/17] drm/amd/display: watermark latencies is not enough on DCN31

2022-01-28 Thread Stylon Wang
From: Paul Hsieh [Why] The original latencies were causing underflow in some modes. Resolution: 2880x1620@60p when HDR enable [How] 1. Replace with the up-to-date watermark values based on new measurments 2. Correct the ddr_wm_table name to DDR5 on DCN31 Reviewed-by: Aric Cyr Acked-by: Stylon

[PATCH 04/17] drm/amd/display: add infoframe update sequence debug trace

2022-01-28 Thread Stylon Wang
From: "Leo (Hanghong) Ma" [Why] We find some of the driver sequence debug trace for infoframe update is missing so add it. [How] Add the missing sequence debug trace for infoframe update. Reviewed-by: Martin Leung Acked-by: Stylon Wang Signed-off-by: Leo (Hanghong) Ma --- drive

[PATCH 05/17] drm/amd/display: revert "Reset fifo after enable otg"

2022-01-28 Thread Stylon Wang
From: Zhan Liu [Why] This change causes regression, that prevents some systems from lighting up internal displays. [How] Revert this patch until a new solution is ready. Reviewed-by: Charlene Liu Acked-by: Stylon Wang Signed-off-by: Zhan Liu --- .../amd/display/dc/dce110

[PATCH 06/17] drm/amd/display: add setup/reset stream encoder to link_hwss

2022-01-28 Thread Stylon Wang
From: Wenjing Liu [why] Factor setup/reset stream encoder to link hwss. Acked-by: Wayne Lin Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 64 +++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 23 +-- .../drm/amd/display/dc/core/dc_link_hwss.c| 170

[PATCH 07/17] drm/amd/display: refactor destructive verify link cap sequence

2022-01-28 Thread Stylon Wang
From: Wenjing Liu [how] 1. move decide det link training link resource before each link training. 2. move disable link for handling vbios case into set all streams dpms off for link sequence. 3. extract usbc hotplug workaround into its own wa function. 4. Minor syntax changes to improve code read

[PATCH 08/17] drm/amd/display: add enable/disable dp link output to link_hwss

2022-01-28 Thread Stylon Wang
From: Wenjing Liu [why] Factor enable/disable dp link output to link hwss. Acked-by: Wayne Lin Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +- .../drm/amd/display/dc/core/dc_link_hwss.c| 256 +- .../gpu/drm/amd/display/dc/inc/link_hws

[PATCH 09/17] drm/amd/display: add set dp link test pattern to link_hwss

2022-01-28 Thread Stylon Wang
From: Wenjing Liu [why] Factor set dp link test pattern to link_hwss. Reviewed-by: Jun Lei Acked-by: Stylon Wang Signed-off-by: Wenjing Liu --- .../drm/amd/display/dc/core/dc_link_hwss.c| 46 +++ .../gpu/drm/amd/display/dc/inc/link_hwss.h| 3 ++ 2 files changed, 29

[PATCH 10/17] drm/amd/display: add set dp lane settings to link_hwss

2022-01-28 Thread Stylon Wang
From: Wenjing Liu [why] Factor set dp lane settings to link_hwss. Reviewed-by: Jun Lei Acked-by: Stylon Wang Signed-off-by: Wenjing Liu --- .../drm/amd/display/dc/core/dc_link_hwss.c| 40 ++- .../drm/amd/display/dc/dce/dce_link_encoder.c | 17 .../drm/amd

[PATCH 11/17] drm/amd/display: temporarly move non link_hwss code to dc_link_dp

2022-01-28 Thread Stylon Wang
Acked-by: Stylon Wang Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 613 .../drm/amd/display/dc/core/dc_link_hwss.c| 653 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 4 +- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c

[PATCH 12/17] drm/amd/display: move get_link_hwss to dc_resource

2022-01-28 Thread Stylon Wang
From: Wenjing Liu [why] Isolate the way to obtain link_hwss from the actual implemenation of link_hwss. So the caller can call link_hwss without knowing the implementation detail of link_hwss. Reviewed-by: Jun Lei Acked-by: Stylon Wang Signed-off-by: Wenjing Liu --- .../drm/amd/display/dc

[PATCH 13/17] drm/amd/display: move link_hwss to link folder and break down to files

2022-01-28 Thread Stylon Wang
From: Wenjing Liu [why] Move link_hwss to its own folder as part of DC LIB and break it down to separate file one for each type of backend for code isolation. Reviewed-by: Jun Lei Acked-by: Stylon Wang Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/Makefile | 4

[PATCH 14/17] drm/amd/display: [FW Promotion] Release 0.0.102.0

2022-01-28 Thread Stylon Wang
From: Anthony Koo - Correct number of reserved bits in cmd_lock_hw - Extend bits of hw_lock_client to allow for more clients Acked-by: Stylon Wang Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 8 1 file changed, 4 insertions(+), 4 deletions

[PATCH 16/17] drm/amd/display: Trigger DP2 Sequence With Uncertified Cable

2022-01-28 Thread Stylon Wang
From: Fangzhi Zuo DP2 sequence is triggered only if VESA certified cable is detected. Force DP2 sequence with uncertified cable for testing purpose. Reviewed-by: Wenjing Liu Acked-by: Stylon Wang Signed-off-by: Fangzhi Zuo --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 26

[PATCH 15/17] drm/amd/display: 3.2.171

2022-01-28 Thread Stylon Wang
From: Aric Cyr This version brings along following fixes: - DC refactor and bug fixes for DP links - Bug fixes for DP2 - Fix regressions causing display not light up - Improved debug trace - Improved DP AUX transfer - Updated watermark latencies to fix underflows in some modes Acked-by: Stylon

[PATCH 17/17] drm/amd/display: Add Missing HPO Stream Encoder Function Hook

2022-01-28 Thread Stylon Wang
s that hook, and that causes null ptr hang. Signed-off-by: Fangzhi Zuo Acked-by: Stylon Wang --- .../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c| 11 +++ .../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.h| 9 ++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff -

[PATCH 06/30] drm/amd/display: Refactor visual confirm

2021-06-07 Thread Stylon Wang
visual confirm to updated independently of MPCC blending updates. Signed-off-by: Wyatt Wood Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 98 .../display/dc/dce110/dce110_hw_sequencer.c | 35 -- .../amd/display/dc/dcn10

[PATCH 07/30] drm/amd/display: add visual confirm colors to differentiate layer_index > 0

2021-06-07 Thread Stylon Wang
-by: Aric Cyr Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c index e0badab84

[PATCH 28/30] drm/amd/display: Add swizzle visual confirm mode

2021-06-07 Thread Stylon Wang
From: Po-Ting Chen [Why] To support a new visual confirm mode: swizzle to show the specific color at the screen border according to different surface swizzle mode. Currently we only support the Linear mode with red color. Signed-off-by: Po-Ting Chen --- .../drm/amd/display/dc/core/dc_hw_sequen

[PATCH 01/30] drm/amd/display: Trigger full update after DCC on/off

2021-06-07 Thread Stylon Wang
From: Jake Wang [Why] During DCC on/off, stutter period is calculated before DCC has fully transitioned. This results in incorrect stutter period calculation. [How] Trigger a full update when DCC changes between on/off. Signed-off-by: Jake Wang Reviewed-by: Aric Cyr Acked-by: Stylon Wang

[PATCH 00/30] DC Patches June, 7, 2021

2021-06-07 Thread Stylon Wang
This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC v3.2.139 * FW v0.0.69 * Improvements across DP, eDP, DMUB, MPO, etc -- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.68 Aric Cyr (4): drm/amd/display: Change default policy for MPO with mul

[PATCH 02/30] drm/amd/display: Enabling PSR support for multiple panels

2021-06-07 Thread Stylon Wang
capable panels when enabling/disabling all Signed-off-by: Mikita Lipski Reviewed-by: Nicholas Kazlauskas Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 22 +++-- drivers/gpu/drm/amd/display/dc/core/dc.c | 11 ++- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 21

[PATCH 10/30] drm/amd/display: Support mappable encoders when transmitting training patterns.

2021-06-07 Thread Stylon Wang
From: Jimmy Kizito [Why & How] Add support for transmitting training pattern sequences for links whose encoders have been dynamically assigned. Signed-off-by: Jimmy Kizito Reviewed-by: Jun Lei Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c | 11 ++

[PATCH 04/30] drm/amd/display: Fix DCN 3.01 DSCCLK validation

2021-06-07 Thread Stylon Wang
. [how] Remove DSCCLK validation because it's implicitly validated under DISPCLK Signed-off-by: Nikola Cornij Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../dc/dml/dcn30/display_mode_vba_30.c| 64 ++- 1 file changed, 21 insertions(+), 43 deletions(-)

[PATCH 03/30] drm/amd/display: delay 100ms before restart after failing to read CP_IRQ

2021-06-07 Thread Stylon Wang
retry if within 100ms there is no disconnection call to HDCP module. Signed-off-by: Wenjing Liu Reviewed-by: Nicholas Kazlauskas Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp2_transition.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 05/30] drm/amd/display: Control power gating by driver.

2021-06-07 Thread Stylon Wang
From: "JinZe.Xu" [Why] This disablement would be specific for Nav10 and shouldn’t be propagated to the other programs. [How] Power gating is controlled by driver. Signed-off-by: JinZe.Xu Reviewed-by: Jun Lei Acked-by: Stylon Wang --- .../drm/amd/display/dc/dcn302/dcn302_hws

[PATCH 08/30] drm/amd/display: Revert "Fix clock table filling logic"

2021-06-07 Thread Stylon Wang
From: Ilya Bakoulin [Why] This change was found to break some high-refresh modes. Reverting to unblock mainline. Signed-off-by: Ilya Bakoulin Reviewed-by: Sung Lee Acked-by: Stylon Wang --- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 78 +++ .../drm/amd/display/dc/dcn21

[PATCH 12/30] drm/amd/display: Remove unused definition of DMUB SET_CONFIG

2021-06-07 Thread Stylon Wang
From: Meenakshikumar Somasundaram [Why & How] SET_CONFIG transactions with DMUB is not used and removed. Signed-off-by: Meenakshikumar Somasundaram Reviewed-by: Jun Lei Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 1 file changed, 4 deletions(-)

[PATCH 13/30] drm/amd/display: Return last used DRR VTOTAL from DC

2021-06-07 Thread Stylon Wang
From: Jayendran Ramani [How] Add call to get the last used VTOTAL from DC Signed-off-by: Jayendran Ramani Reviewed-by: Anthony Koo Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc.c | 42 +++ drivers/gpu/drm/amd/display/dc/dc_stream.h| 4 ++ .../dc

[PATCH 15/30] drm/amd/display: Release MST resources on switch from MST to SST

2021-06-07 Thread Stylon Wang
releasing MST resources. Signed-off-by: Vladimir Stempen Reviewed-by: Wenjing Liu Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc

[PATCH 14/30] drm/amd/display: Enable PSR Residency for multiple panels

2021-06-07 Thread Stylon Wang
From: Mikita Lipski [why] Allow specifying which panel to take PSR Residency measurements from. [how] Pass panel instance to DMUB through GPINT in the upper 8 bits of the parameter. Signed-off-by: Mikita Lipski Reviewed-by: Nicholas Kazlauskas Acked-by: Stylon Wang --- drivers/gpu/drm/amd

[PATCH 17/30] drm/amd/display: [FW Promotion] Release 0.0.68

2021-06-07 Thread Stylon Wang
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd

[PATCH 09/30] drm/amd/display: Expand DP module equalization API.

2021-06-07 Thread Stylon Wang
From: Jimmy Kizito [Why & How] Add functionality useful for DP equalization phase of link training to public interface. Signed-off-by: Jimmy Kizito Reviewed-by: Jun Lei Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 22 +-- .../gpu/drm/amd/dis

[PATCH 18/30] drm/amd/display: 3.2.138

2021-06-07 Thread Stylon Wang
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index c0fbcbd4cbfc

[PATCH 11/30] drm/amd/display: Update scaling settings on modeset

2021-06-07 Thread Stylon Wang
-by: Stylon Wang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 09bbec4dab7c..0b12299da93d 100644 --- a/drivers

[PATCH 16/30] drm/amd/display: Change default policy for MPO with multidisplay

2021-06-07 Thread Stylon Wang
: Krunoslav Kovac Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c | 2

[PATCH 19/30] drm/amd/display: Add Interface to set FIFO ERRDET SW Override

2021-06-07 Thread Stylon Wang
From: Wesley Chalmers [WHY] HW has handed down a new sequence which requires access to the FIFO ERRDET SW Override register. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.c | 10 +++ .../gpu/drm/amd

[PATCH 25/30] drm/amd/display: Revert "Disconnect non-DP with no EDID"

2021-06-07 Thread Stylon Wang
From: Roy Chan [Why] Found a use case (IPKVM) that DP-VGA active dongle does not return any EDID and the mentioned commit broke it. [How] This reverts "Disconnect non-DP with no EDID" Signed-off-by: Roy Chan Reviewed-by: Chris Park Acked-by: Stylon Wang --- drivers/gpu/drm/amd/

[PATCH 24/30] drm/amd/display: Add debugfs entry for dsc passthrough

2021-06-07 Thread Stylon Wang
From: Fangzhi Zuo [Why & How] Add debugfs entry to force dsc decoding at PCON when DSC capable external RX is connected. In such case, it is free to test DSC decoding at external RX or at PCON. Signed-off-by: Fangzhi Zuo Reviewed-by: Hersen Wu Acked-by: Stylon Wang --- .../gpu/drm

[PATCH 20/30] drm/amd/display: Add interface for ADD & DROP PIXEL Registers

2021-06-07 Thread Stylon Wang
From: Wesley Chalmers [WHY] HW has handed down a new sequence that requires access to these registers. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.c | 26 ++ .../gpu/drm/amd/display/dc/dcn20

[PATCH 26/30] drm/amd/display: Updates for ODM Transition Test

2021-06-07 Thread Stylon Wang
From: Eric Bernstein [Why] There is an assert in cases where transition from ODM 2:1 to ODM 1:1 (bypass) [How] Remove assert since this case is now valid. Update diags tests for ODM transitions. Signed-off-by: Eric Bernstein Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- drivers

[PATCH 22/30] drm/amd/display: Fix off-by-one error in DML

2021-06-07 Thread Stylon Wang
From: Wesley Chalmers [WHY] For DCN30 and later, there is no data in DML arrays indexed by state at index num_states. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../amd/display/dc/dml/dcn30/display_mode_vba_30.c | 14 +++--- 1 file

[PATCH 27/30] drm/amd/display: force CP to DESIRED when removing display

2021-06-07 Thread Stylon Wang
ion caused, which has now been cleared. [HOW] In hdcp display removal, change CP to DESIRED if at the moment CP is ENABLED before the auth reset and removal of linked list element. Signed-off-by: Dingchen (David) Zhang Signed-off-by: Qingqing Zhuo Reviewed-by: Rodrigo Siqueira Acked-by: S

[PATCH 23/30] drm/amd/display: Fix crash during MPO + ODM combine mode recalculation

2021-06-07 Thread Stylon Wang
ff-by: Aric Cyr Reviewed-by: Krunoslav Kovac Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c index cd864cc

[PATCH 21/30] drm/amd/display: Set DISPCLK_MAX_ERRDET_CYCLES to 7

2021-06-07 Thread Stylon Wang
From: Wesley Chalmers [WHY] DISPCLK_MAX_ERRDET_CYCLES must be 7 to prevent connection loss when changing DENTIST_DISPCLK_WDIVIDER from 126 to 127 and back. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dcn20

[PATCH 29/30] drm/amd/display: [FW Promotion] Release 0.0.69

2021-06-07 Thread Stylon Wang
From: Wyatt Wood Signed-off-by: Wyatt Wood Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display

[PATCH 30/30] drm/amd/display: 3.2.139

2021-06-07 Thread Stylon Wang
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index b4104b7422d8

[PATCH 1/2] drm/amd/display: Revert "Re-enable 'Guard ASSR with internal display flag'"

2021-07-20 Thread Stylon Wang
[Why] A new change that simplifies the ASSR enabling and guarding is found that also fixes regression on some embedded panels. [How] Revert the ASSR changes in preparation for upcoming patch. Signed-off-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 54

[PATCH 0/2] Fix regression on embedded panels caused by enabling ASSR

2021-07-20 Thread Stylon Wang
Previous ASSR-enabling patches cause blank screen on some embedded panels. This patch set minimize the changes made to code logic prior to the ASSR change and also improve on code readability. Stylon Wang (2): drm/amd/display: Revert "Re-enable 'Guard ASSR with internal display fl

[PATCH 2/2] drm/amd/display: Fix ASSR regression on embedded panels

2021-07-20 Thread Stylon Wang
display flag Signed-off-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index cc62124b0b82

[PATCH v2 1/2] drm/amd/display: Revert "Re-enable 'Guard ASSR with internal display flag'"

2021-07-21 Thread Stylon Wang
[Why] A new change that simplifies the ASSR enabling and guarding is found that also fixes regression on some embedded panels. [How] Revert the ASSR changes in preparation for upcoming patch. Reviewed-by: Alex Deucher Signed-off-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c

[PATCH v2 2/2] drm/amd/display: Fix ASSR regression on embedded panels

2021-07-21 Thread Stylon Wang
display flag Bug: https://bugzilla.kernel.org/show_bug.cgi?id=213779 Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1620 Reviewed-by: Alex Deucher Signed-off-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions

[PATCH v2 0/2] Fix regression on embedded panels caused by enabling ASSR

2021-07-21 Thread Stylon Wang
Previous ASSR-enabling patches cause blank screen on some embedded panels. This patch set minimize the changes made to code logic prior to the ASSR change and also improve on code readability. Changes from prior rev1 to now: v2: - Update reviewed-by and bug links Stylon Wang (2): drm/amd

[PATCH] drm/amd/display: Enable ASSR in Linux DM

2021-02-23 Thread Stylon Wang
ASSR implementation was already in DC and DM guarded by CONFIG_DRM_AMD_DC_HDCP. This patch enables ASSR if display declares such support in DPCD. Signed-off-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 16 1 file changed, 16 insertions(+) diff --git a

[PATCH] drm/amd/display: Fix memory leaks in S3 resume

2020-11-09 Thread Stylon Wang
EDID parsing in S3 resume pushes new display modes to probed_modes list but doesn't consolidate to actual mode list. This creates a race condition when amdgpu_dm_connector_ddc_get_modes() re-initializes the list head without walking the list and results in memory leak. Signed-off-by: Stylon

[PATCH 00/28] DC Patches Sep 8, 2023

2023-09-06 Thread Stylon Wang
This DC patchset brings improvements in multiple areas. In summary, we have: - Fix MST bugs - Fix ODM combine debugfs - Fix DML calculations - Fix 2nd DPIA encoder issue - Fix AUX-based backlight control - Fix on MPO+ODM use case - Fix DCCG clock programming - Improvements on replay - Improvements

[PATCH 01/28] drm/amd/display: Blank phantom OTG before enabling

2023-09-06 Thread Stylon Wang
From: Alvin Lee [Description] Before enabling the phantom OTG for an update we must enable DPG to avoid underflow. Reviewed-by: Samson Tam Acked-by: Stylon Wang Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/core/dc.c | 50 +-- .../drm/amd/display/dc/dcn20

[PATCH 02/28] drm/amd/display: Don't lock phantom pipe on disabling

2023-09-06 Thread Stylon Wang
underflow due to phantom HUBP being blanked by default) Reviewed-by: Samson Tam Acked-by: Stylon Wang Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10

[PATCH 03/28] drm/amd/display: set default return value for ODM Combine debugfs

2023-09-06 Thread Stylon Wang
From: Aurabindo Pillai [Why&How] Set a default return value of -ENOTSUPP to indicate that the hardware does not support querying ODM Combine mode. Reviewed-by: Rodrigo Siqueira Acked-by: Stylon Wang Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/amdgp

[PATCH 04/28] drm/amd/display: Add dirty rect support for Replay

2023-09-06 Thread Stylon Wang
From: Bhawanpreet Lakha Dirty rect can be used with replay, so enable them to allow for more powersaving. Reviewed-by: Sun peng Li Acked-by: Stylon Wang Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 05/28] drm/amd/display: Don't check registers, if using AUX BL control

2023-09-06 Thread Stylon Wang
[How] Only check DCN registers if we aren't using AUX based brightness control. Reviewed-by: Wenjing Liu Acked-by: Stylon Wang Signed-off-by: Swapnil Patel --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/

  1   2   3   >