[PATCH v11 00/28] AMDGPU usermode queues

2024-09-09 Thread Shashank Sharma
t;drm/amdgpu: don't allow userspace to create a doorbell BO" Shashank Sharma (18): drm/amdgpu: add usermode queue base code drm/amdgpu: add new IOCTL for usermode queue drm/amdgpu: add helpers to create userqueue object drm/amdgpu: create MES-V11 usermode queue for GFX drm/amdgpu:

[PATCH v11 01/28] drm/amdgpu: UAPI for user queue management

2024-09-09 Thread Shashank Sharma
f-by: Alex Deucher Signed-off-by: Shashank Sharma --- include/uapi/drm/amdgpu_drm.h | 90 +++ 1 file changed, 90 insertions(+) diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index 3e488b0119eb..bd8d47a3 100644 --- a/include/uapi/drm/am

[PATCH v11 02/28] drm/amdgpu: add usermode queue base code

2024-09-09 Thread Shashank Sharma
lex Deucher Cc: Christian Koenig Reviewed-by: Christian König Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma Change-Id: I6585d012a7ead1105bf43a7b91f361d7dd20a9a9 --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 + drivers/gpu

[PATCH v11 03/28] drm/amdgpu: add new IOCTL for usermode queue

2024-09-09 Thread Shashank Sharma
ucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 120 ++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 2 + 3 files changed, 123 insertions(+) diff --git a/drivers/gpu/drm/amd/a

[PATCH v11 04/28] drm/amdgpu: add helpers to create userqueue object

2024-09-09 Thread Shashank Sharma
B Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 62 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 13 2 files changed, 75 insertions(+) diff --git a/drivers/gpu/dr

[PATCH v11 06/28] drm/amdgpu: create context space for usermode queue

2024-09-09 Thread Shashank Sharma
GFX specific patch (Alex) Cc: Alex Deucher Cc: Christian Koenig Acked-by: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 33 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 2 files

[PATCH v11 05/28] drm/amdgpu: create MES-V11 usermode queue for GFX

2024-09-09 Thread Shashank Sharma
Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Change-Id: I855f895a4822ef015957542bc17eabb166b792e6 --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 98 +++ .../gpu/drm/amd/amdgpu/mes_v11_

[PATCH v11 07/28] drm/amdgpu: map usermode queue into MES

2024-09-09 Thread Shashank Sharma
queue->proc/gang/fw_ctx_address variables and doing the address calculations locally to keep the queue structure GEN independent (Alex) V7: Added R-B from Alex V8: Rebase V9: Rebase V10: Rebase Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Alex Deucher Signed-off-by: Shash

[PATCH v11 09/28] drm/amdgpu: generate doorbell index for userqueue

2024-09-09 Thread Shashank Sharma
* V10: Rebase Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 59 +++ .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 1 + .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 3

[PATCH v11 08/28] drm/amdgpu: map wptr BO into GART

2024-09-09 Thread Shashank Sharma
v11* to mes_v11* V10: Remove unused adev (Harish) Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 76 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 2 files changed,

[PATCH v11 10/28] drm/amdgpu: cleanup leftover queues

2024-09-09 Thread Shashank Sharma
: Bas Nieuwenhuizen Signed-off-by: Bas Nieuwenhuizen Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 27 ++- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/drm/amd/a

[PATCH v11 13/28] drm/amdgpu: enable compute/gfx usermode queue

2024-09-09 Thread Shashank Sharma
drm_amdgpu_userq_mqd_compute_gfx11 (Marek) Cc: Alex Deucher Cc: Christian Koenig Acked-by: Christian König Signed-off-by: Arvind Yadav Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 4 +++- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 2 ++ .../gpu/drm/amd/amdgpu

[PATCH v11 11/28] drm/amdgpu: enable GFX-V11 userqueue support

2024-09-09 Thread Shashank Sharma
review comments: - update the comments in GFX mqd structure informing user about using the INFO IOCTL for object sizes (Alex) - rename struct drm_amdgpu_userq_mqd_gfx_v11 to drm_amdgpu_userq_mqd_gfx11 (Marek) Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma

[PATCH v11 14/28] drm/amdgpu: update userqueue BOs and PDs

2024-09-09 Thread Shashank Sharma
syncobj_handle -> timeline_syncobj_out Rename point -> timeline_point_in (Marek) Cc: Alex Deucher Cc: Christian Koenig Cc: Felix Kuehling Signed-off-by: Arvind Yadav Signed-off-by: Shashank Sharma Change-Id: I0942942641e095408a95d4ab6e2e9d813f0f78db --- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH v11 12/28] drm/amdgpu: enable SDMA usermode queues

2024-09-09 Thread Shashank Sharma
drm_amdgpu_userq_mqd_sdma_gfx11 (Marek) Cc: Christian König Cc: Alex Deucher Reviewed-by: Christian König Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Signed-off-by: Srinivasan Shanmugam Change-Id: I782acfc08fef0fa5302e665173788fc03dbc51e1 --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c

[PATCH v11 15/28] drm/amdgpu: add kernel config for gfx-userqueue

2024-09-09 Thread Shashank Sharma
instead of CONFIG_DRM_AMDGPU_USERQ_GFX (Christian) V11: Add GFX in the config help description message. Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Christian König Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Change-Id: I509a1fc9eb9ae1a1e042ae4456737333a606 --- drivers/gpu/drm/

[PATCH v11 21/28] drm/amdgpu: add gfx eviction fence helpers

2024-09-09 Thread Shashank Sharma
Christian: - create a separate ev_fence_mgr structure - cleanup fence init part - do not add a domain for fence owner KGD Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Change-Id: I7a8d27d7172bafbfe34aa9decf2cd36655948275 --- drivers/gpu

[PATCH v11 23/28] drm/amdgpu: suspend gfx userqueues

2024-09-09 Thread Shashank Sharma
oy, dont signal it - Wait for eviction fence to get signaled in replace fence, dont signal it Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Change-Id: Ib60a7feda5544e3badc87bd1a991931ee726ee82 --- .../drm/amd/amdgpu/amdgpu_evictio

[PATCH v11 25/28] drm/amdgpu: Add input fence to sync bo unmap

2024-09-09 Thread Shashank Sharma
: Arvind Yadav Signed-off-by: Shashank Sharma Change-Id: Ib1572da97b640d80e39d73c9c166fa1759d720b5 --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 41 + include/uapi/drm/amdgpu_drm.h | 4 +++ 2 files changed, 45 insertions(+) diff --git a/drivers/gpu/drm/amd

[PATCH v11 26/28] drm/amdgpu: fix MES GFX mask

2024-09-09 Thread Shashank Sharma
different. Cc: Christian König Cc: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Change-Id: I86f5b89c5527c23df94edc707c69c78819f4c8cf --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 2 +- drivers/gpu/drm/amd/amdgpu

[PATCH v11 27/28] Revert "drm/amdgpu/gfx11: only enable CP GFX shadowing on SR-IOV"

2024-09-09 Thread Shashank Sharma
From: Shashank Sharma This reverts commit 81af32520e7aaa337fe132f16c12ce54170187ea. This commit prevents a usermode queue client to get the shadow related information. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v11 24/28] drm/amdgpu: resume gfx userqueues

2024-09-09 Thread Shashank Sharma
_lock failures - no need to reserve bos after drm_exec_locked - schedule the resume worker immediately (not after 100 ms) - check for NULL BO (Arvind) Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/a

[PATCH v11 28/28] Revert "drm/amdgpu: don't allow userspace to create a doorbell BO"

2024-09-09 Thread Shashank Sharma
From: Arvind Yadav This reverts commit 6be2ad4f0073c541146caa66c5ae936c955a8224. --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c index 7823faa3dbaa..2e3c974a3340

[PATCH v11 22/28] drm/amdgpu: add userqueue suspend/resume functions

2024-09-09 Thread Shashank Sharma
igned-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 33 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 5 +++ 2 files changed, 38 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c b/drivers/gp

[PATCH v2 1/3] drm/amdgpu: replace TLB seq callback with HW seq

2024-01-31 Thread Shashank Sharma
From: Christian König The callback we installed for the SDMA update were actually pretty horrible. since we now have seq64 use that one and HW seq writes instead. V2:(Shashank) - rebased on amd-drm-staging-next - changed amdgpu_seq64_gpu_addr Cc: Christian König Cc: Alex Deucher Cc: Felix K

[PATCH v2 3/3] drm/amdgpu: sync page table freeing with tlb flush

2024-01-31 Thread Shashank Sharma
page table objects until we have the respective TLB entries flushed. V2: rebase Cc: Christian König Cc: Alex Deucher Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h

[PATCH v2 2/3] drm/amdgpu: implement TLB flush fence

2024-01-31 Thread Shashank Sharma
lex Deucher Signed-off-by: Christian König Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 10 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h| 4 + .../gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c |

[PATCH v3] drm/amdgpu: change vm->task_info handling

2024-02-05 Thread Shashank Sharma
Cc: Alex Deucher Cc: Felix Kuehling Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 9 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 18 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 12 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH v3 2/3] drm/amdgpu: implement TLB flush fence

2024-02-23 Thread Shashank Sharma
lex Deucher Signed-off-by: Christian König Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 10 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h| 4 + .../gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c |

[PATCH v3 1/3] drm/amdgpu: replace TLB seq callback with HW seq

2024-02-23 Thread Shashank Sharma
From: Christian König The callback we installed for the SDMA update were actually pretty horrible. since we now have seq64 use that one and HW seq writes instead. V2:(Shashank) - rebased on amd-drm-staging-next - changed amdgpu_seq64_gpu_addr Cc: Christian König Cc: Alex Deucher Cc: Felix K

[PATCH v3 3/3] drm/amdgpu: sync page table freeing with tlb flush

2024-02-23 Thread Shashank Sharma
ian) Cc: Christian König Cc: Alex Deucher Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 6 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h| 6 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 51 ---

[PATCH v4 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-01 Thread Shashank Sharma
entries in TLB flush waitlist. - do not create a separate function for list flush. - do not create a new lock for TLB flush. - there is no need to wait on tlb_flush_fence exclusively. Cc: Christian König Cc: Alex Deucher Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Signed-off-by: Shash

[PATCH v4 1/2] drm/amdgpu: implement TLB flush fence

2024-03-01 Thread Shashank Sharma
istian) - move the misplaced fence_create call to the end (Philip) Cc: Christian Koenig Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Cc: Alex Deucher Signed-off-by: Christian König Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/

[PATCH v5 1/2] drm/amdgpu: implement TLB flush fence

2024-03-06 Thread Shashank Sharma
istian) - move the misplaced fence_create call to the end (Philip) V5: - free the f->dependency properly (Christian) Cc: Christian Koenig Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Cc: Alex Deucher Reviewed-by: Shashank Sharma Signed-off-by: Christian König Signed-off-by: Shashank Sharma --- dr

[PATCH v5 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-06 Thread Shashank Sharma
endently - call amdgpu_vm_pt_free_list directly Cc: Christian König Cc: Alex Deucher Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 4 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h| 7 +++ drivers/gpu/drm/am

[PATCH] drm/amdgpu: cleanup unused variable

2024-03-12 Thread Shashank Sharma
This patch removes an unused input variable in the MES doorbell function. Cc: Christian König Cc: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v6 1/2] drm/amdgpu: implement TLB flush fence

2024-03-15 Thread Shashank Sharma
dwaj Tested-by: Rajneesh Bhardwaj Reviewed-by: Shashank Sharma Signed-off-by: Christian König Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 77 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h| 2

[PATCH v6 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-15 Thread Shashank Sharma
endently - call amdgpu_vm_pt_free_list directly V6: Rebase Cc: Christian König Cc: Alex Deucher Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Acked-by: Felix Kuehling Acked-by: Rajneesh Bhardwaj Tested-by: Rajneesh Bhardwaj Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amd

[PATCH v7 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-18 Thread Shashank Sharma
endently - call amdgpu_vm_pt_free_list directly V6: Rebase V7: Rebase Cc: Christian König Cc: Alex Deucher Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Acked-by: Felix Kuehling Acked-by: Rajneesh Bhardwaj Tested-by: Rajneesh Bhardwaj Signed-off-by: Shashank Sharma --- drivers/gpu/drm/am

[PATCH v7 1/2] drm/amdgpu: implement TLB flush fence

2024-03-18 Thread Shashank Sharma
ed-by: Felix Kuehling Acked-by: Rajneesh Bhardwaj Tested-by: Rajneesh Bhardwaj Reviewed-by: Shashank Sharma Signed-off-by: Christian Koenig Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 68 +++-

[PATCH v8] drm/amdgpu: sync page table freeing with tlb flush

2024-03-18 Thread Shashank Sharma
neesh Bhardwaj Acked-by: Felix Kuehling Acked-by: Rajneesh Bhardwaj Tested-by: Rajneesh Bhardwaj Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h| 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 58 +-

[PATCH v9 1/2] drm/amdgpu: implement TLB flush fence

2024-03-18 Thread Shashank Sharma
ave callback memory allocated Cc: Christian Koenig Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Cc: Alex Deucher Acked-by: Felix Kuehling Acked-by: Rajneesh Bhardwaj Tested-by: Rajneesh Bhardwaj Reviewed-by: Shashank Sharma Signed-off-by: Christian Koenig Signed-off-by: Shashank Sharma --- dri

[PATCH v9 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-18 Thread Shashank Sharma
qd for root PT freeing - Free PT list regardless of needs_flush - Move adding BOs in list in a separate function Cc: Christian König Cc: Alex Deucher Cc: Felix Kuehling Cc: Rajneesh Bhardwaj Acked-by: Felix Kuehling Acked-by: Rajneesh Bhardwaj Tested-by: Rajneesh Bhardwaj Signed-off-by: S

[PATCH] drm/amdgpu: Add a NULL check for freeing root PT

2024-03-21 Thread Shashank Sharma
off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c index d904fc96ba0f..a0a5b955a4b4 100644 --- a/drivers/gpu/drm/amd/

[PATCH] drm/amdgpu: fix the list movement

2024-03-22 Thread Shashank Sharma
This patch adds a fix for list object movement, which was introduced in the TLB flush series. Fixes: 0a29a49f3ed4 ("drm/amdgpu: sync page table freeing with tlb flush") Cc: Christian König Suggested-by: Christian König Signed-off-by: Shashank Sharma --- drivers/gpu/drm/

[PATCH] drm/amdgpu: fix MES HQD masks

2024-04-05 Thread Shashank Sharma
This patch fixes the existing HQD masks prepared during the MES initialization. These existing masks values were causing problems when we try to enable GFX oversubscription. Cc: Christian König Cc: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm

[PATCH] drm/amdgpu: fix MES GFX mask

2024-04-23 Thread Shashank Sharma
: Christian König Cc: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 1 - drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 9 +++-- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 9

[PATCH v9 00/14] AMDGPU usermode queues

2024-04-26 Thread Shashank Sharma
and a sample DRM test program can be found in the MESA merge request here: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/287 Alex Deucher (1): drm/amdgpu: UAPI for user queue management Arvind Yadav (1): drm/amdgpu: enable compute/gfx usermode queue Shashank Sharma (12): drm/amdgpu

[PATCH v9 02/14] drm/amdgpu: add usermode queue base code

2024-04-26 Thread Shashank Sharma
tian König Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_u

[PATCH v9 01/14] drm/amdgpu: UAPI for user queue management

2024-04-26 Thread Shashank Sharma
_userq_mqd as its being used for SDMA and compute queues as well Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma --- include/uapi/drm/amdgpu_drm.h | 110 ++ 1 file changed, 110

[PATCH v9 06/14] drm/amdgpu: create context space for usermode queue

2024-04-26 Thread Shashank Sharma
create/destroy userqueue objects. - Removed FW object space allocation. V8: - Updating FW object address from user values. V9: - uppdated function name from gfx_v11_* to mes_v11_* Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav

[PATCH v9 04/14] drm/amdgpu: add helpers to create userqueue object

2024-04-26 Thread Shashank Sharma
: Christian Koenig Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 62 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 13 2 files changed, 75 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/drm/amd/amdgpu

[PATCH v9 05/14] drm/amdgpu: create MES-V11 usermode queue for GFX

2024-04-26 Thread Shashank Sharma
used for SDMA userqueues as well (Shashank, Alex) Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 4 + .../gpu/drm/amd/amdgpu/mes_v11_0_userq

[PATCH v9 03/14] drm/amdgpu: add new IOCTL for usermode queue

2024-04-26 Thread Shashank Sharma
Yifan) V9: - Rebase Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 121 ++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 2 + 3 files changed

[PATCH v9 08/14] drm/amdgpu: map wptr BO into GART

2024-04-26 Thread Shashank Sharma
v11* to mes_v11* Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 77 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 2 files changed, 78 insertions(+) diff --git a/driv

[PATCH v9 09/14] drm/amdgpu: generate doorbell index for userqueue

2024-04-26 Thread Shashank Sharma
Alex Deucher Cc: Christian Koenig Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 59 +++ .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 1 + .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 3 files change

[PATCH v9 07/14] drm/amdgpu: map usermode queue into MES

2024-04-26 Thread Shashank Sharma
->proc/gang/fw_ctx_address variables and doing the address calculations locally to keep the queue structure GEN independent (Alex) V7: Added R-B from Alex V8: Rebase V9: Rebase Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma --- .../gpu/

[PATCH v9 11/14] drm/amdgpu: fix MES GFX mask

2024-04-26 Thread Shashank Sharma
: introduce this patch in the series Cc: Christian König Cc: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 1 - drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 9 +++-- drivers/gpu

[PATCH v9 14/14] drm/amdgpu: add kernel config for gfx-userqueue

2024-04-26 Thread Shashank Sharma
This patch: - adds a kernel config option "CONFIG_DRM_AMD_USERQ_GFX" - moves the usequeue initialization code for all IPs under this flag so that the userqueue works only when the config is enabled. Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma --- drive

[PATCH v9 10/14] drm/amdgpu: cleanup leftover queues

2024-04-26 Thread Shashank Sharma
igned-off-by: Bas Nieuwenhuizen Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 27 ++- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c

[PATCH v9 12/14] drm/amdgpu: enable SDMA usermode queues

2024-04-26 Thread Shashank Sharma
This patch does necessary modifications to enable the SDMA usermode queues using the existing userqueue infrastructure. V9: introduced this patch in the series Cc: Christian König Cc: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav Signed-off-by: Srinivasan Shanmugam

[PATCH v9 13/14] drm/amdgpu: enable compute/gfx usermode queue

2024-04-26 Thread Shashank Sharma
From: Arvind Yadav This patch does the necessary changes required to enable compute workload support using the existing usermode queues infrastructure. Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Arvind Yadav Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: fix doorbell regression

2024-04-29 Thread Shashank Sharma
This patch adds a missed handling of PL domain doorbell while handling VRAM faults. Fixes: a6ff969fe9cb ("drm/amdgpu: fix visible VRAM handling during faults") Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/

[PATCH] drm/amdgpu: add gfx eviction fence helpers

2024-04-30 Thread Shashank Sharma
Koenig Cc: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 15 +++ .../drm/amd/amdgpu/amdgpu_eviction_fence.c| 96 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 10

[PATCH v10 00/14] AMDGPU usermode queues

2024-05-02 Thread Shashank Sharma
Shashank Sharma (13): drm/amdgpu: add usermode queue base code drm/amdgpu: add new IOCTL for usermode queue drm/amdgpu: add helpers to create userqueue object drm/amdgpu: create MES-V11 usermode queue for GFX drm/amdgpu: create context space for usermode queue drm/amdgpu: map usermode

[PATCH v10 01/14] drm/amdgpu: UAPI for user queue management

2024-05-02 Thread Shashank Sharma
f-by: Alex Deucher Signed-off-by: Shashank Sharma --- include/uapi/drm/amdgpu_drm.h | 90 +++ 1 file changed, 90 insertions(+) diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index 5b6c0055cfcf..f7313e576f06 100644 --- a/include/uapi/drm/am

[PATCH v10 02/14] drm/amdgpu: add usermode queue base code

2024-05-02 Thread Shashank Sharma
lex Deucher Cc: Christian Koenig Reviewed-by: Christian König Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu

[PATCH v10 03/14] drm/amdgpu: add new IOCTL for usermode queue

2024-05-02 Thread Shashank Sharma
Yifan) V9: - Rebase V10: Addressed review comments from Christian, and added R-B: - Do not initialize the local variable - Convert DRM_ERROR to DEBUG. Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Christian Koenig Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH v10 06/14] drm/amdgpu: create context space for usermode queue

2024-05-02 Thread Shashank Sharma
GFX specific patch (Alex) Cc: Alex Deucher Cc: Christian Koenig Acked-by: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 33 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 2 files

[PATCH v10 04/14] drm/amdgpu: add helpers to create userqueue object

2024-05-02 Thread Shashank Sharma
B Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 62 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 13 2 files changed, 75 insertions(+) diff --git a/drivers/gpu/dr

[PATCH v10 05/14] drm/amdgpu: create MES-V11 usermode queue for GFX

2024-05-02 Thread Shashank Sharma
Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/Makefile | 1 + .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 117 ++ .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.h | 30 + 3 files changed, 1

[PATCH v10 07/14] drm/amdgpu: map usermode queue into MES

2024-05-02 Thread Shashank Sharma
queue->proc/gang/fw_ctx_address variables and doing the address calculations locally to keep the queue structure GEN independent (Alex) V7: Added R-B from Alex V8: Rebase V9: Rebase V10: Rebase Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Alex Deucher Signed-off-by: Shash

[PATCH v10 08/14] drm/amdgpu: map wptr BO into GART

2024-05-02 Thread Shashank Sharma
v11* to mes_v11* V10: Remove unused adev (Harish) Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 76 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 2 files changed,

[PATCH v10 10/14] drm/amdgpu: cleanup leftover queues

2024-05-02 Thread Shashank Sharma
: Bas Nieuwenhuizen Signed-off-by: Bas Nieuwenhuizen Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 27 ++- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/drm/amd/a

[PATCH v10 09/14] drm/amdgpu: generate doorbell index for userqueue

2024-05-02 Thread Shashank Sharma
* V10: Rebase Cc: Alex Deucher Cc: Christian Koenig Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 59 +++ .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 1 + .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 3

[PATCH v10 11/14] drm/amdgpu: enable GFX-V11 userqueue support

2024-05-02 Thread Shashank Sharma
Cc: Christian Koenig Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 3 +++ .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 22 +++ include/uapi/drm/amdgpu_drm.h | 22 +++ 3 files

[PATCH v10 12/14] drm/amdgpu: enable SDMA-V6 usermode queues

2024-05-02 Thread Shashank Sharma
This patch does necessary modifications to enable the SDMA-v6 usermode queues using the existing userqueue infrastructure. V9: introduced this patch in the series V10: use header file instead of extern (Alex) Cc: Christian König Cc: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by

[PATCH v10 13/14] drm/amdgpu: enable compute/gfx usermode queue

2024-05-02 Thread Shashank Sharma
-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c| 3 ++- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 15 +++ include/uapi/drm/amdgpu_drm.h| 10 ++ 4 files changed, 29

[PATCH v10 14/14] drm/amdgpu: add kernel config for gfx-userqueue

2024-05-02 Thread Shashank Sharma
instead of CONFIG_DRM_AMDGPU_USERQ_GFX (Christian) Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Kconfig | 8 drivers/gpu/drm/amd/amdgpu/Makefile| 4 +++- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 4 drivers/gpu/drm/amd/amdgpu/s

[PATCH 0/4] AMDGPU userqueue suspend/resume

2024-05-08 Thread Shashank Sharma
/113675/ Shashank Sharma (4): drm/amdgpu: add gfx eviction fence helpers drm/amdgpu: add core userqueue suspend/resume functions drm/amdgpu: suspend gfx userqueues drm/amdgpu: add userqueue resume drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h

[PATCH 2/4] drm/amdgpu: add core userqueue suspend/resume functions

2024-05-08 Thread Shashank Sharma
This patch adds userqueue suspend/resume functions at core MES V11 IP level. Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma --- .../gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 31 +++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 5 +++ 2 files changed

[PATCH 3/4] drm/amdgpu: suspend gfx userqueues

2024-05-08 Thread Shashank Sharma
manager and signals the eviction fence, - adds reference of userq manager in the eviction fence container so that it can be used in the suspend function. Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + .../drm/amd

[PATCH 4/4] drm/amdgpu: add userqueue resume

2024-05-08 Thread Shashank Sharma
of userq manager. Cc: Alex Deucher Cc: Christian Koenig Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 166 ++ .../gpu/drm/amd/include/amdgpu_userqueue.h| 1 + 2 files changed, 167 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 1/4] drm/amdgpu: add gfx eviction fence helpers

2024-05-08 Thread Shashank Sharma
: Christian Koenig Cc: Alex Deucher Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 20 .../drm/amd/amdgpu/amdgpu_eviction_fence.c| 106 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

[PATCH] drm/amdgpu: change vm->task_info handling

2024-01-02 Thread Shashank Sharma
gt;task_info. Cc: Christian Koenig Cc: Alex Deucher Cc: Felix Kuehling Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 15 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 17 ++- drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu: change vm->task_info handling

2024-01-03 Thread Shashank Sharma
Hey Felix, On 02/01/2024 19:02, Felix Kuehling wrote: On 2024-01-02 06:12, Shashank Sharma wrote: drm/amdgpu: change vm->task_info handling This patch changes the handling and lifecycle of vm->task_info object. The major changes are: - vm->task_info is a dynamically allocated ptr

[PATCH v2] drm/amdgpu: change vm->task_info handling

2024-01-18 Thread Shashank Sharma
ints when task_info not found (Felix) Cc: Christian Koenig Cc: Alex Deucher Cc: Felix Kuehling Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 18 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 12 +- driver

Re: [PATCH v2] drm/amdgpu: change vm->task_info handling

2024-01-24 Thread Shashank Sharma
On 19/01/2024 21:23, Felix Kuehling wrote: On 2024-01-18 14:21, Shashank Sharma wrote: This patch changes the handling and lifecycle of vm->task_info object. The major changes are: - vm->task_info is a dynamically allocated ptr now, and its uasge is    reference counted. - introduci

[PATCH v3] drm/amdgpu/OLAND: clip the ref divider max value

2021-08-20 Thread Shashank Sharma
other cards. - Changed unsigned -> unsigned int to make checkpatch quiet. V3: Apply the change on SI family (not only oland) (Christian) Cc: Alex Deucher Cc: Christian König Cc: Eddy Qin Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c| 20 +---

[PATCH] drm/amdgpu/dm: Fix NULL pointer crash during DP MST hotplug

2021-04-15 Thread Shashank Sharma
This patch checks the return value of the function dc_link_add_remote_sink before using it. This was causing a crash during consecutive hotplugs of DP MST displays. Cc: Harry Wentland Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 5 + 1

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-04-28 Thread Shashank Sharma
Hello Harry, Many of us in the mail chain have discussed this before, on what is the right way to blend and tone map a SDR and a HDR buffer from same/different color spaces, and what kind of DRM plane properties will be needed. As you can see from the previous comments, that the majority of the

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-04-30 Thread Shashank Sharma
Hello Pekka, On 30/04/21 15:13, Pekka Paalanen wrote: > On Wed, 28 Apr 2021 13:24:27 +0530 > Shashank Sharma wrote: > >> Assuming these details, A compositor will look for DRM color properties like >> these: >> >> 1. Degamma plane property : To make buffers

[PATCH] drm/amdgpu/display: DP MST hot-unplug cleanup

2021-04-30 Thread Shashank Sharma
nplug situation. Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Shashank Sharma --- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 30 ++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/dr

[PATCH v2] drm/amdgpu/display: DP MST hot-unplug cleanup

2021-04-30 Thread Shashank Sharma
nplug situation. V2: Removed one extra line added in V1 Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Shashank Sharma --- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 30 ++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdg

[PATCH v3] drm/amdgpu: add new trace event for page table update v3

2020-08-11 Thread Shashank Sharma
-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 38 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 9 -- 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu

Re: [PATCH v3] drm/amdgpu: add new trace event for page table update v3

2020-08-12 Thread Shashank Sharma
Hello Christian, On 12/08/20 12:15 pm, Christian König wrote: > Am 12.08.20 um 06:33 schrieb Shashank Sharma: >> This patch adds a new trace event to track the PTE update >> events. This specific event will provide information like: >> - start and end of virtual memory m

Re: [PATCH v3] drm/amdgpu: add new trace event for page table update v3

2020-08-12 Thread Shashank Sharma
On 12/08/20 2:02 pm, Christian König wrote: > Am 12.08.20 um 10:15 schrieb Shashank Sharma: >> Hello Christian, >> >> On 12/08/20 12:15 pm, Christian König wrote: >>> Am 12.08.20 um 06:33 schrieb Shashank Sharma: >>>> This patch adds a new trace event

[PATCH v4] drm/amdgpu: add new trace event for page table update v3

2020-08-12 Thread Shashank Sharma
use incr instead of page_sz to be accurate Cc: Christian König Cc: Alex Deucher Signed-off-by: Christian König Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 37 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c| 9 -- 2 files change

Re: [PATCH v4] drm/amdgpu: add new trace event for page table update v3

2020-08-19 Thread Shashank Sharma
On 13/08/20 1:28 pm, Christian König wrote: > Am 13.08.20 um 05:04 schrieb Shashank Sharma: >> This patch adds a new trace event to track the PTE update >> events. This specific event will provide information like: >> - start and end of virtual memory mapping >> -

Re: [PATCH v4] drm/amdgpu: add new trace event for page table update v3

2020-08-19 Thread Shashank Sharma
On 19/08/20 5:38 pm, Christian König wrote: > Am 19.08.20 um 13:52 schrieb Shashank Sharma: >> On 13/08/20 1:28 pm, Christian König wrote: >>> Am 13.08.20 um 05:04 schrieb Shashank Sharma: >>>> This patch adds a new trace event to track the PTE update >>>>

  1   2   3   4   5   >