partitions through the sysfs interface.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
Suggested-by: Alex Deucher
---
v2:
- Incorporated feedbacks for function descriptions (Alex)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 45 +
1 file c
Added debug logging to provide insights into KGD/KFD scheduling, cleaner
shader emission, and isolation processes.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 30 +
drivers/gpu/drm/amd/amdgpu
Ping!?
On 12/17/2024 3:08 PM, Srinivasan Shanmugam wrote:
It ensures that appropriate error codes are returned when an error
condition is detected
Fixes the below;
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2849 amdgpu_ras_add_bad_pages() warn:
missing error code here? 'amdgpu_umc_pages_in_
e state before executing new tasks.
Cc: lin cao
Cc: Jingwen Chen
Cc: Christian König
Cc: Alex Deucher
Suggested-by: Shaoyun Liu
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/me
e state before executing new tasks.
Cc: lin cao
Cc: Jingwen Chen
Cc: Christian König
Cc: Alex Deucher
Suggested-by: Shaoyun Liu
Signed-off-by: Srinivasan Shanmugam
---
v2: The checks for amdgpu_sriov_is_mes_info_enable were removed to
simplify the resource management logic in the MES initial
e state before executing new tasks.
Cc: lin cao
Cc: Jingwen Chen
Cc: Christian König
Cc: Alex Deucher
Suggested-by: Shaoyun Liu
Signed-off-by: Srinivasan Shanmugam
---
v2: The checks for amdgpu_sriov_is_mes_info_enable were removed to
simplify the resource management logic in the MES initial
aner shader is emitted when necessary in
scenarios requiring enforced isolation.
Fixes: 2feee98e6f2c ("drm/amdgpu: Update VM flush condition for
'enforce_isolation'")
Cc: Christian König
Cc: Alex Deucher
Suggested-by: Christian König
Signed-off-by: Srinivasan Shanmuga
("drm/amd/display: Make DMCUB tracebuffer debugfs
chronological")
Cc: Leo Li
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Alex Hung
Cc: Aurabindo Pillai
Cc: Harry Wentland
Cc: Hamza Mahfooz
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
---
v2:
-
("drm/amd/display: Make DMCUB tracebuffer debugfs
chronological")
Cc: Leo Li
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Alex Hung
Cc: Aurabindo Pillai
Cc: Harry Wentland
Cc: Hamza Mahfooz
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v2:
- s/-EIO/-EINVAL, retained the use of -EINVAL from
amdgpu_umc_pages_in_a_row & and amdgpu_ras_mca2pa_by_idx, when the
RAS context is not initialized or the convert_ras_err_addr function is
unavailab
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index db081618e85c..2af
VMIDs is done
correctly and without interference
Fixes: 96595204195d ("drm/amdgpu: Make enforce_isolation setting per GPU")
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 ++
1 file changed, 2 insertions(+)
di
.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 14 ++
.../drm/amd/amdgpu/gfx_v10_0_cleaner_shader.h | 35 +
.../amdgpu/gfx_v10_1_10_cleaner_shader.asm| 126 ++
3 files changed, 175
On 1/24/2025 10:01 PM, Marek Olšák wrote:
Does this commit really enable it though? Or is it just for sysfs?
Yes it enables cleaner shader support not only sysfs.
Best regards,
Srini
Marek
On Fri, Jan 24, 2025 at 1:42 AM Srinivasan Shanmugam
wrote:
Enable the cleaner shader for
.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 14 ++
.../drm/amd/amdgpu/gfx_v10_0_cleaner_shader.h | 35 +
.../amdgpu/gfx_v10_1_10_cleaner_shader.asm| 126 ++
3 files changed, 175
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 1878c83ff7e3..938f7d60a0ee 100644
--- a/drivers/gpu/drm/amd
: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 938f7d60a0ee..9816e2a4d62e 100644
--- a
ie link width")
Cc: Christian König
Cc: Alex Deucher
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/a
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
Suggested-by: Lijo Lazar
---
v3: change the else s/parent/adev->pdev (Lijo)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
Suggested-by: Lijo Lazar
---
v2: Use the device itself if no upstream bridge is found (Lijo)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/am
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
Suggested-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
in
ensures that GPU resources are reset between workloads,
preventing data leaks and ensuring accurate computation.
By enabling the cleaner shader, this update enhances the security and
reliability of GPU operations on GFX12.0 hardware.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan
König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 88393c2c08e4..5ba263fe5512 100644
--- a/drivers/gpu
: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v2: Updated commit message
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 88393c2c08e4
0xe7/0x120
[ 606.303449] ? __pfx_kthread+0x10/0x10
[ 606.303463] ret_from_fork+0x3c/0x60
[ 606.303476] ? __pfx_kthread+0x10/0x10
[ 606.303489] ret_from_fork_asm+0x1a/0x30
[ 606.303512]
Fixes: afefd6f24502 ("drm/amdgpu: Implement Enforce Isolation Handler for
KGD/KFD serialization")
0xe7/0x120
[ 606.303449] ? __pfx_kthread+0x10/0x10
[ 606.303463] ret_from_fork+0x3c/0x60
[ 606.303476] ? __pfx_kthread+0x10/0x10
[ 606.303489] ret_from_fork_asm+0x1a/0x30
[ 606.303512]
Fixes: afefd6f24502 ("drm/amdgpu: Implement Enforce Isolation Handler for
KGD/KFD serialization&quo
Li
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Alex Hung
Cc: Aurabindo Pillai
Cc: Harry Wentland
Cc: Hamza Mahfooz
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +
1 file changed, 5 insertions(
rom_fork+0x3c/0x60
[ 253.019468] ? __pfx_kthread+0x10/0x10
[ 253.019701] ret_from_fork_asm+0x1a/0x30
[ 253.019939]
Fixes: e864180ee49b ("drm/amdgpu: Add lock around VF RLCG interface")
Cc: lin cao
Cc: Jingwen Chen
Cc: Victor Skvortsov
Cc: Zhigang Luo
Cc: Christian König
Cc: Alex Deuche
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
index c5f9db6b32a4..5576ed0b508f 100644
--
xa0
Fixes: afefd6f24502 ("drm/amdgpu: Implement Enforce Isolation Handler for
KGD/KFD serialization")
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 ++
-Novales
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
index 8261308fc1f2
goto err;
Reviewed-by: Srinivasan Shanmugam
On 4/4/2025 7:46 PM, Christian König wrote:
This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned out
that this has some negative consequences for some workloads. Instead check
if the cleaner shader should run directly.
While at it remove amdgpu_vm_need_pipeline_sync(), we also
-Novales
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index
On 3/27/2025 2:54 PM, Christian König wrote:
Over all this change doesn't seem to make much sense to me.
Why exactly is isolation->spearhead not pointing to the dummy kernel job we
submit?
Does the owner check or gang_submit check in
amdgpu_device_enforce_isolation() fail to set up the spear
On 4/9/2025 8:12 PM, Alex Deucher wrote:
On Wed, Apr 9, 2025 at 10:36 AM SRINIVASAN SHANMUGAM
wrote:
On 4/8/2025 9:30 PM, Alex Deucher wrote:
Switch from a bool to an enum and allow more options
for enforce isolation. There are now 3 modes of operation:
- Disabled (0)
- Enabled
: Mario Sopena-Novales
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 28 ++
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
crash caused by incorrect check
v5: once more fix the logic
Signed-off-by: Christian König
Reviewed-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 6 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 94 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5
On 4/8/2025 9:30 PM, Alex Deucher wrote:
Switch from a bool to an enum and allow more options
for enforce isolation. There are now 3 modes of operation:
- Disabled (0)
- Enabled (serialization and cleaner shader) (1)
- Enabled in legacy mode (no serialization or cleaner shader) (2)
This provid
On 4/9/2025 7:16 PM, SRINIVASAN SHANMUGAM wrote:
On 4/9/2025 7:11 PM, SRINIVASAN SHANMUGAM wrote:
On 4/9/2025 6:45 PM, SRINIVASAN SHANMUGAM wrote:
On 4/9/2025 4:15 PM, Christian König wrote:
This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936.
Turned out
that this has some
On 4/9/2025 6:45 PM, SRINIVASAN SHANMUGAM wrote:
On 4/9/2025 4:15 PM, Christian König wrote:
This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned out
that this has some negative consequences for some workloads. Instead
check
if the cleaner shader should run directly.
While
On 4/9/2025 7:11 PM, SRINIVASAN SHANMUGAM wrote:
On 4/9/2025 6:45 PM, SRINIVASAN SHANMUGAM wrote:
On 4/9/2025 4:15 PM, Christian König wrote:
This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned
out
that this has some negative consequences for some workloads. Instead
check
On 3/31/2025 6:31 PM, Christian König wrote:
This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936.
Turned out that this has some negative consequences for some workloads.
Instead check if the cleaner shader should run directly.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd
On 3/31/2025 6:31 PM, Christian König wrote:
Otherwise triggering sysfs multiple times without other submissions in
between only runs the shader once.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
di
On 2/18/2025 9:43 PM, Christian König wrote:
Instead of emitting the cleaner shader for every job which has the
enforce_isolation flag set only emit it for the first submission from
every client.
v2: add missing NULL check
v3: fix another NULL pointer deref
Signed-off-by: Christian König
---
On 3/7/2025 7:18 PM, Christian König wrote:
We keep the gang submission fence around in adev, make sure that it
stays alive.
v2: fix memory leak on retry
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +-
1 file changed, 9 insertions(+), 1 delet
On 3/7/2025 7:18 PM, Christian König wrote:
Instead of emitting the cleaner shader for every job which has the
enforce_isolation flag set only emit it for the first submission from
every client.
v2: add missing NULL check
v3: fix another NULL pointer deref
Signed-off-by: Christian König
---
Thanks for these patches and feedback's.
The series is:
Acked-by: Srinivasan Shanmugam
On 3/14/2025 7:50 PM, Christian König wrote:
Am 14.03.25 um 05:09 schrieb SRINIVASAN SHANMUGAM:
On 3/7/2025 7:18 PM, Christian König wrote:
We keep the gang submission fence around in adev, make sure
On 4/7/2025 5:44 PM, Christian König wrote:
Am 05.04.25 um 09:32 schrieb SRINIVASAN SHANMUGAM:
On 4/4/2025 7:46 PM, Christian König wrote:
This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned out
that this has some negative consequences for some workloads. Instead check
if
inc_return(&counter),
+ owner = (void *)(unsigned long)atomic_inc_return(&counter);
r = amdgpu_job_alloc_with_ib(ring->adev, &entity, owner,
64, 0, &job);
Reviewed-by: Srinivasan Shanmugam
thout being checked.
140 break;
Fixes: 16856d135622 ("drm/amdgpu: update userqueue BOs and PDs")
Cc: Christian König
Cc: Alex Deucher
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 +++-
1 file chan
, it fetches and runs the cleaner
shader instructions from the specified location in the packet. Thus by
preventing data leaks and ensuring that previous job states do not
interfere with subsequent workloads.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers
refines the handling logic of cleaner shader emissions
for other GFX v9.0 variants
Srinivasan Shanmugam (2):
drm/amdgpu: Add PACKET3_RUN_CLEANER_SHADER_9_0 for Cleaner Shader
execution
drm/amdgpu: Enhance Cleaner Shader Handling in GFX v9.0 Architecture
drivers/gpu/drm/amd/amdgpu
, 9.2.2, 9.3.0, and 9.4.0, while retaining
PACKET3_RUN_CLEANER_SHADER for version 9.4.2.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
Suggested-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 21 -
1 file changed, 20 insertions(+), 1
v2: Simplified logic in second patch (Alex).
Srinivasan Shanmugam (2):
drm/amdgpu: Add PACKET3_RUN_CLEANER_SHADER_9_0 for Cleaner Shader
execution
drm/amdgpu: Enhance Cleaner Shader Handling in GFX v9.0 Architecture
v2
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 8 +++-
drivers/gpu
, 9.2.2, 9.3.0, and 9.4.0, while retaining
PACKET3_RUN_CLEANER_SHADER for version 9.4.2.
v2: Simplify logic (Alex).
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
Suggested-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 8 +++-
1 file changed, 7
, it fetches and runs the cleaner
shader instructions from the specified location in the packet. Thus by
preventing data leaks and ensuring that previous job states do not
interfere with subsequent workloads.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers
, fix crash caused by incorrect check
v5: once more fix the logic
v6: separate cleaner shader checks as suggested by Srini
Signed-off-by: Christian König
Reviewed-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 6 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 106
.
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Cc: Tom Chung
Cc: Roman Li
Cc: Alex Hung
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu
d
return -EINVAL to indicate an invalid state when the pointer is NULL.
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Alex Hung
Cc: Aurabindo Pillai
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
Reviewed-by: Aurabindo P
eaner shader for GFX10.1.10")
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10
without being checked.
140 break;
v2: Refactor `amdgpu_gem_update_bo_mapping()` to move the last update
fence logic to `amdgpu_gem_va_update_vm()`. (Christian)
Fixes: 16856d135622 ("drm/amdgpu: update userqueue BOs and PDs")
Cc: Christian König
Cc: Alex Deu
-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index b9a1ef343c79..801603510d56 100644
--- a/drivers/gpu/drm/amd
Cc: Christian König
Suggested-by: Christian König
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 96 +++--
1 file changed, 41 insertions(+), 55 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
b/drivers/gpu/drm/amd/amdgpu
t;funcs->program_lut_mode(mpc,
MCM_LUT_SHAPER, MCM_LUT_ENABLE, lut_bank_a, mpcc_id);
Cc: Yihan Zhu
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Alex Hung
Cc: Aurabindo Pillai
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
mpc->funcs->program_lut_mode(mpc,
MCM_LUT_SHAPER, MCM_LUT_ENABLE, lut_bank_a, mpcc_id);
Cc: Yihan Zhu
Cc: Harry Wentland
Cc: Nicholas Kazlauskas
Cc: Tom Chung
Cc: Rodrigo Siqueira
Cc: Roman Li
Cc: Alex Hung
Cc: Aurabindo Pillai
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Sha
, fix crash caused by incorrect check
v5: once more fix the logic
v6: separate cleaner shader checks as suggested by Srini
v7: re-order incorrect check
Signed-off-by: Christian König
Reviewed-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 6 +-
drivers/gpu/drm/amd/amdgpu
Adjusted the enforce isolation setting handling to include the ability
to disable the cleaner shader without affecting isolation between tasks.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
drivers/gpu/drm/amd
On 2/17/2025 7:44 PM, Alex Deucher wrote:
On Sat, Feb 15, 2025 at 3:02 AM SRINIVASAN SHANMUGAM
wrote:
On 2/14/2025 11:05 PM, Alex Deucher wrote:
Re-send the mes message on resume to make sure the
mes state is up to date.
Fixes: 8521e3c5f058 ("drm/amd/amdgpu: limit single process i
11: 0246 R12: 0001
[ 223.426986] R13: 7fff5c3e5470 R14: 7fff5c3e53e0 R15: 7fff5c3e5410
[ 223.427004]
Fixes: 4683cfecadeb ("drm/amdkfd: deregister svm range")
Cc: Philip Yang
Cc: Alex Sierra
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
inactive[idx] = false;
+ amdgpu_amdkfd_start_sched(adev, idx);
+ adev->gfx.kfd_sch_inactive[idx] = false;
}
}
mutex_unlock(&adev->enforce_isolation_mutex);
Thanks!
Reviewed-by: Srinivasan Shanmugam
Cc: Aurabindo Pillai
Reported-by: Dan Carpenter
Signed-off-by: Srinivasan Shanmugam
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 +++
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd
On 3/7/2025 7:18 PM, Christian König wrote:
That was quite troublesome for gang submit. Completely drop this
approach and enforce the isolation separately.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 9 +--
On 3/7/2025 7:18 PM, Christian König wrote:
That was quite troublesome for gang submit. Completely drop this
approach and enforce the isolation separately.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 9 +
On 3/7/2025 7:18 PM, Christian König wrote:
This allows using amdgpu_sync even without peeking into the fences for a
long time.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/driv
On 2/24/2025 6:54 PM, Christian König wrote:
Am 24.02.25 um 12:45 schrieb Srinivasan Shanmugam:
This commit updates the documentation for the function
amdgpu_sdma_register_on_reset_callbacks to include a description
for the 'adev' parameter.
The 'adev' parameter
Updated description for the 'other_mode' parameter. This parameter is
used to determine the display mode of another display controller that
may be sharing the line buffer.
Cc: Ken Wang
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/
vcn_v2_5_enable_clock_gating() instead
Cc: Leo Liu
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd
ion(adev, i, true);
+ if (adev->enable_mes && adev->gfx.enable_cleaner_shader)
+ amdgpu_mes_set_enforce_isolation(adev, i, true);
}
adev->enforce_isolation[i] = partition_values[i];
}
Reviewed-by: Srinivasan Shanmugam
By adding these NULL pointer checks and improving error handling, we can
prevent crashes when the enforce_isolation sysfs file is accessed on
non-supported systems.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 17
Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 9 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 3 ++-
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/a
On 2/14/2025 2:39 PM, Christian König wrote:
Am 14.02.25 um 09:57 schrieb Srinivasan Shanmugam:
RLCG Register Access is a way for virtual functions to safely access GPU
registers in a virtualized environment., including TLB flushes and
register reads. When multiple threads or VFs try to access
ve kfd driver use same PASID values from
graphic driver")
Reported by: Dan Carpenter
Cc: Xiaogang Chen
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 2/14/2025 11:05 PM, Alex Deucher wrote:
Re-send the mes message on resume to make sure the
mes state is up to date.
Fixes: 8521e3c5f058 ("drm/amd/amdgpu: limit single process inside MES")
Signed-off-by: Alex Deucher
Cc: Shaoyun Liu
Cc: Srinivasan Shanmugam
---
drivers/gpu/drm/
On 2/20/2025 10:25 AM, Felix Kuehling wrote:
On 2025-02-18 15:51, Philip Yang wrote:
On 2025-02-18 11:01, Srinivasan Shanmugam wrote:
This commit addresses a circular locking dependency in the
svm_range_cpu_invalidate_pagetables function. The function previously
held a lock while determining
On 2/17/2025 8:05 PM, Alex Deucher wrote:
On Mon, Feb 17, 2025 at 9:18 AM SRINIVASAN SHANMUGAM
wrote:
On 2/17/2025 7:44 PM, Alex Deucher wrote:
On Sat, Feb 15, 2025 at 3:02 AM SRINIVASAN SHANMUGAM
wrote:
On 2/14/2025 11:05 PM, Alex Deucher wrote:
Re-send the mes message on resume to make
0
[ 223.426975] R10: 7f4675e81a50 R11: 0246 R12: 0001
[ 223.426986] R13: 7fff5c3e5470 R14: 7fff5c3e53e0 R15: 7fff5c3e5410
[ 223.427004]
Fixes: 3e5199134e47 ("drm/amdkfd: pause autosuspend when creating pdd")
Cc: Jesse Zhang
Cc: Yunxiang Li
Cc: Philip Ya
the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:474: warning: Function parameter or
struct member 'adev' not described in 'amdgpu_sdma_register_on_reset_callbacks'
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/dr
m/amd/amdgpu/vcn_v4_0_5.c:1460: warning: Function parameter or
struct member 'ip_block' not described in 'vcn_v4_0_5_is_idle'
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c:1460: warning: Excess function
parameter 'handle' description in 'vcn_v4_0_5_is_idle'
0
[ 223.426975] R10: 7f4675e81a50 R11: 0246 R12: 0001
[ 223.426986] R13: 7fff5c3e5470 R14: 7fff5c3e53e0 R15: 7fff5c3e5410
[ 223.427004]
Fixes: 3e5199134e47 ("drm/amdkfd: pause autosuspend when creating pdd")
Cc: Jesse Zhang
Cc: Yunxiang Li
Cc: Philip Ya
5] R10: 7f4675e81a50 R11: 0246 R12: 0001
[ 223.426986] R13: 7fff5c3e5470 R14: 7fff5c3e53e0 R15: 7fff5c3e5410
[ 223.427004]
Fixes: 3e5199134e47 ("drm/amdkfd: pause autosuspend when creating pdd")
Cc: Jesse Zhang
Cc: Yunxiang Li
Cc: Philip Ya
5] R10: 7f4675e81a50 R11: 0246 R12: 0001
[ 223.426986] R13: 7fff5c3e5470 R14: 7fff5c3e53e0 R15: 7fff5c3e5410
[ 223.427004]
Fixes: 3e5199134e47 ("drm/amdkfd: pause autosuspend when creating pdd")
Cc: Jesse Zhang
Cc: Yunxiang Li
Cc: Philip Ya
nable_clock_gating'
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:965: warning: Excess function parameter
'adev' description in 'vcn_v3_0_enable_clock_gating'
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:965: warning: Excess function parameter
'inst' description in '
231: warning: Excess function
parameter 'handle' description in 'vcn_v5_0_0_is_idle'
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
On 3/28/2025 8:28 PM, Alex Deucher wrote:
On Thu, Mar 27, 2025 at 9:50 AM Christian König
wrote:
Am 27.03.25 um 10:37 schrieb SRINIVASAN SHANMUGAM:
On 3/27/2025 2:54 PM, Christian König wrote:
Over all this change doesn't seem to make much sense to me.
Why exactly is isolation->s
On 4/2/2025 7:32 PM, Christian König wrote:
Otherwise triggering sysfs multiple times without other submissions in
between only runs the shader once.
v2: add some comment
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 14 +++---
1 file changed, 11 ins
t amdgpu_vm_clear_freed(struct amdgpu_device *adev,
@@ -550,8 +551,6 @@ void amdgpu_vm_adjust_size(struct amdgpu_device *adev,
uint32_t min_vm_size,
uint32_t fragment_size_default, unsigned max_level,
unsigned max_bits);
int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file
*filp);
-bool amdgpu_vm_need_pipeline_sync(struct amdgpu_ring *ring,
- struct amdgpu_job *job);
void amdgpu_vm_check_compute_bug(struct amdgpu_device *adev);
struct amdgpu_task_info *
Requesting for feedback's that is marked as *[1]* , *[2]* & *[3]*
addressed , with this, the patch is:
Reviewed-by: Srinivasan Shanmugam
ence for
cleaner shader calls.
- Updated the `amdgpu_vm_flush` function to properly initialize
`isolation->spearhead` to the job's scheduled fence when the cleaner
shader is required.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amd
On 4/3/2025 2:40 PM, Christian König wrote:
Am 03.04.25 um 05:15 schrieb SRINIVASAN SHANMUGAM:
On 4/2/2025 7:32 PM, Christian König wrote:
Otherwise triggering sysfs multiple times without other submissions in
between only runs the shader once.
v2: add some comment
Signed-off-by: Christian
review comments from Christian.
Cc: Alex Deucher
Cc: Christian König
Suggested-by: Christian König
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 82 +
1 file changed, 30 insertions(+), 52 deletions(-)
diff --git a/drivers/gpu/drm/amd
501 - 600 of 617 matches
Mail list logo
