[PATCH] drm/radeon: Fix ENOSYS with better fitting error codes in radeon_gem.c

Replace the error code from 'ENOSYS' to 'EOPNOTSUPP' for unimplemented radeon_gem_pread_ioctl & radeon_gem_pwrite_ioctl Fixes the following: WARNING: ENOSYS means 'invalid syscall nr' and nothing else. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srin

[PATCH] drm/radeon: Prefer strscpy over strlcpy in 'radeon_combios_get_power_modes'

over strlcpy + strlcpy(info.type, name, sizeof(info.type)); Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/radeon_combios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] drm/radeon: Prefer strscpy over strlcpy calls in radeon_atombios.c

Use the strscpy method instead of strlcpy method. Fixes the below: WARNING: Prefer strscpy over strlcpy Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/radeon_atombios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amdgpu: Use parentheses for sizeof *numa_info in 'amdgpu_acpi_get_numa_info'

Fixes the below: WARNING: sizeof *numa_info should be sizeof(*numa_info) Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/radeon: Remove unnecessary NULL test before kfree in 'radeon_connector_free_edid'

Fixes the below: WARNING: kfree(NULL) is safe and this check is probably not required. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/radeon_connectors.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

[PATCH] drm/amdgpu: Fix printk_ratelimit() with DRM_ERROR_RATELIMITED in 'amdgpu_cs_ioctl'

Replaced printk_ratelimit() with its DRM equivalent to avoid flooding of dmesg logs & hence fixes the following: WARNING: Prefer printk_ratelimited or pr__ratelimited to printk_ratelimit + if (printk_ratelimit()) Cc: Christian König Cc: Alex Deucher Signed-off-by: Sriniv

[PATCH] drm/radeon: Remove the references of radeon_gem_ pread & pwrite ioctls

tian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/radeon.h | 4 drivers/gpu/drm/radeon/radeon_drv.c | 2 -- drivers/gpu/drm/radeon/radeon_gem.c | 16 3 files changed, 22 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeo

[PATCH] drm/amdgpu: Clean up style problems in mmhub_v2_3.c

) + if (!(data & (DAGB0_CNTL_MISC2__DISABLE_WRREQ_CG_MASK | [...] + *flags |= AMD_CG_SUPPORT_MC_MGCG; Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(

[PATCH] drm/amdgpu: Move vram, gtt & flash defines to amdgpu_ ttm & _psp.h

König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 3 +++ 4 files changed, 6 insertions(+), 4 de

[PATCH] drm/amdgpu: Sort the includes in amdgpu/amdgpu_drv.c

Sort the include files that are included in amdgpu_drv.c alphabetically. Suggested-by: Mario Limonciello Cc: Mario Limonciello Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 25 - 1 file changed

[PATCH v2] drm/amdgpu: Move vram, gtt & flash defines to amdgpu_ ttm & _psp.h

König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: 1. As a prerequisite, sorted the inludes in other patch https://patchwork.freedesktop.org/patch/549850/ | drm/amdgpu: Sort the includes in amdgpu/amdgpu_drv.c (Mario) 2. Include _psp.h, & moved vram & gtt

[PATCH] drm/amdpgu: Fix printk() should include KERN_ in 'amdgpu_atpx_verify_interface'

er Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c index 6f241c574665..dccebe6aaad4 10

[PATCH] drm/amdpgu: Cleanup amdgpu/amdgpu_cgs.c

ig Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 76 - 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c index 456e385333b6.

[PATCH] Revert "drm/amdgpu: Prefer dev_* variant over printk in amdgpu_atpx_handler.c"

Cc: Bert Karwatzki Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 35 +++ 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c

[PATCH] Revert "drm/radeon: Prefer dev_* variant over printk"

Usage of container_of is wrong here. struct acpi_device *adev = container_of(handle, struct acpi_device, handle) References: https://gitlab.freedesktop.org/drm/amd/-/issues/2744 Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: Bert Karwatzki Signed-off-by: Srinivasan Shanmugam

[PATCH] drm/amdgpu: Prefer pr_err/_info over printk in amdgpu_atpx_handler.c

Fixes the following style issues: ERROR: open brace '{' following function definitions go on the next line WARNING: printk() should include KERN_ facility level Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: Bert Karwatzki Signed-off-by: Srinivasan Shanmugam --- .../g

[PATCH v2] Revert "drm/radeon: Prefer dev_* variant over printk"

Cc: Bert Karwatzki Cc: "Pan, Xinhui" Cc: Luben Tuikov Signed-off-by: Srinivasan Shanmugam Reviewed-by: Guchun Chen --- v2: - Added missing commit id. drivers/gpu/drm/radeon/radeon_atpx_handler.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/d

[PATCH v2] drm/amdgpu: Prefer pr_err/_warn/_notice over printk in amdgpu_atpx_handler.c

uikov Signed-off-by: Srinivasan Shanmugam --- v2: - Updated commit title as per log levels updated in this patch - Updated with appropriate log levels (Luben) .../gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 29 +++ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/driver

[PATCH] drm/amdgpu: Fix unused variable ‘i’ in 'gfxhub_v1_2_xcc_gart_enable'

ned-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_2.c b/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_2.c index db7ad3af7439..0834af771549 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1

[PATCH] drm/amdgpu: Refactor 'amdgpu_connector_dvi_detect' in amdgpu_connectors.c

drigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 69 +++ 1 file changed, 42 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/am

[PATCH] drm/amdgpu: Use READ_ONCE() when reading the values in 'sdma_v4_4_2_ring_get_rptr'

Instead of declaring pointers use READ_ONCE(), when accessing those values to make sure that the compiler doesn't voilate any cache coherences Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Cc: Le Ma Cc: Hawking Zhang Signed-off-by: Srinivasan Shanmuga

[PATCH] drm/amdgpu: Fix identation issues in 'kgd_gfx_v9_program_trap_handler_settings'

Fixes the following: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gf

[PATCH] drm/amdgpu: Fix identifier names to function definition arguments in atom.h

identifier name WARNING: Unnecessary space before function pointer name ERROR: space prohibited after that '*' (ctx:BxW) CHECK: Prefer kernel type 'u32' over 'uint32_t' Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Signed-off-b

[PATCH] drm/amdgpu: Fix missing comment for wmb() in 'amdgpu_device_aper_access'

ned-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 4f818f13dc9d..a1c214f86e4d 100644 --- a/drivers/gpu/drm/

[PATCH v2] drm/amdgpu: Fix missing comment for wmb() in 'amdgpu_device_aper_access'

ned-off-by: Srinivasan Shanmugam --- v2: - Fixed indendation issues. drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 4f818f13dc9d..bb65e12ed027 100644 ---

[PATCH v3] drm/amdgpu: Fix missing comment for mb() in 'amdgpu_device_aper_access'

ned-off-by: Srinivasan Shanmugam --- v3: Corrected title message drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 4f818f13dc9d..bb65e12ed027 100644 ---

[PATCH] drm/radeon: Cleanup radeon/radeon_fence.c

#x27; to bare use of 'unsigned' WARNING: quoted string split across lines WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Signed-off-by: Srinivasa

[PATCH v4] drm/amdgpu: Fix missing comment for mb() in 'amdgpu_device_aper_access'

ned-off-by: Srinivasan Shanmugam --- v4: - Incorporated comments from (Lijo) drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 4f818f13dc9d..65c36987f7d6 10

[PATCH] drm/radeon: Fix multiple line dereference in 'atom_iio_execute'

Cc: "Pan, Xinhui" Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/radeon/atom.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 93acb0e42bd6..ceb6d772ef94 100644 --- a/drivers/gpu/drm/

[PATCH] drm/amdgpu: Replace ternary operator with min() in 'amdgpu_iomem_read'

: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index df

[PATCH] drm/amdgpu: Replace ternary operator with min() in 'amdgpu_iomem_write'

: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index c0

[PATCH] drm/amd/display: Fix unnecessary conversion to bool in 'amdgpu_dm_setup_replay'

Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c b

[PATCH] drm/amd/display: Replace ternary operator with min() in 'dm_helpers_parse_edid_caps'

Fixes the following coccicheck: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:120:41-42: WARNING opportunity for min() Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH 0/3] Fixup some coccicheck warnings

Srinivasan Shanmugam (3): drm/amd/display: Update ternary operator with min() in 'do_aquire_global_lock' drm/amdgpu: Update ternary operator with max() in 'amdgpu_fence_wait_polling' drm/amdgpu: Update ternary operator with min() in 'amdgpu_ras_eepro

[PATCH 1/3] drm/amd/display: Update ternary operator with min() in 'do_aquire_global_lock'

Fixes the following coccicheck: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9079:12-13: WARNING opportunity for min() Cc: Hamza Mahfooz Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Cc: Christian König Signed-off-by: Srinivasan Shanmugam --- drivers

[PATCH 2/3] drm/amdgpu: Update ternary operator with max() in 'amdgpu_fence_wait_polling'

Fixes the following coccicheck: drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:384:16-17: WARNING opportunity for max() Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 3/3] drm/amdgpu: Update ternary operator with min() in 'amdgpu_ras_eeprom_init'

Fixes the following coccicheck: drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c:1412:12-13: WARNING opportunity for min() Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drm/amd/display: Fix useless else if in display_mode_vba_util_32.c

Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Cc: Christian König Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32

[PATCH v2 0/3] Fixup some coccicheck warnings

v2: Updated to max_t/min_t along with commit title message Srinivasan Shanmugam (3): drm/amd/display: Update ternary operator with min_t() in 'do_aquire_global_lock' drm/amdgpu: Update ternary operator with max_t() in 'amdgpu_fence_wait_polling' drm/amdgpu: Upd

[PATCH v2 1/3] drm/amd/display: Update ternary operator with min_t() in 'do_aquire_global_lock'

Fixes the following coccicheck: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9079:12-13: WARNING opportunity for min() Cc: Hamza Mahfooz Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Cc: Christian König Signed-off-by: Srinivasan Shanmugam --- drivers

[PATCH v2 2/3] drm/amdgpu: Update ternary operator with max_t() in 'amdgpu_fence_wait_polling'

Fixes the following coccicheck: drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:384:16-17: WARNING opportunity for max() Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 3/3] drm/amdgpu: Update ternary operator with min_t() in 'amdgpu_ras_eeprom_init'

Fixes the following coccicheck: drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c:1412:12-13: WARNING opportunity for min() Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drm/amdgpu: Fix kcalloc over kzalloc in 'gmc_v9_0_init_mem_ranges'

t; Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index f9a5a2c0573e..0673cda547bb 100644 --- a/drivers/gpu/drm/

[PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()'

ession compared with zero: val < 0 Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: "Pan, Xinhui" Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amd

[PATCH] drm/amd/display: Fix up kdoc format for 'dc_set_edp_power'

: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 025e0fdf486d..ed225e1a1299 100644 --- a/drivers/gpu/drm/amd/display/dc/core

[PATCH v3] drm/amdkfd: Use dynamic allocation for CU occupancy array in 'kfd_get_cu_occupancy()'

ggested-by: Mukul Joshi Cc: Harish Kasiviswanathan Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v3: - Remove unused "bytes_written" (Mukul) fixes the below: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c: In function ‘

[PATCH v2] drm/amdkfd: Use dynamic allocation for CU occupancy array in 'kfd_get_cu_occupancy()'

ggested-by: Mukul Joshi Cc: Harish Kasiviswanathan Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: - Use kcalloc for zero-initialization (Mukul) - Remove bytes_written call kfree just before the return statement. (Mukul) drivers/gpu/drm/

[PATCH] drm/amd/amdgpu: Fix double unlock in amdgpu_mes_add_ring

>mes); ^^ 1241 return r; 1242 } Fixes: d0c423b64765 ("drm/amdgpu/mes: use ring for kernel queue submission") Cc: Christian König Cc: Alex Deucher Cc: Hawking Zhang Suggested-by: Jack Xiao Reported by: Dan Carpenter Si

Re: [PATCH] drm/amdgpu: enable enforce_isolation sysfs node on VFs

On 10/9/2024 1:35 AM, Alex Deucher wrote: It should be enabled on both bare metal and VFs. Fixes: e189be9b2e38 ("drm/amdgpu: Add enforce_isolation sysfs attribute") Signed-off-by: Alex Deucher Cc: Srinivasan Shanmugam Cc: Amber Lin --- drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH] drm/amd/display: Add hpd_source index out-of-bounds check for dcn3x link encoder creation

Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c | 2 +- .../gpu/drm/amd/display/dc/resource/dcn301/dcn301_resource.c| 2 +- .../gpu/drm/amd/display/dc/resource/d

[PATCH 2/6] drm/amdgpu/gfx10: Apply Isolation Enforcement to GFX & Compute rings

. This function schedules `enforce_isolation_work` to be run after a delay. These functions are part of the Enforce Isolation Handler, which enforces shader isolation on AMD GPUs to prevent data leakage between different processes. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan

[PATCH 3/6] drm/amdgpu/gfx11: Implement cleaner shader support for GFX11 hardware

nclude the new gfx_v11_0_ring_emit_cleaner_shader function. This allows the cleaner shader to be emitted as part of the ring's operations. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 40 +++--- 1 f

[PATCH 4/6] drm/amdgpu/gfx11: Apply Isolation Enforcement to GFX & Compute rings

. This function schedules `enforce_isolation_work` to be run after a delay. These functions are part of the Enforce Isolation Handler, which enforces shader isolation on AMD GPUs to prevent data leakage between different processes. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan

[PATCH 1/6] drm/amdgpu/gfx10: Implement cleaner shader support for GFX10 hardware

nclude the new gfx_v10_0_ring_emit_cleaner_shader function. This allows the cleaner shader to be emitted as part of the ring's operations. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 40 +++--- 1 f

[PATCH 5/6] drm/amdgpu/gfx12: Implement cleaner shader support for GFX12 hardware

ring function structures to include the new gfx_v12_0_ring_emit_cleaner_shader function. This allows the cleaner shader to be emitted as part of the ring's operations. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v1

[PATCH 6/6] drm/amdgpu/gfx12: Apply Isolation Enforcement to GFX & Compute rings

. This function schedules `enforce_isolation_work` to be run after a delay. These functions are part of the Enforce Isolation Handler, which enforces shader isolation on AMD GPUs to prevent data leakage between different processes. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan

[PATCH] drm/amd/display: Ensure HPD source index is valid for dcn20/dcn201 link encoders

an Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 2 +- .../gpu/drm/amd/display/dc/resource/dcn201/dcn201_resource.c| 2 +- 2 files changed, 2 insertions(

[PATCH 1/3] drm/amd/display: Add hpd_source index check for DCE60/80/100/110/112/120 link encoders

i Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 2 +- .../gpu/drm/amd/display/dc/resource/dce100/dce100_resource.c| 2 +- .../gpu/drm/amd/display/dc/res

[PATCH 3/3] drm/amd/display: Add hpd_source index check for dcn401 link encoder setup

: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn401

[PATCH 2/3] drm/amd/display: Add hpd_source index check for dcn10 link encoder setup

: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/resource/dcn10/dcn10_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn10

[PATCH 1/2] drm/amdgpu/gfx9: Enable Cleaner Shader for GFX9.4.2 Hardware

different processes, preventing data leakage and enhancing security. It also aligns with the serialization mechanism between KGD and KFD, ensuring that the GPU state is consistent across different workloads. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu

[PATCH 2/2] drm/amdgpu/gfx9: Add cleaner shader for GFX9.4.2

. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Alex Deucher --- .../drm/amd/amdgpu/gfx_v9_0_cleaner_shader.h | 41 - .../amd/amdgpu/gfx_v9_4_2_cleaner_shader.asm | 153 ++ 2 files changed, 192 insertions(+), 2 deletions(-) create

[PATCH v3] drm/amdgpu/gfx9: Add cleaner shader for GFX9.4.2

König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Alex Deucher --- v2: - Updated comments to "// Note: original source code from SQ team" (Alex) v3: - Squashed patches 1 & 2 (Alex). drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 12 ++ .../

[PATCH] drm/amdkfd: Use dynamic allocation for CU occupancy array in 'kfd_get_cu_occupancy()'

Cc: Mukul Joshi Cc: Harish Kasiviswanathan Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd

[PATCH v4] drm/amdkfd: Use dynamic allocation for CU occupancy array in 'kfd_get_cu_occupancy()'

Cc: Harish Kasiviswanathan Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Mukul Joshi --- v4: - Allocation is moved just before it's needed (Mukul) drivers/gpu/drm/amd/amdkfd/kfd_process.c | 9 ++--- 1 file changed, 6 insertions(

Re: [PATCH] drm/amdgpu: Group gfx sysfs functions

On 10/29/2024 10:57 AM, Lijo Lazar wrote: Make amdgpu_gfx_sysfs_init/fini functions as common entry points for all gfx related sysfs nodes. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 37 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 --

Re: [PATCH] drm/amdgpu: Group gfx sysfs functions

On 10/29/2024 12:07 PM, SRINIVASAN SHANMUGAM wrote: On 10/29/2024 10:57 AM, Lijo Lazar wrote: Make amdgpu_gfx_sysfs_init/fini functions as common entry points for all gfx related sysfs nodes. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 37

Re: [PATCH] drm/amdgpu/mes: fetch fw version from firmware header

version, before fw gets loaded. Reviewed-by: Srinivasan Shanmugam

[PATCH] drm/amd/amdgpu/vcn: Fix kdoc entries for VCN clock/power gating functions

Excess function parameter 'handle' description in 'vcn_v4_0_5_set_powergating_state' drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c:1629: warning: Function parameter or struct member 'ip_block' not described in 'vcn_v4_0_3_set_powergating_state' drivers/gpu/drm/amd

[PATCH] drm/amd/amdgpu: Add missing kdoc 'inst' parameter in 'smu_dpm_set_power_gate' function

u_smu.c:359: warning: Function parameter or struct member 'inst' not described in 'smu_dpm_set_power_gate' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[PATCH] drm/amdgpu/gfx10: Add cleaner shader for GFX10.3.0

. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 15 +++ .../drm/amd/amdgpu/gfx_v10_0_cleaner_shader.h | 56 .../amd/amdgpu/gfx_v10_3_0_cleaner_shader.asm | 124 ++ 3 files changed, 195

[PATCH] drm/amdgpu/gfx9: Add cleaner shader for GFX11.0.3

. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 18 +++ .../amd/amdgpu/gfx_v11_0_3_cleaner_shader.asm | 118 ++ .../drm/amd/amdgpu/gfx_v11_0_cleaner_shader.h | 56 + 3 files changed, 192

[PATCH v2] drm/amdgpu/gfx9: Add cleaner shader for GFX11.0.3

. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Alex Deucher --- v2: - Updated comments to "// Note: original source code from SQ team" (Alex) - The file now uses GFX11 (Alex) drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 18 +++ .../

Re: [PATCH 1/2] drm/amdkfd: add an interface to query whether is KFD is active

The series is: Acked-by: Srinivasan Shanmugam On 10/28/2024 8:22 PM, Alex Deucher wrote: Add an interface to query whether KFD has any active queues. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 9 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 7

Re: [PATCH v4] drm/amdkfd: Use dynamic allocation for CU occupancy array in 'kfd_get_cu_occupancy()'

Ping? On 10/25/2024 8:13 AM, Srinivasan Shanmugam wrote: The `kfd_get_cu_occupancy` function previously declared a large `cu_occupancy` array as a local variable, which could lead to stack overflows due to excessive stack usage. This commit replaces the static array allocation with dynamic

[PATCH] drm/amd/amdgpu: Add missing kdoc 'inst' parameter in 'amdgpu_device_ip_set_powergating_state'

Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2182: warning: Function parameter or struct member 'inst' not described in 'amdgpu_device_ip_set_powergating_state' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- driver

[PATCH] drm/amd/amdgpu: Add missing kdoc 'gpu_addr' parameter in amdgpu_seq64_alloc()

Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168: warning: Function parameter or struct member 'gpu_addr' not described in 'amdgpu_seq64_alloc' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/a

[PATCH 1/5] drm/amdgpu: Add 'inst' parameter to kdoc in VCN v5.0.0 functions

r struct member 'inst' not described in 'vcn_v5_0_0_set_unified_ring_funcs' drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c:1331: warning: Function parameter or struct member 'inst' not described in 'vcn_v5_0_0_set_irq_funcs' Cc: Christian König Cc: Alex Deucher Signed-off-by: Sri

[PATCH 3/5] drm/amdgpu: Add missing 'inst' parameter to VCN v4.0.5 function interfaces

in 'vcn_v4_0_5_set_unified_ring_funcs' drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c:1594: warning: Function parameter or struct member 'inst' not described in 'vcn_v4_0_5_set_irq_funcs' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers

[PATCH 4/5] drm/amdgpu: Add missing 'inst' parameter to VCN v2.5 clock gating functions

le_clock_gating' drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:778: warning: Function parameter or struct member 'inst' not described in 'vcn_v2_5_enable_clock_gating' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/vcn_v2_

[PATCH 2/5] drm/amdgpu: Add missing 'inst' parameter to VCN v4.0.3 function interfaces

bed in 'vcn_v4_0_3_set_unified_ring_funcs' drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c:1732: warning: Function parameter or struct member 'inst' not described in 'vcn_v4_0_3_set_irq_funcs' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam ---

[PATCH 5/5] drm/amdgpu: Add missing 'inst' parameter to VCN v4.0 function interfaces

v4_0_set_unified_ring_funcs' drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:2142: warning: Function parameter or struct member 'inst' not described in 'vcn_v4_0_set_irq_funcs' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgp

[PATCH] drm/amd/display: Fix out-of-bounds access in 'dcn21_link_encoder_create'

3087] [ 65.923927] ---[ end trace ]--- Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/resource/dcn21/dcn21_resource.c | 3 ++- 1 file changed, 2 inse

[PATCH] drm/amd/display: Fix kdoc entry for 'tps' in dc_process_dmub_dpia_set_tps_notification

Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH] drm/amdgpu/gfx9: Add Cleaner Shader Deinitialization in gfx_v9_0 Module

any allocated resources for the cleaner shader are freed correctly, avoiding potential memory leaks and ensuring that the GPU state is clean for the next initialization sequence. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

Re: [PATCH 2/2] drm/amdgpu/gfx9: Explicitly halt CP before init

e GPU is in a known state before the driver attempts to initialize it. Adds calls to gfx_v9_0_cp_gfx_enable and gfx_v9_0_cp_compute_enable with enable set to false to halt the CP before the KIQ (Kernel Interface Queue) is resumed. Reviewed-by: Srinivasan Shanmugam

Re: [PATCH 1/2] drm/amdgpu/gfx9: set additional bits on CP halt

oad, to prevent stale state from causing issues. Reviewed-by: Srinivasan Shanmugam

[PATCH] drm/amdkfd: Fix kdoc entry for 'get_wave_count()' function parameters

#x27;get_wave_count' drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:954: warning: Excess function parameter 'vmid' description in 'get_wave_count' Cc: Ramesh Errabolu Cc: Harish Kasiviswanathan Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by

[PATCH v3] drm/amd/display: Fix out-of-bounds access in 'dcn21_link_encoder_create'

c1e5480 [ 65.923087] R13: 564c9c1db260 R14: R15: 564c9c1e54b0 [ 65.923087] [ 65.923927] ---[ end trace ]--- Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Sriniva

[PATCH v2] drm/amd/display: Fix out-of-bounds access in 'dcn21_link_encoder_create'

3087] [ 65.923927] ---[ end trace ]--- Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- v2: - Changed to ARRAY_SIZE() to be generic (Roman) drivers/gpu/drm/amd/disp

[PATCH v2 1/6] drm/amdgpu/gfx10: Implement cleaner shader support for GFX10 hardware

nclude the new gfx_v10_0_ring_emit_cleaner_shader function. This allows the cleaner shader to be emitted as part of the ring's operations. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: Removed xcc mask, as it is calculated in amdgpu_discovery.c for

[PATCH v2 5/6] drm/amdgpu/gfx12: Implement cleaner shader support for GFX12 hardware

ring function structures to include the new gfx_v12_0_ring_emit_cleaner_shader function. This allows the cleaner shader to be emitted as part of the ring's operations. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: Removed xcc mask, as it is cal

[PATCH v2 3/6] drm/amdgpu/gfx11: Implement cleaner shader support for GFX11 hardware

nclude the new gfx_v11_0_ring_emit_cleaner_shader function. This allows the cleaner shader to be emitted as part of the ring's operations. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: Removed xcc mask, as it is calculated in amdgpu_discovery.c for

[PATCH] drm/amdgpu/gfx11: Enable cleaner shader for GFX11.0.0/11.0.2 GPUs

: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Alex Deucher Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c index

[PATCH] drm/amdgpu: Add documentation for enforce isolation feature

This feature enables process isolation on the graphics engine by serializing access to it and adding a cleaner shader which clears LDS (Local Data Store) and GPRs (General Purpose Registers) between jobs. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by

[PATCH v2 2/2] drm/amdgpu/gfx9: Enable Cleaner Shader for GFX9.4.2 Hardware

different processes, preventing data leakage and enhancing security. It also aligns with the serialization mechanism between KGD and KFD, ensuring that the GPU state is consistent across different workloads. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu

[PATCH v2 1/2] drm/amdgpu/gfx9: Add cleaner shader for GFX9.4.2

. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Alex Deucher --- v2: - Reordered the patches 1 & 2 (Alex) - Updated comments to "// Note: original source code from SQ team" (Alex) .../drm/amd/amdgpu/gfx_v9_0_cleaner_shader.h | 44

[PATCH] drm/amd/amdgpu: Add Descriptions to Process Isolation and Cleaner Shader Sysfs Functions

rface. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c index e5

[PATCH] drm/amd/amdgpu: Add Annotations to Process Isolation functions

. amdgpu_gfx_enforce_isolation_ring_end_use: Handles cleanup and state updates when finishing the use of a GPU ring. It may also adjust the KFD scheduler, using a mutex to manage shared data access. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu

[PATCH v2] drm/amd/amdgpu: Add Annotations to Process Isolation functions

. amdgpu_gfx_enforce_isolation_ring_end_use: Handles cleanup and state updates when finishing the use of a GPU ring. It may also adjust the KFD scheduler, using a mutex to manage shared data access. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Alex Deucher

<    1   2   3   4   5   6   7   >