: Alex Hung
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 0bf1bc7ced7d
+ Cc: Tom Chung
On 1/29/2024 9:19 PM, Srinivasan Shanmugam wrote:
The error message buffer overflow 'dc->links' 12 <= 12 suggests that the
code is trying to access an element of the dc->links array that is
beyond its bounds. In C, arrays are zero-indexed, so an array with 12
27;amdgpu_gmc_vram_checking()'")
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v3:
- Changed from 'return r;' to 'return 0' (Christian)
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 4 ++--
dri
eira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/dc/dcn35/dcn35_optc.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn35/dcn35_optc.c
b/driv
eira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Addressed the following comments (Rodrigo)
- Updated Commit title to 'drm/amd/display: Adjust kdoc for
'optc35_set_odm_combine'
- Updated the description for par
t char * array should probably be static const char * const
Cc: Christian König
Cc: Alex Deucher
Cc: "Pan, Xinhui"
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 4 ++--
2 files changed, 5 insertion
Use min_t to replace min, min_t is a bit fast because min use
twice typeof.
Fixes the below checkpatch warning:
WARNING: min() should probably be min_t()
Cc: Christian König
Cc: Alex Deucher
Cc: "Pan, Xinhui"
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/am
ucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
b/drivers/gpu/drm/amd/display/dc/core/dc.c
index c5a74b202bc8..ab403d2d9038 100644
--- a/drivers/gpu/drm/amd/display/dc/cor
ned-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 1 -
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c| 2 --
drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 4
drivers/gpu/drm/amd/amdgpu/navi10_ih.c
t;
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h| 2 +-
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.h | 6 --
4 files changed, 7 insertions(+), 5 d
Fixes the below:
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:274: warning: Function parameter or
member 'gart_placement' not described in 'amdgpu_gmc_gart_location'
Cc: Christian König
Cc: Alex Deucher
Cc: "Pan, Xinhui"
Signed-off-by: Srinivasan Shanmugam
-
Fixes the below:
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:274: warning: Function parameter or
member 'gart_placement' not described in 'amdgpu_gmc_gart_location'
Cc: Christian König
Cc: Alex Deucher
Cc: "Pan, Xinhui"
Signed-off-by: Srinivasan Shanmugam
---
v2
Fixes the below:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:2073: warning: Function
parameter or member 'remap_list' not described in 'svm_range_add'
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
Cc: "Pan, Xinhui"
Signed-off-by: Srinivasan Shanm
Fix the following checkpatch checks in amdgpu_dm.c
CHECK: Prefer kernel type 'u8' over 'uint8_t'
CHECK: Prefer kernel type 'u32' over 'uint32_t'
CHECK: Prefer kernel type 'u64' over 'uint64_t'
CHECK: Prefer kernel type 's32'
_DF)
~^~
Presumably the author intended to test if AMDGPU_RAS_BLOCK__DF
bit was set if ras is enabled, so that's what I'm changing the
code to. Hopefully to do the right thing.
Cc: Christian König
Cc: Alex Deucher
Cc: Mario Limonciello
Signed-off-by: Sriniva
c: Candice Li
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 5b17790218811..fac45f98145d8 100644
--- a/driver
Limonciello
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 917926c8dc5f5..67dbac87202e4 100644
--- a/drivers/gpu
Cc: Alex Deucher
Cc: Mario Limonciello
Cc: Hamza Mahfooz
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
x27;,' (ctx:WxV)
+module_param_named(job_hang_limit, amdgpu_job_hang_limit, int ,0444);
This patch gets rid of all above type of "ERROR" messages in
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:
Cc: Christian König
Cc: Alex Deucher
Cc: Mario Limonciello
Signed-off-by: Srinivasan Shanm
arameter. (Christian)
Suggested-by: Christian König
Cc: Alex Deucher
Cc: Mario Limonciello
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gp
The driver doesn't resubmit jobs on hangs any more, hence drop
the hang limit parameter - amdgpu_job_hang_limit, wherever it is used.
Suggested-by: Christian König
Cc: Alex Deucher
Cc: Mario Limonciello
Cc: Kent Russell
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/a
Add some more logging for DP link traning test pattern seqeunces
for better debugging.
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
.../display/dc/link/protocols/link_dp_training.c | 16
1 file changed, 16 insertions(+)
diff --git a
frequency range shall be 30 to 33 kHz]
Besides, fix checkpatch warning:
CHECK: Alignment should match open parenthesis
Cc: Mario Limonciello
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
.../display/dc/link/protocols/link_dp_training.c | 14
Add some more logging for DP link traning test pattern seqeunces
for better debugging.
Cc: Jerry Zuo
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
.../drm/amd/display/dc/link/protocols/link_dp_training.c | 9 +
1 file changed, 9 insertions
Log if we fail to setup sink power states.
Cc: Fangzhi Zuo
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
.../gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols
Log if we fail to setup sink power states.
Cc: Fangzhi Zuo
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Change DC_LOG_HW_LINK_TRAINING to DC_LOG_DC, as link training related
code moved to
drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c (Aurabindo
Log when Channel Equalization is successful,
and DP link training completed.
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
.../display/dc/link/protocols/link_dp_training_128b_132b.c | 2 ++
.../amd/display/dc/link/protocols/link_dp_training_8b_10b.c | 5
Log when Clock recovery is successful, as part of
DP link training process.
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
.../amd/display/dc/link/protocols/link_dp_training_8b_10b.c | 4 +++-
.../drm/amd/display/dc/link/protocols/link_dp_training_dpia.c | 2
Log when Channel Equalization is successful,
and DP link training completed.
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
v2:
- For consistency of the printed messages, dropped %s for both the
lines (Aurabindo)
- For 128b/132b, moved the statements after
Log when Channel Equalization is successful,
and DP link training completed.
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
v2:
- For consistency of the printed messages, either drop or keep %s for both the
lines - it is dropped (Aurabindo)
- For 128b/132b
After reading from receiver via DPCD, check & log if it supports MST,
DSC & FEC
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
.../amd/display/dc/link/protocols/link_dp_capability.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers
After reading from receiver via DPCD, check & log if it supports MST,
DSC & FEC
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Added %s: to print the function name.
.../amd/display/dc/link/protocols/link_dp_capability.c | 9 +
1 file
After reading from receiver via DPCD, check & log if it supports MST,
DSC & FEC
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Added %s: to print the function name.
v3:
- Used the defined struct instead of the bitwise logic he
The previous 'commit 9360c01646d4e ("drm/amd/display: Add logging when
setting DP sink power state fails")', it is better to unconditionally
print "failed to power up sink", because we are returning
DC_ERROR_UNEXPECTED.
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signe
Cc: Alex Deucher
Cc: Mario Limonciello
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 1a
(ctx:VxE)
ERROR: space prohibited before that close parenthesis ')'
ERROR: space required before the open parenthesis '('
ERROR: space required before the open brace '{'
ERROR: code indent should use tabs where possible
Cc: Christian König
Cc: Alex Deucher
Cc: Mari
Log when Channel Equalization is successful.
Cc: Aurabindo Pillai
Cc: Fangzhi Zuo
Signed-off-by: Srinivasan Shanmugam
---
v2:
- For consistency of the printed messages, either drop or keep %s for both the
lines - it is dropped (Aurabindo)
- For 128b/132b, moved the statements after EQ
/dcn21/dcn21_hwseq.c:226:20: warning:
unused variable ‘cmd’ [-Wunused-variable]
226 | union dmub_rb_cmd cmd;
|^~~
Cc: Aurabindo Pillai
Cc: Jerry Zuo
Cc: Yongqiang Sun
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c | 2 --
Fix following checkpatch errors in amdgpu_discovery.c
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open parenthesis '('
ERROR: code indent should use tabs where possible
Cc: Christian König
Cc: Alex Deucher
Cc: Mario Limonciello
Signe
ports
MST, DSC & FEC.")'
Suggested-by: Fangzhi Zuo
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
.../drm/amd/display/dc/link/protocols/link_dp_capability.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/pr
Include eDP v1.4 panels supported sink rates in debug output,
useful info for knowing optimized link rates
Cc: Aurabindo Pillai
Cc: Jerry Zuo
Signed-off-by: Srinivasan Shanmugam
---
.../gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c | 3 +++
1 file changed, 3 insertions(+)
diff
Fix following checkpatch errors in amdgpu_display.c
ERROR: spaces required around that '=' (ctx:VxW)
ERROR: that open brace { should be on the previous line
ERROR: else should follow close brace '}'
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
Fix the following checkpatch errors:
ERROR: trailing statements should be on next line
ERROR: space required after that ',' (ctx:VxV)
ERROR: code indent should use tabs where possible
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
.../gpu/drm/
sis '('
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 28 +++--
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
b/driver
ngle statement blocks
ERROR: that open brace { should be on the previous line
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 55 +++--
1 file changed, 24 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu
ngle statement blocks
ERROR: that open brace { should be on the previous line
Suggested-by: Christian König
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v2: (Christian)
- The casts to "void *" are completely superfluous in the first place.
drivers/gpu/
ING: Missing a blank line after declarations
WARNING: braces {} are not necessary for single statement blocks
WARNING: Comparisons should place the constant on the right side of the test
WARNING: printk() should include KERN_ facility level
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Sr
ING: Missing a blank line after declarations
WARNING: braces {} are not necessary for single statement blocks
WARNING: Comparisons should place the constant on the right side of the test
WARNING: printk() should include KERN_ facility level
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Sriniv
The following checkpatch warning is removed.
WARNING: Possible unnecessary 'out of memory' message
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
di
arm of this statement
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 27 +
1 file changed, 14 insertions(+), 13 deletions(
arm of this statement
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Validate the client_id and src_id values or otherwise
this can crash (Christian)
drivers/gpu/
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: else is not generally useful after a break or return
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 26 ++--
1 file changed, 13
races {} are not necessary for single statement blocks
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
permissions '0444'.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ob
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: else is not generally useful after a break or return
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Avoid mulitple return statements in amdgpu_dig_monitor_is_duallink
function
r->devices;
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff -
railing */ on a separate line
WARNING: Missing a blank line after declarations
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/dr
space required before the open parenthesis '('
WARNING: Missing a blank line after declarations
WARNING: please, no spaces at the start of a line
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
permissions '0444'.
Cc: Alex Deu
sible repeated word: 'we'
ERROR: space required before the open parenthesis '('
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 83 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 39 +
Fix below checkpatch warnings:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
WARNING: Comparisons should place the constant on the right side of the test
WARNING: Missing a blank line after declarations
Cc: Luben Tuikov
Cc: Alex Deucher
Cc: Christian König
Signe
v1_2.c:648:9: note: initialize the variable
'ret' to silence this warning
int ret;
^
= 0
1 error generated.
Cc: Luben Tuikov
Cc: Alex Deucher
Cc: Christian König
Cc: Lijo Lazar
Cc: Hawking Zhang
Signed-off-by: Srinivasan Shanmugam
---
driv
ret &= SOC15_WAIT_ON_RREG_OFFSET(
^~~
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c:767:9: note: initialize the variable
'ret' to silence this warning
int ret;
^
= 0
2 errors generated.
Cc: Luben Tuikov
Cc: Alex Deucher
Cc: Christian König
Cc: James Zhu
^
= 0
1 error generated.
Cc: Luben Tuikov
Cc: Alex Deucher
Cc: Christian König
Cc: Felix Kuehling
Cc: Mukul Joshi
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletio
uery_partition_mode(adev->xcp_mgr,
^~
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:1923:7: note: initialize the variable
'r' to silence this warning
int r, i, num_xcc;
^
= 0
1 error generated.
Cc: Luben Tuikov
Cc: Alex Deucher
Cc: Christ
ex Deucher
Cc: Christian König
Signed-off-by: Srinivasan Shanmugam
---
v2:
- init r = 0 (Lijo)
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
index e
efore that '++' (ctx:WxB)
WARNING: Block comments use a trailing */ on a separate line
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff
generated.
By guarding amdgpu_acpi_get_numa_info function,
only when CONFIG_ACPI_NUMA is enabled.
Cc: Christian König
Cc: Lijo Lazar
Cc: Luben Tuikov
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 ++
1 file changed, 2 insertions(+)
di
status_reg[] = {
^
1 error generated.
Mark the variable as __maybe_unused to make it clear to clang that this
is expected, so there is no more warning.
Cc: Christian König
Cc: Lijo Lazar
Cc: Luben Tuikov
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/
generated.
By guarding amdgpu_acpi_get_numa_info & amdgpu_acpi_get_numa_size
function, only when CONFIG_ACPI_NUMA is enabled.
Suggested-by: Lijo Lazar
Cc: Christian König
Cc: Lijo Lazar
Cc: Luben Tuikov
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Guard even amdgpu_acpi
‘amdgpu_acpi_get_dev’ [-Wmissing-prototypes]
There are no callers from other files, so just mark them as 'static'.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
’ set but
not used [-Wunused-but-set-variable]
630 | int r, i, j;
|
This variable is not used so remove them.
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 16
1 file changed, 4 insertions(+), 12
’ set but
not used [-Wunused-but-set-variable]
630 | int r, i, j;
|
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 27 +
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
index ad5368e151
used in gfx_v9_4_3.c, hence remove its
include in gfx_v9_4_3.c
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers/gpu/drm/amd
removed them.
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
.../drm/amd/display/dc/dcn32/dcn32_resource.c | 29 --
.../amd/display/dc/dcn321/dcn321_resource.c | 30 ---
2 files changed, 59 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc
, sq_int_errtype, sq_int_priv;
|
Remove unused sq_int_priv variable.
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd
ber 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush'
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v
rm/amd/amdgpu/sdma_v4_4_2.c:810: warning: Function parameter or
member 'inst_mask' not described in 'sdma_v4_4_2_inst_load_microcode'
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c:854: warning: Function parameter or
member 'inst_mask' not described in 'sdma_v4_4_2_inst_start
device.c:870: warning: Excess function
parameter 'pcie_data' description in 'amdgpu_device_indirect_wreg64'
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4
1 file changed, 4 deletions(-)
diff
cess function
parameter 'nid' description in 'amdgpu_acpi_get_node_id'
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
ream_update' not described in
'update_planes_and_stream_adapter'
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:374: warning:
Function parameter or member 'array_of_surface_update' not described in
'update_planes_and_stream_adapter'
Cc: Rodrigo Si
dml/dcn32/dcn32_fpu.c:2929: warning:
Function parameter or member 'context' not described in
'dcn32_find_vactive_pipe'
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:2929: warning:
Function parameter or member 'vactive_margin_req_us' not described in
'
Fix the following gcc with W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:292: warning: Cannot
understand * @create_dmamap_sg_bo: Creates a amdgpu_bo object to reflect
information
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd
ameter or
member 'xcc_id' not described in 'amdgpu_gfx_rlc_enter_safe_mode'
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:62: warning: Function parameter or
member 'xcc_id' not described in 'amdgpu_gfx_rlc_exit_safe_mode'
Cc: Christian König
Cc: Alex Deucher
Fix these warnings by adding 'xcp_id' argument.
gcc with W=1
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:160: warning: Function
parameter or member 'xcp_id' not described in 'amdgpu_amdkfd_reserve_mem_limit'
Cc: Christian König
Cc: Alex Deucher
Signe
Fix the following gcc with W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:292: warning: Cannot
understand * @create_dmamap_sg_bo: Creates a amdgpu_bo object to reflect
information
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
v2
/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:671: warning: Excess
function parameter 'adev' description in 'svm_migrate_vma_to_ram'
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:771: warning: Function
parameter or member 'fault_page' not described in 'svm_migrate_vra
ameter or
member 'xcc_id' not described in 'amdgpu_gfx_rlc_enter_safe_mode'
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:62: warning: Function parameter or
member 'xcc_id' not described in 'amdgpu_gfx_rlc_exit_safe_mode'
Cc: Christian König
Cc: Alex Deucher
.c:328: warning: Function parameter or
member 'inst' not described in 'gmc_v11_0_flush_gpu_tlb_pasid'
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:950: warning: Function parameter or
member 'inst' not described in 'gmc_v9_0_flush_gpu_tlb_pasid'
Cc: Christian König
Cc: Ale
Function
parameter or member 'inst' not described in 'kgd_gfx_v9_get_cu_occupancy'
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 8 +---
1 file changed, 5 insertion
Fix this warning by adding 'ring' arguments to kdoc.
gcc with W=1
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1128: warning: Function parameter or
member 'ring' not described in 'sdma_v6_0_ring_pad_ib'
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
Signe
Fixes the following W=1 kernel build warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_vba.c:936: warning:
Cannot understand *
*
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu
)
snprintf_count(char *pBuf, unsigned int bufSize, char *fmt, ...)
Cc: Hamza Mahfooz
Cc: Rodrigo Siqueira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
.../drm/amd/display/dc/dcn10/dcn10_hw_sequencer_debug.c | 9 +
1 file changed, 5 insertions(+), 4
, 0x02403C00, 0, 0, 0 } },
| ^~~~
Cc: Hamza Mahfooz
Cc: Rodrigo Siqueira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 9 -
1 file changed, 9 deletions(-)
diff
Siqueira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.c
b/drivers/gpu/drm/amd/display/dc
fw_based_vblank_stretch'
Cc: Hamza Mahfooz
Cc: Rodrigo Siqueira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
.../display/dc/dcn32/dcn32_resource_helpers.c | 56 ---
1 file changed, 22 insertions(+), 34 deletions(-)
diff --gi
:
warning: Function parameter or member 'pipe_ctx' not described in
'delay_cursor_until_vupdate'
Cc: Rodrigo Siqueira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 5 +
1 fil
:
warning: Function parameter or member 'pipe_ctx' not described in
'delay_cursor_until_vupdate'
Cc: Rodrigo Siqueira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 5 +
1 fil
esource_helpers.c:587:
warning: Function parameter or member 'context' not described in
'dcn32_can_support_mclk_switch_using_fw_based_vblank_stretch'
Cc: Hamza Mahfooz
Cc: Rodrigo Siqueira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan S
, 0x02403C00, 0, 0, 0 } },
| ^~~~
Suggested-by: Roman Li
Cc: Hamza Mahfooz
Cc: Rodrigo Siqueira
Cc: Harry Wentland
Cc: Aurabindo Pillai
Signed-off-by: Srinivasan Shanmugam
---
v2:
- Remove even unused IP_BASE_INSTANCE and IP_BASE struct definitions
Fixes the following gcc with W=1:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:1841: warning: Function
parameter or member 'event' not described in 'svm_range_evict'
Cc: Felix Kuehling
Cc: Christian König
Cc: Alex Deucher
Signed-off-by: Srinivasan Shanmugam
---
driver
201 - 300 of 617 matches
Mail list logo
