Re: [PATCH] drm/amd/gfx11: move the gfx mutex into the caller

e gfx mutex during soft reset\n"); return r; By moving locking and unlocking of the mutex to the gfx_v11_0_soft_reset function (the caller). This ensures that the mutex is always unlocked, regardless of whether (indicated by if (i >= adev->usec_timeout)) succeeds or fails. Acked-by: Srinivasan Shanmugam

[PATCH] drm/amdgpu/: Add missing kdoc entry in amdgpu_vm_handle_fault function

m_handle_fault' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index ad2e469548c9..0fa165e8fb

Re: [PATCH 1/2] drm/amdgpu/gfx11: return early in preempt_ib()

ing, this series is: Acked-by: Srinivasan Shanmugam

[PATCH v2] drm/amdgpu/: Add missing kdoc entry in amdgpu_vm_handle_fault function

ndle_fault' Cc: Xiaogang.Chen Cc: Christian König Cc: Alex Deucher Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202408251419.vgzhg3gv-...@intel.com/ Signed-off-by: Srinivasan Shanmugam --- v2: Added Reported-by (Xiaogang) drivers/gpu/drm/amd/amdgpu/a

[PATCH] drm/amd/display: Add missing kdoc entry for 'bs_coeffs_updated' in dpp401_dscl_program_isharp

Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c b/drivers/gpu/dr

[PATCH v2] drm/amd/display: Add missing kdoc entry for 'bs_coeffs_updated' in dpp401_dscl_program_isharp

rivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_dpp_dscl.c:961: warning: Function parameter or struct member 'bs_coeffs_updated' not described in 'dpp401_dscl_program_isharp' Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland

[PATCH] drm/amdgpu: Replace 'amdgpu_job_submit_direct' with 'drm_sched_entity' in cleaner shader

hader") Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 32 - drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 + 2 files changed, 17 insertions(+), 16 deletions(-) di

[PATCH] drm/amdgpu: Fix kdoc entry in 'amdgpu_vm_cpu_prepare'

mode' description in 'amdgpu_vm_cpu_prepare' Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c

[PATCH] drm/amd/display: Add kdoc entry for 'program_isharp_1dlut' in 'dpp401_dscl_program_isharp'

uct member 'program_isharp_1dlut' not described in 'dpp401_dscl_program_isharp' Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dpp/dcn401/d

[PATCH v2] drm/amdgpu: Replace 'amdgpu_job_submit_direct' with 'drm_sched_entity' in cleaner shader

hader") Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Christian König --- v2: - Dropped default assignment of f. (Christian) - Moved drm_sched entity; to stack from amdgpu_gfx structure. (Christian) drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH] drm/amdgpu/gfx9: Convert `//` to `/* ... */` in cleaner shader code

VGPRs, LDS, and lower SGPRs, and to clean remaining SGPRs. Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- .../amd/amdgpu/gfx_v9_4_3_cleaner_shader.asm | 139 +- 1 file changed, 72 insertions(+), 67 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH v2] drm/amdgpu/gfx9: Convert `//` to `/* ... */` in cleaner shader code

VGPRs, LDS, and lower SGPRs, and to clean remaining SGPRs. Fixes: 3b721dfb2c95 ("drm/amdgpu/gfx9: Add cleaner shader for GFX9.4.3") Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: - Corrected typo for iteraions - Added fixes tag .../

[PATCH 1/3] drm/amdgpu: Refactor cleaner shader initialization in amdgpu

ese values are now obtained directly from the adev->gfx structure inside the functions. Fixes: 63063b6c5a8d ("drm/amdgpu: Add infrastructure for Cleaner Shader feature") Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Christian König --- dri

[PATCH 2/3] drm/amdgpu/gfx9: Refactor cleaner shader initialization for GFX9

mplement cleaner shader support for GFX9 hardware") Cc: Christian König Cc: Alex Deucher Suggested-by: Christian König Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

[PATCH 3/3] drm/amdgpu/gfx9: Refactor cleaner shader initialization for GFX9.4.3

ted. Fixes: 1b66421d29b7 ("drm/amdgpu/gfx9: Implement cleaner shader support for GFX9.4.3 hardware") Cc: Christian König Cc: Alex Deucher Suggested-by: Christian König Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 17 ++--- 1 fil

[PATCH v2] drm/amd/display: Fix 'panel_cntl' could be null in 'dcn21_set_backlight_level()'

_cntl' could be null (see line 250) Fixes: 474ac4a875ca ("drm/amd/display: Implement some asic specific abm call backs.") Cc: Yongqiang Sun Cc: Anthony Koo Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- v2: - Add NULL check for timing gene

[PATCH] drm/amd/display: Add NULL test for 'timing generator' in 'dcn21_set_pipe()'

Koo Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../amd/display/dc/hwss/dcn21/dcn21_hwseq.c | 24 +++ 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c b/drivers/gpu/

[PATCH v3] drm/amd/display: Fix 'panel_cntl' could be null in 'dcn21_set_backlight_level()'

_cntl' could be null (see line 250) Fixes: 474ac4a875ca ("drm/amd/display: Implement some asic specific abm call backs.") Cc: Yongqiang Sun Cc: Anthony Koo Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- v3: - s/u32/uint32_t for consistency (Anth

[PATCH v2] drm/amd/display: Add NULL test for 'timing generator' in 'dcn21_set_pipe()'

Koo Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- v2: - s/u32/uint32_t for consistency (Anthony) .../amd/display/dc/hwss/dcn21/dcn21_hwseq.c | 24 +++ 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/

[PATCH] drm/amdgpu: Fix potential out-of-bounds access in 'amdgpu_discovery_reg_base_init()'

_inst' is within the bounds of the array before it is used as an index. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1289 amdgpu_discovery_reg_base_init() error: testing array offset 'adev->vcn.num_vcn_inst' after use. Cc: Christian König Cc: Alex Deucher Signe

[PATCH v2] drm/amdgpu: Fix potential out-of-bounds access in 'amdgpu_discovery_reg_base_init()'

_inst' is within the bounds of the array before it is used as an index. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1289 amdgpu_discovery_reg_base_init() error: testing array offset 'adev->vcn.num_vcn_inst' after use. Cc: Christian König Cc: Alex Deucher

[PATCH v3] drm/amdgpu: Fix potential out-of-bounds access in 'amdgpu_discovery_reg_base_init()'

instance mask for VCN and JPEG") Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v3: - Added fixes tag. drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_disc

[PATCH] drm/amd/display: Implement bounds check for stream encoder creation in DCN301

Roman Li Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../display/dc/resource/dcn301/dcn301_resource.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn301/dcn301_resource.c b/

[PATCH v2] drm/amd/display: Implement bounds check for stream encoder creation in DCN301

4 <= 5 Fixes: 3a83e4e64bb1 ("drm/amd/display: Add dcn3.01 support to DC (v2)") Cc: Roman Li Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/display/dc/resource/dcn301/dcn301_resource.c | 9 - 1 file changed, 4 insertions(+), 5

[PATCH] drm/amd/display: Initialize 'wait_time_microsec' variable in link_dp_training_dpia.c

168a97314 ("drm/amd/display: move dp link training logic to link_dp_training") Cc: Wenjing Liu Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/display/dc/link/protocols/link_dp_training_dpia.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] drm/amd/display: Fix possible NULL dereference on device remove/driver unload

usly assumed 'adev->dm.dc' could be null (see line 1943) Fixes: 006c26a0f1c8 ("drm/amd/display: Fix crash on device remove/driver unload") Cc: Andrey Grodzovsky Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/

[PATCH] drm/amd/display: Fix possible buffer overflow in 'find_dcfclk_for_voltage()'

>DcfClocks' 7 <= 7 Fixes: 3a83e4e64bb1 ("drm/amd/display: Add dcn3.01 support to DC (v2)") Cc: Roman Li Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c | 2 ++ 1 file changed, 2 inse

[PATCH] drm/amd/display: Fix possible use of uninitialized 'max_chunks_fbc_mode' in 'calculate_bandwidth()'

x_chunks_fbc_mode'. Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)") Cc: Harry Wentland Cc: Alex Deucher Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/basics/dce_calcs.c | 2 +- 1 file changed, 1 ins

[PATCH] drm/amd/display: Fix && vs || in 'edp_set_replay_allow_active()'

drm/amd/display: Add Functions to enable Freesync Panel Replay") Cc: Bhawanpreet Lakha Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/display/dc/link/protocols/link_edp_panel_control.c | 2 +- 1 file changed, 1 inse

[PATCH] drm/amdgpu/display: Initialize gamma correction mode variable in dcn30_get_gamcor_current()

low: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_dpp_cm.c:77 dpp30_get_gamcor_current() error: uninitialized symbol 'mode'. Fixes: 03f54d7d3448 ("drm/amd/display: Add DCN3 DPP") Cc: Bhawanpreet Lakha Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Tom Chung Signed-of

[PATCH v2] drm/amdgpu/display: Initialize gamma correction mode variable in dcn30_get_gamcor_current()

low: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_dpp_cm.c:77 dpp30_get_gamcor_current() error: uninitialized symbol 'mode'. Fixes: 03f54d7d3448 ("drm/amd/display: Add DCN3 DPP") Cc: Bhawanpreet Lakha Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Tom Chung Signed-of

Re: [PATCH v2] drm/amd/display: Add NULL test for 'timing generator' in 'dcn21_set_pipe()'

On 2/13/2024 12:07 AM, Kees Cook wrote: On Thu, Feb 01, 2024 at 03:28:45PM +0530, Srinivasan Shanmugam wrote: In "u32 otg_inst = pipe_ctx->stream_res.tg->inst;" pipe_ctx->stream_res.tg could be NULL, it is relying on the caller to ensure the tg is not NULL. Fixes: 474

[PATCH] drm/amdgpu: Drop unused function 'static void amdgpu_choose_low_power_state()' in amdgpu/amdgpu.h

tatic void amdgpu_choose_low_power_state(struct amdgpu_device *adev) { } | ^ cc1: all warnings being treated as errors Fixes: c1251e31ec25 ("drm/amd: Stop evicting resources on APUs in suspend") Cc: Mario Limonciello Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Sha

[PATCH] drm/amdgpu: Fix missing parameter descriptions in ih_v7_0.c

eter or member 'ih' not described in 'ih_v7_0_set_rptr' Fixes: b6ba7a165b13 ("drm/amdgpu: Add ih v7_0 ip block support") Cc: Likun Gao Cc: Hawking Zhang Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/ih_v

[PATCH] drm/amdgpu/display: Address kdoc for 'is_psr_su' in 'fill_dc_dirty_rects'

a...@vger.kernel.org Cc: Hamza Mahfooz Cc: Mario Limonciello Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdg

[PATCH] drm/amd/display: Add 'replay' NULL check in 'edp_set_replay_allow_active()'

uot;drm/amd/display: Add Functions to enable Freesync Panel Replay") Cc: Bhawanpreet Lakha Cc: Roman Li Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Tom Chung Suggested-by: Tom Chung Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/display/dc/link/protocols/link_edp_panel_control.

[PATCH] drm/amd/display: Fix potential null pointer dereference in dc_dmub_srv

Li Cc: Qingqing Zhuo Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Tom Chung Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/

[PATCH v2] drm/amd/display: Fix potential null pointer dereference in dc_dmub_srv

Li Cc: Qingqing Zhuo Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Tom Chung Signed-off-by: Srinivasan Shanmugam --- v2: - For dc_dmub_srv_is_hw_pwr_up() move 'dc_ctx = dc_dmub_srv->ctx;' below 'if (dc_dmub_srv->ctx->dc->debug.dmcub_em

[PATCH] drm/amd/display: Prevent potential buffer overflow in map_hw_resources

") Cc: Rodrigo Siqueira Cc: Roman Li Cc: Qingqing Zhuo Cc: Aurabindo Pillai Cc: Tom Chung Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_wrappe

[PATCH v2] drm/amd/display: Prevent potential buffer overflow in map_hw_resources

") Cc: Rodrigo Siqueira Cc: Roman Li Cc: Qingqing Zhuo Cc: Aurabindo Pillai Cc: Tom Chung Signed-off-by: Srinivasan Shanmugam --- v2: - fixes the below warnings due to incorrect line continuation string split across two lines /linux/drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml2

[PATCH v3] drm/amd/display: Prevent potential buffer overflow in map_hw_resources

c1b ("drm/amd/display: Introduce DML2") Cc: Rodrigo Siqueira Cc: Roman Li Cc: Qingqing Zhuo Cc: Aurabindo Pillai Cc: Tom Chung Signed-off-by: Srinivasan Shanmugam --- v3: - s/return/break as return may leave the system in a bad state drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper

[PATCH] drm/amd/amdgpu: Fix potential ioremap() memory leaks in amdgpu_device_init()

gpu/amdgpu_device.c:4337 amdgpu_device_init() warn: 'adev->rmmio' from ioremap() not released on lines: 4035,4045,4051,4058,4068,4337 Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 18 ++ 1

[PATCH] drm/amdgpu: Fix missing break in ATOM_ARG_IMM Case of atom_get_src_int()

("drm/amdgpu: add core driver (v4)") Cc: Jammy Zhou Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/atom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c b/drivers/gpu

[PATCH] drm/amd/display: Improve 'dml32_TruncToValidBPP()' function

/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:1680 dml32_TruncToValidBPP() warn: ignoring unreachable code. Fixes: dda4fb85e433 ("drm/amd/display: DML changes for DCN32/321") Cc: Rodrigo Siqueira Cc: Roman Li Cc: Aurabindo Pillai Cc: Tom Chung Signed-off-by: Srinivasan

[PATCH] drm/amd/display: Fix logical operator in get_meta_and_pte_attr()

p;& instead of & drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_rq_dlg_calc_31.c:622 get_meta_and_pte_attr() warn: maybe use && instead of & drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:710 get_meta_and_pte_attr() warn: maybe use &

[PATCH] drm/amd/display: Remove redundant condition in dcn35_calc_blocks_to_gate()

ueira Cc: Roman Li Cc: Aurabindo Pillai Cc: Tom Chung Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c b/drive

Re: [PATCH] drm/amd/amdgpu: Fix potential ioremap() memory leaks in amdgpu_device_init()

Hi Christian, On 2/26/2024 1:46 PM, Christian König wrote: Am 24.02.24 um 07:38 schrieb Srinivasan Shanmugam: This ensures that the memory mapped by ioremap for adev->rmmio, is properly handled in amdgpu_device_init(). If the function exits early due to an error, the memory is unmapped. If

[PATCH v2] drm/amd/amdgpu: Fix potential ioremap() memory leaks in amdgpu_device_init()

gpu/amdgpu_device.c:4337 amdgpu_device_init() warn: 'adev->rmmio' from ioremap() not released on lines: 4035,4045,4051,4058,4068,4337 Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- v2: - updated commit message - use a goto label and error handling in

[PATCH] drm/amdgpu: Fix potential truncation by increasing SMU_FW_NAME_LEN

er Cc: Lijo Lazar Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h index a870bdd49a4e..3d98b0e

[PATCH] drm/amdgpu: Fix multiple truncation issues in multiple driver files

ay be truncated writing 8 bytes into a region of size between 4 and 33 [-Wformat-truncation=] Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c| 2 +- drivers/gpu

[PATCH] drm/amd/display: Fix potential index out of bounds in color transformation function

m_helper_translate_curve_to_hw_format() error: buffer overflow 'output_tf->tf_pts.blue' 1025 <= s32max Fixes: b629596072e5 ("drm/amd/display: Build unity lut for shaper") Cc: Vitaly Prosyak Cc: Charlene Liu Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Roman Li Cc: Aurabi

[PATCH] drm/amdgpu: Fix potential Spectre vulnerability in amdgpu_gfx_parse_disable_cu()

k' [w] Fixes: 6f8941a23088 ("drm/amdgpu: add disable_cu parameter") Cc: Nicolai Hähnle Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/g

Re: [PATCH] drm/amdgpu: Fix the iounmap error of rmmio

Acked-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 39dd76e57154..d65a6aabefbb 100644 --- a/drive

[PATCH] drm/amdgpu: Fix truncation issues in smu_v13_0_init_microcode

bytes into a destination of size 30 108 | snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin", ucode_prefix); | ^ Cc: Alex Deucher Cc: Christian König Signed-off-by: Srinivasan Shanmugam Sugg

[PATCH] drm/amd/display: Address kdoc for commit_minimal_transition_state_in_dc_update()

7; description in 'commit_minimal_transition_state_in_dc_update' Cc: Wenjing Liu Cc: Alex Hung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Aurabindo Pillai Cc: Tom Chung Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +++- 1 file changed, 3 insertions(+)

[PATCH] drm/amdgpu: Fix format character cut-off issues in amdgpu_vcn_early_init()

_name, sizeof(fw_name), "amdgpu/%s_%d.bin", ucode_prefix, i); | ^~~ Cc: Alex Deucher Cc: Christian König Suggested-by: Lijo Lazar Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH] drm/amdgpu: Fix format character cut-off issues in amdgpu_vcn_early_init()

On 3/20/2024 3:12 PM, Lazar, Lijo wrote: On 3/20/2024 2:15 PM, Srinivasan Shanmugam wrote: The issue was present in the lines where 'fw_name' was being formatted. This fix ensures that the output is not truncated Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH v2] drm/amdgpu: Fix format character cut-off issues in amdgpu_vcn_early_init()

0 105 | snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_%d.bin", ucode_prefix, i); | ^~~ Cc: Alex Deucher Cc: Christian König Suggested-by: Lijo Lazar Signed-off

[PATCH] drm/amdgpu: Fix 'fw_name' buffer size to prevent truncations in amdgpu_mes_init_microcode

^~~~ drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1489:17: note: ‘snprintf’ output between 16 and 45 bytes into a destination of size 40 1489 | snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mes.bin", | ^~~~~~

[PATCH] drm/amdgpu: Fix truncation issues in gfx_v9_0.c

drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:1358:25: note: ‘snprintf’ output between 17 and 46 bytes into a destination of size 30 1358 | snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mec2.bin", chip_name); | ^~~~

[PATCH] drm/amdgpu: Fix truncations in gfx_v11_0_init_microcode()

CC [M] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_clockpowergating.o Cc: Alex Deucher Cc: Christian König Suggested-by: Lijo Lazar Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH] drm/amdgpu: Fix truncation in gfx_v10_0_init_microcode

t between 17 and 50 bytes into a destination of size 40 4024 | snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mec2%s.bin", ucode_prefix, wks); | ^~~~~ Cc: Alex Deucher Cc: Christian König Suggested-by: Lijo Lazar Signed-off-by: Srinivasan Shanmugam --- drivers/

[PATCH] drm/amdgpu: Fix truncation in smu_v11_0_init_microcode

quot;, ucode_prefix); | ^ Cc: Alex Deucher Cc: Christian König Suggested-by: Lijo Lazar Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[PATCH] drm/amd/display: Add missing parameter desc in dc_commit_streams

dgpu/../display/dc/core/dc.c:2138: warning: Excess function parameter 'stream_count' description in 'dc_commit_streams' Fixes: 515023b2ce5f ("drm/amd/display: Add handling for DC power mode") Cc: Joshua Aberback Cc: Rodrigo Siqueira Cc: Roman Li Cc: Aurabindo Pillai C

[PATCH] drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor

8444 DRM_ERROR("DC failed to set cursor position\n"); 8445 8446 update->cursor_position = &crtc_state->stream->cursor_position; 8447 } 8448 } Fixes: 66eba12a5482 ("drm/amd/display: Do cursor progr

[PATCH] drm/amd/display: Add NULL check for 'afb' before dereferencing in amdgpu_dm_plane_handle_cursor_update

Harry Wentland Signed-off-by: Srinivasan Shanmugam --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu

[PATCH] drm/amdgpu: Move SR-IOV check into amdgpu_gfx_sysfs_compute_init

future the conditions for creating the compute partition sysfs entries change, we would only need to update the amdgpu_gfx_sysfs_compute_init function. Cc: Alex Deucher Cc: Christian König Suggested-by: Christian König Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu: Move SR-IOV check into amdgpu_gfx_sysfs_compute_init

On 6/6/2024 10:58 PM, Lazar, Lijo wrote: On 6/6/2024 5:35 PM, Srinivasan Shanmugam wrote: Previously, this check was performed in the gfx_v9_4_3_sw_init function, and the amdgpu_gfx_sysfs_compute_init function was only called if the GPU was not a VF in SR-IOV mode. This is because the sysfs

[PATCH] drm/amdgpu: Add NULL check for imu.funcs in gfx_v11_0_rlc_backdoor_autoload_enable

Unchecked dereference inside the function. 4505 return r; 4506 } else { Fixes: 3d879e81f0f9 ("drm/amdgpu: add init support for GFX11 (v2)") Reported-by: Dan Carpenter Cc: Hawking Zhang Cc: Alex Deucher Cc: Christian König

[PATCH] drm/amdgpu/acpi: Add NULL check for event->device_class in amdgpu_atif_handler

ing is defined here 452 | DRM_DEBUG_DRIVER("event, device_class = %s, type = %#x\n", | Cc: Alex Deucher Cc: Christian König Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH] drm/amd/display: Add checks to prevent buffer overflow in mod_hdcp_dump_binary_message

uf_pos], "%02X ", msg[i]); | ^~~ Cc: Wenjing Liu Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Signed-off-by: Srinivasan Shanmugam --- drivers

[PATCH] drm/amd/display: Add null check for dm_state in create_validate_stream_for_sink

ot;drm/amd/display: Fix ineffective setting of max bpc property") Reported-by: Dan Carpenter Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd

[PATCH] drm/amd/display: Add null check for set_output_gamma in dcn30_set_output_transfer_func

hen it will crash 402 return ret; 403 } Fixes: d99f13878d6f ("drm/amd/display: Add DCN3 HWSEQ") Reported-by: Dan Carpenter Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed

[PATCH v2] drm/amd/display: Add null check for dm_state in create_validate_stream_for_sink

ot;drm/amd/display: Fix ineffective setting of max bpc property") Reported-by: Dan Carpenter Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- v2: s/DRM_ERROR/d

Re: [PATCH v2] drm/amd/display: Add null check for dm_state in create_validate_stream_for_sink

I think we can ignore this change, as it already exists in the below commit of asdn. commit b90c2f233397f40c757995b9c00f8c6e380c6913 Author: Alex Hung Date:   Thu Jun 27 17:38:16 2024 -0600 drm/amd/display: Check null pointers before using them On 7/17/2024 8:10 AM, Srinivasan Shanmugam

[PATCH] drm/amd/display: Add 'pstate_keepout' kdoc entry in 'optc1_program_timing'

Fixes the below with gcc W=1: Function parameter or struct member 'pstate_keepout' not described in 'optc1_program_timing' Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by:

[PATCH] drm/amd/display: Implement bounds check for stream encoder creation in DCN401

<= 5 Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] drm/amd/display: Add NULL check for clk_mgr in dcn32_init_hw

Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/

[PATCH] drm/amd/display: Add NULL check for clk_mgr in dcn30_init_hw

Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn30/

[PATCH] drm/amd/display: Add null check for set_output_gamma in dcn30_set_output_transfer_func

hen it will crash 402 return ret; 403 } Fixes: d99f13878d6f ("drm/amd/display: Add DCN3 HWSEQ") Reported-by: Dan Carpenter Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed

[PATCH] drm/amd/display: Add NULL check for clk_mgr in dcn401_init_hw

Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c| 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dc

[PATCH] drm/amd/display: Fix index out of bounds in DCN30 color transformation

s/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_cm_common.c:182 cm3_helper_translate_curve_to_hw_format() error: buffer overflow 'output_tf->tf_pts.blue' 1025 <= s32max Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Sri

[PATCH] drm/amd/display: Fix index out of bounds in DCN30 degamma hardware format translation

25 <= s32max drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_cm_common.c:340 cm3_helper_translate_curve_to_degamma_hw_format() error: buffer overflow 'output_tf->tf_pts.blue' 1025 <= s32max Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pill

[PATCH] drm/amd/display: Fix index out of bounds in degamma hardware format translation

cm_helper_translate_curve_to_degamma_hw_format() error: buffer overflow 'output_tf->tf_pts.blue' 1025 <= s32max Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam ---

[PATCH 1/2] drm/amd/display: Add null check for head_pipe in dcn201_acquire_free_pipe_for_layer

queira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/dc/resource/dcn201/dcn201_resource.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/d

[PATCH 2/2] drm/amd/display: Add null check for head_pipe in dcn32_acquire_idle_pipe_for_head_pipe_in_layer

Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c| 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/g

[PATCH v2] drm/amd/display: Add NULL check for clk_mgr and clk_mgr->funcs in dcn30_init_hw

Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- v2: Along with "dc->clk_mgr" add check for even dc->clk_mgr->funcs" (Tom) drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c | 7 --- 1 file

[PATCH v2] drm/amd/display: Add NULL check for clk_mgr in dcn32_init_hw

Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- v2: Along with "dc->clk_mgr" add check for even dc->clk_mgr->funcs" (Tom) drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v2] drm/amd/display: Add NULL check for clk_mgr and clk_mgr->funcs in dcn401_init_hw

Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- v2: Along with "dc->clk_mgr" add check for even dc->clk_mgr->funcs" (Tom) drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 8 +---

[PATCH v2] drm/amd/display: Add null check for set_output_gamma in dcn30_set_output_transfer_func

hen it will crash 402 return ret; 403 } Fixes: d99f13878d6f ("drm/amd/display: Add DCN3 HWSEQ") Reported-by: Dan Carpenter Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz

[PATCH] drm/amd/display: Add kdoc entry for 'bs_coeffs_updated' in dpp401_dscl_program_isharp

d ISHARP coefficients are programmed together") Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 1 + 1 file

[PATCH] drm/amd/display: Add null check for pipe_ctx->plane_state in dcn20_program_pipe

Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 30 --- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/di

[PATCH] drm/amd/display: Add null check for top_pipe_to_program in commit_planes_for_stream

Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/core/dc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index b8a6c062426d..95

[PATCH] drm/amdkfd: Fix missing error code in kfd_queue_acquire_buffers

_err_release: 313 kfd_queue_release_buffers(pdd, properties); 314 return err; 315 } Fixes: 629568d25fea ("drm/amdkfd: Validate queue cwsr area and eop buffer size") Reported-by: Dan Carpenter Cc: Philip Yang Cc: Felix Kuehling Cc: Christian König Cc

[PATCH] drm/amd/display: Handle null 'stream_status' in 'planes_changed_for_existing_stream'

i Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_res

[PATCH] drm/amd/display: Align 'dpp401_dscl_program_isharp' with actual function parameters

oman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_dscl.c b/driv

[PATCH 1/3] drm/amd/display: Add NULL check for function pointer in dcn20_set_output_transfer_func

Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c

[PATCH 3/3] drm/amd/display: Add NULL check for function pointer in dcn401_set_output_transfer_func

Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn401

[PATCH 2/3] drm/amd/display: Add NULL check for function pointer in dcn32_set_output_transfer_func

Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn32

[PATCH v2 1/2] drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor (v2)

hung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Co-developed-by: Alex Hung Signed-off-by: Alex Hung Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

  1   2   3   4   5   6   >