Re: [PATCH v6 5/8] drm/i915: Enable async flips on the primary plane

2024-06-14 Thread Rodrigo Vivi
On Fri, Jun 14, 2024 at 12:35:32PM -0300, André Almeida wrote: > This driver can perfom async flips on primary planes, so enable it. > Cc: Ville Syrjälä Cc: Naveen Kumar c: Vandita Kulkarni > Signed-off-by: André Almeida > --- > drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++ > 1 file ch

Re: [PATCH v5] drm/display: split DSC helpers from DP helpers

2024-06-26 Thread Rodrigo Vivi
o: David Airlie > To: Daniel Vetter > To: Maarten Lankhorst > To: Maxime Ripard > To: Thomas Zimmermann > To: Jani Nikula > To: Joonas Lahtinen > To: Rodrigo Vivi > To: Tvrtko Ursulin > To: Rob Clark > To: Abhinav Kumar > To: Sean Paul > To: Marijn Suijten

Re: [PATCH v1 03/12] drm/i915: Make I2C terminology more inclusive

2024-04-30 Thread Rodrigo Vivi
ned-off-by: Easwar Hariharan I'm glad to see this change! Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/dvo_ch7017.c | 14 - > drivers/gpu/drm/i915/display/dvo_ch7xxx.c | 18 +-- > drivers/gpu/drm/i915/display/dvo_ivch.c |

Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive

2024-05-03 Thread Rodrigo Vivi
r users of > I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists > in the specification. > > Compile tested, no functionality changes intended > > [1]: > https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ > > Revie

Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive

2024-05-03 Thread Rodrigo Vivi
On Fri, May 03, 2024 at 02:04:15PM -0700, Easwar Hariharan wrote: > On 5/3/2024 12:34 PM, Rodrigo Vivi wrote: > > On Fri, May 03, 2024 at 06:13:24PM +, Easwar Hariharan wrote: > >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced > >> "master/s

Re: [PATCH 08/11] drm/i915: Use drm_fbdev_helper_client_unregister()

2024-05-07 Thread Rodrigo Vivi
at the releasing after the unprepare sounds more logical, but if there's no actual issue with that and it is working for everybody, let's do that. Reviewed-by: Rodrigo Vivi Acked-by: Rodrigo Vivi (to get through drm-misc with everything else if you prefer) > - kfree(fb_helpe

Re: misc vgaarb cleanups

2021-07-16 Thread Rodrigo Vivi
t; drivers/gpu/drm/i915/display/intel_vga.c |9 +- The parts touching i915 looks clean to me Acked-by: Rodrigo Vivi > drivers/gpu/drm/nouveau/nouveau_vga.c |8 - > drivers/gpu/drm/radeon/radeon_device.c | 11 +- > drivers/gpu/vga/vgaarb.c | 67 +++

Re: [Intel-gfx] [PATCH 0/4] managed drm_device, absolute final leftover bits

2020-09-18 Thread Rodrigo Vivi
gt; > - bugfixed i915 selftests > > - patch from Luben to finalize the admgpu conversion > > > > Alex & i915 maintainers, pls ack for merging this all through > > drm-misc-next since otherwise the final patch (and the resulting confusion > > with outdated

Re: [Intel-gfx] [PATCH 19/30] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-02-23 Thread Rodrigo Vivi
one already solves the issue... Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- > drivers/gpu/drm/drm_dp_helper.c | 3 ++- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +- > drive

Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

2023-09-06 Thread Rodrigo Vivi
On Mon, Sep 04, 2023 at 08:32:40AM +0200, Andi Shyti wrote: > Hi Jim, > > On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > > By at least strong convention, a print-buffer's trailing newline says > > "message complete, send it". The exception (no TNL, followed by a call > > to pr_cont

Re: [Intel-gfx] [PATCH v2 2/3] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-01-18 Thread Rodrigo Vivi
On Thu, Jan 12, 2023 at 09:11:55PM +0100, Thomas Zimmermann wrote: > Set the framebuffer info for drivers that support VGA switcheroo. Only > affects the amdgpu and nouveau drivers, which use VGA switcheroo and > generic fbdev emulation. For other drivers, this does nothing. > > This fixes a poten

Re: [Intel-gfx] [PATCH v2 2/3] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-01-19 Thread Rodrigo Vivi
On Thu, Jan 19, 2023 at 09:06:54AM +0100, Thomas Zimmermann wrote: > Hi > > Am 18.01.23 um 20:21 schrieb Rodrigo Vivi: > > On Thu, Jan 12, 2023 at 09:11:55PM +0100, Thomas Zimmermann wrote: > > > Set the framebuffer info for drivers that support VGA switcheroo. Only >

Re: [PATCH v2] drm: Spelling s/sempahore/semaphore/

2023-07-17 Thread Rodrigo Vivi
ernal fence >* that may fail catastrophically, then we want to avoid using > - * sempahores as they bypass the fence signaling metadata, and we > + * semaphores as they bypass the fence signaling metadata, and we >* lose the fence->error propagation. >

Re: [PATCH v7] drm/doc: Document DRM device reset expectations

2023-08-23 Thread Rodrigo Vivi
On Fri, Aug 18, 2023 at 05:06:42PM -0300, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida > > --- > > v7 changes: > - s/application/graphical API contex/ in the robustness part (Miche

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Rodrigo Vivi
On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > > - Sticking to fdo bugzilla and disabling gitlab issues for at least > > drm-intel for the time being. Doing that migration in the same go is a > > bit much I think. Reass

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Rodrigo Vivi
On Wed, Aug 22, 2018 at 05:37:22PM +0100, Daniel Stone wrote: > Hi Rodrigo, > > On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote: > > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: > > > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > > >

Re: [PATCH v2 06/34] drm/i915: convert put_page() to put_user_page*()

2019-08-05 Thread Rodrigo Vivi
their APIs. Later, i915_gem_userptr_put_pages() > can be simplified to use put_user_pages_dirty_lock(). Thanks for that. with this version we won't have any conflict. Ack for going through mm tree. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi >

Re: [PATCH v3] docs/gpu: ci: update flake tests requirements

2024-09-27 Thread Rodrigo Vivi
sue: > +amdgpu driver: https://gitlab.freedesktop.org/drm/amd/-/issues > +i915 driver: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues Probably good to add: xe driver: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues Acked-by: Rodrigo Vivi > +msm driver: https://gitlab.freedesktop.org/drm/msm/-/issues > + > drivers/gpu/drm/ci/${DRIVER_NAME}-${HW_REVISION}-skips.txt > --- > > -- > 2.43.0 >

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-17 Thread Rodrigo Vivi
On Thu, Oct 17, 2024 at 09:59:10AM +0200, Christian König wrote: > Am 17.10.24 um 04:47 schrieb Raag Jadav: > > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > > > Introduce device wedged event, which will notify userspace of wedged > > > (hanged/unusable) state of the DRM device thro

Re: [PATCH v12 4/5] drm/i915: Use device wedged event

2025-02-04 Thread Rodrigo Vivi
On Tue, Feb 04, 2025 at 12:35:27PM +0530, Raag Jadav wrote: > Now that we have device wedged event provided by DRM core, make use > of it and support both driver rebind and bus-reset based recovery. > With this in place, userspace will be notified of wedged device on > gt reset failure. > > Signed

Re: [PATCH v12 3/5] drm/xe: Use device wedged event

2025-02-04 Thread Rodrigo Vivi
d) > v3: Generic implementation in DRM subsystem (Lucas) > v4: Change authorship to Raag (Aravind) > > Signed-off-by: Raag Jadav > Reviewed-by: Aravind Iddamsetty Acked-by: Rodrigo Vivi to merge this through drm-misc-next > --- > drivers/gpu/drm/xe/xe_device.c | 7 ++- &

Re: [PATCH v12 0/5] Introduce DRM device wedged event

2025-02-12 Thread Rodrigo Vivi
On Wed, Feb 12, 2025 at 08:57:10AM +0200, Raag Jadav wrote: > On Tue, Feb 04, 2025 at 12:35:23PM +0530, Raag Jadav wrote: > > This series introduces device wedged event in DRM subsystem and uses it > > in xe, i915 and amdgpu drivers. Detailed description in commit message. > > > > This was earlier

Re: [PATCH v12 0/5] Introduce DRM device wedged event

2025-02-13 Thread Rodrigo Vivi
On Wed, Feb 12, 2025 at 01:25:05PM -0500, Rodrigo Vivi wrote: > On Wed, Feb 12, 2025 at 08:57:10AM +0200, Raag Jadav wrote: > > On Tue, Feb 04, 2025 at 12:35:23PM +0530, Raag Jadav wrote: > > > This series introduces device wedged event in DRM subsystem and uses it > >

Re: [PATCH v2 1/3] drm: Create an app info option for wedge events

2025-05-12 Thread Rodrigo Vivi
rs/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index c02c4c4e9412..f329613e061f 100644 > --- a/drivers/gpu/drm/xe/xe_device.c > +++ b/drivers/gpu/drm/xe/xe_device.c > @@ -1168,7 +1168,8 @@ void xe_device_declare_wedged(struct xe_device *xe) > > /* Notif