Re: [PATCH] drm/amdgpu/display: Address kdoc for 'is_psr_su' in 'fill_dc_dirty_rects'

On 2/15/24 05:57, Srinivasan Shanmugam wrote: The is_psr_su parameter is a boolean flag indicating whether the Panel Self Refresh Selective Update (PSR SU) feature is enabled which is a power-saving feature that allows only the updated regions of the screen to be refreshed, reducing the amount

Re: [PATCH] drm/amd/display: clean unnecessary braces

Hi Túlio, First of all thanks for your patch. See my comments inline. On 2/17/24 13:20, Túlio Fernandes wrote: Clean unnecessary braces in dc/dcn32/dcn32_resource_helpers.c and dc/dcn32/dcn201_link_encoder.c Did you identify this issue with checkpatch? If so, I recommend you paste the error

Re: [PATCH] drm/amd/display: Use kcalloc() instead of kzalloc()

On 1/28/24 02:04, Lenko Donchev wrote: We are trying to get rid of all multiplications from allocation functions to prevent integer overflows. Here the multiplication is obviously safe, but using kcalloc() is more appropriate and improves readability. This patch has no effect on runtime behavi

Re: [PATCH v5 7/8] drm/amd/display: Introduce KUnit tests to dc_dmub_srv library

On 2/26/24 04:12, Jani Nikula wrote: On Thu, 22 Feb 2024, Rodrigo Siqueira wrote: diff --git a/drivers/gpu/drm/amd/display/test/kunit/.kunitconfig b/drivers/gpu/drm/amd/display/test/kunit/.kunitconfig index eb6f81601757..4c5861ad58bd 100644 --- a/drivers/gpu/drm/amd/display/test/kunit/.kuni

Re: [PATCH] drm/amd/display: Address kdoc for commit_minimal_transition_state_in_dc_update()

On 3/18/24 6:50 AM, Srinivasan Shanmugam wrote: Adds descriptions for 'new_context', 'srf_updates', and 'surface_count', and removes the excess description for 'context'. Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4411: warning: Function parameter or mem

Re: [PATCH] drm/amd/display: Improve 'dml32_TruncToValidBPP()' function

On 2/23/24 11:39 PM, Srinivasan Shanmugam wrote: Refactors the dml32_TruncToValidBPP function by removing a redundant return statement. The function previously had a return statement at the end that was never executed because all execution paths in the function ended with a return statement b

Re: [PATCH] drm/amd/display: Remove redundant condition in dcn35_calc_blocks_to_gate()

On 2/23/24 11:39 PM, Srinivasan Shanmugam wrote: pipe_ctx->plane_res.mpcc_inst is of a type that can only hold values between 0 and 255, so it's always greater than or equal to 0. Thus the condition 'pipe_ctx->plane_res.mpcc_inst >= 0' was always true and has been removed. Fixes the below: d

Re: [PATCH] Revert "drm/amd/display: Fix sending VSC (+ colorimetry) packets for DP/eDP displays without PSR"

On 3/12/24 9:24 AM, Harry Wentland wrote: This causes flicker on a bunch of eDP panels. The info_packet code also caused regressions on other OSes that we haven't' seen on Linux yet, but that is likely due to the fact that we haven't had a chance to test those environments on Linux. We'll nee

Re: [PATCH] drm/amd/display: Fix null pointer deref in dcn20_resource.c

On 6/26/24 11:16 AM, Aurabindo Pillai wrote: Fixes a hang that has the following calltrace: [ 181.843989] BUG: kernel NULL pointer dereference, address: [ 181.843997] #PF: supervisor instruction fetch in kernel mode [ 181.844003] #PF: error_code(0x0010) - not-present page

Re: [PATCH v2] drm/amd/display: Fix null pointer deref in dcn20_resource.c

On 6/26/24 4:28 PM, Aurabindo Pillai wrote: Changes in v2: detailed description about the how the issue is reproduced, and remove an extraneous else keyword. Just remove this 'Changes in v2' part, with this change: Reviewed-by: Rodrigo Siqueira Fixes a hang thats triggered when MPV is r

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

On 6/28/24 9:19 AM, Alex Deucher wrote: On Fri, Jun 21, 2024 at 6:45 AM Mikhail Gavrilov wrote: On Fri, Jun 21, 2024 at 12:56 PM Linux regression tracking (Thorsten Leemhuis) wrote: Hmmm, I might have missed something, but it looks like nothing happened here since then. What's the status?

Re: [PATCH] drm/amd/display/dc: Remove dc code repetition

Hi Joao, First of all, thanks for your patch. Follows some of my comments: > On 6/13/24 10:05 AM, Joao Paulo Pereira da Silva wrote: You can drop the dc part in the commit title. Also, the title should highlight that you are decoupling one part of the code in a single place to avoid duplicati

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

On 6/29/24 5:18 PM, Mikhail Gavrilov wrote: On Sat, Jun 29, 2024 at 9:46 PM Rodrigo Siqueira Jordao wrote: Hi Mikhail, I'm trying to reproduce this issue, but until now, I've been unable to reproduce it. I tried some different scenarios with the following components: 1. Display

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

On 7/9/24 6:41 AM, Linux regression tracking (Thorsten Leemhuis) wrote: On 30.06.24 01:18, Mikhail Gavrilov wrote: On Sat, Jun 29, 2024 at 9:46 PM Rodrigo Siqueira Jordao wrote: I'm trying to reproduce this issue, but until now, I've been unable to reproduce it. I tried some

Re: [PATCH v2] drm/amd/display: Add otg_master NULL check within init_pipe_slice_table_from_context

On 7/9/24 3:10 AM, Ma Ke wrote: To avoid reports of NULL_RETURN warning, we should add otg_master NULL check. Cc: sta...@vger.kernel.org Fixes: c51d87202d1f ("drm/amd/display: do not attempt ODM power optimization if minimal transition doesn't exist") Signed-off-by: Ma Ke --- Changes in v2: -

Re: [PATCH] drm/amd/display: fix corruption with high refresh rates on DCN 3.0

On 7/16/24 11:33 AM, Alex Deucher wrote: This reverts commit bc87d666c05a13e6d4ae1ddce41fc43d2567b9a2 and the register changes from commit 6d4279cb99ac4f51d10409501d29969f687ac8dc. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3478 Cc: mikhail.v.gavri...@gmail.com Cc: Rodrigo Siquei

Re: [PATCH] drm/amd/display: Add kdoc entry for 'bs_coeffs_updated' in dpp401_dscl_program_isharp

On 7/22/24 7:15 AM, Srinivasan Shanmugam wrote: Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_dpp_dscl.c:961: warning: Function parameter or struct member 'bs_coeffs_updated' not described in 'dpp401_dscl_program_isharp' Fixes: 431ae65ea4e1 ("drm/a

Re: [PATCH 22/24] drm/amd/display: Adjust cursor position

On 8/8/24 4:06 PM, Melissa Wen wrote: On 07/08/2024 04:55, Tom Chung wrote: From: Rodrigo Siqueira [why & how] When the commit 9d84c7ef8a87 ("drm/amd/display: Correct cursor position on horizontal mirror") was introduced, it used the wrong calculation for the position copy for X. This com

Re: [PATCH RESEND] drm/amd/display: Fix division by zero in setup_dsc_config

On 4/22/24 8:35 AM, Jose Fernandez wrote: When slice_height is 0, the division by slice_height in the calculation of the number of slices will cause a division by zero driver crash. This leaves the kernel in a state that requires a reboot. This patch adds a check to avoid the division by zero.

Re: [PATCH] drm/amd/display: use mpcc_count to log MPC state

On 4/12/24 10:39 AM, Melissa Wen wrote: According to [1]: ``` DTN only logs 'pipe_count' instances of MPCC. However in some cases there are different number of MPCC than DPP (pipe_count). ``` As DTN log still relies on pipe_count to print mpcc state, switch to mpcc_count in all occurrences.

Re: [PATCH] drm/amd/display: Remove duplicated function signature from dcn3.01 DCCG

On 2/22/24 7:19 AM, David Tadokoro wrote: In the header file dc/dcn301/dcn301_dccg.h, the function dccg301_create is declared twice, so remove duplication. Signed-off-by: David Tadokoro --- drivers/gpu/drm/amd/display/dc/dcn301/dcn301_dccg.h | 6 -- 1 file changed, 6 deletions(-) dif

Re: [PATCH 1/2] drm/amd/display: clean inconsistent indenting

On 2/13/24 3:43 PM, Joao Paulo Pereira da Silva wrote: From: jppaulo Clean some wrong indenting that throw errors in checkpatch. Signed-off-by: Joao Paulo Pereira da Silva --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH] drm/amd/display: fix documentation warnings for mpc.h

Hi Marcelo, First of all, thanks a lot for your patch! Please check some of my inline comments. On 4/27/24 10:05 AM, Marcelo Mendes Spessoto Junior wrote: Fix most of the display documentation compile warnings by documenting struct mpc_funcs functions in dc/inc/hw/mpc.h file. Could you add

Re: [PATCH v3 1/9] drm/amd/display: decouple color state from hw state log

On 11/28/23 10:52, Melissa Wen wrote: Prepare to hook up color state log according to the DCN version. v3: - put functions in single line (Siqueira) Signed-off-by: Melissa Wen --- .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 26 +-- 1 file changed, 18 insertions(+), 8

Re: [PATCH v3 3/9] drm/amd/display: read gamut remap matrix in fixed-point 31.32 format

On 11/28/23 10:52, Melissa Wen wrote: Instead of read gamut remap data from hw values, convert HW register values (S2D13) into a fixed-point 31.32 matrix for color state log. Change DCN10 log to print data in the format of the gamut remap matrix. Signed-off-by: Melissa Wen --- .../amd/disp

Re: [PATCH] drm/amd/display: Disable IPS by default

On 12/20/23 12:30, roman...@amd.com wrote: From: Roman Li [Why] Instability is observed on DCN35 if idle power optimization is enabled. [How] Disable IPS until issue is resolved. Signed-off-by: Roman Li Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2

Re: [PATCH v2] drm/amd/display: Address function parameter 'context' not described in 'dc_state_rem_all_planes_for_stream' & 'populate_subvp_cmd_drr_info'

On 12/21/23 09:28, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_state.c:524: warning: Function parameter or member 'state' not described in 'dc_state_rem_all_planes_for_stream' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc

Re: [PATCH] drm/amd/display: Adjust kdoc for 'dcn35_hw_block_power_down' & 'dcn35_hw_block_power_up'

On 12/19/23 00:37, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn35/dcn35_hwseq.c:1124: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Charlene Liu C

Re: [PATCH v2] drm/amd/display: Adjust kdoc for 'dcn35_hw_block_power_down' & 'dcn35_hw_block_power_up'

On 12/21/23 10:13, Srinivasan Shanmugam wrote: Fixes the following gcc with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn35/dcn35_hwseq.c:1124: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Charlene Liu C

Re: [PATCH 1/1] Revert "drm/amd/display: fix bandwidth validation failure on DCN 2.1"

On 1/7/24 11:51, Melissa Wen wrote: On 01/06, LIPSKI, IVAN wrote: [AMD Official Use Only - General] @Siqueira, Rodrigo From: LIPSKI, IVAN Sent: January 5, 2024 7:40 PM To: amd-gfx@lists.freedesktop.org Cc: rodrigo.siqui...@a

Re: [PATCH] drm/amd/display: cleanup inconsistent indenting in amdgpu_dm_color

On 1/5/24 15:02, Melissa Wen wrote: smatch warnings: amdgpu_dm_update_plane_color_mgmt() warn: inconsistent indenting Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202401051643.ppdbmg1u-...@intel.com/ Signed-off-by: Melissa Wen --- drivers/gpu/drm/amd/displ

Re: [PATCH v2] drm/amd/display: Fix uninitialized variable usage in core_link_ 'read_dpcd() & write_dpcd()' functions

Hi Srinivasan On 1/17/24 08:23, Srinivasan Shanmugam wrote: The 'status' variable in 'core_link_read_dpcd()' & 'core_link_write_dpcd()' was uninitialized. Thus, initializing 'status' variable to 'DC_ERROR_UNEXPECTED' by default. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/dc/link/pr

Re: [PATCH v2 0/8] Expand and improve AMDGPU documentation

On 1/23/24 09:19, Hamza Mahfooz wrote: On 1/22/24 16:24, Rodrigo Siqueira wrote: This patchset improves how the AMDGPU display documentation is organized, expands the kernel-doc to extract information from the source, and adds more context about DC workflow. Finally, at the end of this series

Re: [PATCH] MAINTAINERS: Add Siqueira for AMD DC

Hi, Acked-by: Rodrigo Siqueira Thanks a lot, I'm going to apply this patch. On 2021-10-08 5:21 p.m., Harry Wentland wrote: He's been helping maintain it for quite a while now. Make it official. Signed-off-by: Harry Wentland --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --gi

Re: [PATCH] amd/display: remove ChromeOS workaround

Hi Simon, I tested this patch and it lgtm. I also agree to revert it. Btw, did you send the revert patch for "amd/display: only require overlay plane to cover whole CRTC on ChromeOS"? I think we need to revert it as well. Sean, Mark For ChromeOS, we should ignore this patch. Do we need to t

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

On 2021-10-11 11:16 a.m., Simon Ser wrote: Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when using overlay") changed the atomic validation code to forbid the overlay plane from being used if it doesn't cover the whole CRTC. The motivation is that ChromeOS uses the atomic AP

Re: [PATCH 32/33] drm/amd/display: fix link training regression for 1 or 2 lane

Hi Paul, First of all, thanks for your feedback. Before I address your comments, I just want to give you some background about this type of patchset. All patches in this series are from a week ago and came from all display teams in AMD. Keep in mind that we share our display core with other

Re: [PATCH 1/3] drm/amd/display: Don't allow partial copy_from_user

Hi Harry, lgtm. Btw, it looks like that the other patches from this series are already applied to amd-staging-drm-next. Reviewed-by: Rodrigo Siqueira On 2021-10-27 10:26 a.m., Harry Wentland wrote: There is no reason to allow for partial buffers from userspace in our debugfs. In this parti

Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0

On 2021-11-24 5:20 a.m., Jiapeng Chong wrote: Fix the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c:96:14-15: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fp

Re: [PATCH] drm/amd/display: fix application of sizeof to pointer

On 2021-11-23 10:04 p.m., cgel@gmail.com wrote: From: Lv Ruyi Both of split and merge are pointers, not arrays. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/amd/display/dc/dml/dml_wrapper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

On 2021-11-29 7:06 a.m., Jani Nikula wrote: On Fri, 26 Nov 2021, Daniel Vetter wrote: On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira wrote: Display core documentation is not well organized, and it is hard to find information due to the lack of sections. This commit reorganizes t

Re: [PATCH 6/6] Documentation/gpu: Add DC glossary

On 2021-11-29 3:48 p.m., ydir...@free.fr wrote: Hi Rodrigo, That will really be helpful! I know drawing the line is a difficult problem (and can even make things harder when searching), but maybe it would make sense to keep generic acronyms not specific to amdgpu in a separate list. I bet a

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

On 2021-11-30 10:48 a.m., Harry Wentland wrote: On 2021-11-30 10:46, Rodrigo Siqueira Jordao wrote: On 2021-11-29 7:06 a.m., Jani Nikula wrote: On Fri, 26 Nov 2021, Daniel Vetter wrote: On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira wrote: Display core documentation is not

Re: [PATCH 06/10] drm/amd/display: fix function scopes

Hi Isabella, First of all, thanks a lot for sending this patch. This is a very welcome improvement to display code :) I added a few comments inline. On 2021-12-07 8:25 p.m., Isabella Basso wrote: This turns previously global functions into static, thus removing compile-time warnings such as:

Re: [PATCH 09/10] drm/amdgpu: remove unnecessary variables

On 2021-12-07 8:25 p.m., Isabella Basso wrote: This fixes the warnings below: In function 'svm_range_map_to_gpu': warning: variable 'bo_va' set but not used [-Wunused-but-set-variable] 1172 | struct amdgpu_bo_va bo_va; | ^ ... In functi

Re: [PATCH 07/10] drm/amd: append missing includes

On 2021-12-07 8:25 p.m., Isabella Basso wrote: This fixes warnings caused by global functions lacking prototypes:, such as: warning: no previous prototype for 'dcn303_hw_sequencer_construct' [-Wmissing-prototypes] 12 | void dcn303_hw_sequencer_construct(struct dc *dc) | ^~

Re: [PATCH 00/10] drm/amd: fix various compilation warnings

Hi Isabella, Thanks a lot for all of these improvements. I reviewed all patches related to the display code. Best Regards Siqueira On 2021-12-07 8:25 p.m., Isabella Basso wrote: This patchset aims at fixing various compilation warnings in the AMD GPU driver. All warnings were generated using

Re: [PATCH] drm/amd/display: fix a missing prototype warning in DCN303

On 2021-12-07 2:18 p.m., Aurabindo Pillai wrote: [Why&How] A missing include statement triggered a warning when running a build with W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_init.c:30:6: warning: no previous prototype for 'dcn303_hw_sequencer_construct' [-Wmissing-prototy

Re: [PATCH v2 6/6] Documentation/gpu: Add amdgpu and dc glossary

On 2021-12-07 2:49 p.m., Yann Dirson wrote: On Thu, Dec 02, 2021 at 11:01:32AM -0500, Rodrigo Siqueira wrote: In the DC driver, we have multiple acronyms that are not obvious most of the time; the same idea is valid for amdgpu. This commit introduces a DC and amdgpu glossary in order to mak

Re: [PATCH v2 6/6] Documentation/gpu: Add amdgpu and dc glossary

On 2021-12-08 11:16 a.m., Yann Dirson wrote: Hi Rodrigo, On 2021-12-07 2:49 p.m., Yann Dirson wrote: On Thu, Dec 02, 2021 at 11:01:32AM -0500, Rodrigo Siqueira wrote: In the DC driver, we have multiple acronyms that are not obvious most of the time; the same idea is valid for amdgpu. Thi

Re: [PATCH v4 0/6] Expand display core documentation

On 2021-12-09 4:04 p.m., Yann Dirson wrote: Thanks for this. It's really good to see this. Reviewed-by: Harry Wentland Hearfully seconded, let's get this rolling :) Reviewed-by: Yann Dirson Series applied to amd-staging-drm-next Thanks a lot! Harry On 2021-12-09 09:20, Rodrigo S

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

On 2021-12-09 11:46 a.m., Michel Dänzer wrote: From: Michel Dänzer Move code using the Pipe struct to a new helper function. Works around[0] this warning (resulting in failure to build a RHEL debug kernel with Werror enabled): ../drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_m

Re: [PATCH v2 06/10] drm/amd/display: fix function scopes

Hi Isabella, Sorry for the delay. Since this is a large patch, I submitted it to our CI, and I was waiting for the result. Apparently, everything is alright and your patch lgtm. Reviewed-by: Rodrigo Siqueira And applied to amd-staging-drm-next Thanks Siqueira On 2021-12-09 10:47 a.m., Isa

Re: [PATCH 1/2] drm/amd/display: Reduce stack size for dml31_ModeSupportAndSystemConfigurationFull

On 2021-12-13 4:46 a.m., Michel Dänzer wrote: On 2021-12-11 13:20, Rodrigo Siqueira Jordao wrote: On 2021-12-09 11:46 a.m., Michel Dänzer wrote: From: Michel Dänzer Move code using the Pipe struct to a new helper function. Works around[0] this warning (resulting in failure to build a

Re: [PATCH v2 1/3] Documentation/gpu: split amdgpu/index for readability

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This starts to make the formated index much more manageable to the reader. Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/driver-core.rst | 65 Documentation/gpu/amdgpu/driver-misc.rst | 112 ++ Documentation/gpu/am

Re: [PATCH v2 2/3] Documentation/gpu: include description of AMDGPU hardware structure

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Maybe you can improve this commit message by describing what you are documenting and also adding a link to the original discussion. Perhaps you can use this lin

Re: [PATCH v2 3/3] Documentation/gpu: include description of some of the GC microcontrollers

On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "Looking for clarifications around gfx/kcq/kiq" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland --- Documentation/gpu/amdgpu/driver-core.rst | 35

Re: [PATCH v2 2/3] Documentation/gpu: include description of AMDGPU hardware structure

On 2021-12-13 3:16 p.m., Rodrigo Siqueira Jordao wrote: On 2021-12-10 1:20 p.m., Yann Dirson wrote: This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Maybe you can improve this commit message by describing what you are documenting an

Re: [PATCH 10/19] drm/amd/display: Changed pipe split policy to allow for multi-display pipe split

On 2021-12-17 4:36 p.m., Deucher, Alexander wrote: [AMD Official Use Only] Maybe add Bug links for: https://gitlab.freedesktop.org/drm/amd/-/issues/1522 https://gitlab.freedesktop.org/drm/amd/-/issues/1709

Re: [PATCH 0/2]

Hi Zhenneng, + some display folks First of all, thanks a lot for your patch. We had a similar patch in the past, but we had to revert it because we cannot simply enable DCN for ARM-based systems. You can refer to this commit message to get a better context: https://gitlab.freedesktop.org/ag

Re: [PATCH 1/4] drm/amdgpu: Treat warning as an error

On 2022-01-11 6:00 a.m., Michel Dänzer wrote: On 2022-01-11 11:41, Michel Dänzer wrote: On 2022-01-11 00:39, Rodrigo Siqueira wrote: We have one internal CI that builds our kernel with the -Werror flag; as a result, when we try to sync our branch with amd-staging-drm-next we get some failure

Re: [PATCH 1/3] drm/amdgpu: fix warning

On 2022-01-10 3:19 p.m., Alex Deucher wrote: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] Fixes: 8c50db2f64ee ("drm/amdgpu: Adjust error inject function code style in amdgpu_ras.c") Cc: yipechai Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/

Re: [PATCH v3] drm/amd/display: move calcs folder into DML

On 2022-01-07 4:33 p.m., Isabella Basso wrote: The calcs folder has FPU code on it, which should be isolated inside the DML folder as per https://patchwork.freedesktop.org/series/93042/. This commit aims single-handedly to correct the location of such FPU code and does not refactor any functi

Re: [PATCH] drm/amd/display: Copy crc_skip_count when duplicating CRTC state

On 2022-01-18 11:49 a.m., Kazlauskas, Nicholas wrote: On 1/18/2022 11:40 AM, Rodrigo Siqueira wrote: From: Leo Li [Why] crc_skip_count is used to track how many frames to skip to allow the OTG CRC engine to "warm up" before it outputs correct CRC values. Experimentally, this seems to be 2 f

Re: [PATCH] drm/amd/display: Fix up kdoc for 'optc35_set_odm_combine'

Hi, Consider renaming the commit title to something like "Adjust kernel-doc for ...". Anyway, avoid use the keyword "Fix/Fixes" for kernel-doc. On 8/28/23 22:50, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_opt

Re: [PATCH v2] drm/amd/display: Adjust kdoc for 'optc35_set_odm_combine'

On 8/29/23 08:38, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_optc.c:46: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRTC Cc

Re: [RFC PATCH v2 1/5] drm/amd/display: detach color state from hw state logging

On 9/13/23 10:43, Melissa Wen wrote: Prepare to hook color state logging according to DCN version. Signed-off-by: Melissa Wen --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 27 +-- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/disp

Re: [RFC PATCH v2 2/5] drm/amd/display: fill up DCN3 DPP color state

On 9/13/23 10:43, Melissa Wen wrote: DCN3 DPP color state was uncollected and some state elements from DCN1 doesn't fit DCN3. Create new elements according to DCN3 color caps and fill them up for DTN log output. rfc-v2: - fix reading of gamcor and blnd gamma states Signed-off-by: Melissa Wen

Re: [RFC PATCH v2 0/5] drm/amd/display: improve DTN color state log

On 9/13/23 10:43, Melissa Wen wrote: Hi, This is an update of previous RFC [0] improving the data collection of Gamma Correction and Blend Gamma color blocks. As I mentioned in the last version, I'm updating the color state part of DTN log to match DCN3.0 HW better. Currently, the DTN log co

Re: [PATCH] drm/amd/display: switch DC over to the new DRM logging macros

Hi Hamza, This is a very nice improvement and overall lgtm. I just one comment and one question. For future series like this, I recommend splitting your commit into minor changes to make it easier to review and revert changes in case of regressions. Also, with a patchset, you could add a cov

Re: [PATCH] drm/amd/display: switch DC over to the new DRM logging macros

On 9/22/23 08:42, Hamza Mahfooz wrote: On 9/22/23 10:36, Rodrigo Siqueira Jordao wrote: Hi Hamza, This is a very nice improvement and overall lgtm. I just one comment and one question. For future series like this, I recommend splitting your commit into minor changes to make it easier to

Re: [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation.

On 9/21/23 08:15, Sebastian Andrzej Siewior wrote: Hi, I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix is #4 + #5 and the rest was made while looking at the code. Sebastian Hi Sebastian, Thanks a lot for this patchset. We tested it on multiple devices, and ever

Re: [PATCH 0/2] Reduce stack size for DML2

Hi Nathan, (+Hamza) First of all, thanks a lot for your feedback. You can see my comments inline. On 10/17/23 11:22, Nathan Chancellor wrote: Hi Rodrigo, On Mon, Oct 16, 2023 at 08:19:16AM -0600, Rodrigo Siqueira wrote: Stephen discovers a stack size issue when compiling the latest amdgpu c

Re: [PATCH v2 0/2] Fix issues caused by DML2 in ASICs older than DCN35

On 10/20/23 15:38, Harry Wentland wrote: On 2023-10-20 17:26, Rodrigo Siqueira wrote: The first commit of this series just sets the variable using_dml2 to false for all ASICs that do not require it. The second commit adds a fix to the DC sequence that calls a DML2 operation in ASICs that does

Re: [PATCH] drm/amd/display: add kernel docs for dc_stream_forward_crc_window

Hi Sagar, First of all, thanks for your patch. On 10/25/23 08:04, Sagar Vashnav wrote: Add kernel documentation for the dc_stream_forward_crc_window Signed-off-by: Sagar Vashnav --- drivers/gpu/drm/amd/display/dc/core/dc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/

Re: [PATCH] drm/amd/display: fix documentation for amdgpu_dm_update_freesync_caps()

On 2022-08-30 17:57, Alex Deucher wrote: Document missing parameter. Fixes: 8889a13f99e5 ("drm/amd/display: Add some extra kernel doc to amdgpu_dm") Reported-by: Stephen Rothwell Signed-off-by: Alex Deucher Cc: Rodrigo Siqueira Cc: Harry Wentland --- v2: fix aconnector too. drivers/gp

Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()

On 2022-09-01 10:15, Hamza Mahfooz wrote: Address the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3508 | if (update_type != UPDATE_TYPE_FAST) | ^~ drivers/gpu/drm/

Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

On 2022-09-02 09:10, Greg Kroah-Hartman wrote: On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. Fix this up by properly calling dput(). Cc: Harry Wentland Cc

Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

On 2022-09-06 11:06, Greg Kroah-Hartman wrote: On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote: On 2022-09-02 09:10, Greg Kroah-Hartman wrote: On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote: When calling debugfs_lookup() the result must have

Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable

On 2022-09-02 03:54, cgel@gmail.com wrote: From: zhang songyi Return the enable_link_dp() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: zhang songyi --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +- 1 file changed,

Re: [PATCH] drm/amd/display: Fix register definitions for DCN32/321

On 2022-09-01 15:27, Aurabindo Pillai wrote: [Why & How] Fix the instatiation sequence for MPC registers and add a few other missing register definitions that were ommited erroneously when copying them over to enable runtime initialization of reigster offsets for DCN32/321 Signed-off-by: Aura

Re: [PATCH 0/5] drm/amd/display: Reduce stack usage for clang

On 2022-08-30 16:34, Nathan Chancellor wrote: Hi all, This series aims to address the following warnings, which are visible when building x86_64 allmodconfig with clang after commit 3876a8b5e241 ("drm/amd/display: Enable building new display engine with KCOV enabled"). drivers/gpu/drm/

Re: [PATCH 0/5] drm/amd/display: Reduce stack usage for clang

On 2022-09-12 18:02, Nathan Chancellor wrote: Hi Rodrigo, On Mon, Sep 12, 2022 at 05:50:31PM -0400, Rodrigo Siqueira Jordao wrote: On 2022-08-30 16:34, Nathan Chancellor wrote: Hi all, This series aims to address the following warnings, which are visible when building x86_64

Re: [PATCH V3 46/47] drm/amd/display: Fix failures of disabling primary plans

Hi Michel, First of all, thanks a lot for your review. I want to take this opportunity to discuss this topic in more depth and learn more from you and others. +(Nick, Leo, Daniel, Mark, Dave, Sean, Simon) On 2022-09-15 04:55, Michel Dänzer wrote: On 2022-09-14 22:08, Alex Hung wrote: On 20

Re: [PATCH v5] drm/amd/display: Fix vblank refcount in vrr transition

On 2022-09-21 17:20, Yunxiang Li wrote: manage_dm_interrupts disable/enable vblank using drm_crtc_vblank_off/on which causes drm_crtc_vblank_get in vrr_transition to fail, and later when drm_crtc_vblank_put is called the refcount on vblank will be messed up. Therefore move the call to after ma

Re: [PATCH] drm: amd: clean up dcn32_fpu.c kernel-doc

On 2022-10-01 00:33, Randy Dunlap wrote: Rectify multiple kernel-doc warnings in dcn32_fpu.c. E.g.: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:247: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst

Re: [PATCH -next] drm/amd/display: Removed unused variable 'sdp_stream_enable'

On 2022-09-30 02:38, Dong Chenchen wrote: Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c: In function 'dcn31_hpo_dp_stream_enc_update_dp_info_packets': drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stre

Re: [PATCH] drm/amd/display: Remove unused struct i2c_id_config_access

On 2022-09-27 09:39, Yuan Can wrote: After commit 5a8132b9f606("drm/amd/display: remove dead dc vbios code"), no one use struct i2c_id_config_access, so remove it. Signed-off-by: Yuan Can --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 7 --- 1 file changed, 7 deletions(-) d

Re: [PATCH] drm/amdgpu/dm/mst: Fix incorrect usage of drm_dp_add_payload_part2()

On 2022-10-04 16:24, Lyude Paul wrote: Yikes, it appears somehow I totally made a mistake here. We're currently checking to see if drm_dp_add_payload_part2() returns a non-zero value to indicate success. That's totally wrong though, as this function only returns a zero value on success - not t

Re: [PATCH] drm/amd/display: Revert logic for plane modifiers

On 2022-10-19 11:15, Joaquín Ignacio Aramendía wrote: This file was split in commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f ("drm/amd/display: Create a file dedicated to planes") the logic in dm_plane_format_mod_supported() function got changed by a switch logic. That change broke drm_plane m

Re: [PATCH v3 1/1] drm/amd/display: add DCN support for ARM64

On 2022-10-28 11:09, Nathan Chancellor wrote: Hi Ao, On Thu, Oct 27, 2022 at 09:52:29PM +0200, Ao Zhong wrote: After moving all FPU code to the DML folder, we can enable DCN support for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the code in the DML folder that needs to use

Re: [PATCH RESEND 1/1] drm/amd/display: add DCN support for ARM64

On 2022-10-27 15:24, Estela ad Astra wrote: Hello. I have tested it on a Phytium D2000 platform with RX 5500 XT. Distro: Arch Linux ARM Kernel: Linux 6.0.5-1-phytium aarch64 (patched, https://github.com/saeziae/pkgbuild-linux-phytium ) Plug and unplug: OK on all ports. Resolutions teste

Re: [PATCH v4 1/1] drm/amd/display: add DCN support for ARM64

On 2022-10-31 15:37, Ao Zhong wrote: After moving all FPU code to the DML folder, we can enable DCN support for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the code in the DML folder that needs to use hardware FPU, and add a control mechanism for ARM Neon. Signed-off-by: Ao

Re: [PATCH v4 1/1] drm/amd/display: add DCN support for ARM64

On 2022-11-01 12:31, Nathan Chancellor wrote: On Tue, Nov 01, 2022 at 10:36:08AM -0400, Rodrigo Siqueira Jordao wrote: On 2022-10-31 15:37, Ao Zhong wrote: After moving all FPU code to the DML folder, we can enable DCN support for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG

Re: [PATCH] drm/amd/display: move FPU-related code from dcn20 to dml folder

On 2022-02-21 06:31, Melissa Wen wrote: Move parts of dcn20 code that uses FPU to dml folder. It aims to isolate FPU operations as described by series: drm/amd/display: Introduce FPU directory inside DC https://patchwork.freedesktop.org/series/93042/ This patch moves the following functions

Re: [PATCH 0/3] Move FPU related code from DCN3.1x drivers to DML folder

On 2022-03-07 10:47, Melissa Wen wrote: This series moves FPU code from DCN 3.1x drivers to dml/dcn31 folder to isolate FPU operations. For this, it creates dcn31_fpu files to centralize FPU operations and structs from dcn31x drivers, that include: - _vcs_dpi_ip_params_st and _vcs_dpi_soc_boun

Re: [PATCH v2] drm/amd/display: don't ignore alpha property on pre-multiplied mode

On 2022-03-29 16:18, Melissa Wen wrote: "Pre-multiplied" is the default pixel blend mode for KMS/DRM, as documented in supported_modes of drm_plane_create_blend_mode_property(): https://cgit.freedesktop.org/drm/drm-misc/tree/drivers/gpu/drm/drm_blend.c In this mode, both 'pixel alpha' and 'pl

Re: [PATCH 0/2] remove DC_FP_* wrappers in dml files

On 2022-03-26 16:24, Melissa Wen wrote: From FPU documentation, developers must not use DC_FP_START/END in dml files, but invoke it when calling FPU-associated functions (isolated in dml folder). Therefore, the first patch renames dcn10_validate_bandwidth in dml/calcs to dcn_ for generalizati

Re: [PATCH] drm/amd/display: Fix by adding FPU protection for dcn30_internal_validate_bw

On 2022-03-30 09:57, Melissa Wen wrote: On 03/30, VURDIGERENATARAJ, CHANDAN wrote: Hi Paul, Am 29.03.22 um 10:29 schrieb CHANDAN VURDIGERE NATARAJ: Is it common to spell your name all uppercase? If not, please use Chandan nVurdigere Nataraj. [WHY] The [] already emphasize the word, so

Re: [PATCH v2] drm/amd/display: don't ignore alpha property on pre-multiplied mode

Patch merged to amd-staging-drm-next. Thanks a lot! On 2022-04-05 15:32, Simon Ser wrote: I've tested this patch and it fixes my bug [1]. Thanks! Tested-by: Simon Ser [1]: https://gitlab.freedesktop.org/drm/amd/-/issues/1734>

  1   2   >