isp
to allocate GTT internal buffers required for fw to run. These buffers are
always allcoated from GTT domain, scope is limited to kernel and will not be
exposed to userspace.
Pratap Nirujogi (1):
drm/amd/amdgpu: Add support for isp buffers
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c |
: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 103 +
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 4 +
2 files changed, 107 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index
ISP hw block is supported in some of the AMD GPU versions, add support
to discover ISP IP in amdgpu_discovery.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
drivers/gpu/drm/amd/include/amd_shared.h
Add the isp driver in amdgpu to support ISP device on the APUs that
supports ISP IP block. ISP hw block is used for camera front-end, pre
and post processing operations.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/Makefile | 3 +
drivers/gpu/drm/amd/amdgpu/amdgpu.h
Enable ISP for ISP V4.1.0 and V4.1.1 in amdgpu_discovery.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 22 +++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
b/drivers/gpu/drm/amd/amdgpu
Add the isp driver in amdgpu to support ISP device on the APUs that
supports ISP IP block. ISP hw block is used for camera front-end, pre
and post processing operations.
Signed-off-by: Pratap Nirujogi
Change-Id: I67ef206e5eca1fe74e495c3262746be495e17d09
---
drivers/gpu/drm/amd/amdgpu/Makefile
Add the isp driver in amdgpu to support ISP device on the APUs that
supports ISP IP block. ISP hw block is used for camera front-end, pre
and post processing operations.
Signed-off-by: Pratap Nirujogi
Change-Id: I67ef206e5eca1fe74e495c3262746be495e17d09
---
Changes in v2:
- Remove adding
Add the isp driver in amdgpu to support ISP device on the APUs that
supports ISP IP block. ISP hw block is used for camera front-end, pre
and post processing operations.
Pratap Nirujogi (3):
drm/amd/amdgpu: Add ISP support to amdgpu_discovery
drm/amd/amdgpu: Add ISP driver support
drm/amd
ISP hw block is supported in some of the AMD GPU versions, add support
to discover ISP IP in amdgpu_discovery.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
drivers/gpu/drm/amd/include/amd_shared.h
Enable ISP for ISP V4.1.0 and V4.1.1 in amdgpu_discovery.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 22 +++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
b/drivers/gpu/drm/amd/amdgpu
Add Reviewed-by tag and address review comments on patch-2.
Changes made:
- Add Reviewed-by tag on patch-1 and 3.
- Remove unwanted header files
- Remove suprious lines, duplicate error prints
- Fix multi-line comment style
Pratap Nirujogi (3):
drm/amd/amdgpu: Add ISP support to
Enable ISP for ISP V4.1.0 and V4.1.1 in amdgpu_discovery.
Reviewed-by: Mario Limonciello
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 22 +++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
b
ISP hw block is supported in some of the AMD GPU versions, add support
to discover ISP IP in amdgpu_discovery.
Reviewed-by: Mario Limonciello
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 +
drivers/gpu
Add the isp driver in amdgpu to support ISP device on the APUs that
supports ISP IP block. ISP hw block is used for camera front-end, pre
and post processing operations.
Signed-off-by: Pratap Nirujogi
---
Changes made in v3:
- Remove unwanted header files
- Remove suprious lines, duplicate
Add support for ISP interrupts and disable MMHUB prefetch for ISP v4.1.1
Pratap Nirujogi (3):
drm/amd/amdgpu: Map ISP interrupts as generic IRQs
drm/amd/amdgpu: Add ISP4.1.0 and ISP4.1.1 modules
drm/amd/amdgpu: Disable MMHUB prefetch for ISP v4.1.1
drivers/gpu/drm/amd/amdgpu/Makefile
Disable MMHUB prefetch for ISP v4.1.1 as a temporary WA until
the GART supports MMHUB TLSi and SAW for ISP HW to access
GART memory using the TLSi path.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 12
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.h | 7
Add independent IP centric modules for ISP4.1.0 and ISP4.1.1 hw blocks.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/Makefile | 5 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 167
Map ISP IH interrupts to Linux generic IRQ for ISP driver to
handle the interrupts using MFD IORESOURCE_IRQ resource.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 31 --
drivers/gpu/drm/amd
tween 12 and 41 bytes into a destination of size 40
192 | snprintf(fw_name, sizeof(fw_name), "amdgpu/%s.bin",
ucode_prefix);
|
^~~~~~~~~
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/am
AMDGPU_MAX_IP_NUM to fix the issue.
Fixes: 14c11b71985c ("drm/amdgpu: Add init levels")
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/
Update AMDGPU_IP_BLK_MASK_ALL to use AMD_IP_BLOCK_TYPE_NUM instead
of AMDGPU_MAX_IP_NUM to fix the issue.
Pratap Nirujogi (1):
drm/amdgpu: Fix ISP HW init issue
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.43.0
From: Benjamin Chan
AMDISP GPIO control uses a dedicated pinctrl driver,
and requires MFD hotadd GPIO resources.
Co-developed-by: Pratap Nirujogi
Signed-off-by: Benjamin Chan
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h | 1 +
drivers/gpu/drm/amd/amdgpu
passed using
the MFD interface from amdgpu.
Benjamin Chan (1):
drm/amdgpu: Add amdisp pinctrl MFD resource
Pratap Nirujogi (1):
drm/amdgpu: Replace DRM_ERROR() with drm_err()
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h | 1 +
drivers/gpu/drm/amd/amdgpu/isp_v4_1_0.c | 57
DRM_ERROR() is no longer preferred. Replace DRM_ERROR() usage
with drm_err() in isp driver.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/isp_v4_1_0.c | 15 ++-
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 15 ++-
2 files changed, 20 insertions(+), 10
streaming mode.
Signed-off-by: Pratap Nirujogi
---
Changes v2 -> v3:
* Add NULL check for acpi_device handle in amdgpu_acpi_get_isp4_dev_hid()
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 31
drivers/gpu/drm/amd/amd
streaming mode.
Signed-off-by: Pratap Nirujogi
---
Changes v3 -> v4:
* Use __free() macro to call put_device on exit in
amdgpu_acpi_get_isp4_dev_hid()
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 29 ++
drivers/gpu/drm/
streaming mode.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 46 +
1 file changed, 46 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
b/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
index 69dd92f6e86d..c488af6c8013 100644
--- a
streaming mode.
Signed-off-by: Pratap Nirujogi
---
Changes v1 -> v2:
* Use fixed "isp_dev_hid[ACPI_ID_LEN]" instead of allocating using
devm_kzalloc()
* Instead of "pointer to pointer" use "pointer to array" type arg in
amdgpu_acpi_get_isp4_dev_hid()
* Include
streaming mode.
Signed-off-by: Pratap Nirujogi
---
Changes v0 -> v1:
* Add amdgpu_acpi_get_isp4_dev_hid() utility to retrieve isp4
platform device hid.
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 29
drivers/gpu/drm/amd/amd
streaming mode.
Signed-off-by: Pratap Nirujogi
Reviewed-by: Mario Limonciello
---
Changes v4 -> v5:
* Build errors reported on the platform that doesn't enable CONFIG_ACPI
or CONFIG_SUSPEND. Include amdgpu_acpi_get_isp4_dev_hid() only when both
CONFIG_DRM_AMD_ISP and ACPI are enabled to
set power and clocks using PM methods.
Co-developed-by: Bin Du
Signed-off-by: Bin Du
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h | 3 +
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 155 +++-
2 files changed, 157 insertions(+), 1 deletion(-)
diff
Replace DRM_ERROR with drm_err function and update log
messages to drop __func__ and print return value.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
and other driver modules to set the min/max clocks. Any
clock specific restrictions are expected to be taken care in
SOC specific SMU implementations instead of generic amdgpu_dpm
and amdgpu_smu interfaces.
Signed-off-by: Pratap Nirujogi
---
.../gpu/drm/amd/include/kgd_pp_interface.h| 2
amdgpu_dpm_set_powergating_by_smu() and amdgpu_dpm_set_soft_freq_range(); and
the underlying SOC specific SMU implementation for isp v4.1.
Pratap Nirujogi (4):
drm/amd/pm: Add support to set ISP Power
drm/amd/pm: Add support to set min ISP clocks
drm/amd/amdgpu: Add ISP Generic PM Domain (genpd) support
drm/amd/amdgpu
Add support to set ISP power for SMU v14.0.0. ISP driver
uses amdgpu_dpm_set_powergating_by_smu() API to
enable / disable power via SMU interface than communicating
with PMFW directly.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 1 +
drivers/gpu/drm/amd
'isp_user_buffer_alloc'
Fixes: 5cab8cc383a5 ("drm/amd/amdgpu: Add helper functions for isp buffers")
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202507131324.tkf4ison-...@intel.com/
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgp
ISP4
based targets.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 11 ---
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm
u internal functions
amdgpu_bo_create_isp_user() and amdgpu_bo_create_kernel() to
alloc/free GART buffers.
Signed-off-by: Pratap Nirujogi
---
Changes v2 -> v3:
* Move isp.h to include/drm/amd/
* Add function headers for exported symbols
* Add checks to validate isp device handle
* Add checks to validate exported
u internal functions
amdgpu_bo_create_isp_user() and amdgpu_bo_create_kernel() to
alloc/free GART buffers.
Signed-off-by: Pratap Nirujogi
---
Changes v3 -> v4:
* Remove unrelated change in isp_load_fw_by_psp()
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c| 175 +
drivers/gpu/drm/amd/amdgp
u internal functions
amdgpu_bo_create_isp_user() and amdgpu_bo_create_kernel() to
alloc/free GART buffers.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c| 75 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h| 7 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 --
u internal functions
amdgpu_bo_create_isp_user() and amdgpu_bo_create_kernel() to
alloc/free GART buffers.
Signed-off-by: Pratap Nirujogi
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c| 73 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h| 7 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 --
41 matches
Mail list logo
