Re: [PATCH 2/3] drm/amd/pm: Fix incorrect power limit readback in smu11 if POWER_SOURCE_DC

Hi, sorry for the drive-by comment but limit_param |= 0 << 24; Doesn't do anything. Best regards Nils Den sön 3 okt. 2021 06:47Darren Powell skrev: > when smu->adev->pm.ac_power == 0, message parameter with bit 16 set is > saved > to smu->current_power_limit. > > Fixes: 0cb4c62125a9 ("drm/

Re: [PATCH 5/7] drm/amd/pm: drop the unnecessary intermediate percent-based transition

Hi Evan, Bit of a drive by comment but I think that maybe all the *_fan_speed_percent() function names are a bit confusing if they no longer operate on percents but on a duty cycle unit of 0-255. No good idea what to call them though :-\ Also max() could be used in a bunch of places instead of

Re: [PATCH] drm/amdkfd: Add GPU reset SMI event

Hi, see inline comment below. Den tis 25 aug. 2020 21:12Mukul Joshi skrev: > Add support for reporting GPU reset events through SMI. KFD > would report both pre and post GPU reset events. > > Signed-off-by: Mukul Joshi > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 +++ > drivers/gpu

Re: [PATCH 08/13] drm/amd/display: Synchronize displays with different timings

Hi Bindu, an inline comment below. Den fre 19 feb. 2021 23:16Bindu Ramamurthy skrev: > From: Vladimir Stempen > > [why] > Vendor based fan noise improvement > > [how] > Report timing synchronizable when DP streams time frame > difference is less than 0.05 percent. Adjust DP DTOs and > sync di

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

Hi Richard, see inline comment. Den fre 8 apr. 2022 21:05Richard Gong skrev: > Active State Power Management (ASPM) feature is enabled since kernel 5.14. > There are some AMD GFX cards (such as WX3200 and RX640) that cannot be > used with Intel AlderLake based systems to enable ASPM. Using these

Re: [PATCH 05/35] drm/amd/display: Initialize stream_update to zero

Hi, Recently several locations initing structs to zero have been changed to use memset [1]. Might want to do that here as well. [1] https://lists.freedesktop.org/archives/amd-gfx/2019-February/031116.html Regards Nils Den fre 1 feb. 2019 16:29 skrev Bhawanpreet Lakha : > From: Nicholas Kazlaus

Re: [PATCH 15/35] drm/amd/display: make vline_config parameter const.

Hi, It seems the commit title is a little confusing. The change is to now pass by (const) reference rather than by value. Regards Nils Den fre 1 feb. 2019 16:29 skrev Bhawanpreet Lakha : > From: Yongqiang Sun > > Change-Id: Icfe018c7579ad2b3ef65195f578b8e44422d53f3 > Signed-off-by: Yongqiang S

Re: [PATCH] drm/amdgpu: Allow to reset to EERPOM table.

Hi Andrey, spotted a typo below, also typo in the title s/EERPOM/EEPROM/ Regards Nils Den fre 6 sep. 2019 17:13Andrey Grodzovsky skrev: > The table grows quickly during debug/development effort when > multiple RAS errors are injected. Allow to avoid this by setting > table header back to empty

Re: [PATCH 6/7] drm/amdgpu:alloc/dealloc csa accordingly

Hi Monk, a comment below. Den 9 jan. 2017 9:07 fm skrev "Monk Liu" : Change-Id: I110af93c4f17ab18d1be199c6ebe9ee965483a66 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH] drm/amdgpu: simplify allocation of scratch regs

The scratch regs are sequential so there's no need to keep them in an array, we can just return the index of the first free register + the base register. Also change the array of bools for keeping track of the free regs to a bitfield. Signed-off-by: Nils Wallménius --- drivers/gpu/dr

Re: [PATCH 1/4] drm/amdgpu/ci: disable mclk switching for high refresh rates

Hi, Alex Shouldn't the function return true when the refresh rate > 120? If so, same comment on patch 2. BR Nils Den 11 maj 2017 7:59 em skrev "Alex Deucher" : Even if the vblank period would allow it, it still seems to be problematic on some cards. bug: https://bugs.freedesktop.org/show_bug.

Re: [PATCH 3/4] drm/amd/powerplay/smu7: add vblank check for mclk switching

Hi Alex, Comment below Den 11 maj 2017 7:59 em skrev "Alex Deucher" : Check to make sure the vblank period is long enough to support mclk switching. bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 31 +

[PATCH] drm/amdgpu: Constify tables

Mark some powerplay tables as 'const' and adjust pointers acessing them to avoid introducing warnings. Signed-off-by: Nils Wallménius --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c | 12 ++-- drivers/g

[PATCH] drm/amdgpu: Remove checking for atombios

This is a left over from radeon, amdgpu doesn't support any non-atombios parts and amdgpu_device_init would bail if the check for atombios failed anyway. Signed-off-by: Nils Wallménius --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c

Re: [PATCH V2] amdgpu/drm: Refine the way to check

Hi Ken, a comment below Den 21 dec. 2016 08:19 skrev "Xue, Ken" : There are several ways to check out a ATOMBIOS. In previous codes, try a new way to fetch out vbios/rom, until current vbios/rom is started with 0x55AA, then check if this vbios is ATOMBIOS. Now, try a new way to fetch out vbios u

Re: [PATCH] drm/amd/display: Add comment for NaN checks in DCN calcs

Hi Harry, couldn't a simple isnan() macro be used? Also a question below. Den 11 okt. 2017 17:01 skrev "Harry Wentland" : This is confusing as-is and really needs a comment. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.c | 4 1 file changed, 4 inser

Re: [PATCH 08/12] drm/amdgpu: add amdgpu_gart_map function

Hi Christian, two comments below Den 30 juni 2017 1:22 em skrev "Christian König" : From: Christian König This allows us to write the mapped PTEs into an IB instead of the table directly. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ++ drivers/gpu/drm/amd

Re: [PATCH 10/21] drm/amd/display: Add back code to allow for rounding error

Den tis 10 apr. 2018 23:11Harry Wentland skrev: > From: Anthony Koo > > Signed-off-by: Anthony Koo > Reviewed-by: Aric Cyr > Acked-by: Harry Wentland > --- > drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff

Re: [PATCH 3/7] drm/amdgpu: init zfb start address and size

Den tis 15 maj 2018 16:50Alex Deucher skrev: > From: Feifei Xu > > Use module parameter passed from user to initialize zfb start address > and size. > > Signed-off-by: Feifei Xu > Signed-off-by: Hawking Zhang > Acked-by: John Bridgman > Reviewed-by: Alex Deucher > Signed-off-by: Alex Deucher