[PATCH] drm/radeon/ni: Fix wrong firmware size logging in ni_init_microcode()

deon/kms: add dpm support for btc (v3)") Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/ni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c index 927e5f42e97d..3e48cbb522a1 100644 --- a/drivers/gpu/drm/rad

[PATCH] drm/amd/display: fix NULL checks for adev->dm.dc in amdgpu_dm_fini()

;drm/amd/display: Support for DMUB AUX") Signed-off-by: Nikita Zhandarovich --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/displa

[PATCH] drm/amd/display: Fix missing NULL check in dcn21_set_backlight_level()

redundant tests for NULL in 'abm'. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 6f0ef80a00ad ("drm/amd/display: Fix ABM pipe/backlight issues when change backlight") Signed-off-by: Nikita Zhandarovich --- drivers/gpu

[PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

l such cases. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 285484e2d55e ("drm/radeon: add support for evergreen/ni tiling informations v11") Cc: sta...@vger.kernel.org Signed-off-by: Nikita Zhandarovich --- P.S. While I am not certain

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

Hi, On 7/29/24 02:23, Christian König wrote: > Am 26.07.24 um 14:52 schrieb Alex Deucher: >> On Fri, Jul 26, 2024 at 3:05 AM Christian König >> wrote: >>> Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: >>>> Several cs track offsets (such as '

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

On 7/29/24 11:12, Christian König wrote: > Am 29.07.24 um 20:04 schrieb Christian König: >> Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: >>> Hi, >>> >>> On 7/29/24 02:23, Christian König wrote: >>>> Am 26.07.24 um 14:52 schrieb Alex Deucher:

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

On 7/30/24 23:56, Christian König wrote: > Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich: >> On 7/29/24 11:12, Christian König wrote: >>> Am 29.07.24 um 20:04 schrieb Christian König: >>>> Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: >>>>>

[PATCH v2] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

rmat specifiers in debug prints to properly represent 'offset' values. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 285484e2d55e ("drm/radeon: add support for evergreen/ni tiling informations v11") Signed-off-by: Nikita Zhandar

Re: [PATCH v2] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

Hi, On 8/6/24 10:19, Nikita Zhandarovich wrote: > Several cs track offsets (such as 'track->db_s_read_offset') > either are initialized with or plainly take big enough values that, > once shifted 8 bits left, may be hit with integer overflow if the > resulting values en

[PATCH] drm/radeon/r600_cs: Fix possible int overflows in r600_cs_check_reg()

: 1729dd33d20b ("drm/radeon/kms: r600 CS parser fixes") Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/r600_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c index 638f861af80f..6c

[PATCH] drm/radeon/r100: Fix integer overflow issues in r100_cs_track_check()

d by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 0242f74d29df ("drm/radeon: clean up CS functions in r100.c") Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/r100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

[PATCH] drm/radeon: remove dead code in ni_mc_load_microcode()

ot;) Found by Linux Verification Center (linuxtesting.org) with static analysis tool Svace. Fixes: 0af62b016804 ("drm/radeon/kms: add ucode loader for NI") Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/ni.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-)

[PATCH] drm/radeon/ni_dpm: remove redundant NULL check

Fixes: 69e0b57a91ad ("drm/radeon/kms: add dpm support for cayman (v5)") Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/ni_dpm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/ni_dpm.c b/drivers/gpu/drm/radeon/ni_dpm.c index 3e1c1a392fb7..e085

[PATCH] radeon: avoid double free in ci_dpm_init()

analysis tool SVACE. Fixes: cc8dbbb4f62a ("drm/radeon: add dpm support for CI dGPUs (v2)") Cc: sta...@vger.kernel.org Co-developed-by: Natalia Petrova Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/ci_dpm.c | 20 +--- 1 file changed, 5 insertions(+), 15

Re: [PATCH] radeon: avoid double free in ci_dpm_init()

On 4/11/23 14:11, Deucher, Alexander wrote: > [Public] > >> -Original Message----- >> From: Nikita Zhandarovich >> Sent: Monday, April 3, 2023 2:28 PM >> To: Deucher, Alexander >> Cc: Nikita Zhandarovich ; Koenig, Christian >> ; Pan, Xinhui ; D

[PATCH] video/hdmi: minor fixes for *_infoframe_init functions

ned-off-by: Nikita Zhandarovich --- drivers/gpu/drm/display/drm_hdmi_helper.c | 5 +--- drivers/gpu/drm/drm_edid.c| 5 +--- drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +-- drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 ++ drivers/gpu/drm/radeon/r600_hdmi.c

[PATCH v2] video/hdmi: minor fixes for *_infoframe_init functions

ned-off-by: Nikita Zhandarovich --- v2: Fix build warning by removing unnecessary call to drm_WARN_ON() with uninitialized value. Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202304131234.ht3mzkju-...@intel.com/ drivers/gpu/drm/display/drm_hdmi_hel

[PATCH v2] radeon: avoid double free in ci_dpm_init()

r.kernel.org Co-developed-by: Natalia Petrova Signed-off-by: Nikita Zhandarovich --- v2: free only resouces allocated prior, do not remove ci_dpm_fini() or other deallocating calls altogether; fix commit message. v1: https://lore.kernel.org/all/20230403182808.8699-1-n.zhandarov...@fintech.ru/ drivers

[PATCH] drm/ttm: fix null-ptr-deref in radeon_ttm_tt_populate()

g.org) with static analysis tool SVACE. Fixes: 40f5cf996991 ("drm/radeon: add PRIME support (v2)") Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/radeon_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c

Re: [PATCH] drm/ttm: fix null-ptr-deref in radeon_ttm_tt_populate()

On 4/17/23 07:42, Christian König wrote: > > > Am 17.04.23 um 16:34 schrieb Nikita Zhandarovich: >> Currently, drm_prime_sg_to_page_addr_arrays() dereferences 'gtt->ttm' >> without ensuring that 'gtt' (and therefore 'gtt->tmm') is

[PATCH] drm/radeon: fix possible division-by-zero errors

sue should nonetheless be prevented so add a sanity check for such cases by testing 'decoded_ref' value against 0. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 66229b200598 ("drm/radeon/kms: add dpm support for rv7xx (v4)") Sign

[PATCH] drm/radeon: Fix potential null-ptr-deref

-check to prevent the issue. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 9843ead08f18 ("drm/radeon: add DisplayPort MST support (v2)") Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/radeon_encoders.c | 3 +++ 1 file changed, 3 insertions(

[PATCH] drm/radeon: Fix potential null-ptr-deref

Due to my rookie mistake this patch isn't necessary anymore in upstream version. The issue was already resolved in a different manner. Apologies for inconvenience.

[PATCH] video/hdmi: convert *_infoframe_init() functions to void

quot;) Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/display/drm_hdmi_helper.c | 5 +--- drivers/gpu/drm/drm_edid.c| 5 +--- drivers/gpu/drm/i915/display/intel_hdmi.c | 7 ++--- drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 ++ drivers/gpu/drm/radeon/r60

[PATCH] drm/radeon: check return value of radeon_ring_lock()

t;drm/radeon/kms: add support for CP setup on SI") Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/si.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c index 8d5e4b25609d..df1b2ebc37c2 100644 --- a/drivers/gpu/drm/r

Re: [PATCH] video/hdmi: convert *_infoframe_init() functions to void

Hello, On 8/10/23 01:13, Maxime Ripard wrote: > Hi, > > On Tue, Aug 08, 2023 at 11:02:45AM -0700, Nikita Zhandarovich wrote: >> Four hdmi_*_infoframe_init() functions that initialize different >> types of hdmi infoframes only return the default 0 value, contrary to >&

[PATCH] drm/radeon/ci_dpm: Remove needless NULL checks of dpm tables

t;) Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/ci_dpm.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c index abe9d65cc460..7c3a960f486a 100644 --- a/drive

Re: [PATCH] drm/radeon/ci_dpm: Remove needless NULL checks of dpm tables

Gentle ping :) On 1/14/25 16:58, Nikita Zhandarovich wrote: > This patch removes useless NULL pointer checks in functions like > ci_set_private_data_variables_based_on_pptable() and > ci_setup_default_dpm_tables(). > > The pointers in question are initialized as addres

[PATCH] drm/radeon: fix uninitialized size issue in radeon_vce_cs_parse()

ation Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 2fc5703abda2 ("drm/radeon: check VCE relocation buffer range v3") Cc: sta...@vger.kernel.org Signed-off-by: Nikita Zhandarovich --- drivers/gpu/drm/radeon/radeon_vce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion