GFXOFF feature is not there for GFX 9.4.3 ASICs.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
index 564770c3875e..4bbe9c5ed87f 100644
7957ec80ef97 ("drm/amdgpu: Add FRU sysfs nodes only if needed") moved
the documentation for some of the sysfs nodes to amdgpu_fru_eeprom.c.
Update the documentation accordingly.
Signed-off-by: Lijo Lazar
---
Documentation/gpu/amdgpu/driver-misc.rst | 6 +++---
1 file changed, 3 insert
GFXOFF feature is not there for GFX 9.4.3 ASICs.
Signed-off-by: Lijo Lazar
Reviewed-by: Hawking Zhang
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
index
Show only firmware version attributes that have valid version. Hide
others.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 33 ---
1 file changed, 29 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c
b/drivers
function.
Signed-off-by: Lijo Lazar
Reported-by: Hao Zhou
Fixes: 1b665567fd6d ("drm/amdgpu: Add reset on init handler for XGMI")
---
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 6 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 26 ++-
drivers/gpu/drm/amd/amdgpu/am
Zero-initialize mqd backup memory, otherwise the check for
'already-backed-up' could go wrong.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
b/d
In certain cases - ex: when a reset is required on initialization - XCP
manager won't have a valid partition mode. In such cases, use SPX as the
default selected mode for which partition configuration details are
populated.
Signed-off-by: Lijo Lazar
Reported-by: Hao Zhou
Fixes: c7de570
Add dynamic NPS switch support for GC 9.4.3 variants. Only GC v9.4.3 and
GC v9.4.4 currently support this. NPS switch is only supported if an SOC
supports multiple NPS modes.
Signed-off-by: Lijo Lazar
Signed-off-by: Rajneesh Bhardwaj
Reviewed-by: Feifei Xu
---
v2: Add NULL check for
When reset on initialization is requested, wait for the reset to finish.
In cases where module is loaded after boot, this makes sure all
initialization work is done after a successful return of modprobe.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 9 -
1
On a hive, NPS request is placed by the first one for all devices in the
hive. If the request fails, mark the mode as UNKNOWN so that subsequent
devices on unload don't request it. Also, fix the mutex double lock
issue in error condition, should have been mutex_unlock.
Signed-off-by: Lijo
On a hive, NPS request is placed by the first one for all devices in the
hive. If the request fails, mark the mode as UNKNOWN so that subsequent
devices on unload don't request it. Also, fix the mutex double lock
issue in error condition, should have been mutex_unlock.
Signed-off-by: Lijo
function.
Signed-off-by: Lijo Lazar
Reported-by: Hao Zhou
Fixes: 1b665567fd6d ("drm/amdgpu: Add reset on init handler for XGMI")
---
v2: Rename save function to a more appropriate amdgpu_vcn_save_vcpu_bo (Leo)
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 6 ++
drivers/gpu/drm/
Make amdgpu_gfx_sysfs_init/fini functions as common entry points for all
gfx related sysfs nodes.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 37 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 --
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 5
code.
Signed-off-by: Lijo Lazar
Fixes: 6c10b5cc4eaa ("drm/amdgpu: Remove duplicate code in gfx_v8_0.c")
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 13 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c| 47 ++
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c |
Reset sequence indicates that hardware already ran into a bad state.
Avoid sending unmap queue request to reset KCQ. This will also cover RAS
error scenarios which need a reset to recover, hence remove the check.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 10
For DPX mode, the number of memory partitions supported should be less
than or equal to 2.
Signed-off-by: Lijo Lazar
Fixes: 1589c82a1085 ("drm/amdgpu: Check memory ranges for valid xcp mode")
---
drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c | 2 +-
1 file changed, 1 insertion(+),
For RAS errors, source of error is known. Skip the core dump of IP
states.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index
Reset sequence indicates that hardware already ran into a bad state.
Avoid sending unmap queue request to reset KCQ. This will also cover RAS
error scenarios which need a reset to recover, hence remove the check.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 10
newer code.
Signed-off-by: Lijo Lazar
Fixes: 6c10b5cc4eaa ("drm/amdgpu: Remove duplicate code in gfx_v8_0.c")
---
v2: Add same changes to map queue also (Le Ma)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 13 -
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c| 63 +++--
Make amdgpu_gfx_sysfs_init/fini functions as common entry points for all
gfx related sysfs nodes.
Signed-off-by: Lijo Lazar
---
v2: Check cleaner shader capability only for creation of run_cleaner_shader
attribute.
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 36 -
drivers
Populate the compatible NPS modes also for providing partition
configuration details through sysfs.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.h| 1 +
drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c | 11 +++
2 files changed, 12 insertions(+)
diff --git a
ch is pending and initiates a mode-1
reset.
7) During resume after a reset, NPS ranges are read again from discovery table.
8) Driver detects the new NPS mode and makes a compatible compute partition mode
switch if required.
Lijo Lazar (7):
drm/amdgpu: Add option to refresh NPS data
drm/amdgpu: Ad
In certain use cases, NPS data needs to be refreshed again from
discovery table. Add API parameter to refresh NPS data from discovery
table.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 68 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h | 2
Implement PSP ring command interface for memory partitioning on the fly
on the supported asics.
Signed-off-by: Rajneesh Bhardwaj
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 25 +
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 1 +
drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 1
Add a common interface in GMC to request NPS mode through PSP. Also add
a variable in hive and gmc control to track the last requested mode.
Signed-off-by: Rajneesh Bhardwaj
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 16
drivers/gpu/drm/amd/amdgpu
If a user has requested NPS mode switch, place the request through PSP
during unload of the driver. For devices which are part of a hive, all
requests are placed together. If one of them fails, revert back to the
current NPS mode.
Signed-off-by: Lijo Lazar
Signed-off-by: Rajneesh Bhardwaj
Add a callback to check if there is any condition detected by GMC block
for reset on init. One case is if a pending NPS change request is
detected. If reset is done because of NPS switch, refresh NPS info from
discovery table.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu
Add dynamic NPS switch support for GC 9.4.3 variants. Only GC v9.4.3 and
GC v9.4.4 currently support this. NPS switch is only supported if an SOC
supports multiple NPS modes.
Signed-off-by: Lijo Lazar
Signed-off-by: Rajneesh Bhardwaj
---
drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h | 1 +
drivers
memory partition sysfs logic to be more
generic.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 114
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 6 ++
2 files changed, 104 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/
Use the memory ranges published in discovery table to deduce NPS mode
of GC v9.4.3 VFs.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 12 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 2 +-
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 30
Enable sysfs node for current compute partition mode on VFs also.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 29 +++--
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 12 --
2 files changed, 31 insertions(+), 10 deletions(-)
diff --git a
eifei)
Lijo Lazar (7):
drm/amdgpu: Add option to refresh NPS data
drm/amdgpu: Add PSP interface for NPS switch
drm/amdgpu: Add gmc interface to request NPS mode
drm/amdgpu: Add sysfs interfaces for NPS mode
drm/amdgpu: Place NPS mode request on unload
drm/amdgpu: Check gmc requiremen
Implement PSP ring command interface for memory partitioning on the fly
on the supported asics.
Signed-off-by: Rajneesh Bhardwaj
Reviewed-by: Feifei Xu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 25 +
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 1 +
drivers/gpu/drm/amd
In certain use cases, NPS data needs to be refreshed again from
discovery table. Add API parameter to refresh NPS data from discovery
table.
Signed-off-by: Lijo Lazar
Reviewed-by: Rajneesh Bhardwaj
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 68 +++
drivers/gpu/drm/amd
If a user has requested NPS mode switch, place the request through PSP
during unload of the driver. For devices which are part of a hive, all
requests are placed together. If one of them fails, revert back to the
current NPS mode.
Signed-off-by: Lijo Lazar
Signed-off-by: Rajneesh Bhardwaj
Add a callback to check if there is any condition detected by GMC block
for reset on init. One case is if a pending NPS change request is
detected. If reset is done because of NPS switch, refresh NPS info from
discovery table.
Signed-off-by: Lijo Lazar
---
v2:
Move NPS request check ahead of TOS
memory partition sysfs logic to be more
generic.
Signed-off-by: Lijo Lazar
Reviewed-by: Rajneesh Bhardwaj
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 114
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 6 ++
2 files changed, 104 insertions(+), 16 deletions(-)
diff -
Implement PSP ring command interface for memory partitioning on the fly
on the supported asics.
Signed-off-by: Rajneesh Bhardwaj
Reviewed-by: Feifei Xu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 25 +
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 1 +
drivers/gpu/drm/amd
eifei)
Lijo Lazar (7):
drm/amdgpu: Add option to refresh NPS data
drm/amdgpu: Add PSP interface for NPS switch
drm/amdgpu: Add gmc interface to request NPS mode
drm/amdgpu: Add sysfs interfaces for NPS mode
drm/amdgpu: Place NPS mode request on unload
drm/amdgpu: Check gmc requiremen
In certain use cases, NPS data needs to be refreshed again from
discovery table. Add API parameter to refresh NPS data from discovery
table.
Signed-off-by: Lijo Lazar
Reviewed-by: Rajneesh Bhardwaj
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 68 +++
drivers/gpu/drm/amd
Add dynamic NPS switch support for GC 9.4.3 variants. Only GC v9.4.3 and
GC v9.4.4 currently support this. NPS switch is only supported if an SOC
supports multiple NPS modes.
Signed-off-by: Lijo Lazar
Signed-off-by: Rajneesh Bhardwaj
Reviewed-by: Feifei Xu
---
drivers/gpu/drm/amd/amdgpu
Add a common interface in GMC to request NPS mode through PSP. Also add
a variable in hive and gmc control to track the last requested mode.
Signed-off-by: Rajneesh Bhardwaj
Signed-off-by: Lijo Lazar
Reviewed-by: Feifei Xu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 16
Avoid comparing TOS version on APUs. On APUs driver doesn't take care of
TOS load.
Fixes: 2edc5ecbf1a9 ("drm/amdgpu: Add interface for TOS reload cases")
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
FRU info is expected to be non-NULL if FRU sys files are created.
Simplify the check.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c
b/drivers/gpu
Write pointer could be 32-bit or 64-bit. Use the correct size during
initialization.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c
b/drivers/gpu/drm
As per power team, there is no need to impose a lower bound on arcturus
power limit. Any unreasonable limit set will result in frequent
throttling.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
As per power team, there is no need to impose a lower bound on arcturus
power limit. Any unreasonable limit set will result in frequent
throttling.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
Some in_reset checks are infact checking whether the state is
reinitialization after reset. Replace with reset_in_recovery calls to
identify that it's really checking for recovery stage after reset.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
driver
o identify post reset reinitialization
phase. This only provides a device level identification, IP/features may
choose to track their state independently also.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/aldebaran.c | 4
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
d
ed to look for a fatal error. Skip fatal error checking
in such cases.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/aldebaran.c| 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 15 -
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 55 ++-
drivers/gp
GFXOFF is not valid for these IP versions. Also, SDMA v4.4.2 is not in
GFX domain.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 4
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 2 --
2 files changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 58 +
1 file changed, 35 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
index 4d90e3f0bd17..6a9e26905edf 100644
--- a/drivers/gpu/drm/amd
VF device sets the RAS flag when mailbox data can't be read properly.
There is no conclusive way to tell if the real source is RAS error.
Therefore VF schedules a KFD based reset which doesn't set RAS source.
SKip checking RAS source for any VF scheduled recovery.
Signed-off-by:
Context empty interrupt is enabled for SDMA 4.4.2. Add a handler for
context empty interrupt so that it is disposed of fast, and not
propagated to KFD layer.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 +
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 22
atom bios header files are not required in these files.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 1 -
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c| 1
Use bios_release wrapper to release memory allocated for vbios image and
reset the variables.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
Keep VBIOS image read optional for select SOCs in passthrough mode.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index
Instead of read_bios, use get_bios_flags to get various options around
reading VBIOS.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b
Wrap the checks before device access in helper functions and use them
for device access. The generic order of APIs now is to do input argument
validation first and check if device access is allowed.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 616
ctive. Hence no need to get() to increment usage count. Remove < 0
return value check. Also, ignore runpm state to determine active status.
If the device is already in suspend state, disallow access.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 28 ++
For amdgpu_get_pp_force_state, amdgpu_get_pp_cur_state already takes
care of device state check. In other cases, values are returned from
driver cached variables and are not dependent on device state.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 14 --
1 file
Certain SOCs may not need much data from VBIOS. Some data like VBIOS
version used will be missed but it doesn't affect functionality. Add a
flag to make VBIOS image optional.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 70 +--
.../gpu/dr
Move definitions related to xgmi to amdgpu_xgmi header
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 23 +---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 8 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.h | 35 +---
3 files changed, 34
Initialize xgmi related static information during early_init. Use xgmi
API to get max bandwidth details.
Signed-off-by: Lijo Lazar
---
v2:
Move XGMI info init to early init phase (Jon)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3
XGMI v4.8.0 is not used in any SOCs. Remove the associated functions.
Also, ensure get_xgmi_info callback pointer is not NULL before calling
the function.
Signed-off-by: Lijo Lazar
---
v2:
Remove XGMI v4.8.0 as it is unused (Hawking)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 2
Add APIs to initialize XGMI speed, width details and get to max
bandwidth supported. It is assumed that a device only supports same
generation of XGMI links with uniform width.
Signed-off-by: Lijo Lazar
---
v2:
Use GC versions as XGMI version is not populated for all SOCs (Hawking
Certain SOCs may not need much data from VBIOS. Some data like VBIOS
version used will be missed but it doesn't affect functionality. Add a
flag to make VBIOS image optional.
Signed-off-by: Lijo Lazar
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
Use bios_release wrapper to release memory allocated for vbios image and
reset the variables.
v2:
Use the same wrapper for clean up in sw_fini (Alex Deucher)
Signed-off-by: Lijo Lazar
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
drivers/gpu/drm/amd
Instead of read_bios, use get_bios_flags to get various options around
reading VBIOS.
Signed-off-by: Lijo Lazar
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd
Keep VBIOS image read optional for select SOCs in passthrough mode.
Signed-off-by: Lijo Lazar
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu
Add APIs to initialize XGMI speed, width details and get to max
bandwidth supported. It is assumed that a device only supports same
generation of XGMI links with uniform width.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 41
drivers/gpu/drm
Move definitions related to xgmi to amdgpu_xgmi header
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 23 +---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 8 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.h | 35 +---
3 files changed, 34
Use xgmi API to get max bandwidth details.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index
Initialize xgmi related static information during discovery.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 20 +--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
b/drivers/gpu/drm/amd
ctive. Hence no need to get() to increment usage count. Remove < 0
return value check.
Signed-off-by: Lijo Lazar
Fixes: 6e796cb4a972b ("drm/amd/pm: use pm_runtime_get_if_active for debugfs
getters")
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 129 +++--
1
JPEG 5.0.1 supports upto 10 rings, however PMFW support for SMU v13.0.6
variants is now limited to 8 per instance. Limit to 8 temporarily to
avoid out of bounds access.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 8 +---
1 file changed, 5 insertions
Driver has different ways to fetch VBIOS. If one of the methods doesn't
find an authentic one, it will show misleading info messages eventhough
a subsequent method finds a valid VBIOS. Keep the message level at debug
and add device context.
Signed-off-by: Lijo Lazar
---
drivers/gpu/dr
'add ip block' causes a confusion if the blocks are disabled later with
ip_block_mask. Instead change to 'detected' and also add device context.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
Some boards use longer File Ids.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.h
index bc58dca18035
Fix the initialization and usage of SMU v13.0.6 capability values. Use
caps_set/clear functions to set/clear capability.
Also, fix SET_UCLK_MAX capability on APUs, it is supported on APUs.
Signed-off-by: Lijo Lazar
Reviewed-by: Alex Deucher
Reviewed-by: Yang Wang
Fixes: 9bb53d2ce109 (&quo
Fix the initialization and usage of SMU v13.0.6 capability values. Use
caps_set/clear functions to set/clear capability.
Also, fix SET_UCLK_MAX capability on APUs, it is supported on APUs.
Signed-off-by: Lijo Lazar
Reviewed-by: Alex Deucher
Fixes: 9bb53d2ce109 ("drm/amd/pm: Add capab
Fix the initialization and usage of SMU v13.0.6 capability values. Use
caps_set/clear functions to set/clear capability.
Also, fix SET_UCLK_MAX capability on APUs, it is supported on APUs.
Signed-off-by: Lijo Lazar
Fixes: 9bb53d2ce109 ("drm/amd/pm: Add capability flags for SMU v13.0.6&quo
IP tables with version <=2 may use harvest bit. For version 3 and above,
harvest bit is not applicable, instead uses harvest table. Fix the
logic accordingly.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 27 +++
1 file changed, 16 inserti
Use IP instance number and hwid as function args for validation checks.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 42 ---
1 file changed, 28 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
b/drivers
Clean up some IP version checks in gmcv9.0
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 49 ++-
1 file changed, 17 insertions(+), 32 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index
Remove unnecessary IP version checks for GFX 9.4.3 and similar variants.
Wrap checks inside meaningful function.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 68 ++--
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_2.c | 22
2 files changed, 29
Aldebaran doesn't support querying MM activity percentage. Keep the
field as 0xFFs to mark it as unsupported.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt
For SMU v13.0.6 variants, if dpm is disabled for a clock, fill current
frequency as the only level in frequency table. Also, drop Lclk table as
it is not used.
Signed-off-by: Lijo Lazar
---
.../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 33 +++
1 file changed, 19 insertions
Add capability flags for SMU v13.0.6 variants. Initialize the flags
based on firmware support. As there are multiple IP versions maintained,
it is more manageable with one time initialization caps flags based on
IP version and firmware feature support.
Signed-off-by: Lijo Lazar
---
drivers/gpu
Add RRMT control register offset for VCN v4.0.3
Signed-off-by: Lijo Lazar
Reviewed-by: Sathishkumar S
---
drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_4_0_3_offset.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/include/asic_reg/vcn
RRMT could get dynamically enabled/disabled by PSP firmware. Read the
status from register for reading RRMT status. For VFs, this is not
accessible, hence assume that it's always disabled for now.
Signed-off-by: Lijo Lazar
Reviewed-by: Sathishkumar S
---
drivers/gpu/drm/amd/a
RRMT could get dynamically enabled/disabled by PSP firmware. Read the
status from register for reading RRMT status. For VFs, this is not
accessible, hence assume that it's always disabled for now.
Signed-off-by: Lijo Lazar
Reviewed-by: Sathishkumar S
---
drivers/gpu/drm/amd/amdgpu/amdgpu_
Fix the initialization and usage of capability values and mask.
SMU_CAPS_MASK indicates mask value, and SMU_CAPS represent the
capability value.
Signed-off-by: Lijo Lazar
Fixes: 9bb53d2ce109 ("drm/amd/pm: Add capability flags for SMU v13.0.6")
---
.../drm/amd/pm/swsmu/smu13/smu_v13
If firmware supported NPS modes are available through CAP register, use
those values for supported NPS modes.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 36 +++
1 file changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd
GFXOFF check is not need for GC v9.4.3. Also, save/restore list is
available by default.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers
To get the device context, replace pr_ with dev_ functions.
Signed-off-by: Lijo Lazar
---
.../gpu/drm/amd/amdkfd/kfd_int_process_v10.c | 142 --
.../gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 92
.../gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 142
If RAS header read from EEPROM is corrupted, it could result in trying
to allocate huge memory for reading the records. Add some validation to
header fields.
Signed-off-by: Lijo Lazar
---
.../gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c| 22 ---
1 file changed, 19 insertions(+), 3
If a valid header is not found during RAS eeprom init, consider it as
new and reset RAS table info.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
Use the right register offsets for getting link status.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
b/drivers/gpu/drm/amd/amdgpu
Except HDP v5.2 all use a common logic for HDP flush. Use a generic
function. HDP v5.2 forces NO_KIQ logic, revisit it later.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c | 21 +
drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.h | 2 ++
drivers/gpu/drm/amd
301 - 400 of 488 matches
Mail list logo
