RE: [PATCH 3/6] drm/amdkfd: enable watch points globally for gfx943

2023-07-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Huang, JinHuiEric > Sent: Thursday, July 6, 2023 2:19 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kim, Jonathan ; Kim, Jonathan > ; Kuehling, Felix ; > Huang, JinHuiEric > Subject: [PATCH 3/6] drm/amdkfd: enable watch po

RE: [PATCH 6/6] drm/amdkfd: add multi-process debugging support for GC v9.4.3

2023-07-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Huang, JinHuiEric > Sent: Thursday, July 6, 2023 2:19 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kim, Jonathan ; Kim, Jonathan > ; Kuehling, Felix ; > Huang, JinHuiEric > Subject: [PATCH 6/6] drm/amdkfd: add multi-proce

RE: [PATCH 4/6] drm/amdkfd: enable grace period for xcc instance

2023-07-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Huang, JinHuiEric > Sent: Friday, July 7, 2023 11:46 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 4/6] drm/amdkfd: enable grace period for xcc instance > > > On 2023-07-07 10:59, Kim, Jon

RE: [PATCH 4/6] drm/amdkfd: enable grace period for xcc instance

2023-07-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Huang, JinHuiEric > Sent: Friday, July 7, 2023 12:44 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul > Subject: Re: [PATCH 4/6] drm/amdkfd: enable grace period for xcc instance > > > On 2023-07-07

RE: [PATCH 4/6] drm/amdkfd: enable grace period for xcc instance

2023-07-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kim, Jonathan > Sent: Friday, July 7, 2023 1:06 PM > To: Huang, JinHuiEric ; amd- > g...@lists.freedesktop.org > Cc: Joshi, Mukul > Subject: RE: [PATCH 4/6] drm/amdkfd: enable grace period for xcc instance > >

Re: [PATCH 1/4] drm/amdkfd: add kfd2kgd debugger callbacks for GC v9.4.3

2023-07-07 Thread Kim, Jonathan
: Huang, JinHuiEric Sent: Friday, July 7, 2023 1:46 PM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan ; Kim, Jonathan ; Huang, JinHuiEric Subject: [PATCH 1/4] drm/amdkfd: add kfd2kgd debugger callbacks for GC v9.4.3 From: Jonathan Kim Implement the similarities as GC v9.4.2, and the

Re: [PATCH 1/4] drm/amdkfd: add kfd2kgd debugger callbacks for GC v9.4.3

2023-07-07 Thread Kim, Jonathan
Yeah that's an unfortunate mismatch. Leave it then. We can always clean it up later if theres a strong preference to do so. Jon From: Huang, JinHuiEric Sent: Friday, July 7, 2023 8:25 PM To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org Subject: Re: [PA

RE: [PATCH] drm/amdkfd: enable grace period for xcp instance

2023-07-11 Thread Kim, Jonathan
cp_id)\ (num_inst ? GENMASK(num_inst - 1, 0) << (xcp_id * num_inst) : 0) Thanks, Jon > -Original Message- > From: Huang, JinHuiEric > Sent: Tuesday, July 11, 2023 10:28 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kim, Jonathan ; Huang, JinHuiEric > > Sub

RE: [PATCH 1/2] drm/amdkfd: fix trap handling work around for debugging

2023-07-18 Thread Kim, Jonathan
Signed-off-by: Aaron Liu Reviewed-by: Alex Deucher To ensure debugger is consistent with other checks. Thanks, Jon > -Original Message- > From: Kim, Jonathan > Sent: Friday, July 14, 2023 5:38 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Kim, Jonath

RE: [PATCH] drm/amdgpu: enable trap of each kfd vmid for gfx v9.4.3

2023-07-25 Thread Kim, Jonathan
[Public] > -Original Message- > From: Huang, JinHuiEric > Sent: Tuesday, July 25, 2023 2:16 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kim, Jonathan ; Huang, JinHuiEric > > Subject: [PATCH] drm/amdgpu: enable trap of each kfd vmid for gfx v9.4.3 > > To setup

RE: [PATCH] drm/amdkfd: fix address watch clearing bug for gfx v9.4.2

2023-08-10 Thread Kim, Jonathan
letting the HWS do this. Are we sure we're not working around some HWS bug? Thanks, Jon > -Original Message- > From: Kuehling, Felix > Sent: Thursday, August 10, 2023 5:03 PM > To: Huang, JinHuiEric ; amd- > g...@lists.freedesktop.org > Cc: Kim, Jonathan >

RE: [PATCH] drm/amdkfd: fix address watch clearing bug for gfx v9.4.2

2023-08-10 Thread Kim, Jonathan
ay, August 10, 2023 5:56 PM > To: Huang, JinHuiEric ; Kim, Jonathan > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdkfd: fix address watch clearing bug for gfx v9.4.2 > > I think Jon is suggesting that the UNMAP_QUEUES command should clear the > address watch regist

RE: [PATCH] drm/amdkfd: fix address watch clearing bug for gfx v9.4.2

2023-08-10 Thread Kim, Jonathan
1-1 to a process ... And that there's no race scenarios with trailing exceptions on dynamic watch point address changes ... Thanks, Jon > -Original Message- > From: Huang, JinHuiEric > Sent: Thursday, August 10, 2023 6:31 PM > To: Kim, Jonathan ; Kuehling, Felix > ; a

[PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-16 Thread Kim, Jonathan
read or writes to df registers when gpu df is in c-states will result in hang. df c-states should be disabled prior to read or writes then re-enabled after read or writes. Change-Id: I6d5a83e4fe13e29c73dfb03a94fe7c611e867fec Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c |

RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-16 Thread Kim, Jonathan
+ Felix -Original Message- From: Kim, Jonathan Sent: Wednesday, October 16, 2019 8:49 PM To: amd-gfx@lists.freedesktop.org Cc: felix.keuhl...@amd.com; Quan, Evan ; Kim, Jonathan ; Kim, Jonathan Subject: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons read or writes to df

[PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-16 Thread Kim, Jonathan
read or writes to df registers when gpu df is in c-states will result in hang. df c-states should be disabled prior to read or writes then re-enabled after read or writes. v2: use old powerplay routines for vega20 Change-Id: I6d5a83e4fe13e29c73dfb03a94fe7c611e867fec Signed-off-by: Jonathan Kim

RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-16 Thread Kim, Jonathan
Thanks Evan. Resent with fixes. -Original Message- From: Quan, Evan Sent: Wednesday, October 16, 2019 9:34 PM To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons Hi Jonathan, At default, vega20

[PATCH] drm/amdgpu: fix compiler warnings for df perfmons

2019-10-17 Thread Kim, Jonathan
fixing compiler warnings in df v3.6 for c-state toggle and pmc count. Change-Id: I74f8f1eafccf523a89d60d005e3549235f75c6b8 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3

RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-17 Thread Kim, Jonathan
Thanks for the catch Philip. I must have missed this with the renoir warnings. I sent fix. Jon -Original Message- From: Yang, Philip Sent: Thursday, October 17, 2019 1:40 PM To: Quan, Evan ; Kim, Jonathan ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: Re: [PATCH] drm

[PATCH 2/2] Revert "drm/amdgpu: disable c-states on xgmi perfmons"

2019-10-18 Thread Kim, Jonathan
This reverts commit 54275cd1649f4034c6450b6c5a8358fcd4f7dda6. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 36 +--- 1 file changed, 1 insertion(+), 35 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/d

[PATCH 1/2] Revert "drm/amdgpu: fix compiler warnings for df perfmons"

2019-10-18 Thread Kim, Jonathan
This reverts commit 7dd2eb31fcd564574e8efea6bf23cf504f9e2fd7. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c index e1cf7e9c61

[PATCH] Revert "drm/amdgpu: fix compiler warnings for df perfmons"

2019-10-18 Thread Kim, Jonathan
This reverts commit 7dd2eb31fcd564574e8efea6bf23cf504f9e2fd7. revert fix of compiler warning on incomplete df-cstate race condition handling solution i.e. smu msg cannot be sent within perfevents Change-Id: Ia09dd24ef91ef75a79a223f72f0cb6a86cd08667 Signed-off-by: Jonathan Kim --- drivers/gpu/dr

[PATCH 2/2] Revert "drm/amdgpu: disable c-states on xgmi perfmons"

2019-10-18 Thread Kim, Jonathan
This reverts commit 54275cd1649f4034c6450b6c5a8358fcd4f7dda6. incomplete solution to df c-state race condition. smu msg in perf events causes deadlock. Change-Id: Ia85179df2bd167657e42a2d828c4a7c475c392ff Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 36 +--

[PATCH] drm/amdgpu: revert calling smu msg in df callbacks

2019-10-18 Thread Kim, Jonathan
reverting the following changes: commit 7dd2eb31fcd5 ("drm/amdgpu: fix compiler warnings for df perfmons") commit 54275cd1649f ("drm/amdgpu: disable c-states on xgmi perfmons") perf events use spin-locks. embedded smu messages have potential long response times and potentially deadlocks the syste

RE: [PATCH 2/2] drm/amdgpu: perform p-state switch after the whole hive initialized

2019-11-05 Thread Kim, Jonathan
Please see inline. Jon -Original Message- From: Quan, Evan Sent: Tuesday, November 5, 2019 5:24 AM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan ; Strawbridge, Michael ; Quan, Evan Subject: [PATCH 2/2] drm/amdgpu: perform p-state switch after the whole hive initialized P

RE: [PATCH 2/2] drm/amdgpu: perform p-state switch after the whole hive initialized

2019-11-05 Thread Kim, Jonathan
Yes that's correct. This should fix the issue. Jon From: Strawbridge, Michael Sent: Tuesday, November 5, 2019 11:40 AM To: Kim, Jonathan ; Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: perform p-state switch after the whole hive initialized Hi Jon,

RE: [PATCH 2/2] drm/amdgpu: perform p-state switch after the whole hive initialized

2019-11-05 Thread Kim, Jonathan
_instance->adev->flags & AMD_IS_APU) + continue; + From: Kim, Jonathan Sent: Tuesday, November 5, 2019 11:42 AM To: Strawbridge, Michael ; Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/2] drm/amdgpu: perform p-state switch after the who

RE: [PATCH 2/2] drm/amdgpu: perform p-state switch after the whole hive initialized

2019-11-05 Thread Kim, Jonathan
er reach mgpu_info.num_gpu == >adev->gmc.xgmi.num_physical_nodes until in this code path. From: Kim, Jonathan Sent: Tuesday, November 5, 2019 12:07 PM To: Strawbridge, Michael ; Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/2] drm/amdgpu: perform p-state switch a

RE: [PATCH 2/2] drm/amdgpu: perform p-state switch after the whole hive initialized

2019-11-05 Thread Kim, Jonathan
No problem. With the incoming patch referenced below, this patch should be ok since it doesn't break the build. Reviewed-by: Jonathan Kim From: Quan, Evan Sent: Tuesday, November 5, 2019 10:11 PM To: Kim, Jonathan ; Strawbridge, Michael ; amd-gfx@lists.freedesktop.org Subject: RE: [PA

[PATCH] drm/amdgpu: fix vega20 pstate status change

2019-11-06 Thread Kim, Jonathan
vega20 only requires all devices be set to same pstate level for low pstate and not high. Change-Id: I399c84a47f6e24abca937ce950685c0c7f0e3279 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drive

RE: [PATCH] Revert "drm/amdgpu: use the BAR if possible in amdgpu_device_vram_access v2"

2020-04-14 Thread Kim, Jonathan
n From: Koenig, Christian Sent: Tuesday, April 14, 2020 10:47 AM To: Deucher, Alexander Cc: Russell, Kent ; amd-gfx@lists.freedesktop.org; Kuehling, Felix ; Kim, Jonathan Subject: Re: [PATCH] Revert "drm/amdgpu: use the BAR if possible in amdgpu_device_vram_access v2" That's exactly my

RE: [PATCH] Revert "drm/amdgpu: use the BAR if possible in amdgpu_device_vram_access v2"

2020-04-14 Thread Kim, Jonathan
with BAR. Also cwsr tests fail on Vega20 with or without the revert with the same RAS error. Thanks, Jon From: Kuehling, Felix Sent: Tuesday, April 14, 2020 2:32 PM To: Kim, Jonathan ; Koenig, Christian ; Deucher, Alexander Cc: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PAT

RE: [PATCH] Revert "drm/amdgpu: use the BAR if possible in amdgpu_device_vram_access v2"

2020-04-15 Thread Kim, Jonathan
AS event is BAR access triggered or the result of HW instability is beyond me since I don't have access to the machine. Thanks, Jon From: Koenig, Christian Sent: Wednesday, April 15, 2020 4:11 AM To: Kim, Jonathan ; Kuehling, Felix ; Deucher, Alexander Cc: Russell, Kent ; amd-gfx@lists.fre

RE: [PATCH] Revert "drm/amdgpu: use the BAR if possible in amdgpu_device_vram_access v2"

2020-04-16 Thread Kim, Jonathan
To: Koenig, Christian ; Kim, Jonathan ; Deucher, Alexander Cc: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] Revert "drm/amdgpu: use the BAR if possible in amdgpu_device_vram_access v2" [AMD Official Use Only - Internal Distribution Only] The test does not

RE: [PATCH] drm/amdgpu: sw pstate switch should only be for vega20

2020-04-24 Thread Kim, Jonathan
[AMD Official Use Only - Internal Distribution Only] Yes that is correct. Thank you, Jon -Original Message- From: Kuehling, Felix Sent: Friday, April 24, 2020 6:51 PM To: Kim, Jonathan Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: sw pstate switch should only be

[PATCH] drm/amdgpu: xgmi counters via perfevent

2019-04-17 Thread Kim, Jonathan
get xgmi counters through perf_event.h. added files: amdgpu_pmu.c/h - handles perf event logic (e.g. start/stop/add/delete) amdgpu_df_pmc.c/h - xgmi counter setup logic via DF PerfmonCtr modified files: soc15.c - added xgmi specific r/w functions to setup/read DF perfmonCtr amdgpu_device.c - adde

[PATCH] drm/amdgpu: add pmu counters

2019-05-24 Thread Kim, Jonathan
add pmu counters to monitor amdgpu device performance Change-Id: I8449f4ea824c411ee24a5b783ac066189b9de08e Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/Makefile| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c| 370 +++

[PATCH] drm/amdgpu: add pmu counters

2019-05-29 Thread Kim, Jonathan
add pmu counters to monitor amdgpu device performance. each pmu registered recorded per pmu type per asic type. Change-Id: I8449f4ea824c411ee24a5b783ac066189b9de08e Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/Makefile| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |

RE: [PATCH v2] drm/amdgpu: add pmu counters

2019-05-31 Thread Kim, Jonathan
been made to reflect per asic type per pmu requirements. Please review when possible. Thanks, Jon -Original Message- From: Alex Deucher Sent: Thursday, May 30, 2019 9:30 AM To: Kim, Jonathan Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: add pmu counters [CAUTION

[PATCH] drm/amdgpu: add pmu counters

2019-06-03 Thread Kim, Jonathan
add performance monitoring unit (pmu) counters. Change-Id: I4d0480b8aaa8086a28b6a79a60322b060e1aa73e Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/Makefile| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 + drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c| 353 +

RE: [PATCH] drm/amdgpu: attempt xgmi perfmon re-arm on failed arm

2019-12-19 Thread Kim, Jonathan
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Kim, Jonathan Sent: Thursday, December 19, 2019 4:31 PM To: amd-gfx@lists.freedesktop.org Cc: felix.khuel...@amd.com; Kim, Jonathan ; Kim, Jonathan Subject: [PATCH] drm/amdgpu: attempt xgmi perfmon re-arm

RE: [PATCH 4/4] drm/amdgpu: use amdgpu_device_vram_access in amdgpu_ttm_access_memory

2020-02-05 Thread Kim, Jonathan
[AMD Public Use] Tested on Vega20 via proc mem op reads. Old MMIO ~2.7MB/s, Improved MMIO ~3.2MB/s, BAR ~44MB/s Acked-by: Jonathan Kim -Original Message- From: Christian König Sent: Wednesday, February 5, 2020 10:23 AM To: amd-gfx@lists.freedesktop.org; Kuehling, Felix ; Kim

RE: [PATCH] drm/amdgpu: fix amdgpu pmu to use hwc->config instead of hwc->conf

2020-02-06 Thread Kim, Jonathan
[AMD Official Use Only - Approved for External Use] Thanks for pointing that out Felix. I'll append that as well to the comments for the commit. Jon -Original Message- From: Kuehling, Felix Sent: Thursday, February 6, 2020 3:08 PM To: Kim, Jonathan ; amd-gfx@lists.freedeskto

RE: [PATCH] drm/amd/amdgpu: add sw_fini interface for df_funcs

2019-09-03 Thread Kim, Jonathan
Reviewed-by: Jonathan Kim -Original Message- From: amd-gfx On Behalf Of Jack Zhang Sent: Tuesday, September 3, 2019 5:54 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jack (Jian) Subject: [PATCH] drm/amd/amdgpu: add sw_fini interface for df_funcs [CAUTION: External Email] add sw_fin

[PATCH] drm/amdgpu: update df_v3_6 for xgmi perfmons

2019-06-18 Thread Kim, Jonathan
v3: fixed cleanup by adding fini to free up adev df config counters v2: simplified by removing xgmi references in function names and moving to generic df function names. fixed issue by removing hardcoded cake tx data events. streamlined error handling by having df_v3_6_pmc_get_ctrl return error

[PATCH] drm/amdgpu: add pmu counters

2019-06-18 Thread Kim, Jonathan
v2: fixed missing break in switch statement add pmu counters Change-Id: I1aca271fd12cabce0ccfc076f771cde2d4cadd54 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/Makefile| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |

[PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons

2019-06-19 Thread Kim, Jonathan
v4: fixed kzalloc error check and modified df func init to return error code v3: fixed cleanup by adding fini to free up adev df config counters v2: simplified by removing xgmi references in function names and moving to generic df function names. fixed issue by removing hardcoded cake tx data ev

[PATCH 2/2] drm/amdgpu: add pmu counters

2019-06-19 Thread Kim, Jonathan
adding perf event counters Change-Id: Ib8800c2d652e3e788872bd721458ac5422859b62 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/Makefile| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 + drivers/gpu/drm/amd/amdgpu/

RE: [PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons

2019-06-19 Thread Kim, Jonathan
Hi Felix - Patch 1 as promised for review. Jon -Original Message- From: Kim, Jonathan Sent: Wednesday, June 19, 2019 6:50 PM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan ; Kim, Jonathan Subject: [PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons v4: fixed kzalloc error

RE: [PATCH 2/2] drm/amdgpu: add pmu counters

2019-06-19 Thread Kim, Jonathan
Patch 2 for Felix. Jon -Original Message- From: Kim, Jonathan Sent: Wednesday, June 19, 2019 6:50 PM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan Subject: [PATCH 2/2] drm/amdgpu: add pmu counters adding perf event counters Change-Id: Ib8800c2d652e3e788872bd721458ac5422859b62

RE: [PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons

2019-06-19 Thread Kim, Jonathan
just up the hard limit if it's still small enough. Jon -Original Message- From: Kuehling, Felix Sent: Wednesday, June 19, 2019 7:28 PM To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons One more possible simplific

[PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons

2019-06-19 Thread Kim, Jonathan
v4: fixed kzalloc error check and modified df func init to return error code v3: fixed cleanup by adding fini to free up adev df config counters v2: simplified by removing xgmi references in function names and moving to generic df function names. fixed issue by removing hardcoded cake tx data ev

RE: [PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons

2019-06-19 Thread Kim, Jonathan
For Felix as requested - Simplifying adev df perfmon config assign mask to be fixed length and related simplification. Jon -Original Message- From: Kim, Jonathan Sent: Wednesday, June 19, 2019 8:53 PM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan ; Kim, Jonathan Subject: [PATCH

[PATCH] drm/amdgpu: set max df perfmon to 4

2019-06-19 Thread Kim, Jonathan
fixed df permon to 4 and remove not needed ret Change-Id: Ia9897612937e652e7f8a09c1d23bb1c0e6f3d8f7 --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- drivers/gpu/drm/amd/amdgpu/soc15.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drive

RE: [PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons

2019-06-19 Thread Kim, Jonathan
Apologies. I confused the review approval from the 2nd patch in the series. Re-submitted requested changes for review in new patch - "drm/amdgpu: set max df perfmon to 4". Thanks, Jon -Original Message- From: Kuehling, Felix Sent: Thursday, June 20, 2019 12:18 AM To: Kim

RE: [PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons

2019-06-20 Thread Kim, Jonathan
: Kim, Jonathan Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: update df_v3_6 for xgmi perfmons [CAUTION: External Email] On Wed, Jun 19, 2019 at 8:53 PM Kim, Jonathan wrote: > > v4: fixed kzalloc error check and modified df func init to return > error code >

[PATCH] drm/amdgpu: early merge post fix to df_v3_6 for xgmi

2019-06-20 Thread Kim, Jonathan
fixed df permon to 4 removed unrequired ret in soc15 renamed df init to df sw init and moved callback from soc15 hw init to soc15 sw init Change-Id: Ia9897612937e652e7f8a09c1d23bb1c0e6f3d8f7 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- drivers/gpu/drm/amd/amdgpu/d

[PATCH] drm/amdgpu: add sw_init to df_v1_7

2019-06-21 Thread Kim, Jonathan
add df sw init to df 1.7 function to prevent regression issues on pre-vega20 products. Change-Id: I4941003ea4a99ba0ea736c7ecc8800148423c379 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/df_v1_7.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/df_

[PATCH] drm/amdgpu: add sw_init to df_v1_7

2019-06-21 Thread Kim, Jonathan
change df_init to df_sw_init df 1.7 to prevent regression issues on pre-vega20 products when callback is called in sw_common_sw_init. Change-Id: I4941003ea4a99ba0ea736c7ecc8800148423c379 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/df_v1_7.c | 4 ++-- 1 file changed, 2 insertions(+

RE: [PATCH] drm/amdgpu: add sw_init to df_v1_7

2019-06-21 Thread Kim, Jonathan
Thanks, sorry about this. I'll be more thorough next time. Patch verified with vega20 and vega10 systems. Jon -Original Message- From: Kuehling, Felix Sent: Friday, June 21, 2019 12:10 PM To: amd-gfx@lists.freedesktop.org; Kim, Jonathan Subject: Re: [PATCH] drm/amdgpu: add sw

RE: [PATCH -next v4] drm/amdgpu: return 'ret' immediately if failed in amdgpu_pmu_init

2019-06-24 Thread Kim, Jonathan
nMing) ; dan.carpen...@oracle.com; julia.law...@lip6.fr Cc: kernel-janit...@vger.kernel.org; amd-gfx@lists.freedesktop.org; linux-ker...@vger.kernel.org; Kim, Jonathan ; Mao Wenan Subject: [PATCH -next v4] drm/amdgpu: return 'ret' immediately if failed in amdgpu_pmu_init [CAUTION: Externa

[PATCH 1/2] drm/amdgpu: add perfmon and fica atomics for df

2019-07-12 Thread Kim, Jonathan
adding perfmon and fica atomic operations to adhere to data fabrics finite state machine requirements for indirect register access. Change-Id: I2ab17fd59d566b4251c9a9d0e67b897b8c221249 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 + drivers/gpu/drm/amd/amdgpu/df_v3_

[PATCH 2/2] drm/amdgpu: adding xgmi error monitoring

2019-07-12 Thread Kim, Jonathan
monitor xgmi errors via mc pie status through fica registers. Change-Id: Id80b6c2f635a294afe343cf55a03902e9a1787a5 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 38 ++-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

RE: [PATCH 1/2] drm/amdgpu: add perfmon and fica atomics for df

2019-07-12 Thread Kim, Jonathan
PCIE macros breaks data fabric state machine. Subsequent reads after write calls to address/data offsets in macros causes unexpected behavior. Thanks, Jon -Original Message- From: Alex Deucher Sent: Friday, July 12, 2019 2:45 PM To: Kim, Jonathan Cc: amd-gfx@lists.freedesktop.org

[PATCH 3/3] drm/amdgpu: adding xgmi error monitoring

2019-07-16 Thread Kim, Jonathan
monitor xgmi errors via mc pie status through fica registers. Change-Id: Id80b6c2f635a294afe343cf55a03902e9a1787a5 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 38 ++-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[PATCH 2/3] drm/amdgpu: add perfmon and fica atomics for df

2019-07-16 Thread Kim, Jonathan
adding perfmon and fica atomic operations to adhere to data fabrics finite state machine requirements for indirect register access. Change-Id: I2ab17fd59d566b4251c9a9d0e67b897b8c221249 Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 + drivers/gpu/drm/amd/amdgpu/df_v3_

RE: [PATCH 3/3] drm/amdgpu: adding xgmi error monitoring

2019-07-16 Thread Kim, Jonathan
Note patch 1 sent to internal amd mailing list for review. -Original Message- From: Kim, Jonathan Sent: Tuesday, July 16, 2019 1:09 PM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan ; Kim, Jonathan Subject: [PATCH 3/3] drm/amdgpu: adding xgmi error monitoring monitor xgmi errors

RE: [PATCH 2/3] drm/amdgpu: add perfmon and fica atomics for df

2019-07-16 Thread Kim, Jonathan
Note patch 1 sent to internal amd mailing list for review. -Original Message- From: Kim, Jonathan Sent: Tuesday, July 16, 2019 1:09 PM To: amd-gfx@lists.freedesktop.org Cc: Kim, Jonathan ; Kim, Jonathan Subject: [PATCH 2/3] drm/amdgpu: add perfmon and fica atomics for df adding

RE: [PATCH] Revert "drm/amdgpu/gfx9: put queue resets behind a debug option"

2024-10-16 Thread Kim, Jonathan
[Public] > -Original Message- > From: Deucher, Alexander > Sent: Tuesday, October 15, 2024 4:00 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Kim, Jonathan > ; Zhu, Jiadong > Subject: [PATCH] Revert "drm/amdgpu/gfx9: put queue resets behind

RE: [PATCH] drm/amdkfd: sever xgmi io link if host driver has disable sharing

2024-10-16 Thread Kim, Jonathan
[Public] Messed up James' email in Tested-by tag. CC'ing James. > -Original Message----- > From: Kim, Jonathan > Sent: Wednesday, October 16, 2024 11:59 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish ; Kuehling, Felix > ; Kim, Jonathan ;

RE: [PATCH] drm/amdkfd: Move gfx12 trap handler to separate file

2024-10-03 Thread Kim, Jonathan
[Public] + David/Sreekant for KFD impact Acked-by: Jonathan Kim > -Original Message- > From: Cornwall, Jay > Sent: Thursday, October 3, 2024 3:31 PM > To: amd-gfx@lists.freedesktop.org > Cc: Cornwall, Jay ; Six, Lancelot > ; Kim, Jonathan > Subject: [PATCH] d

RE: [PATCH] drm/amdkfd: Copy wave state only for compute queue

2024-10-03 Thread Kim, Jonathan
[Public] > -Original Message- > From: Yang, Philip > Sent: Thursday, October 3, 2024 12:29 PM > To: amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul ; Kim, Jonathan > ; Yang, Philip > Subject: [PATCH] drm/amdkfd: Copy wave state only for compute queue > > ge

RE: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery

2025-02-07 Thread Kim, Jonathan
n that gfxhub says xgmi is ok, I think the series would start to make much more sense. Jon From: Lazar, Lijo Sent: Friday, February 7, 2025 12:35 PM To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: Re: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery

RE: [PATCH 3/4] drm/amdgpu: Add common lock and reset caller parameter for SDMA reset synchronization

2025-02-10 Thread Kim, Jonathan
[Public] > -Original Message- > From: jesse.zh...@amd.com > Sent: Monday, February 10, 2025 2:32 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Kuehling, Felix > ; Kim, Jonathan ; Zhu, > Jiadong ; Zhang, Jesse(Jie) ; > Deucher, Alex

RE: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery

2025-02-06 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, February 6, 2025 8:13 AM > To: amd-gfx@lists.freedesktop.org; Lazar, Lijo > Cc: Zhang, Hawking ; Kim, Jonathan > > Subject: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery > &

RE: [PATCH 2/4] drm/amdgpu: Add xgmi speed/width related info

2025-02-06 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, February 6, 2025 8:13 AM > To: amd-gfx@lists.freedesktop.org; Lazar, Lijo > Cc: Zhang, Hawking ; Kim, Jonathan > > Subject: [PATCH 2/4] drm/amdgpu: Add xgmi speed/width related info > >

RE: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery

2025-02-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Friday, February 7, 2025 9:20 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking > Subject: Re: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery > > > > On 2

RE: [PATCH 2/4] drm/amdgpu: Add xgmi speed/width related info

2025-02-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, February 6, 2025 10:51 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking > Subject: Re: [PATCH 2/4] drm/amdgpu: Add xgmi speed/width related info > > > > On 2

RE: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery

2025-02-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, February 6, 2025 10:56 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking > Subject: Re: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery > > > > On 2

RE: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery

2025-02-07 Thread Kim, Jonathan
easier to debug/dev later on (at least for me). Maybe someone else has a different opinion. Jon From: Lazar, Lijo Sent: Friday, February 7, 2025 11:06 AM To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: Re: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during disc

RE: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery

2025-02-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Friday, February 7, 2025 10:18 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking > Subject: Re: [PATCH 3/4] drm/amdgpu: Initialize xgmi info during discovery > > > > On 2

RE: [PATCH v2 4/4] drm/amdgpu: Use xgmi APIs for init and bandwidth

2025-02-10 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Monday, February 10, 2025 2:01 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Kim, Jonathan > Subject: [PATCH v2 4/4] drm/amdgpu: Use xgmi APIs for init and bandwidt

RE: [PATCH] drm/amdkfd: only flush the validate MES contex

2025-01-23 Thread Kim, Jonathan
[Public] > -Original Message- > From: Liang, Prike > Sent: Wednesday, January 22, 2025 4:26 AM > To: amd-gfx@lists.freedesktop.org > Cc: Koenig, Christian ; Kuehling, Felix > ; Kim, Jonathan ; > Kasiviswanathan, Harish ; Liang, Prike > > Subject: [PATCH]

RE: [PATCH] drm/amdgpu: validate process_context_addr for the MES shader debugger

2025-01-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Liang, Prike > Sent: Tuesday, January 14, 2025 12:15 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Kuehling, Felix > ; Koenig, Christian ; Kim, > Jonathan ; Liang, Prike > Subject: [PAT

RE: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset

2025-01-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Friday, January 10, 2025 10:37 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: Re: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset > >

RE: [PATCH] drm/amdgpu: validate process_context_addr for the MES shader debugger

2025-01-16 Thread Kim, Jonathan
[Public] > -Original Message- > From: Liang, Prike > Sent: Thursday, January 16, 2025 4:16 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org; Xiao, > Jack > Cc: Deucher, Alexander ; Kuehling, Felix > ; Koenig, Christian > Subject: RE: [PAT

RE: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset

2025-01-10 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, January 9, 2025 10:39 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: Re: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset > >

RE: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset

2025-01-10 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Friday, January 10, 2025 11:29 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: Re: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset > >

RE: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset

2025-01-09 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, January 9, 2025 1:14 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: Re: [PATCH] drm/amdgpu: fix gpu recovery disable with per queue reset > >

RE: [PATCH] drm/amdkfd: Block per-queue reset when halt_if_hws_hang=1

2025-01-16 Thread Kim, Jonathan
[Public] > -Original Message- > From: Cornwall, Jay > Sent: Thursday, January 16, 2025 3:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Cornwall, Jay ; Kim, Jonathan > > Subject: [PATCH] drm/amdkfd: Block per-queue reset when halt_if_hws_hang=1 > > The purpos

RE: [PATCH] drm/amdgpu: simplify xgmi peer info calls

2025-02-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Friday, February 14, 2025 12:58 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: simplify xgmi peer info calls > > > > On 2/13/2025 9:20 PM, Kim,

RE: [PATCH v3] drm/amdkfd: Fix bug in config_dequeue_wait_counts

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: amd-gfx On Behalf Of Harish > Kasiviswanathan > Sent: Friday, March 14, 2025 8:44 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: [PATCH v3] drm/amdkfd: Fix bug in config_dequeue_wait_counts > > For certain ASICs where

RE: [PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kasiviswanathan, Harish > Sent: Friday, March 14, 2025 5:04 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH v2] drm/amdkfd: Update return value of > config_dequeue_wait_counts > > [Public] &

RE: [PATCH] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: amd-gfx On Behalf Of Harish > Kasiviswanathan > Sent: Friday, March 14, 2025 12:17 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: [PATCH] drm/amdkfd: Update return value of config_dequeue_wait_counts > > .config_deque

RE: [PATCH v2] drm/amdkfd: Update return value of config_dequeue_wait_counts

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: amd-gfx On Behalf Of Harish > Kasiviswanathan > Sent: Friday, March 14, 2025 4:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: [PATCH v2] drm/amdkfd: Update return value of > config_dequeue_wait_counts > > .config_d

RE: [PATCH 1/7] drm/amd/amdgpu: Simplify SDMA reset mechanism by removing dynamic callbacks

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Alex Deucher > Sent: Thursday, March 13, 2025 10:38 AM > To: Zhang, Jesse(Jie) > Cc: Koenig, Christian ; amd- > g...@lists.freedesktop.org; Deucher, Alexander ; > Kim, Jonathan ; Zhu, Jiadong > > Subject: Re: [PATCH 1/

RE: [PATCH 1/7] drm/amd/amdgpu: Simplify SDMA reset mechanism by removing dynamic callbacks

2025-03-14 Thread Kim, Jonathan
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, March 14, 2025 5:46 PM > To: Kim, Jonathan > Cc: Zhang, Jesse(Jie) ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Zhu, Jiadong > Subject: Re: [PATCH 1/7] drm/a

RE: [PATCH] drm/amdkfd: Add rec SDMA engines support with limited XGMI

2025-04-11 Thread Kim, Jonathan
[Public] > -Original Message- > From: amd-gfx On Behalf Of Shane > Xiao > Sent: Thursday, April 10, 2025 12:40 AM > To: amd-gfx@lists.freedesktop.org; Kim, Jonathan > Cc: Xiao, Shane > Subject: [PATCH] drm/amdkfd: Add rec SDMA engines support with limited XGM

RE: [PATCH V7 3/9] drm/amdgpu: Add common lock and reset caller parameter for SDMA reset synchronization

2025-02-18 Thread Kim, Jonathan
[Public] > -Original Message- > From: Lazar, Lijo > Sent: Monday, February 17, 2025 10:36 PM > To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Kuehling, Felix > ; Kim, Jonathan ; Zhu, > Jiadong > Subject: Re: [PATCH V7 3/9] drm

RE: [PATCH 1/4] drm/amdkfd: Rename grace_period to wait_times

2025-02-18 Thread Kim, Jonathan
[Public] > -Original Message- > From: amd-gfx On Behalf Of Harish > Kasiviswanathan > Sent: Wednesday, February 12, 2025 5:04 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kasiviswanathan, Harish > Subject: [PATCH 1/4] drm/amdkfd: Rename grace_period to wait_times > > Rename .set_grace_pe

<    1   2   3   >