Re: [PATCH] drm/amd/display: fix IPX enablement

[Public] Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas From: Mahfooz, Hamza Sent: Friday, March 22, 2024 2:56 PM To: amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas ; Li, Roman ; Li, Sun peng (Leo) ; Wentland, Harry ; Deucher

Re: [PATCH 2/6] drm/amd/display: Add DP 2.0 HPO Stream Encoder

On 2021-08-16 4:59 p.m., Fangzhi Zuo wrote: HW Blocks: ++ +-+ +--+ | OPTC | | HDA | | HUBP | ++ +-+ +--+ | || | || HPO |==|| | |

Re: [PATCH v3 5/6] drm/amd/display: Add DP 2.0 BIOS and DMUB Support

On 2021-08-19 2:58 p.m., Fangzhi Zuo wrote: Parse DP2 encoder caps and hpo instance from bios Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 ++ drivers/gpu/drm/amd/display/dc/bios/command_table2.c | 10 ++ .../drm/amd/display/dc

Re: [PATCH v2] drm/amd/display: Fix two cursor duplication when using overlay

On 2021-08-24 9:59 a.m., Simon Ser wrote: Hi Rodrigo! Thanks a lot for your reply! Comments below, please bear with me: I'm a bit familiar with the cursor issues, but my knowledge of AMD hw is still severely lacking. On Wednesday, August 18th, 2021 at 15:18, Rodrigo Siqueira wrote: On 08/18

Re: [PATCH 3/7] drm/amd/display: Use vblank control events for PSR enable/disable

On 2021-09-04 10:36 a.m., Mike Lothian wrote: Hi This patch is causing issues on my PRIME system I've opened https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1700&data=04%7C01%7Cnicholas.kazlauskas%40amd.com%7Cd230db90a08d4b530

Re: [PATCH] amd/display: downgrade validation failure log level

On 2021-09-07 10:19 a.m., Simon Ser wrote: In amdgpu_dm_atomic_check, dc_validate_global_state is called. On failure this logs a warning to the kernel journal. However warnings shouldn't be used for atomic test-only commit failures: user-space might be perfoming a lot of atomic test-only commits

Re: [PATCH] drm/amd/display: Fix white screen page fault for gpuvm

On 2021-09-13 3:13 p.m., Alex Deucher wrote: Acked-by: Alex Deucher Can you add a fixes: tag? Alex Sure, I think the relevant patch is: Fixes: 64b1d0e8d50 ("drm/amd/display: Add DCN3.1 HWSEQ") Regards, Nicholas Kazlauskas On Mon, Sep 13, 2021 at 3:11 PM Nicholas Kazlauskas wrote: [Wh

Re: [PATCH] drm/amd/display: Enable PSR by default on DCN3.1

On 2021-10-11 1:04 a.m., Vishwakarma, Pratik wrote: On 10/8/2021 9:44 PM, Nicholas Kazlauskas wrote: [Why] New idle optimizations for DCN3.1 require PSR for optimal power savings on panels that support it. This was previously left disabled by default because of issues with compositors that do

Re: [PATCH 16/27] drm/amd/display: increase Z9 latency to workaround underflow in Z9

On 2021-10-15 7:53 p.m., Mike Lothian wrote: This patch seems to change z8 - not that I know what z8 or z9 are It's a little misleading but the patch and terminology is correct. Z9 is the usecase for these watermarks even if the calculation is shared with Z8/Z9. Regards, Nicholas Kazlauskas

Re: [PATCH] drm/amdgpu/display: add yellow carp B0 with rest of driver

On 2021-10-20 9:53 a.m., Alex Deucher wrote: Fix revision id. Fixes: 626cbb641f1052 ("drm/amdgpu: support B0&B1 external revision id for yellow carp") Signed-off-by: Alex Deucher Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/include/dal_a

Re: [PATCH 32/33] drm/amd/display: fix link training regression for 1 or 2 lane

On 2021-10-25 9:58 a.m., Harry Wentland wrote: On 2021-10-25 07:25, Paul Menzel wrote: Dear Wenjing, dear Rodrigo, On 24.10.21 15:31, Rodrigo Siqueira wrote: From: Wenjing Liu [why] We have a regression that cause maximize lane settings to use uninitialized data from unused lanes. Which

Re: [PATCH] drm/amd/display: Fix error handling on waiting for completion

On 2021-10-26 7:07 a.m., Stylon Wang wrote: [Why] In GNOME Settings->Display the switching from mirror mode to single display occasionally causes wait_for_completion_interruptible_timeout() to return -ERESTARTSYS and fails atomic check. [How] Replace the call with wait_for_completion_timeout() s

Re: [PATCH] drm/amd/display: Fix error handling on waiting for completion

On 2021-10-26 11:51 a.m., Michel Dänzer wrote: On 2021-10-26 13:07, Stylon Wang wrote: [Why] In GNOME Settings->Display the switching from mirror mode to single display occasionally causes wait_for_completion_interruptible_timeout() to return -ERESTARTSYS and fails atomic check. [How] Replace t

Re: [PATCH] drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not set

On 2021-10-28 10:46 a.m., Alex Deucher wrote: ping On Wed, Oct 27, 2021 at 6:40 PM Alex Deucher wrote: Need to guard some things with CONFIG_DRM_AMD_DC_DCN. Fixes: 707021dc0e16f6 ("drm/amd/display: Enable dpia in dmub only for DCN31 B0") Signed-off-by: Alex Deucher Reviewed-by: Nicholas K

Re: [PATCH] drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DCN is not set

On 2021-10-28 10:46 a.m., Alex Deucher wrote: Ping On Wed, Oct 27, 2021 at 6:40 PM Alex Deucher wrote: Need to guard some things with CONFIG_DRM_AMD_DC_DCN. Fixes: 0c865d1d817b77 ("drm/amd/display: fix link training regression for 1 or 2 lane") Signed-off-by: Alex Deucher Reviewed-by: Ni

Re: [PATCH] drm/amd/display: Reduce dmesg error to a debug print

On 2021-11-12 10:56 a.m., Leo (Hanghong) Ma wrote: [Why & How] Dmesg errors are found on dcn3.1 during reset test, but it's not a really failure. So reduce it to a debug print. Signed-off-by: Leo (Hanghong) Ma This is expected to occur on displays that aren't connected/don't support LTTPR so

Re: [PATCH v1] drm/amd/display: Add DP-HDMI PCON SST Support

On 2021-11-24 12:28 p.m., Fangzhi Zuo wrote: 1. Parse DSC caps from PCON DPCD 2. Determine policy if decoding DSC at PCON 3. Enable/disable DSC at PCON Signed-off-by: Fangzhi Zuo Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_d

Re: [PATCH v2] drm/amd/display: Add DP-HDMI FRL PCON Support in DC

On 2021-11-26 9:32 a.m., Fangzhi Zuo wrote: Change since v1: add brief description 1. Add hdmi frl pcon support to existing asic family. 2. Determine pcon frl capability based on pcon dpcd. 3. pcon frl is taken into consideration into mode validation. Signed-off-by: Fangzhi Zuo Reviewed-by: N

Re: [PATCH v2] drm/amd/display: Use oriented source size when checking cursor scaling

On 2021-12-02 7:52 a.m., Vlad Zahorodnii wrote: dm_check_crtc_cursor() doesn't take into account plane transforms when calculating plane scaling, this can result in false positives. For example, if there's an output with resolution 3840x2160 and the output is rotated 90 degrees, CRTC_W and CRTC_

Re: [PATCH v1] drm/amd/display: Add Debugfs Entry to Force in SST Sequence

On 2021-12-07 1:55 p.m., Fangzhi Zuo wrote: It is w/a to check DP2 SST behavior on M42d box. Isn't this useful beyond just the m42d/dp2? This should affect regular DP MST support I think. Adding this debug flag is okay I think, but I think the names should be updated (inline). Signed-off-

Re: [PATCH] drm/amdgpu: add DMUB outbox event IRQ source define/complete/debug flag

On 2021-03-31 11:21 p.m., Jude Shih wrote: [Why & How] We use outbox interrupt that allows us to do the AUX via DMUB Therefore, we need to add some irq source related definition in the header files; Also, I added debug flag that allows us to turn it on/off for testing purpose. Missing your sign

Re: [PATCH] drm/amdgpu: add DMUB outbox event IRQ source define/complete/debug flag

On 2021-04-06 9:40 a.m., Jude Shih wrote: [Why & How] We use outbox interrupt that allows us to do the AUX via DMUB Therefore, we need to add some irq source related definition in the header files; Also, I added debug flag that allows us to turn it on/off for testing purpose. Signed-off-by: Jude

Re: [PATCH] drm/amdgpu: add DMUB outbox event IRQ source define/complete/debug flag

eloper testing we can hardcode the flag = true, I think the DC debug flags here in AMDGPU base driver only have value if we want general end user or validation to use this to debug potential issues. Regards, Nicholas Kazlauskas Thanks, Best Regards, Jude -Original Message- From:

Re: [PATCH] drm/amd/display: Reject non-zero src_y and src_x for video planes

On 2021-04-22 7:20 p.m., Harry Wentland wrote: [Why] This hasn't been well tested and leads to complete system hangs on DCN1 based systems, possibly others. The system hang can be reproduced by gesturing the video on the YouTube Android app on ChromeOS into full screen. [How] Reject atomic comm

Re: [PATCH] drm/amd/display: Make underlay rules less strict

On 2021-05-07 10:37 a.m., Rodrigo Siqueira wrote: Currently, we reject all conditions where the underlay plane goes outside the overlay plane limits, which is not entirely correct since we reject some valid cases like the ones illustrated below: ++ ++

Re: [PATCH] drm/amd/display: Move plane code from amdgpu_dm to amdgpu_dm_plane

On 2021-05-07 10:39 a.m., Rodrigo Siqueira wrote: The amdgpu_dm file contains most of the code that works as an interface between DRM API and Display Core. We maintain all the plane operations inside amdgpu_dm; this commit extracts the plane code to its specific file named amdgpu_dm_plane. This c

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

[AMD Official Use Only] > -Original Message- > From: Limonciello, Mario > Sent: January 7, 2022 11:50 AM > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Kazlauskas, Nicholas > ; Zhuo, Qingqing (Lillian) > ; Scott Bruce ; Chris > Hixon ; spassw...@

Re: [PATCH] drm/amd/display: reset dcn31 SMU mailbox on failures

On 2022-01-07 4:40 p.m., Mario Limonciello wrote: Otherwise future commands may fail as well leading to downstream problems that look like they stemmed from a timeout the first time but really didn't. Signed-off-by: Mario Limonciello I guess we used to do this but after we started adding the

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

[Public] > -Original Message- > From: Limonciello, Mario > Sent: January 14, 2022 10:38 AM > To: Chris Hixon ; Kazlauskas, Nicholas > ; amd-gfx@lists.freedesktop.org > Cc: Zhuo, Qingqing (Lillian) ; Scott Bruce > ; spassw...@web.de > Subject: RE: [PATCH v5] drm

Re: [PATCH] drm/amd/display: Copy crc_skip_count when duplicating CRTC state

On 1/18/2022 11:40 AM, Rodrigo Siqueira wrote: From: Leo Li [Why] crc_skip_count is used to track how many frames to skip to allow the OTG CRC engine to "warm up" before it outputs correct CRC values. Experimentally, this seems to be 2 frames. When duplicating CRTC states, this value was not c

Re: [PATCH] drm/amd/display: Cap pflip irqs per max otg number

On 2/3/2022 5:14 PM, roman...@amd.com wrote: From: Roman Li [Why] pflip interrupt order are mapped 1 to 1 to otg id. e.g. if irq_src=26 corresponds to otg0 then 27->otg1, 28->otg2... Linux DM registers pflip interrupts per number of crtcs. In fused pipe case crtc numbers can be less than otg i

Re: [PATCH] drm/amd/display: take dc_lock in short pulse handler only

On 2021-05-19 4:55 p.m., Aurabindo Pillai wrote: [Why] Conditions that end up modifying the global dc state must be locked. However, during mst allocate payload sequence, lock is already taken. With StarTech 1.2 DP hub, we get an HPD RX interrupt for a reason other than to indicate down reply ava

Re: [PATCH] drm/amdgpu/display: make backlight setting failure messages debug

On 2021-05-21 12:08 a.m., Alex Deucher wrote: Avoid spamming the log. The backlight controller on DCN chips gets powered down when the display is off, so if you attempt to set the backlight level when the display is off, you'll get this message. This isn't a problem as we cache the requested ba

Re: [PATCH 2/2] drm/amdgpu/dc: fix DCN3.1 FP handling

On 2021-06-04 2:16 p.m., Alex Deucher wrote: Missing proper DC_FP_START/DC_FP_END. Signed-off-by: Alex Deucher Thanks for catching these. Series is Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas --- .../drm/amd/display/dc/dcn31/dcn31_resource.c | 18 +-

Re: [PATCH] drm/amdgpu/display: fold DRM_AMD_DC_DCN3_1 into DRM_AMD_DC_DCN

On 2021-06-21 4:58 p.m., Alex Deucher wrote: No need for a separate flag now that DCN3.1 is not in bring up. Fold into DRM_AMD_DC_DCN like previous DCN IPs. Signed-off-by: Alex Deucher Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/Kconfig

Re: [PATCH] drm/amd/display: use correct scale for actual_brightness

This is a cleaner change the other proposed patch since it doesn't need to modify the exist conversion functions but I'd be worried about broken userspace relying on 0-255 as the only acceptable range. Not an expert on existing implementations to point out a specific one though. Regards, Nic

Re: [PATCH] drm/amd/display: use correct scale for actual_brightness

On 2020-08-03 4:02 p.m., Alexander Monakov wrote: Documentation for sysfs backlight level interface requires that values in both 'brightness' and 'actual_brightness' files are interpreted to be in range from 0 to the value given in the 'max_brightness' file. With amdgpu, max_brightness gives 255

Re: [PATCH] drm/amd/display: use correct scale for actual_brightness

On 2020-08-04 12:28 p.m., Alexander Monakov wrote: On Tue, 4 Aug 2020, Kazlauskas, Nicholas wrote: This is a cleaner change the other proposed patch since it doesn't need to Can you give a URL to the other patch please? Sorry, replied to the wrong email by accident here. The

Re: [PATCH 7/7] drm/amd/display: Replace DRM private objects with subclassed DRM atomic state

On 2020-08-05 4:37 p.m., Rodrigo Siqueira wrote: Hi, I have some minor inline comments, but everything looks fine when I tested it on Raven; feel free to add Tested-by: Rodrigo Siqueira in the whole series. Thanks for the reviews! I can clean up the nitpicks for this patch and make a v2.

Re: [PATCH 2/7] drm/amd/display: Reset plane when tiling flags change

On 2020-08-05 5:11 p.m., Rodrigo Siqueira wrote: On 07/30, Nicholas Kazlauskas wrote: [Why] Enabling or disable DCC or switching between tiled and linear formats can require bandwidth updates. They're currently skipping all DC validation by being treated as purely surface updates. [How] Treat

Re: [PATCH 5/7] drm/amd/display: Reset plane for anything that's not a FAST update

On 2020-08-05 4:45 p.m., Rodrigo Siqueira wrote: On 07/30, Nicholas Kazlauskas wrote: [Why] MEDIUM or FULL updates can require global validation or affect bandwidth. By treating these all simply as surface updates we aren't actually passing this through DC global validation. [How] There's curre

Re: [PATCH 5/7] drm/amd/display: Reset plane for anything that's not a FAST update

On 2020-08-07 4:34 a.m., dan...@ffwll.ch wrote: On Thu, Jul 30, 2020 at 04:36:40PM -0400, Nicholas Kazlauskas wrote: [Why] MEDIUM or FULL updates can require global validation or affect bandwidth. By treating these all simply as surface updates we aren't actually passing this through DC global v

Re: [PATCH 3/7] drm/amd/display: Avoid using unvalidated tiling_flags and tmz_surface in prepare_planes

On 2020-08-07 4:30 a.m., dan...@ffwll.ch wrote: On Thu, Jul 30, 2020 at 04:36:38PM -0400, Nicholas Kazlauskas wrote: [Why] We're racing with userspace as the flags could potentially change from when we acquired and validated them in commit_check. Uh ... I didn't know these could change. I thin

Re: [PATCH 7/7] drm/amd/display: Replace DRM private objects with subclassed DRM atomic state

On 2020-08-07 4:52 a.m., dan...@ffwll.ch wrote: On Thu, Jul 30, 2020 at 04:36:42PM -0400, Nicholas Kazlauskas wrote: @@ -440,7 +431,7 @@ struct dm_crtc_state { #define to_dm_crtc_state(x) container_of(x, struct dm_crtc_state, base) struct dm_atomic_state { - struct drm_private_stat

Re: [PATCH v2] drm/amd/display: use correct scale for actual_brightness

No objections from my side - and thanks for addressing my feedback. Regards, Nicholas Kazlauskas On 2020-08-18 12:15 p.m., Alex Deucher wrote: Applied. Thanks! Alex On Mon, Aug 17, 2020 at 1:59 PM Alex Deucher wrote: On Mon, Aug 17, 2020 at 3:09 AM Alexander Monakov wrote: Ping. Patc

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

On 2020-08-21 12:57 p.m., Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: * Hence drivers must not consult @active in their various * &drm_mode_config_funcs.atomic_check callback to reject an atom

Re: [PATCH] drm/amd/display: Add DPCS regs for dcn3 link encoder

On 2020-08-24 11:11 a.m., Bhawanpreet Lakha wrote: dpcs reg are missing for dcn3 link encoder regs list, so add them. Also remove DPCSTX_DEBUG_CONFIG and RDPCSTX_DEBUG_CONFIG as they are unused and cause compile errors for dcn3 Signed-off-by: Bhawanpreet Lakha Reviewed-by: Nicholas Kazlauska

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

On 2020-08-22 5:59 a.m., Michel Dänzer wrote: On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: On 2020-08-21 12:57 p.m., Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h:   * Hence drivers

Re: [PATCH 1/3] drm/amdgpu: Move existing pflip fields into separate struct

On 2020-09-09 10:28 a.m., Aurabindo Pillai wrote: [Why&How] To refactor DM IRQ management, all fields used by IRQ is best moved to a separate struct so that main amdgpu_crtc struct need not be changed Location of the new struct shall be in DM Signed-off-by: Aurabindo Pillai Reviewed-by: Nicho

Re: [PATCH 2/3] drm/amd/display: Refactor to prevent crtc state access in DM IRQ handler

On 2020-09-09 10:28 a.m., Aurabindo Pillai wrote: [Why&How] Currently commit_tail holds global locks and wait for dependencies which is against the DRM API contracts. Inorder to fix this, IRQ handler should be able to run without having to access crtc state. Required parameters are copied over so

Re: [PATCH 3/3] drm/amd/display: Move disable interrupt into commit tail

On 2020-09-09 10:28 a.m., Aurabindo Pillai wrote: [Why&How] Since there is no need for accessing crtc state in the interrupt handler, interrupts need not be disabled well in advance, and can be moved to commit_tail where it should be. Signed-off-by: Aurabindo Pillai This patch is fine in idea

Re: [PATCH v2 3/3] drm/amd/display: Move disable interrupt into commit tail

On 2020-09-11 12:27 p.m., Aurabindo Pillai wrote: [Why&How] Since there is no need for accessing crtc state in the interrupt handler, interrupts need not be disabled well in advance, and can be moved to commit_tail where it should be. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/displa

Re: [PATCH v2 3/4] drm/amd/display: Add pipe_state tracepoint

On 2020-09-11 10:59 a.m., Rodrigo Siqueira wrote: This commit introduces a trace mechanism for struct pipe_ctx by adding a middle layer struct in the amdgpu_dm_trace.h for capturing the most important data from struct pipe_ctx and showing its data via tracepoint. This tracepoint was added to dc.c

Re: [PATCH v2 1/4] drm/amd/display: Rework registers tracepoint

On 2020-09-11 10:59 a.m., Rodrigo Siqueira wrote: amdgpu_dc_rreg and amdgpu_dc_wreg are very similar, for this reason, this commits abstract these two events by using DECLARE_EVENT_CLASS and create an instance of it for each one of these events. Signed-off-by: Rodrigo Siqueira This looks reas

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

On 2020-09-14 3:52 a.m., Michel Dänzer wrote: On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h:   * Hence driver

Re: [PATCH v2] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

On 2020-09-14 11:22 a.m., Michel Dänzer wrote: On 2020-09-14 4:37 p.m., Kazlauskas, Nicholas wrote: On 2020-09-14 3:52 a.m., Michel Dänzer wrote: On 2020-09-07 9:57 a.m., Daniel Vetter wrote: On Fri, Sep 04, 2020 at 12:43:04PM +0200, Michel Dänzer wrote: From: Michel Dänzer Don't

Re: [PATCH v2 0/4] Enlarge tracepoints in the display component

On 2020-09-16 5:12 a.m., Daniel Vetter wrote: On Fri, Sep 11, 2020 at 10:59:23AM -0400, Rodrigo Siqueira wrote: Debug issues related to display can be a challenge due to the complexity around this topic and different source of information might help in this process. We already have support for t

Re: [PATCH] drm/amd/display: Add missing "Copy GSL groups when committing a new context"

On 2020-09-16 1:08 p.m., Bhawanpreet Lakha wrote: [Why] "Copy GSL groups when committing a new context" patch was accidentally removed during a refactor Patch: 21ffcc94d5b ("drm/amd/display: Copy GSL groups when committing a new context") [How] Re add it Fixes: b6e881c9474 ("drm/amd/display:

Re: [PATCH] drm/amdgpu/dc: Pixel encoding DRM property and module parameter

On 2020-09-28 3:31 p.m., Christian König wrote: Am 28.09.20 um 19:35 schrieb James Ettle: On Mon, 2020-09-28 at 10:26 -0400, Harry Wentland wrote: On 2020-09-25 5:18 p.m., Alex Deucher wrote: On Tue, Sep 22, 2020 at 4:51 PM James Ettle wrote: On 22/09/2020 21:33, Alex Deucher wrote: +/** +

Re: [PATCH] drm/amd/display: Fix external display detection with overlay

On 2020-10-01 5:06 a.m., Pratik Vishwakarma wrote: [Why] When overlay plane is in use and external display is connected, atomic check will fail. [How] Disable overlay plane on multi-monitor scenario by tying it to single crtc. Signed-off-by: Pratik Vishwakarma This will break overlay usage o

Re: [PATCH] drm/amd/display: Add missing function pointers for dcn3

On 2020-10-05 2:10 p.m., Bhawanpreet Lakha wrote: These function pointers are missing from dcn30_init .calc_vupdate_position .set_pipe So add them Signed-off-by: Bhawanpreet Lakha Reviewed-by: Nicholas Kazlauskas Would be good to mention what these are used for specifically though. The c

Re: [PATCH 1/2] drm/amd/display: setup system context in dm_init

On 2020-10-14 3:04 a.m., Yifan Zhang wrote: Change-Id: I831a5ade8b87c23d21a63d08cc4d338468769e2b Signed-off-by: Yifan Zhang --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_d

Re: [PATCH 1/2] drm/amd/display: setup system context in dm_init

On 2020-10-14 9:20 a.m., Kazlauskas, Nicholas wrote: On 2020-10-14 3:04 a.m., Yifan Zhang wrote: Change-Id: I831a5ade8b87c23d21a63d08cc4d338468769e2b Signed-off-by: Yifan Zhang ---   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 61 +++   1 file changed, 61 insertions(+) diff

Re: [PATCH 2/2] drm/amd/display: Avoid MST manager resource leak.

On 2020-10-15 11:02 p.m., Alex Deucher wrote: On Wed, Oct 14, 2020 at 1:25 PM Andrey Grodzovsky wrote: On connector destruction call drm_dp_mst_topology_mgr_destroy to release resources allocated in drm_dp_mst_topology_mgr_init. Do it only if MST manager was initialized before otherwsie a cras

Re: [PATCH] drm/amd/display: Fix deadlock during gpu reset

On 2021-01-11 2:55 p.m., Bhawanpreet Lakha wrote: [Why] during idle optimizations we acquire the dc_lock, this lock is also acquired during gpu_reset so we end up hanging the system due to a deadlock [How] If we are in gpu reset dont acquire the dc lock, as we already have it Are we sure this

Re: [PATCH] drm/amd/display: Fix deadlock during gpu reset v3

On 2021-01-12 11:13 a.m., Bhawanpreet Lakha wrote: [Why] during idle optimizations we acquire the dc_lock, this lock is also acquired during gpu_reset so we end up hanging the system due to a deadlock [How] If we are in gpu reset: - disable idle optimizations and skip calls to the dc function

Re: [PATCH 3/3] drm/amd/display: Update dcn30_apply_idle_power_optimizations() code

On 2021-01-19 3:38 p.m., Bhawanpreet Lakha wrote: Update the function for idle optimizations -remove hardcoded size -enable no memory-request case -add cursor copy -update mall eligibility check case Signed-off-by: Bhawanpreet Lakha Signed-off-by: Joshua Aberback Series is: Reviewed-by: Nic

Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

On 2021-01-19 3:40 p.m., Bhawanpreet Lakha wrote: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from within DC. [How] Call amdgpu_bo_create_kernel to allocate GPU memory and use a list in amdgpu_display

Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

On 2021-01-20 5:26 a.m., Christian König wrote: Am 19.01.21 um 21:40 schrieb Bhawanpreet Lakha: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from within DC. [How] Call amdgpu_bo_create_kernel to alloc

Re: [PATCH 3/3] drm/amd/display: Skip modeset for front porch change

On 2021-01-19 10:50 a.m., Aurabindo Pillai wrote: [Why] A seamless transition between modes can be performed if the new incoming mode has the same timing parameters as the optimized mode on a display with a variable vtotal min/max. Smooth video playback usecases can be enabled with this seamless

Re: [PATCH 2/2] drm/amd/display: Fix HDMI deep color output for DCE 6-11.

On 2021-01-25 12:57 p.m., Alex Deucher wrote: On Thu, Jan 21, 2021 at 1:17 AM Mario Kleiner wrote: This fixes corrupted display output in HDMI deep color 10/12 bpc mode at least as observed on AMD Mullins, DCE-8.3. It will hopefully also provide fixes for other DCE's up to DCE-11, assuming th

Re: [PATCH 3/3] drm/amd/display: Skip modeset for front porch change

On 2021-01-24 11:00 p.m., Aurabindo Pillai wrote: On 2021-01-21 2:05 p.m., Kazlauskas, Nicholas wrote: On 2021-01-19 10:50 a.m., Aurabindo Pillai wrote: [Why] A seamless transition between modes can be performed if the new incoming mode has the same timing parameters as the optimized mode on

Re: [PATCH] Revert "drm/amd/display: move edp sink present detection to hw init"

On 2021-02-08 2:25 p.m., Anson Jacob wrote: This reverts commit de6571ecbb88643fa4bb4172e65c12795a2f3124. Patch causes regression in resume time. Shouldn't affect any system that has an eDP connector on the board since it's expected to be present in end user configuration. If we want to rep

Re: [PATCH] Revert "drm/amd/display: reuse current context instead of recreating one"

On 2021-02-10 9:25 a.m., Alex Deucher wrote: This reverts commit 8866a67ab86cc0812e65c04f1ef02bcc41e24d68. This breaks hotplug of HDMI on some systems, resulting in a blank screen. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=211649>> Signed-off-by: Alex Deucher --- Hotplug is still wor

Re: [PATCH 2/2] amd/display: add cursor check for YUV primary plane

On 2021-02-19 11:19 a.m., Simon Ser wrote: The cursor plane can't be displayed if the primary plane isn't using an RGB format. Reject such atomic commits so that user-space can have a fallback instead of an invisible cursor. In theory we could support YUV if the cursor is also YUV, but at the mo

Re: [PATCH 2/2] amd/display: add cursor check for YUV primary plane

On 2021-02-19 12:29 p.m., Simon Ser wrote: On Friday, February 19th, 2021 at 6:22 PM, Kazlauskas, Nicholas wrote: We can support cursor plane, but only if we have an overlay plane enabled that's using XRGB/ARGB. This is what we do on Chrome OS for video playback: Cursor Plane - ARG

Re: [PATCH] drm/amdgpu: stream's id should reduced after stream destruct

On 2021-02-20 1:30 a.m., ZhiJie.Zhang wrote: Signed-off-by: ZhiJie.Zhang --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c index c103f8583

Re: [PATCH] drm/amdgpu/display: fix compilation when CONFIG_DRM_AMD_DC_DCN is not set

On 2021-02-23 10:22 a.m., Alex Deucher wrote: Missing some CONFIG_DRM_AMD_DC_DCN ifdefs. Fixes: 9d99a805a9a0 ("drm/amd/display: Fix system hang after multiple hotplugs") Signed-off-by: Alex Deucher Cc: Stephen Rothwell Cc: Qingqing Zhuo Reviewed-by: Nicholas Kazlauskas Regards, Nicholas K

Re: [PATCH v6 3/3] drm/amd/display: Skip modeset for front porch change

On 2021-02-12 8:08 p.m., Aurabindo Pillai wrote: [Why] A seamless transition between modes can be performed if the new incoming mode has the same timing parameters as the optimized mode on a display with a variable vtotal min/max. Smooth video playback usecases can be enabled with this seamless

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

On 2021-03-04 4:05 a.m., Michel Dänzer wrote: On 2021-03-03 8:17 p.m., Daniel Vetter wrote: On Wed, Mar 3, 2021 at 5:53 PM Michel Dänzer wrote: On 2021-02-19 7:58 p.m., Simon Ser wrote: Make sure there's an underlying pipe that can be used for the cursor. Signed-off-by: Simon Ser Cc: Alex

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

On 2021-03-04 10:35 a.m., Michel Dänzer wrote: On 2021-03-04 4:09 p.m., Kazlauskas, Nicholas wrote: On 2021-03-04 4:05 a.m., Michel Dänzer wrote: On 2021-03-03 8:17 p.m., Daniel Vetter wrote: On Wed, Mar 3, 2021 at 5:53 PM Michel Dänzer wrote: Moreover, in the same scenario plus an overlay

Re: [PATCH 2/4] drm/amdgpu/display: don't assert in set backlight function

On 2021-03-04 12:41 p.m., Alex Deucher wrote: It just spams the logs. Signed-off-by: Alex Deucher This series in general looks reasonable to me: Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/

Re: [PATCH 2/4] drm/amdgpu/display: don't assert in set backlight function

On 2021-03-04 1:41 p.m., Alex Deucher wrote: On Thu, Mar 4, 2021 at 1:33 PM Kazlauskas, Nicholas wrote: On 2021-03-04 12:41 p.m., Alex Deucher wrote: It just spams the logs. Signed-off-by: Alex Deucher This series in general looks reasonable to me: Reviewed-by: Nicholas Kazlauskas

Re: [PATCH 3/6] amd/display: fail on cursor plane without an underlying plane

On 2021-03-08 3:18 p.m., Daniel Vetter wrote: On Fri, Mar 5, 2021 at 10:24 AM Michel Dänzer wrote: On 2021-03-04 7:26 p.m., Kazlauskas, Nicholas wrote: On 2021-03-04 10:35 a.m., Michel Dänzer wrote: On 2021-03-04 4:09 p.m., Kazlauskas, Nicholas wrote: On 2021-03-04 4:05 a.m., Michel Dänzer

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

On 2020-05-15 1:19 a.m., Mario Kleiner wrote: Testing on a Polaris11 gpu with DCE-11.2 suggests that it seems to work fine there, so optimistically enable it for DCE-11 and later. Signed-off-by: Mario Kleiner Series is: Reviewed-by: Nicholas Kazlauskas Thanks! --- drivers/gpu/drm/amd/d

Re: [PATCH] drm/amd/display: Handle GPU reset for DC block

On 2020-05-20 11:29 a.m., Bhawanpreet Lakha wrote: [Why] Previously we used the s3 codepath for gpu reset. This can lead to issues in certain case where we end of waiting for fences which will never come (because parts of the hw are off due to gpu reset) and we end up waiting forever causing a de

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

On 2020-05-20 2:44 p.m., Mario Kleiner wrote: On Wed, May 20, 2020 at 8:25 PM Alex Deucher > wrote: On Wed, May 20, 2020 at 12:39 PM Harry Wentland mailto:hwent...@amd.com>> wrote: > > On 2020-05-15 1:19 a.m., Mario Kleiner wrote: > > Testing on a

Re: [PATCH] drm/amd/display: Handle GPU reset for DC block

On 2020-05-22 10:45 a.m., Alex Deucher wrote: On Thu, May 21, 2020 at 5:39 PM Bhawanpreet Lakha wrote: [Why] Previously we used the s3 codepath for gpu reset. This can lead to issues in certain case where we end of waiting for fences which will never come (because parts of the hw are off due t

Re: [PATCH] drm/amdgpu/display: fix logic inversion in program_timing_sync()

On Tue, Feb 4, 2020 at 9:06 AM Kazlauskas, Nicholas wrote: Comments inline. On 2020-02-03 4:07 p.m., Alex Deucher wrote: Ping? On Fri, Jan 10, 2020 at 3:11 PM Alex Deucher wrote: It looks like we should be reducing the group size when we don't have a plane rather than when we do.

Re: [PATCH] Revert "drm/amd/display: disable dcn20 abm feature for bring up"

On 2020-05-28 10:08 a.m., Alex Deucher wrote: On Thu, May 28, 2020 at 9:47 AM Harry Wentland wrote: This reverts commit 96cb7cf13d8530099c256c053648ad576588c387. This change was used for DCN2 bringup and is no longer desired. In fact it breaks backlight on DCN2 systems. Cc: Alexander Monakov

Re: [PATCH] drm/amdgpu/display: drop the reduction loop when setting the sync groups

On 2020-05-28 10:06 a.m., Alex Deucher wrote: The logic for blanked is not the same as having a plane_state. Technically you can drive an OTG without anything connected in the front end and it'll just draw out the back color which is distinct from having the OTG be blanked. If we add planes or un

Re: [PATCH] drm/amdgpu/display: drop the reduction loop when setting the sync groups

On 2020-05-29 2:04 p.m., Alex Deucher wrote: On Fri, May 29, 2020 at 9:56 AM Kazlauskas, Nicholas wrote: On 2020-05-28 10:06 a.m., Alex Deucher wrote: The logic for blanked is not the same as having a plane_state. Technically you can drive an OTG without anything connected in the front end

Re: [PATCH] drm/amdgpu/display: use blanked rather than plane state for sync groups

On 2020-06-02 5:25 p.m., Alex Deucher wrote: We may end up with no planes set yet, depending on the ordering, but we should have the proper blanking state which is either handled by either DPG or TG depending on the hardware generation. Check both to determine the proper blanked state. Bug: htt

Re: [PATCH] drm/amdgpu/display: fix build without CONFIG_DRM_AMD_DC_DCN3_0

On 2020-06-03 2:00 p.m., Alex Deucher wrote: Need to guard some new DCN3.0 stuff. Signed-off-by: Alex Deucher Reviewed-by: Nicholas Kazlauskas Thanks! Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) d

Re: [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig

On 2020-06-19 11:27 a.m., Alex Deucher wrote: On Thu, Jun 18, 2020 at 3:49 PM Qingqing Zhuo wrote: when compiled with allmodconfig option, there are error messages as below: ERROR: modpost: "mod_color_is_table_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "mod_color_

Re: [PATCH 04/11] drm/amd/display: Handle SMU msg response

On 2020-06-26 12:48 p.m., Alex Deucher wrote: On Fri, Jun 26, 2020 at 12:19 PM Eryk Brol wrote: From: Yongqiang Sun [Why] SMU may return error code to driver, but driver only check if response is OK. [How] Check SMU response instead of reg_wait, assert in case of reponse isn't OK. Will yo

Re: [PATCH] Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates"

On 2020-06-29 11:36 a.m., Alex Deucher wrote: Seems to cause stability issues for some users. This reverts commit a24eaa5c51255b344d5a321f1eeb3205f2775498. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1191 Signed-off-by: Alex Deucher I don't see the error in their log. How do we know

Re: [PATCH] Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates"

On 2020-06-29 11:40 a.m., Kazlauskas, Nicholas wrote: On 2020-06-29 11:36 a.m., Alex Deucher wrote: Seems to cause stability issues for some users. This reverts commit a24eaa5c51255b344d5a321f1eeb3205f2775498. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1191 Signed-off-by: Alex

Re: [PATCH] drm/amd/display: add dmcub check on RENOIR

Looks good to me. Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas On 2020-07-08 10:15 a.m., Deucher, Alexander wrote: [AMD Public Use] [AMD Public Use] Acked-by: Alex Deucher *From:* Aaron Ma *Sent:*

Re: [PATCH] drm/amdgpu/display: create fake mst encoders ahead of time (v2)

On 2020-07-10 9:58 a.m., Alex Deucher wrote: Prevents a warning in the MST create connector case. v2: create global fake encoders rather per connector fake encoders to avoid running out of encoder indices. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1108 Fixes: c6385e503aeaf9 ("drm/amd

  1   2   3   4   >