Re: [PATCH v2 51/86] drm/ast: Run DRM default client setup

2024-08-21 Thread Jocelyn Falempe
fault if no format has been given, leave it out entirely. Thanks for this whole series. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 6 -- 1 file changed, 4 insertions(

Re: [PATCH v2 56/86] drm/mgag200: Run DRM default client setup

2024-08-21 Thread Jocelyn Falempe
On 21/08/2024 14:59, Thomas Zimmermann wrote: Call drm_client_setup_with_fourcc() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Thanks for this whole series. Reviewed-by: Jocelyn Fa

Re: [PATCH] drm/amdgpu: add dce6 drm_panic support

2024-08-05 Thread Jocelyn Falempe
On 02/08/2024 11:39, Christian König wrote: Am 02.08.24 um 09:17 schrieb Lu Yao: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao --- The patch can work properly on the TTY, but after st

[PATCH] drm/amd/display: Remove var declaration in dcn32_full_validate_bw_helper()

2022-09-08 Thread Jocelyn Falempe
gnu99, -std=c11 or -std=gnu11 to compile your code drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/dcn32_fpu.c:982:11: error: unused variable 'i' [-Werror=unused-variable] uint32_t i = 0; Fixes: f5b9c1ffabce ("drm/amd/display: Re-initialize viewport after pipe merge") Sig

Re: Annoying AMDGPU boot-time warning due to simplefb / amdgpu resource clash

2022-06-28 Thread Jocelyn Falempe
On 28/06/2022 10:43, Thomas Zimmermann wrote: Hi Am 27.06.22 um 19:25 schrieb Linus Torvalds: On Mon, Jun 27, 2022 at 1:02 AM Javier Martinez Canillas wrote: The flag was dropped because it was causing drivers that requested their memory resource with pci_request_region() to fail with -EBUSY

Re: [PATCH] drm/amd/amdgpu: fix warining during suspend

2023-02-14 Thread Jocelyn Falempe
amdgpu_bo_free_kernel+0xf5/0x110 [amdgpu] Tested-by: Jocelyn Falempe -- Jocelyn

[PATCH v2] drm/amdgpu: Add dcn30 drm_panic support

2024-10-08 Thread Jocelyn Falempe
dcn30/dcn31. It should be easy to add support for dcn20, but I can't test it. I've tested it on a Radeon W6400 pro. Signed-off-by: Jocelyn Falempe --- v2: - Disable tiling, and force page flip in the panic_flush() callback. - Enable tiling support for dcn31. - Force immediate

[PATCH] drm/amdgpu: Add dcn30 drm_panic support

2024-10-04 Thread Jocelyn Falempe
dcn30. It should be easy to add support for dcn20 or dcn31, but I can't test it. I've tested it on a Radeon W6400 pro. Signed-off-by: Jocelyn Falempe --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 137 +- .../amd/display/dc/hubp/dcn30/dcn30_hubp.c| 17 +++ .../a

Re: [PATCH] drm/amdgpu: Add dcn30 drm_panic support

2024-10-22 Thread Jocelyn Falempe
On 22/10/2024 22:10, Alex Deucher wrote: On Fri, Oct 4, 2024 at 5:09 AM Jocelyn Falempe wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. It should work on all readeon using amdgpu_dm_plane.c, when the

[PATCH v3] drm/amdgpu: Add dcn30 drm_panic support

2024-10-23 Thread Jocelyn Falempe
dcn3x. It should be easy to add support for dcn20, but I can't test it. I've tested it on a Radeon W6400 pro, Radeon 7900XTX and Radeon RX 5700. Also it doesn't work yet on laptop's panel, maybe due to PSR. Signed-off-by: Jocelyn Falempe --- v2: - Disable tiling, and fo

Re: [PATCH V2 0/4] Add panic support for all DCE/DCN

2024-11-05 Thread Jocelyn Falempe
ear_tiling hubp callbacks drm/amd/display: add clear_tiling mi callbacks drm/amd/display: add non-DC drm_panic support Jocelyn Falempe (1): drm/amd/display: add DC drm_panic support drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 27 + drivers/gpu/drm/amd/amdgpu/dce_v11_0.c| 27

Re: [PATCH V3 0/5] Add panic support for all DCE/DCN

2024-11-05 Thread Jocelyn Falempe
non-DC drm_panic support Jocelyn Falempe (1): drm/amd/display: add DC drm_panic support drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 80 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 5 + drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 27 + drivers/gpu/drm/amd

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-09-25 Thread Jocelyn Falempe
On 24/09/2024 16:02, Alex Deucher wrote: On Fri, Sep 20, 2024 at 11:36 AM Jocelyn Falempe wrote: On 17/09/2024 15:21, Alex Deucher wrote: On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-09-17 Thread Jocelyn Falempe
On 12/08/2024 08:09, Lu Yao wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. From a drm_panic point of view, it looks good to me. I don't have the required hardware, so unfortunately I wasn't able to test

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-09-20 Thread Jocelyn Falempe
On 17/09/2024 15:21, Alex Deucher wrote: On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao Patch looks good to me. Any chance you want to c

Re: [PATCH 5/5] drm: Add client-lib module

2024-09-30 Thread Jocelyn Falempe
n the KMS-helper module for now. Amdgpu has an internal DRM client, so it has to select DRM_CLIENT by itself unconditionally. Thanks, I found a typo in the Makefile (see below), other than that it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- driver

Re: [PATCH 5/5] drm: Add client-lib module

2024-09-30 Thread Jocelyn Falempe
On 30/09/2024 13:55, Jocelyn Falempe wrote: On 27/09/2024 16:37, Thomas Zimmermann wrote: Add drm_client_lib.ko to contain most of the client code. Move the existing client for fbdev emulation into the new module. Protect the new module behind CONFIG_DRM_CLIENT. The Kconfig rules separate the

Re: [PATCH 3/5] drm: Move client-device functions in to drm_client_dev.c

2024-09-30 Thread Jocelyn Falempe
ut it looks good to me. Reviewed-by: Jocelyn Falempe -- Jocelyn Signed-off-by: Thomas Zimmermann --- Documentation/gpu/drm-client.rst | 3 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_client.c | 121 --- drivers/gpu/drm/drm_client_dev.c

Re: [PATCH 0/5] drm: Introduce DRM client library

2024-09-30 Thread Jocelyn Falempe
On 27/09/2024 16:37, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the common client code. It's designed

Re: [PATCH 4/5] drm: Select fbdev helpers for modules that require them

2024-09-30 Thread Jocelyn Falempe
On 27/09/2024 16:37, Thomas Zimmermann wrote: Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-10-01 Thread Jocelyn Falempe
On 25/09/2024 10:33, Jocelyn Falempe wrote: On 24/09/2024 16:02, Alex Deucher wrote: On Fri, Sep 20, 2024 at 11:36 AM Jocelyn Falempe wrote: On 17/09/2024 15:21, Alex Deucher wrote: On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: Add support for the drm_panic module, which displays a

Re: [PATCH v2 00/11] drm: Introduce DRM client library

2024-10-03 Thread Jocelyn Falempe
On 02/10/2024 15:04, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_client_lib.ko stores most of the in-kernel client code. It is desig

Re: [PATCH V4 0/6] Add panic support for all DCE/DCN

2024-12-09 Thread Jocelyn Falempe
drm/amd/display: add clear_tiling hubp callbacks drm/amd/display: add clear_tiling mi callbacks drm/amd/display/dc: add helper for panic updates drm/amd/display: add non-DC drm_panic support Jocelyn Falempe (1): drm/amd/display: add DC drm_panic support drivers/gpu/drm/amd/amdgpu/