RE: [PATCH] drm/amdgpu: use 2MB fragment size for GFX6,7 and 8

2017-09-18 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, September 18, 2017 8:34 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: use 2MB fragment size for GFX

RE: [PATCH] drm/ttm: set bo->resv point to tbo->ttm_resv after individualize_resv

2017-11-07 Thread He, Roger
I guess this because you move the resv changing out of lock of bo->resv. Because at the beginning ttm_mem_evict_first may __ttm_bo_reserve(bo->resv) success, and then bo->resv has been changed by another thread. That is not matched and at this point bo->ttm_resv also may been freed already. And

Recall: [PATCH 3/4] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional

2017-11-10 Thread He, Roger
He, Roger would like to recall the message, "[PATCH 3/4] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Recall: [PATCH 3/4] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional

2017-11-10 Thread He, Roger
He, Roger would like to recall the message, "[PATCH 3/4] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Recall: [PATCH 3/4] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional

2017-11-10 Thread He, Roger
He, Roger would like to recall the message, "[PATCH 3/4] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH 6/7] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional

2017-11-10 Thread He, Roger
2017 4:59 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; He, Roger ; mic...@daenzer.net Subject: [PATCH 6/7] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional Needed for the next patch. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 52 +++

RE: [PATCH 3/4] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional

2017-11-10 Thread He, Roger
Please see comments inline -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Wednesday, November 08, 2017 11:00 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: [PATCH 3/4] drm/ttm: make unlocking in

RE: [PATCH] drm/amd/amdgpu: not allow gtt size exceed system memory size

2017-11-10 Thread He, Roger
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Friday, November 10, 2017 8:02 PM To: He, Roger ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: not allow gtt size exceed system memory size Am 10.11.2017 um 12:33 schrieb

RE: [PATCH] drm/amdgpu: extend lock range for race condition when gpu reset

2017-06-16 Thread He, Roger
Hi Xiangliang: Could you try to replace spinlock with mutex? Thanks Roger(Hongbo.He) -Original Message- From: Yu, Xiangliang Sent: Friday, June 16, 2017 2:30 PM To: Christian König ; Zhou, David(ChunMing) ; He, Roger ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu

RE: upsteam find bo api

2017-06-16 Thread He, Roger
What is the background or what is it for? Thanks Roger(Hongbo.He) From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of zhoucm1 Sent: Friday, June 16, 2017 4:09 PM To: amd-gfx@lists.freedesktop.org Subject: Fwd: upsteam find bo api ping...? Forwarded Message --

RE: upsteam find bo api

2017-06-18 Thread He, Roger
Patches Look good to me in itself. Acked-by: Roger.He mailto:hongbo...@amd.com>> But of course you should double confirm if there is Christian’s concern. Thanks Roger(Hongbo.He) From: Zhou, David(ChunMing) Sent: Friday, June 16, 2017 7:18 PM To: He, Roger ; amd-gfx@lists.freedesktop.org S

RE: [PATCH 3/3] drm/amdgpu: add gtt_sys_limit

2017-06-27 Thread He, Roger
(Hongbo.He) -Original Message- From: He, Roger Sent: Wednesday, June 28, 2017 9:58 AM To: 'Felix Kuehling' ; Christian König ; Michel Dänzer ; John Brooks Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 3/3] drm/amdgpu: add gtt_sys_limit Yeah, recently we indeed enco

RE: [PATCH 3/3] drm/amdgpu: add gtt_sys_limit

2017-06-27 Thread He, Roger
Yeah, recently we indeed encountered an issue as below: On workstation machine it has 32G system memory and thus the GTT table size takes up about 192M visible VRAM. Maybe if system has bigger memory, GTT table size will exceed 256M, so Limitation for max GTT table size is very necessary. Thank

RE: [PATCH] drm/amdgpu: fix amdgpu_bo_gpu_accessible()

2017-07-13 Thread He, Roger
Reviewed-and-Tested-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, July 13, 2017 6:23 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH] drm/amdgpu: fix a

RE: [PATCH 2/2] drm/amd/amdgpu: expose fragment size as module parameter

2017-08-15 Thread He, Roger
-Original Message- From: Koenig, Christian Sent: Tuesday, August 15, 2017 4:48 PM To: He, Roger ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amd/amdgpu: expose fragment size as module parameter Am 15.08.2017 um 10:36 schrieb Roger He: > Change

RE: [PATCH 1/3] drm/amdgpu: remove the GART copy hack

2017-08-23 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, August 23, 2017 5:03 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 1/3] drm/amdgpu: remove the GART copy hack

RE: [PATCH 3/3] drm/amdgpu: inline amdgpu_ttm_do_bind again

2017-08-23 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, August 23, 2017 5:03 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 3/3] drm/amdgpu: inline amdgpu_ttm_do_bind

RE: [PATCH] drm/amd/amdgpu: fix BANK_SELECT on Vega10

2017-08-25 Thread He, Roger
Ok. Thanks Roger(Hongbo.He) -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: Friday, August 25, 2017 3:33 PM To: He, Roger ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH] drm/amd/amdgpu: fix BANK_SELECT on Vega10 Hi Roger

RE: [PATCH] drm/amd/amdgpu: cover fragment size between 4 and 9 when not aligned

2017-08-30 Thread He, Roger
o:deathsim...@vodafone.de] Sent: Wednesday, August 30, 2017 2:25 PM To: Zhou, David(ChunMing) ; He, Roger ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH] drm/amd/amdgpu: cover fragment size between 4 and 9 when not aligned Hi David & Roger, > I think when you ca

RE: [PATCH] drm/amdgpu: fix new PD update code for Vega10 v2

2017-08-31 Thread He, Roger
Reviewed-and-Tested-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, August 31, 2017 7:58 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: fix new PD update

RE: [PATCH] drm/amdgpu: handle all fragment sizes v4

2017-08-31 Thread He, Roger
It works very well! Tested-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, August 31, 2017 5:45 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: handle all f

RE: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

2017-09-11 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, September 11, 2017 6:53 PM To: Zhou, David(ChunMing) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: f

RE: [PATCH 3/5] drm/radeon: remove extra TT unpopulated check

2018-02-04 Thread He, Roger
-Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Saturday, February 03, 2018 3:10 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: [PATCH 3/5] drm/radeon: remove extra TT unpopulated check

RE: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-04 Thread He, Roger
Patch1 & 2 & 4, Reviewed-by: Roger He Patch 5: Acked-by: Roger He -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Saturday, February 03, 2018 3:10 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.

RE: [PATCH 0/5] prevent OOM triggered by TTM

2018-02-06 Thread He, Roger
, because initially I also concern that but no better way at that time. Going to improve the patches. Thanks! -Original Message- From: Koenig, Christian Sent: Tuesday, February 06, 2018 5:52 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: tho

RE: [PATCH 0/5] prevent OOM triggered by TTM

2018-02-07 Thread He, Roger
truct ttm_bo_device to let driver set according to its request. Thanks Roger(Hongbo.He) -Original Message- From: Thomas Hellstrom [mailto:tho...@shipmail.org] Sent: Wednesday, February 07, 2018 2:43 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: K

RE: [PATCH 0/5] prevent OOM triggered by TTM

2018-02-07 Thread He, Roger
Sure, will make it turn off as default and make the limit configurable. Thanks Roger(Hongbo.He) -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Wednesday, February 07, 2018 4:41 PM To: He, Roger ; Thomas Hellstrom ; amd-gfx@lists.freedesktop.org

RE: [PATCH 3/9] drm/amdgpu: add amdgpu module parameter for zfb

2018-02-08 Thread He, Roger
For the CMA, I have some concern. First, it is strongly depend on other module's robustness which can use CMA memory with flag __GFP_MOVABLE. My mean is dma_alloc_coherent sometimes will fail because its owner cannot migrate its memory out from CMA range because some internal bugs. Second becaus

RE: [PATCH 3/4] drm/ttm: add input parameter force_alloc for ttm_bo_evict_mm

2018-02-08 Thread He, Roger
I can't think of an use case when we don't want this to succeed. That is true. seems I can simplify more here. Thanks Roger(Hongbo.He) -Original Message- From: Koenig, Christian Sent: Thursday, February 08, 2018 8:58 PM To: He, Roger ; amd-gfx@lists.freedesktop.or

RE: [PATCH 4/4] drm/ttm: keep BOs reserved until end of eviction

2018-02-23 Thread He, Roger
looks good to me. Reviewed-by: Roger He -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Tuesday, February 20, 2018 8:58 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel

RE: [PATCH 3/4] drm/ttm: handle already locked BOs during eviction and swapout.

2018-02-23 Thread He, Roger
-Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Tuesday, February 20, 2018 8:58 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org Subject: [PATCH 3/4] drm/ttm: handle

RE: [PATCH 2/4] drm/amdgpu: use new ww_mutex_is_owned_by function

2018-02-23 Thread He, Roger
Reviewed-by: Roger He -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Tuesday, February 20, 2018 8:58 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org Subject: [PATCH 2

RE: [PATCH 3/4] drm/ttm: handle already locked BOs during eviction and swapout.

2018-02-23 Thread He, Roger
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Friday, February 23, 2018 8:06 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH 3/4] drm/ttm: handle already

RE: [PATCH 3/4] drm/ttm: handle already locked BOs during eviction and swapout.

2018-02-23 Thread He, Roger
: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH 3/4] drm/ttm: handle already locked BOs during eviction and swapout. Am 23.02.2018 um 10:46 schrieb He, Roger: > > -Original Message- > From:

RE: [PATCH 4/5] drm/ttm: add ttm_sg_tt_init

2018-03-05 Thread He, Roger
Patch 1: Acked-by: Roger He Patch 2~5: Reviewed-by: Roger He -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, March 05, 2018 8:07 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Ben Ske

RE: [PATCH 1/6] drm/ttm: add ttm_bo_pipeline_gutting

2018-03-07 Thread He, Roger
Patch 1,4,5: Acked-by: Roger He Patch 2,3,6: Reviewed-by: Roger He -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Tuesday, March 06, 2018 10:44 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org S

RE: [PATCH 2/5] drm/ttm: keep a reference to transfer pipelined BOs

2018-03-26 Thread He, Roger
Reviewed-by: Roger He -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, March 16, 2018 9:21 PM To: linaro-mm-...@lists.linaro.org; linux-me...@vger.kernel.org; dri-de...@lists.freedesktop.org; amd-gfx@lists.freede

RE: [PATCH 3/5] drm/ttm: remove the backing store if no placement is given

2018-03-26 Thread He, Roger
Acked-by: Roger He -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Sunday, March 25, 2018 6:58 PM To: linaro-mm-...@lists.linaro.org; linux-me...@vger.kernel.org; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedeskt

RE: [PATCH 1/2] drm/ttm: fix ttm_mem_evict_first once more

2017-11-15 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, November 15, 2017 8:32 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: [PATCH 1/2] dr

RE: 答复: [PATCH] drm/amd/amdgpu: fix over-bound accessing in amdgpu_cs_wait_any_fence

2017-11-16 Thread He, Roger
Ok, so keep your logic here. Going to send a new patch soon. Thanks Roger(Hongbo.He) -Original Message- From: Deng, Emily Sent: Friday, November 17, 2017 1:44 PM To: He, Roger ; Zhou, David(ChunMing) ; Qu, Jim ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject: RE: 答复

RE: 答复: [PATCH] drm/amd/amdgpu: fix over-bound accessing in amdgpu_cs_wait_any_fence

2017-11-16 Thread He, Roger
Theoretically, if first < fence_count, array[first] will not be NULL. Hi Emily: do you remember the issue you fixed has same error log? Thanks Roger(Hongbo.He) -Original Message- From: Zhou, David(ChunMing) Sent: Friday, November 17, 2017 1:24 PM To: Qu, Jim ; He, Roger ; amd-

RE: [PATCH 1/4] drm/ttm: add page order in page pool

2017-11-22 Thread He, Roger
-Original Message- From: Koenig, Christian Sent: Wednesday, November 22, 2017 3:48 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/ttm: add page order in page pool Am 22.11.2017 um 06:36 schrieb Roger He: > to indic

RE: [PATCH 2/4] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread He, Roger
Hi Christian: This is old patch, I already send new patches. And it is clean and simple. Please check that. Thanks Roger(Hongbo.He) -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Wednesday, November 22, 2017 5:29 PM To: He, Roger ; amd-gfx

RE: [PATCH 3/5] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread He, Roger
[mailto:ckoenig.leichtzumer...@gmail.com] Sent: Wednesday, November 22, 2017 6:01 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH 3/5] drm/ttm: add page order support in ttm_pages_put That completely negates the advantage of setting write back on

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

2017-11-28 Thread He, Roger
-Original Message- From: Koenig, Christian Sent: Tuesday, November 28, 2017 6:01 PM To: He, Roger ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only Am 28.11.2017 um 10:40 schrieb Roger He: > Change

RE: [PATCH 1/2] drm/ttm: swap consecutive allocated cached pages v2

2017-12-04 Thread He, Roger
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Monday, December 04, 2017 8:13 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; He, Roger ; ckoenig.leichtzumer...@gmail.com Subject: [PATCH 1/2] drm/ttm: swap consecutive

RE: [PATCH 2/2] drm/ttm: swap consecutive allocated pooled pages v3

2017-12-04 Thread He, Roger
Series is: Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Monday, December 04, 2017 8:46 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; He, Roger Subject: [PATCH 2/2] drm

RE: [PATCH 2/2] drm/ttm: swap consecutive allocated pooled pages v3

2017-12-04 Thread He, Roger
t - 1] == p - 1) { + swap(p, pages[count - 1]);// swap seems breaking the plist, after that iteration plist will not work. } pages[count++] = temp; + } -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of

RE: [PATCH] drm/ttm: swap consecutive allocated pooled pages v4

2017-12-05 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Tuesday, December 05, 2017 8:55 PM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; He, Roger Subject: [PATCH] drm/ttm: swap

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

2017-12-07 Thread He, Roger
) -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Friday, December 08, 2017 1:34 AM To: He, Roger Cc: amd-gfx@lists.freedesktop.org; Koenig, Christian Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only On 2017-11-29 10:12 AM

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

2017-12-10 Thread He, Roger
-Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Saturday, December 09, 2017 1:26 AM To: Koenig, Christian ; He, Roger Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only On 2017-12-07 07:07 PM

RE: [PATCH 1/7] drm/ttm:fix incorrect calculate on shrink_pages

2017-12-12 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk Liu Sent: Tuesday, December 12, 2017 5:47 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH 1/7] drm/ttm:fix incorrect calcul

RE: [PATCH 3/6] drm/ttm: use an ttm operation ctx for ttm_bo_move_xxx

2017-12-12 Thread He, Roger
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Tuesday, December 12, 2017 6:34 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH 3/6] drm/ttm: use an ttm operation ctx for ttm_bo_move_xxx Am

RE: [PATCH 4/6] drm/ttm: init locked again to prevent incorrect unlock

2017-12-12 Thread He, Roger
l.com] Sent: Tuesday, December 12, 2017 6:37 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH 4/6] drm/ttm: init locked again to prevent incorrect unlock Am 12.12.2017 um 10:33 schrieb Roger He: > Change-Id: I8db51d843955f5db14bb4bbff892eaed

RE: [PATCH 5/6] drm/ttm: enable eviction for Per-VM-BO

2017-12-12 Thread He, Roger
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Tuesday, December 12, 2017 6:40 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH 5/6] drm/ttm: enable eviction for Per-VM-BO Am 12.12.2017 um 10

RE: [PATCH 1/6] drm/ttm: add on_alloc_stage and reservation into ttm_operation_ctx

2017-12-14 Thread He, Roger
, 2017 3:21 AM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH 1/6] drm/ttm: add on_alloc_stage and reservation into ttm_operation_ctx Hi, I think this series is quite poorly documented. We should have a log message explaining the purpose of the

RE: [PATCH] drm/ttm: enable eviction for Per-VM-BO

2017-12-15 Thread He, Roger
-Original Message- From: Thomas Hellstrom [mailto:tho...@shipmail.org] Sent: Friday, December 15, 2017 2:25 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH] drm/ttm: enable eviction for Per-VM-BO Hi. On 12/14

RE: [PATCH] Revert "drm/amd/amdgpu: set gtt size according to system memory size only"

2017-12-17 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: Andrey Grodzovsky [mailto:andrey.grodzov...@amd.com] Sent: Saturday, December 16, 2017 3:10 AM To: amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Daenzer, Michel ; He, Roger ; Grodzovsky, Andrey Subject

RE: [PATCH 3/7] drm/ttm: use an operation ctx for ttm_mem_global_alloc_page

2017-12-20 Thread He, Roger
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Wednesday, December 20, 2017 9:36 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH 3/7] drm/ttm: use an operation ctx for

RE: [PATCH 1/7] drm/ttm: call ttm_bo_swapout directly when ttm shrink

2017-12-21 Thread He, Roger
eviction and swapout here is the test always overalloction. Thanks Roger(Hongbo.He) -Original Message- From: Thomas Hellstrom [mailto:tho...@shipmail.org] Sent: Thursday, December 21, 2017 3:34 PM To: He, Roger ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re

RE: [PATCH] drm/ttm: drop the spin in delayed delete if the trylock doesn't work

2017-12-21 Thread He, Roger
Reviewed-by: Roger He -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, December 22, 2017 2:06 AM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/ttm: drop the spin in delaye

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

2017-12-25 Thread He, Roger
-Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Monday, December 11, 2017 7:29 PM To: He, Roger ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only On 2017-12-11 03:49 AM

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

2017-12-27 Thread He, Roger
Got it, thank you! -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Wednesday, December 27, 2017 4:58 PM To: He, Roger ; Koenig, Christian ; Grodzovsky, Andrey Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

2018-01-02 Thread He, Roger
Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Wednesday, December 27, 2017 4:58 PM To: He, Roger ; Koenig, Christian ; Grodzovsky, Andrey Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

RE: [PATCH] drm/amdgpu: optimize moved handling only when vm_debug is inactive

2018-01-03 Thread He, Roger
Fix my concern as well. Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, January 03, 2018 8:37 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: opt

RE: [PATCH 1/2] drm/ttm: Allow page allocations w/o triggering OOM..

2018-01-15 Thread He, Roger
-Original Message- From: Andrey Grodzovsky [mailto:andrey.grodzov...@amd.com] Sent: Saturday, January 13, 2018 6:29 AM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; He, Roger ; Grodzovsky, Andrey Subject: [PATCH 1/2] drm/ttm: Allow page

RE: [PATCH 2/2] drm/amdgpu: Use new TTM flag to avoid OOM triggering.

2018-01-15 Thread He, Roger
-Original Message- From: Andrey Grodzovsky [mailto:andrey.grodzov...@amd.com] Sent: Saturday, January 13, 2018 6:29 AM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; He, Roger ; Grodzovsky, Andrey Subject: [PATCH 2/2] drm/amdgpu: Use new TTM

RE: [PATCH 2/2] drm/amdgpu: Use new TTM flag to avoid OOM triggering.

2018-01-16 Thread He, Roger
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Tuesday, January 16, 2018 8:46 PM To: Grodzovsky, Andrey ; Koenig, Christian ; He, Roger ; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: Use

RE: [PATCH v2 1/2] drm/ttm: Allow page allocations w/o triggering OOM..

2018-01-16 Thread He, Roger
, Christian Cc: He, Roger Subject: [PATCH v2 1/2] drm/ttm: Allow page allocations w/o triggering OOM.. This to allow drivers to choose to avoid OOM invocation and handle page allocation failures instead. v2: Remove extra new lines. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/ttm/ttm_bo.c

RE: [RFC] Per file OOM badness

2018-01-18 Thread He, Roger
Basically the idea is right to me. 1. But we need smaller granularity to control the contribution to OOM badness. Because when the TTM buffer resides in VRAM rather than evict to system memory, we should not take this account into badness. But I think it is not easy to implement. 2. If

RE: [RFC] Per file OOM badness

2018-01-18 Thread He, Roger
-Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Michal Hocko Sent: Friday, January 19, 2018 1:14 AM To: Grodzovsky, Andrey Cc: linux...@kvack.org; amd-gfx@lists.freedesktop.org; linux-ker...@vger.kernel.org; dri-de...@lists.freedesktop.org;

RE: [PATCH 2/2] drm/ttm: Don't unreserve swapped BOs that were previously reserved

2018-01-18 Thread He, Roger
good catch! Thanks Roger(Hongbo.He) -Original Message- From: Kuehling, Felix Sent: Friday, January 19, 2018 12:56 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Koenig, Christian ; He, Roger Cc: Kuehling, Felix Subject: [PATCH 2/2] drm/ttm: Don't unre

RE: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space

2018-01-22 Thread He, Roger
-Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, January 22, 2018 6:44 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space There seems

RE: lock/unlock mismatch in ttm_bo.c

2018-01-23 Thread He, Roger
The patch looks fine to me, please send it to dri mail list. Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Wednesday, January 24, 2018 3:25 AM To: Zhou, David(ChunMing) Cc: Koenig, Christian ; amd-

RE: [PATCH 02/13] drm/amdgpu: drop root shadow sync

2018-01-29 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Saturday, January 27, 2018 4:13 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 02/13] drm/amdgpu: drop root shadow sync